sashimi 0.1.7 → 0.2.0

data/test/unit/repositories/abstract_repository_test.rb

@@ -2,137 +2,312 @@ require 'test/unit'
 require 'test/test_helper'
 
 class AbstractRepositoryTest < Test::Unit::TestCase
+  include Sashimi
+  
   def test_initialize
-    assert repository
-    assert repository.plugin.name
-    assert repository.plugin.url
+    assert repository.plugin
   end
   
-  # CLASS CONSTANTS
-  def test_local_repository_path
-    assert_match(/\.rails\/plugins$/, repository.local_repository_path)
+  def test_plugins_path
+    assert_equal 'sashimi_test/.rails/plugins', repository.class.plugins_path
   end
   
   def test_cache_file
-    assert_equal(".plugins", repository.cache_file)
+    assert_equal cache_file, repository.class.cache_file
   end
-
-  def test_plugins_dir
-    assert_equal('vendor/plugins', repository.plugins_dir)
+  
+  def test_plugins_names
+    assert_equal cached_plugins.keys.sort, repository.class.plugins_names
   end
-
-  # INSTANTIATE
+  
+  def test_temp_suffix
+    assert_equal '-tmp', AbstractRepository::TEMP_SUFFIX
+  end
+  
+  ### INSTANTIATE
+  
+  def test_instantiate_repository
+    assert_kind_of GitRepository, repository.class.instantiate_repository(plugin)
+    assert_kind_of GitRepository, repository.class.instantiate_repository(create_plugin('sashimi', plugin.url))
+  end
+  
   def test_should_instantiate_repository_by_url
-    assert_kind_of(SvnRepository, AbstractRepository.instantiate_repository(create_plugin(nil, 'http://svn.com')))
-    assert_kind_of(GitRepository, AbstractRepository.instantiate_repository(plugin))
+    assert_equal SvnRepository, AbstractRepository.instantiate_repository_by_url(create_plugin(nil, 'http://svn.com'))
+    assert_equal GitRepository, AbstractRepository.instantiate_repository_by_url(plugin)
   end
   
   def test_should_instantiate_repository_by_cache
-    initialize_repository_for_test do
-      assert AbstractRepository.instantiate_repository(create_plugin('sashimi', ''))
+    assert repository.class.instantiate_repository_by_cache(create_plugin('sashimi', plugin.url))
+  end
+  
+  ### COMMANDS
+  
+  # ADD
+  def test_should_add_plugin_to_rails_app
+    with_path rails_app_path do
+      repository.add
+      assert_path_exists "vendor/plugins/#{repository.plugin.name}"
     end
   end
   
-  def test_should_recognize_git_url
-    assert AbstractRepository.git_url?('git://github.com/jodosha/sashimi.git')
+  def test_should_raise_exception_on_adding_missing_plugin
+    with_path rails_app_path do
+      assert_raise PluginNotFound do
+        create_repository('unexistent').add
+      end
+    end
   end
   
-  # COMMANDS
-  def test_should_list_all_installed_plugins
-    initialize_repository_for_test do
-      assert_equal("plug-in\t\t\nplugin\t\t\nsashimi\t\t", AbstractRepository.list)
+  # UNINSTALL
+  def test_should_uninstall_plugin_from_repository
+    repository.uninstall
+    with_path plugins_path do
+      assert_path_not_exists repository.plugin.name
     end
+    assert_not repository.class.plugins_names.include?(repository.plugin.name)
   end
   
-  def test_should_return_all_installed_plugins_names
-    initialize_repository_for_test do
-      assert_equal(['plug-in', 'plugin'], AbstractRepository.plugins_names)
+  def test_should_raise_exception_on_uninstalling_missing_plugin
+    assert_raise PluginNotFound do
+      create_repository('unexistent').uninstall
     end
   end
   
-  # DIRECTORIES
-  def test_should_change_current_dir
-    repository.change_dir(repository.class.find_home)
-    assert_equal(repository.class.find_home, Dir.pwd)
+  # LIST
+  def test_should_list_installed_plugins
+    assert_equal cached_plugins, repository.class.list
   end
+    
+  ### SCM
   
-  def test_should_change_current_dir_with_local_repository_path
-    initialize_repository_for_test do
-      repository.change_dir_to_local_repository
-      assert_equal(repository.local_repository_path, Dir.pwd)
+  uses_mocha 'AbstractRepositoryTestSCM' do
+    def test_guess_version_control_system
+      File.expects(:exists?).with('.git').returns true
+      assert_equal :git, repository.class.guess_version_control_system
+      
+      File.expects(:exists?).with('.git').returns false
+      assert_equal :svn, repository.class.guess_version_control_system      
+    end
+    
+    def test_scm_command
+      File.stubs(:exists?).with('.git').returns true
+      Kernel.expects(:system).with('git add file.rb')
+      repository.class.scm_command('add', 'file.rb')
     end
+    
+    def test_scm_add
+      File.stubs(:exists?).with('.git').returns true
+      Kernel.expects(:system).with('git add file.rb')
+      repository.class.scm_add('file.rb')
+    end
+    
+    def test_scm_remove
+      File.stubs(:exists?).with('.git').returns true
+      Kernel.expects(:system).with('git rm file.rb')
+      repository.class.scm_remove('file.rb')      
+    end
+    
+    def test_under_version_control
+      Dir.expects(:glob).with(".{git,svn}").returns %w(.git)
+      assert repository.class.under_version_control?
+    end    
   end
   
-  def test_should_change_current_dir_with_plugin_cache_path
-    initialize_repository_for_test do
-      FileUtils.mkdir_p(cached_plugin_path)
-      repository.change_dir_to_plugin_path
-      assert_equal(cached_plugin_path, Dir.pwd)
+  def test_git_url
+    assert repository.class.git_url?(plugin.url)
+    assert repository.class.git_url?(plugin.url.gsub('git:', 'http:'))
+    assert_not repository.class.git_url?('http://repository.com/plugin/trunk')
+  end
+  
+  ### PATH
+  
+  uses_mocha 'AbstractRepositoryTestPath' do
+    def test_local_repository_path
+      AbstractRepository.expects(:find_home).returns '/Users/luca'
+      File.stubs(:SEPARATOR).returns '/'
+      expected = [ repository.class.find_home, repository.class.plugins_path ].to_path
+      assert_equal expected, repository.local_repository_path
+    end
+    
+    def _ignore_test_find_home
+      flunk
+    end
+    
+    def test_with_path
+      old_path = Dir.pwd
+      repository.with_path 'test' do
+        assert_equal [old_path, 'test'].to_path, Dir.pwd
+      end
+      assert_equal old_path, Dir.pwd
     end
   end
   
-  def _ignore_test_should_copy_plugin_to_a_rails_app
-    initialize_repository_for_test do
-      repository.change_dir_to_local_repository
-      create_repository('plugin', '').copy_plugin_to_rails_app
-      assert File.exists?(File.join('vendor', 'plugins', 'plugin', 'about.yml'))
+  def test_path_to_rails_app
+    with_path rails_app_path do
+      assert_equal Dir.pwd, repository.class.path_to_rails_app
     end
   end
   
-  # REPOSITORY
-  def test_should_prepare_installation
-    initialize_repository_for_test do
-      assert File.exists?(repository.local_repository_path)
-      assert_equal(repository.local_repository_path, Dir.pwd)
-      assert File.exists?(repository.cache_file)
+  def test_absolute_rails_plugins_path
+    with_path rails_app_path do
+      expected = "#{Dir.pwd}/vendor/plugins".to_path
+      assert_equal expected, repository.class.absolute_rails_plugins_path
     end
   end
+  
+  def test_rails_plugins_path
+    assert_equal 'vendor/plugins'.to_path, repository.class.rails_plugins_path
+  end
+  
+  def test_plugin_path
+    expected = [ plugins_path, repository.plugin.name ].to_path
+    assert_equal expected, repository.plugin_path
+  end
+  
+  ### FILES
+    
+  uses_mocha 'AbstractRepositoryTestFile' do
+    def _ignore_test_copy_plugin_and_remove_hidden_folders
+      flunk
+    end
+
+    def test_update_rails_plugins
+      AbstractRepository.expects(:under_version_control?).returns true
+      AbstractRepository.expects(:update_versioned_rails_plugins)
+      AbstractRepository.update_rails_plugins plugin.name
+
+      AbstractRepository.expects(:under_version_control?).returns false
+      AbstractRepository.expects(:update_unversioned_rails_plugins)
+      AbstractRepository.update_rails_plugins plugin.name
+    end
+
+    def _ignore_test_update_unversioned_rails_plugins
+      FileUtils.stubs(:rm_rf) # because of teardown
+      FileUtils.expects(:rm_rf).with 'sashimi'
+      FileUtils.stubs(:cd)
+      AbstractRepository.expects(:instantiate_repository_by_cache).returns GitRepository
+      GitRepository.stubs(:cache_content).returns({ 'sashimi' => nil })
+      Plugin.expects(:add)
+      FileUtils.expects(:cp_r).with [ plugins_path, repository.plugin.name ].to_path,
+        [ repository.class.rails_plugins_path, repository.temp_plugin_name ].to_path
+      FileUtils.expects(:mv).with [ repository.rails_plugins_path, repository.temp_plugin_name ].to_path,
+        [ repository.rails_plugins_path, repository.plugin.name ].to_path
+
+      AbstractRepository.update_unversioned_rails_plugins 'sashimi'
+    end
+
+    def _ignore_test_update_versioned_rails_plugins
+      flunk
+    end
+
+    def _ignore_test_files_scheduled_for_add
+      flunk
+    end
+
+    def _ignore_test_files_scheduled_for_remove
+      flunk
+    end
+
+    def test_remove_temp_folder
+      with_path rails_app_path do
+        FileUtils.expects(:rm_rf).with [ repository.absolute_rails_plugins_path,
+          repository.temp_plugin_name].to_path
+        repository.remove_temp_folder
+        FileUtils.stubs(:rm_rf) # because of teardown
+      end
+    end
+
+    def test_prepare_installation
+      FileUtils.expects(:mkdir_p).with repository.local_repository_path
+      FileUtils.expects(:touch).with [ repository.local_repository_path, cache_file ].to_path
+      repository.prepare_installation
+    end
 
-  # CACHE
-  def test_should_read_cache_content
-    initialize_repository_for_test do
-      assert_equal(cache_content, repository.cache_content)
+    def test_copy_plugin_to_rails_app
+      FileUtils.expects(:mkdir_p).with repository.absolute_rails_plugins_path
+      FileUtils.expects(:cp_r).with [ repository.local_repository_path, repository.plugin.name ].to_path,
+        [ repository.absolute_rails_plugins_path, repository.temp_plugin_name ].to_path
+      repository.copy_plugin_to_rails_app
     end
   end
+
+  def _ignore_test_remove_hidden_folders
+    flunk
+  end
+  
+  ### CACHE
+  
+  def test_cache_content
+    assert_equal cached_plugins, repository.class.cache_content
+  end
   
-  def test_should_add_plugin_to_the_cache
-    initialize_repository_for_test do
-      expected = cache_content.merge(cached_plugin)
-      repository.add_to_cache(cached_plugin)
-      assert_equal expected, cache_content
+  def test_should_add_a_new_plugin_to_cache
+    with_clear_cache do
+      with_path local_repository_path do
+        create_plugin_directory('brand_new')
+        plugin = create_plugin(nil, 'git://github.com/jodosha/brand_new.git')
+        repository.add_to_cache(plugin)
+        assert_equal cached_plugins.merge(plugin.to_hash), repository.class.cache_content
+      end
     end
   end
   
-  def test_should_remove_plugin_from_cache
-    initialize_repository_for_test do
-      AbstractRepository.new(create_plugin('sashimi', '')).remove_from_cache
-      assert_equal({"plugin"=>{"type"=>"svn"}, "plug-in"=>{"type"=>"svn"}}, cache_content)
+  def test_should_merge_an_existent_plugin_into_cache
+    with_clear_cache do
+      with_path local_repository_path do
+        repository.add_to_cache(plugin)
+        assert_equal cached_plugins.merge(plugin.to_hash), repository.class.cache_content
+      end
     end
   end
   
-  # ABOUT
-  def test_should_return_about_contents_from_about_yml
-    initialize_repository_for_test do
-      plugin = create_plugin('plugin', 'http://dev.repository.com/svn/plugin/trunk')
-      assert_equal({'summary' => "Plugin summary"}, plugin.about)
+  def test_remove_from_cache
+    with_clear_cache do
+      with_path local_repository_path do
+        repository.remove_from_cache
+        assert_not repository.class.plugins_names.include?(plugin.name)
+      end
     end
   end
   
-  def test_should_return_empty_hash_for_unexstistent_about_yml
-    initialize_repository_for_test do
-      
-      plugin = create_plugin('plug-in', 'http://dev.repository.com/svn/plug-in/trunk')
-      assert_equal({}, plugin.about)
+  def test_write_to_cache
+    with_clear_cache do
+      with_path plugins_path do
+        repository.write_to_cache(plugin.to_hash)
+        assert_equal plugin.to_hash, repository.class.cache_content
+      end
     end
   end
   
-private
-  def cache_content
-    FileUtils.cd(repository.local_repository_path)
-    YAML::load_file(repository.cache_file).to_hash
+  ### OTHER
+  
+  def test_should_load_about_yml
+    assert_not_empty repository.about.keys
   end
-    
-  def cached_plugin_path
-    File.join(repository.local_repository_path, 'sashimi')
+
+  def test_should_return_empty_hash_for_unexistent_about_yml
+    assert_nothing_raised Exception do
+      assert_empty create_repository('plug-in').about.keys
+    end
+  end
+
+  def test_temp_plugin_name
+    assert_equal repository.plugin.name + AbstractRepository::TEMP_SUFFIX,
+      repository.temp_plugin_name
+  end
+  
+  uses_mocha 'AbstractRepositoryTestOther' do
+    def test_should_run_install_hook
+      File.expects(:exists?).returns true
+      Kernel.expects(:load)
+      repository.run_install_hook
+    end
+
+    def test_should_not_raise_exception_running_install_hook_with_missing_file
+      assert_nothing_raised Exception do
+        Kernel.expects(:load).never
+        create_repository('plug-in').run_install_hook
+      end
+    end
   end
 end

data/test/unit/repositories/git_repository_test.rb

@@ -20,7 +20,7 @@ class GitRepositoryTest < Test::Unit::TestCase
     end
     
     def test_should_create_git_repository
-      initialize_repository_for_test do
+      repository.with_path plugins_path do
         FileUtils.mkdir_p('sashimi')
         Kernel.expects(:system).with('git clone git://github.com/jodosha/sashimi.git')
         GitRepository.new(plugin).install

data/test/unit/repositories/svn_repository_test.rb

@@ -19,8 +19,8 @@ class SvnRepositoryTest < Test::Unit::TestCase
       assert_raise(Errno::ENOENT) { repository.install }      
     end
     
-    def test_should_create_git_repository
-      initialize_repository_for_test do
+    def test_should_create_svn_repository
+      repository.with_path plugins_path do
         FileUtils.mkdir_p('sashimi')
         Kernel.expects(:system).with('svn co http://dev.repository.com/svn/sashimi/trunk sashimi')
         SvnRepository.new(create_plugin(nil, 'http://dev.repository.com/svn/sashimi/trunk')).install

data/test/unit/version_test.rb

@@ -3,6 +3,6 @@ require 'test/test_helper'
 
 class VersionTest < Test::Unit::TestCase
   def test_version
-    assert_equal '0.1.7', Sashimi::VERSION::STRING
+    assert_equal '0.2.0', Sashimi::VERSION::STRING
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: sashimi
 version: !ruby/object:Gem::Version 
-  version: 0.1.7
+  version: 0.2.0
 platform: ruby
 authors: 
 - Luca Guidi
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-06-23 00:00:00 +02:00
+date: 2008-07-14 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -39,7 +39,9 @@ files:
 - lib/sashimi.rb
 - lib/sashimi/commands.rb
 - lib/sashimi/core_ext.rb
+- lib/sashimi/core_ext/array.rb
 - lib/sashimi/core_ext/class.rb
+- lib/sashimi/core_ext/string.rb
 - lib/sashimi/plugin.rb
 - lib/sashimi/repositories.rb
 - lib/sashimi/repositories/abstract_repository.rb
@@ -49,7 +51,9 @@ files:
 - sashimi.gemspec
 - setup.rb
 - test/test_helper.rb
+- test/unit/core_ext/array_test.rb
 - test/unit/core_ext/class_test.rb
+- test/unit/core_ext/string_test.rb
 - test/unit/plugin_test.rb
 - test/unit/repositories/abstract_repository_test.rb
 - test/unit/repositories/git_repository_test.rb
@@ -82,7 +86,9 @@ signing_key:
 specification_version: 2
 summary: Rails plugins manager
 test_files: 
+- test/unit/core_ext/array_test.rb
 - test/unit/core_ext/class_test.rb
+- test/unit/core_ext/string_test.rb
 - test/unit/plugin_test.rb
 - test/unit/repositories/abstract_repository_test.rb
 - test/unit/repositories/git_repository_test.rb