sanichi-chess_icu 0.3.4 → 0.3.5

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :major: 0
 :minor: 3
-:patch: 4
+:patch: 5

data/lib/tournament.rb

@@ -35,29 +35,36 @@ raise an exception if the players it references through their tournament numbers
 
 A tournament can be validated with either the _validate!_ or _invalid_ methods.
 On success, the first returns true while the second returns false.
-On error, the first throws an exception while the second returns a description of the message.
+On error, the first throws an exception while the second returns a description of the error.
 
 Validations checks that:
 
 * there are at least two players
 * every player has a least one result
-* the round numbers are consistent
-* the tournament dates are consistent
-* the player ranks are consistent (only if the _rank_ or _rerank_ option is set)
+* the round numbers of the players results are consistent
+* the tournament dates (start, finish, round dates) are consistent
+* the player ranks are consistent with their scores
 
-Both messages are capable of taking the following boolean valued hash options:
+Side effects of calling _validate!_ or _invalid_ include:
 
-* _rank_ - check the player ranks
-* _rerank_ - check the player ranks and automatically repair if absent or not consistent
+* the number of rounds will be set if not set already
+* the finish date will be set if not set already and if there are round dates
 
-For example:
+If the _rerank_ option is set, as in this example:
 
-  tournament.validate!(:rank => true)
+  tournament.validate!(:rerank => true)
+
+then there are additional side effects of validating a tournament:
+
+* the players will be ranked if no players have any rank
+* the players will be reranked if the existing ranking is inconsistent
+
+Ranking is consistent if either no players have any rank or if all players have a rank and no player is ranked higher than another player with more points.
 
 =end
 
   class Tournament
-    attr_reader :name, :start, :finish, :rounds, :site, :city, :fed, :type, :arbiter, :deputy, :time_control
+    attr_reader :name, :rounds, :start, :finish, :round_dates, :site, :city, :fed, :type, :arbiter, :deputy, :time_control
     
     # Constructor. Name and start date must be supplied. Other attributes are optional.
     def initialize(name, start, opt={})
@@ -65,6 +72,7 @@ For example:
       self.start = start
       [:finish, :rounds, :site, :city, :fed, :type, :arbiter, :deputy, :time_control].each { |a| self.send("#{a}=", opt[a]) unless opt[a].nil? }
       @player = {}
+      @round_dates = []
     end
     
     # Set the tournament name.
@@ -120,6 +128,20 @@ For example:
       raise "invalid number of rounds (#{rounds})" unless @rounds.nil? || @rounds > 0
     end
     
+    # Add a round date.
+    def add_round_date(round_date)
+      round_date = round_date.to_s.strip
+      parsed_date = Util.parsedate(round_date)
+      raise "invalid round date (#{round_date})" unless parsed_date
+      @round_dates << parsed_date
+      @round_dates.sort!
+    end
+    
+    # Return the date of a given round, or nil if unavailable.
+    def round_date(round)
+      @round_dates[round-1]
+    end
+    
     # Set the tournament web site. Should be either unknown (_nil_) or a reasonably valid looking URL.
     def site=(site)
       @site = site.to_s.strip
@@ -168,7 +190,7 @@ For example:
       @player[num]
     end
     
-    # Return an array of all players in order of their player numbers.
+    # Return an array of all players in order of their player number.
     def players
       @player.values.sort_by{ |p| p.num }
     end
@@ -224,9 +246,9 @@ For example:
     def validate!(options={})
       begin check_ranks rescue rerank end if options[:rerank]
       check_players
-      check_dates
       check_rounds
-      check_ranks if options[:rank]
+      check_dates
+      check_ranks(:allow_none => true)
       true
     end
 
@@ -238,12 +260,6 @@ For example:
       @player.each { |num, p| raise "player #{num} has no results" if p.results.size == 0 }
     end
     
-    # Check dates are consistent.
-    def check_dates
-      # If there is a start date and an end date, the start should not come after the end.
-      raise "start date (#{start}) is after end date (#{finish})" if start && finish && start > finish
-    end
-
     # Round should go from 1 to a maximum, there should be at least one result in every round and,
     # if the number of rounds has been set, it should agree with the largest round from the results.
     def check_rounds
@@ -264,13 +280,23 @@ For example:
       end
     end
 
+    # Check dates are consistent.
+    def check_dates
+      raise "start date (#{start}) is after end date (#{finish})" if @start && @finish && @start > @finish
+      if @round_dates.size > 0
+        raise "the number of round dates (#{@round_dates.size}) does not match the number of rounds (#{@rounds})" unless @round_dates.size == @rounds
+        raise "the date of the first round (#{@round_dates[0]}) comes before the start (#{@start}) of the tournament" if @start && @start > @round_dates[0]
+        raise "the date of the last round (#{@round_dates[-1]}) comes after the end (#{@finish}) of the tournament" if @finish && @finish < @round_dates[-1]
+        @finish = @round_dates[-1] unless @finish
+      end
+    end
+
     # Check if the players ranking is consistent, which will be true if:
     # * every player has a rank
     # * no two players have the same rank
     # * the highest rank is 1
     # * the lowest rank is equal to the total of players
-    def check_ranks
-      # No two players can have the same rank.
+    def check_ranks(options)
       ranks = Hash.new
       @player.values.each do |p|
         if p.rank
@@ -278,16 +304,11 @@ For example:
           ranks[p.rank] = p
         end
       end
-
-      # Otherwise, every player has to have a rank.
+      return if ranks.size == 0 && options[:allow_none]
       raise "every player has to have a rank" unless ranks.size == @player.size
-
-      # The higest and lowest ranks respectively should be 1 and the number of players.
       by_rank = @player.values.sort{ |a,b| a.rank <=> b.rank}
       raise "the highest rank must be 1" unless by_rank[0].rank == 1
       raise "the lowest rank must be #{ranks.size}" unless by_rank[-1].rank == ranks.size
-      
-      # If scores are ordered by ranks, they should go from highest to lowest.
       if by_rank.size > 1
         (1..by_rank.size-1).each do |i|
           p1 = by_rank[i-1]

data/lib/tournament_krause.rb

@@ -14,6 +14,7 @@ Suppose, for example, that the following data is the file <em>tournament.tab</em
   032 IRL
   042 2009.09.09
   0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
+  132                                                                                        09.09.09  09.09.10  09.09.11
   001    1 w    Mouse,Minerva                     1900 USA     1234567 1928.05.15  1.0    2     2 b 0     3 w 1          
   001    2 m  m Duck,Daffy                        2200 IRL     7654321 1937.04.17  2.0    1     1 w 1               3 b 1
   001    3 m  g Mouse,Mickey                      2600 USA     1726354 1928.05.15  0.0    3               1 b 0     2 w 0
@@ -29,9 +30,13 @@ ICU::Tournament (rather than <em>nil</em>, which indicates an error). In this ex
   
   tournament.name                   # => "Fantasy Tournament"
   tournament.start                  # => "2009-09-09"
-  tournament.rounds                 # => 3
   tournament.fed                    # => "IRL"
   tournament.players.size           # => 9
+
+Some values, not explicitly set in the file, are deduced:
+  
+  tournament.rounds                 # => 3
+  tournament.finish                 # => "2009-09-11"
   
 A player can be retrieved from the tournament via the _players_ array or by sending a valid player number to the _player_ method.
 
@@ -72,7 +77,7 @@ The following lists Krause data identification numbers, their description and, w
 [102 Arbiter(s)]              Get or set with -arbiter_. Free text.
 [112 Deputy(ies)]             Get or set with _deputy_. Free text.
 [122 Time control]            Get or set with _time_control_. Free text.
-[132 Round dates]             Not implemented yet.
+[132 Round dates]             Get an array of dates using _round_dates_ or one specific round date by calling _round_date_ with a round number.
 
 =end
 
@@ -131,7 +136,7 @@ The following lists Krause data identification numbers, their description and, w
               when '102' then @tournament.arbiter = @data       # arbiter(s)
               when '112' then @tournament.deputy = @data        # deputy(ies)
               when '122' then @tournament.time_control = @data  # time control
-              when '132' then add_comment                       # round dates (not implemented yet)
+              when '132' then add_round_dates                   # round dates
               else raise "invalid DIN #{din}"
             end
           rescue => err
@@ -172,6 +177,11 @@ The following lists Krause data identification numbers, their description and, w
         krause << "102 #{t.arbiter}\n"      if t.arbiter
         krause << "112 #{t.deputy}\n"       if t.deputy
         krause << "122 #{t.time_control}\n" if t.time_control
+        if t.round_dates.size > 0
+          krause << "132 #{' ' * 85}"
+          t.round_dates.each{ |d| krause << d.sub(/^../, '  ') }
+          krause << "\n"
+        end
         t.players.each{ |p| krause << p.to_krause(@tournament.rounds) }
         krause
       end
@@ -235,6 +245,16 @@ The following lists Krause data identification numbers, their description and, w
         @results << [@lineno, player, data, result]
         result.points
       end
+      
+      def add_round_dates
+        raise "round dates record less than minimum length" if @line.length < 99
+        index  = 87
+        while @data.length >= index + 8
+          date = @data[index, 8].strip
+          @tournament.add_round_date("20#{date}") unless date == ''
+          index+= 10
+        end
+      end
 
       def add_comment
         @comments << @line

data/spec/tournament_krause_spec.rb

@@ -29,7 +29,7 @@ module ICU
 022 Las Vegas
 032 USA
 042 2008.06.07
-052 2008.06.10
+052 2008.06.09
 062 3
 072 3
 082 1
@@ -40,7 +40,7 @@ module ICU
 013 Coaching Team                      1    2
 0         1         2         3         4         5         6         7         8         9         0         1         2
 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
-132                                                                                        08.02.01  08.02.02  08.02.03
+132                                                                                        08.06.07  08.06.08  08.06.09
 001    1 w    Ui Laighleis,Gearoidin            1985 IRL     2501171 1964.06.10  1.0    2     2 b 0     3 w 1          
 001    2 m  m Orr,Mark                          2258 IRL     2500035 1955.11.09  2.0    1     1 w 1               3 b 1
 001    3 m  g Bologan,Viktor                    2663 MDA    13900048 1971.01.01  0.0    3               1 b 0     2 w 0
@@ -57,7 +57,7 @@ KRAUSE
         
         it "should have start and end dates" do
           @t.start.should  == '2008-06-07'
-          @t.finish.should == '2008-06-10'
+          @t.finish.should == '2008-06-09'
         end
         
         it "should have a number of rounds, a type and a time control" do
@@ -84,6 +84,10 @@ KRAUSE
           check_results(3, 2, 0.0)
         end
         
+        it "should have correct round dates" do
+          @t.round_dates.join('|').should == '2008-06-07|2008-06-08|2008-06-09'
+        end
+        
         it "the parser should retain comment lines" do
           comments = <<COMMENTS
 062 3
@@ -92,7 +96,6 @@ KRAUSE
 013 Coaching Team                      1    2
 0         1         2         3         4         5         6         7         8         9         0         1         2
 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
-132                                                                                        08.02.01  08.02.02  08.02.03
 COMMENTS
           @p.comments.should == comments
         end
@@ -105,6 +108,7 @@ COMMENTS
 032 IRL
 042 2009.09.09
 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
+132                                                                                        09.09.09  09.09.10  09.09.11
 001    1 w    Mouse,Minerva                     1900 USA     1234567 1928.05.15  1.0    2     2 b 0     3 w 1          
 001    2 m  m Duck,Daffy                        2200 IRL     7654321 1937.04.17  2.0    1     1 w 1               3 b 1
 001    3 m  g Mouse,Mickey                      2600 USA     1726354 1928.05.15  0.0    3               1 b 0     2 w 0
@@ -118,8 +122,10 @@ KRAUSE
           @t.fed.should  == 'IRL'
         end
 
-        it "should have a startdates" do
+        it "should have a various dates" do
           @t.start.should  == '2009-09-09'
+          @t.finish.should  == '2009-09-11'
+          @t.round_dates.join('|').should == '2009-09-09|2009-09-10|2009-09-11'
         end
 
         it "should have a number of rounds" do
@@ -156,6 +162,7 @@ KRAUSE
 102 Hans Scmidt
 112 Gerry Graham, Herbert Scarry
 122 60 in 2hr, 30 in 1hr, rest in 1hr
+132                                                                                        08-06-07  08-06-08  08-06-09
 001    1 w    Ui Laighleis,Gearoidin            1985 IRL     2501171 1964-06-10  2.0    2     2 b 0     3 w +     4 b 1
 001    2 m  m Orr,Mark                          2258 IRL     2500035 1955-11-09  2.5    1     1 w 1  0000 - =     3 b 1
 001    3 m  g Bologan,Viktor                    2663 MDA    13900048 1971-01-01  0.0    4               1 b -     2 w 0

data/spec/tournament_spec.rb

@@ -2,7 +2,7 @@ require File.dirname(__FILE__) + '/spec_helper'
 
 module ICU
   describe Tournament do
-    context "a typical tournament" do
+    context "a basic tournament" do
       it "has a name, start date, some players and some results" do
         lambda do
           t = Tournament.new('Bangor Bash', '2009-11-09')
@@ -12,134 +12,129 @@ module ICU
           t.add_result(Result.new(1, 1, '=', :opponent => 2, :colour => 'W'))
           t.add_result(Result.new(2, 2, 'L', :opponent => 3, :colour => 'W'))
           t.add_result(Result.new(3, 3, 'W', :opponent => 1, :colour => 'W'))
+          t.validate!
         end.should_not raise_error
       end
     end
-    
-    # Tournament name.
+
     context "name" do
       before(:each) do
         @t = Tournament.new('Edinburgh Masters', '2009-11-09')
       end
-      
+
       it "must be specified in constructor" do
         @t.name.should == 'Edinburgh Masters'
       end
-      
+
       it "can be replaced by accessor" do
         @t.name = 'Bangor Bashers'
         @t.name.should == 'Bangor Bashers'
       end
-      
+
       it "should not be blank or without letters" do
         lambda { Tournament.new('   ', '2009-11-09') }.should raise_error(/invalid.*name/)       
         lambda { @t.name = '333' }.should raise_error(/invalid.*name/)   
       end
     end
-    
-    # Tournament city.
+
     context "city" do
       before(:each) do
         @t = Tournament.new('Edinburgh Masters', '2009-11-09', :city => 'Edinburgh')
       end
-      
+
       it "may be specified in constructor" do
         @t.city.should == 'Edinburgh'
       end
-      
+
       it "can be replaced by accessor" do
         @t.city = 'Glasgow'
         @t.city.should == 'Glasgow'
       end
-      
+
       it "can be set to nil" do
         @t.city = ''
         @t.city.should be_nil
       end
-      
+
       it "should not be without letters if set" do
         lambda { @t.city = '123' }.should raise_error(/invalid.*city/)
       end
     end
 
-    # Tournament federation.
     context "federation" do
       before(:each) do
         @t = Tournament.new('Edinburgh Masters', '2009-11-09', :fed => 'SCO')
       end
-      
+
       it "may be specified in constructor" do
         @t.fed.should == 'SCO'
       end
-      
+
       it "can be replaced by accessor" do
         @t.fed = 'IRL'
         @t.fed.should == 'IRL'
       end
-      
+
       it "can be set to nil" do
         @t.fed = ''
         @t.fed.should be_nil
       end
-      
+
       it "three letters will automatically be upcased" do
         @t.fed = 'rus'
         @t.fed.should == 'RUS'
       end
-      
+
       it "should not be without letters if set" do
         lambda { @t.fed = '123' }.should raise_error(/invalid.*federation/)
       end
     end
 
-    # Tournament start date.
     context "start date" do
       before(:each) do
         @t = Tournament.new('Edinburgh Masters', '2009-11-09')
       end
-      
+
       it "must be specified in constructor" do
         @t.start.should == '2009-11-09'
       end
-      
+
       it "can be replaced by accessor" do
         @t.start = '16th June 2010'
         @t.start.should == '2010-06-16'
       end
-      
+
       it "should be a valid date" do
         lambda { Tournament.new('Edinburgh Masters', '  ') }.should raise_error(/invalid.*date/)
         lambda { @t.start = 'X' }.should raise_error(/invalid.*date/)
       end
     end
-    
-    # Tournament finish date.
+
     context "finish date" do
       before(:each) do
         @t = Tournament.new('Edinburgh Masters', '2009-11-09', :finish => '12th November 2009')
       end
-      
+
       it "may be specified in constructor" do
         @t.finish.should == '2009-11-12'
       end
-      
+
       it "can be replaced by accessor" do
         @t.finish = '16th December 2009'
         @t.finish.should == '2009-12-16'
       end
-      
+
       it "can be set to nil" do
         @t.finish = ''
         @t.finish.should be_nil
       end
-      
+
       it "should be a valid date" do
         lambda { Tournament.new('Edinburgh Masters', '2009-11-09', :finish => 'next week') }.should raise_error(/invalid.*date/)
         lambda { @t.finish = 'X' }.should raise_error(/invalid.*date/)
       end
     end
-    
-    # Number of rounds.
+
     context "rounds" do
       it "defaults to nil" do
         Tournament.new('Edinburgh Masters', '2009-11-09').rounds.should be_nil
@@ -151,8 +146,24 @@ module ICU
         lambda { Tournament.new('Edinburgh Masters', '2009-11-09', :rounds => ' 0 ') }.should raise_error(/invalid.*rounds/)
       end
     end
-    
-    # Web site.
+
+    context "round date" do
+      before(:each) do
+        @t = Tournament.new('Edinburgh Masters', '2009-11-09')
+      end
+
+      it "should default to none" do
+        @t.round_dates.size.should == 0
+      end
+
+      it "can be added one by one in any order" do
+        @t.add_round_date('2009-11-11')
+        @t.add_round_date('09/11/2009')
+        @t.add_round_date('10th November 2009')
+        @t.round_dates.join('|').should == '2009-11-09|2009-11-10|2009-11-11'
+      end
+    end
+
     context "site" do
       it "defaults to nil" do
         Tournament.new('Edinburgh Masters', '2009-11-09').site.should be_nil
@@ -164,20 +175,19 @@ module ICU
         lambda { Tournament.new('Edinburgh Masters', '2009-11-09', :site => 'X') }.should raise_error(/invalid.*site/)
       end
     end
-    
-    # Type, arbiter, deputy and time control.
+
     context "type, arbiter, deputy and time control" do
       before(:each) do
         @t = Tournament.new('Edinburgh Masters', '2009-11-09', :type => 'Swiss', :arbiter => 'Gerry Graham', :deputy => 'Herbert Scarry', :time_control => '120 minutes')
       end
-      
+
       it "may be specified in constructor" do
         @t.type.should == 'Swiss'
         @t.arbiter.should == 'Gerry Graham'
         @t.deputy.should == 'Herbert Scarry'
         @t.time_control.should == '120 minutes'
       end
-      
+
       it "can be replaced by accessor" do
         @t.type = 'all-play-all'
         @t.type.should == 'all-play-all'
@@ -188,7 +198,7 @@ module ICU
         @t.time_control = '90 minutes'
         @t.time_control.should == '90 minutes'
       end
-      
+
       it "can be set to nil" do
         @t.type = ''
         @t.type.should be_nil
@@ -199,7 +209,7 @@ module ICU
         @t.time_control = ''
         @t.time_control.should be_nil
       end
-      
+
       it "should be valid" do
         lambda { @t.type         = '123' }.should raise_error(/invalid.*type/)
         lambda { @t.arbiter      = '123' }.should raise_error(/invalid.*arbiter/)
@@ -207,18 +217,17 @@ module ICU
         lambda { @t.time_control = 'abc' }.should raise_error(/invalid.*time control/)
       end
     end
-    
-    # Tournament players.
+
     context "players" do
       before(:each) do
         @t = Tournament.new('Edinburgh Masters', '2009-11-09')
       end
-      
+
       it "should have unique numbers" do
         @t.add_player(Player.new('Mark', 'Orr', 1))
         lambda { @t.add_player(Player.new('Bobby', 'Fischer', 1)) }.should raise_error(/player.*unique/)
       end
-      
+
       it "can be added one at a time" do
         @t.add_player(Player.new('Mark', 'Orr', -1))
         @t.add_player(Player.new('Gary', 'Kasparov', -2))
@@ -227,8 +236,7 @@ module ICU
         @t.player(-1).first_name.should == 'Mark'
       end
     end
-    
-    # Tournament results.
+
     context "results" do
       before(:each) do
         @t = Tournament.new('Edinburgh Masters', '2009-11-09', :rounds => 3)
@@ -236,7 +244,7 @@ module ICU
         @t.add_player(@gary = Player.new('Gary', 'Kasparov', 2))
         @t.add_player(@boby = Player.new('Bobby', 'Fischer', 3))
       end
-      
+
       it "can be added one at a time" do
         @t.add_result(Result.new(1, 1, 'W', :opponent => 2))
         @t.add_result(Result.new(2, 2, 'D', :opponent => 3))
@@ -248,7 +256,7 @@ module ICU
         @boby.results.size.should == 2
         @boby.points.should == 0.5
       end
-      
+
       it "can be added symmetrically or asymmetrically with respect to rateability" do
         @t.add_result(Result.new(1, 1, 'W', :opponent => 2))
         @mark.results[0].rateable.should be_true
@@ -257,20 +265,20 @@ module ICU
         @mark.results[1].rateable.should be_true
         @boby.results[0].rateable.should be_false
       end
-      
+
       it "should have a defined player" do
         lambda { @t.add_result(Result.new(1, 4, 'L', :opponent => 1)) }.should raise_error(/player.*exist/)
       end
-      
+
       it "should have a defined opponent" do
         lambda { @t.add_result(Result.new(1, 1, 'W', :opponent => 4)) }.should raise_error(/opponent.*exist/)
       end
-      
+
       it "should be consistent with the tournament's number of rounds" do
         lambda { @t.add_result(Result.new(4, 1, 'W', :opponent => 2)) }.should raise_error(/round/)
       end
     end
-    
+
     context "finding players" do
       before(:all) do
         @t = Tournament.new('Bangor Bash', '2009-11-09')
@@ -278,7 +286,7 @@ module ICU
         @t.add_player(Player.new('Garry', 'Gary Kasparov', 2, :fed => 'RUS'))
         @t.add_player(Player.new('Mark', 'Orr', 3, :fed => 'IRL'))
       end
-      
+
       it "should find players based on loose equality" do
         @t.find_player(Player.new('Mark', 'Orr', 4, :fed => 'IRL')).num.should == 3
         @t.find_player(Player.new('Mark', 'Orr', 4, :fed => 'USA')).should be_nil
@@ -286,5 +294,76 @@ module ICU
         @t.find_player(Player.new('John', 'Orr', 4, :fed => 'IRL')).should be_nil
       end
     end
+
+    context "validation" do
+      before(:each) do
+        @t = Tournament.new('Edinburgh Masters', '2009-11-09')
+        @t.add_player(@mark = Player.new('Mark', 'Orr', 1))
+        @t.add_player(@gary = Player.new('Gary', 'Kasparov', 2))
+        @t.add_player(@boby = Player.new('Bobby', 'Fischer', 3))
+        @t.add_result(Result.new(1, 1, 'W', :opponent => 2))
+        @t.add_result(Result.new(2, 2, 'W', :opponent => 3))
+        @t.add_result(Result.new(3, 3, 'L', :opponent => 1))
+        @t.add_round_date('2009-11-09')
+        @t.add_round_date('2009-11-10')
+        @t.add_round_date('2009-11-11')
+      end
+
+      it "should be valid" do
+        @t.invalid.should be_false
+      end
+
+      it "should have side effect of setting number of rounds" do
+        @t.rounds.should be_nil
+        @t.invalid
+        @t.rounds.should == 3
+      end
+
+      it "should detect an inconsistent start date" do
+        @t.start = '2009-11-10'
+        lambda { @t.validate! }.should raise_error(/first round.*before.*start/)
+      end
+
+      it "should detect an inconsistent finish date" do
+        @t.finish = '2009-11-10'
+        lambda { @t.validate! }.should raise_error(/last round.*after.*end/)
+      end
+
+      it "should have side effect of setting missing finish date" do
+        @t.finish.should be_nil
+        @t.invalid
+        @t.finish.should == '2009-11-11'
+      end
+
+      it "should detect inconsistent round dates" do
+        @t.add_round_date('2009-11-12')
+        lambda { @t.validate! }.should raise_error(/round dates.*match.*rounds/)
+      end
+
+      it "should have the side effect of providing missing ranks if the rerank option is set" do
+        @t.players.select{ |p| p.rank }.size.should == 0
+        @t.invalid(:rerank => true)
+        @t.player(1).rank.should == 1
+        @t.player(2).rank.should == 2
+        @t.player(3).rank.should == 3
+      end
+
+      it "should have the side effect of correcting bad ranks if the rerank option is set" do
+        @t.player(1).rank = 2
+        @t.player(2).rank = 1
+        @t.player(3).rank = 3
+        @t.invalid(:rerank => true)
+        @t.player(1).rank.should == 1
+        @t.player(2).rank.should == 2
+        @t.player(3).rank.should == 3
+      end
+
+      it "should detect missranked players" do
+        @t.player(1).rank = 2
+        @t.player(2).rank = 1
+        @t.player(3).rank = 3
+        lambda { @t.validate! }.should raise_error(/player 2.*above.*player 1/)
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: sanichi-chess_icu
 version: !ruby/object:Gem::Version 
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors: 
 - Mark Orr