sane_memcached_ttl 0.0.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 8eabf6e5afe588b8529425c18587573797b8bd3d
+  data.tar.gz: 04cf4fe55796da3690a4767775cd69b4917cd78e
+SHA512:
+  metadata.gz: 531f55f7481de513547df1de895422e8a56d2b2fa2fba25565f8661e628618a0ff31884961ce472a7f1e638166cf1e42416363456304c1c9311a2237a37200b6
+  data.tar.gz: 9c3b47a6d878f630b94f62dea3392fb60a6a934e46b064022809d42f56fc22381dd43052c3d94211d4f23b6f1cb81ec92dd3e97a49f99fc6cdfd13fe0a6dff8a

data/.gitignore

@@ -0,0 +1,14 @@
+/.bundle/
+/.yardoc
+/Gemfile.lock
+/_yardoc/
+/coverage/
+/doc/
+/pkg/
+/spec/reports/
+/tmp/
+*.bundle
+*.so
+*.o
+*.a
+mkmf.log

data/.ruby-gemset

@@ -0,0 +1 @@
+sane_memcached_ttl

data/.ruby-version

@@ -0,0 +1 @@
+ruby-2.1.4

data/.travis.yml

@@ -0,0 +1,15 @@
+language: ruby
+cache:
+  - bundler
+  - apt
+before_install:
+  - curl http://packages.couchbase.com/ubuntu/couchbase.key | sudo apt-key add -
+  - echo "deb http://packages.couchbase.com/ubuntu precise precise/main" | sudo tee -a /etc/apt/sources.list
+  - sudo apt-get update -qq
+  - sudo apt-get install -y libcouchbase-dev
+services:
+  - memcached
+rvm:
+  - 1.9
+  - 2.0
+  - 2.1

data/Gemfile

@@ -0,0 +1,4 @@
+source 'https://rubygems.org'
+
+# Specify your gem's dependencies in sane_memcached_ttl.gemspec
+gemspec

data/Guardfile

@@ -0,0 +1,5 @@
+guard :minitest do
+  watch(%r{^spec/(.*)_spec\.rb$})
+  watch(%r{^lib/(.+)\.rb$})         { |m| "spec/#{m[1]}_spec.rb" }
+  watch(%r{^spec/spec_helper\.rb$}) { 'spec' }
+end

data/LICENSE.txt

@@ -0,0 +1,22 @@
+Copyright (c) 2014 Errikos Koen
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -0,0 +1,73 @@
+# SaneMemcachedTtl
+
+Work around memcached's [feature](https://code.google.com/p/memcached/wiki/NewProgramming#Expiration) of treating expiration times larger than one month as timestamps for Rails cache stores.
+
+This is a memcached documented behaviour:
+
+* Store a key with expiration time of 10 seconds
+* Retrieve key ~> you get it
+* Wait 10 seconds
+* Retrieve key ~> you don't get it
+
+makes sense... but:
+
+* Store a key with expiration time of 3.000.000 seconds (about 35 days)
+* Retrieve key ~> you **don't** get it
+
+3.000.000 is treated as timestamp, so the key expired at 1970-02-04 17:20:00 (3.000.000 seconds after the UNIX epoch). So when you want to store something with an expiration time larger than a month you have to convert the expiration time to a proper timestamp. This is annoying and it even becomes impossible when you want to set default expiration times on stores.
+
+This gem provides additional cache stores, subclasses of the original ones altering this behaviour for sanity.
+
+Supported cache stores: couchbase_store, dalli_store, mem_cache_store.
+
+## Dalli note
+
+The dalli store actually fixed this on version 2.7.1 but it's kinda debated ([issue #436](https://github.com/mperham/dalli/issues/436)) on whether this should stay in as it's a documented memcached "feature" and clients should probably be not alter to these things.
+
+So **don't** use this if your dalli gem version is >= 2.7.1.
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'sane_memcached_ttl'
+```
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install sane_memcached_ttl
+
+## Usage
+
+When defining a Rails cache store like:
+
+```ruby
+config.cache_store = :mem_cache_store, "cache-1.example.com", "cache-2.example.com"
+```
+
+just change to:
+
+```ruby
+config.cache_store = :mem_cache_store_with_sane_ttl, "cache-1.example.com", "cache-2.example.com"
+```
+
+Same for all supported stores:
+
+| Original store    | Sane store                        |
+| ----------------- | --------------------------------- |
+| `mem_cache_store` | `mem_cache_store_with_sane_ttl`   |
+| `dalli_store`     | `dalli_store_store_with_sane_ttl` |
+| `couchbase_store` | `couchbase_store_with_sane_ttl`   |
+
+## Contributing
+
+1. Fork it ( https://github.com/[my-github-username]/sane_memcached_ttl/fork )
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Commit your changes (`git commit -am 'Add some feature'`)
+4. Push to the branch (`git push origin my-new-feature`)
+5. Create a new Pull Request

data/Rakefile

@@ -0,0 +1,19 @@
+require 'bundler/gem_tasks'
+require 'rake/testtask'
+
+Rake::TestTask.new do |t|
+  t.name = 'spec'
+  t.libs << 'spec'
+  t.test_files = FileList['spec/**/*_spec.rb'].exclude(/^spec\/integration\//)
+  t.verbose = true
+end
+
+Rake::TestTask.new do |t|
+  t.name = 'integration'
+  t.libs << 'spec'
+  t.test_files = FileList['spec/integration**/*_spec.rb']
+  t.verbose = true
+end
+
+desc 'Run tests'
+task :default => [:spec, :integration]

data/lib/active_support/cache/concerns/sane_memcached_ttl_helper.rb

@@ -0,0 +1,32 @@
+require 'active_support/concern'
+
+module ActiveSupport
+  module Cache
+    module Concerns
+      module SaneMemcachedTtlHelper
+        extend ActiveSupport::Concern
+        include SaneMemcachedTtl::Utils
+
+        included do
+          attr_accessor :large_default_ttl
+        end
+
+        def extract_large_default_ttl!(options, insane_options)
+          ttl = options[insane_options.find { |option| options[option] != nil }]
+
+          if ttl.present? && is_large_ttl?(ttl)
+            insane_options.each { |option| options.delete option }
+            self.large_default_ttl = ttl
+          end
+        end
+
+        def sanitize_ttl_options!(options, insane_options, default_option)
+          ttl = options[insane_options.find { |option| options[option] != nil }]
+
+          insane_options.each { |option| options.delete(option) }
+          options[default_option] = sanitize_ttl(ttl || large_default_ttl)
+        end
+      end
+    end
+  end
+end

data/lib/active_support/cache/couchbase_store_with_sane_ttl.rb

@@ -0,0 +1,38 @@
+require 'active_support/cache'
+require 'active_support/cache/couchbase_store'
+require 'active_support/cache/concerns/sane_memcached_ttl_helper'
+
+module ActiveSupport
+  module Cache
+    class CouchbaseStoreWithSaneTtl < CouchbaseStore
+
+      include ActiveSupport::Cache::Concerns::SaneMemcachedTtlHelper
+
+      def initialize(options = nil)
+        options = options || {}
+        extract_large_default_ttl! options, [:default_ttl, :expires_in]
+        super options
+      end
+
+      def increment(name, amount = 1, options = nil)
+        options = options || {}
+        sanitize_ttl_options! options, [:ttl, :expires_in], :expires_in
+        super name, amount, options
+      end
+
+      def decrement(name, amount = 1, options = nil)
+        options = options || {}
+        sanitize_ttl_options! options, [:ttl, :expires_in], :expires_in
+        super name, amount, options
+      end
+
+      protected
+
+      def write_entry(key, value, options)
+        options = options || {}
+        sanitize_ttl_options! options, [:ttl, :expires_in], :expires_in
+        super key, value, options
+      end
+    end
+  end
+end

data/lib/active_support/cache/dalli_store_with_sane_ttl.rb

@@ -0,0 +1,40 @@
+require 'active_support/cache'
+require 'active_support/notifications'
+require 'active_support/cache/dalli_store'
+require 'active_support/cache/concerns/sane_memcached_ttl_helper'
+
+module ActiveSupport
+  module Cache
+    class DalliStoreWithSaneTtl < DalliStore
+
+      include ActiveSupport::Cache::Concerns::SaneMemcachedTtlHelper
+
+      def initialize(*addresses)
+        addresses = addresses.flatten
+        options = addresses.extract_options!
+        extract_large_default_ttl! options, [:expires_in]
+        super addresses, options
+      end
+
+      def increment(name, amount = 1, options = nil)
+        options = options || {}
+        sanitize_ttl_options! options, [:expires_in], :expires_in
+        super name, amount, options
+      end
+
+      def decrement(name, amount = 1, options = nil)
+        options = options || {}
+        sanitize_ttl_options! options, [:expires_in], :expires_in
+        super name, amount, options
+      end
+
+      protected
+
+      def write_entry(key, value, options)
+        options = options || {}
+        sanitize_ttl_options! options, [:expires_in], :expires_in
+        super key, value, options
+      end
+    end
+  end
+end

data/lib/active_support/cache/mem_cache_store_with_sane_ttl.rb

@@ -0,0 +1,40 @@
+require 'active_support/cache'
+require 'active_support/cache/mem_cache_store'
+require 'active_support/cache/concerns/sane_memcached_ttl_helper'
+require 'active_support/notifications'
+
+module ActiveSupport
+  module Cache
+    class MemCacheStoreWithSaneTtl < MemCacheStore
+
+      include ActiveSupport::Cache::Concerns::SaneMemcachedTtlHelper
+
+      def initialize(*addresses)
+        addresses = addresses.flatten
+        options = addresses.extract_options!
+        extract_large_default_ttl! options, [:expires_in]
+        super addresses, options
+      end
+
+      def increment(name, amount = 1, options = nil)
+        options = options || {}
+        sanitize_ttl_options! options, [:expires_in], :expires_in
+        super name, amount, options
+      end
+
+      def decrement(name, amount = 1, options = nil)
+        options = options || {}
+        sanitize_ttl_options! options, [:expires_in], :expires_in
+        super name, amount, options
+      end
+
+      protected
+
+      def write_entry(key, value, options)
+        options = options || {}
+        sanitize_ttl_options! options, [:expires_in], :expires_in
+        super key, value, options
+      end
+    end
+  end
+end

data/lib/sane_memcached_ttl.rb

@@ -0,0 +1,7 @@
+require 'sane_memcached_ttl/version'
+
+module SaneMemcachedTtl
+  # Your code goes here...
+end
+
+require 'sane_memcached_ttl/utils'

data/lib/sane_memcached_ttl/utils.rb

@@ -0,0 +1,17 @@
+module SaneMemcachedTtl
+  module Utils
+    MEMCACHED_MAX_TTL = 30 * 24 * 60 * 60 # 30 days
+
+    def sanitize_ttl(ttl)
+      is_large_ttl?(ttl) ? ttl_to_timestamp(ttl) : ttl
+    end
+
+    def is_large_ttl?(ttl)
+      ttl.to_i > MEMCACHED_MAX_TTL
+    end
+
+    def ttl_to_timestamp(ttl)
+      Time.now.utc.to_i + ttl.to_i
+    end
+  end
+end

data/lib/sane_memcached_ttl/version.rb

@@ -0,0 +1,3 @@
+module SaneMemcachedTtl
+  VERSION = '0.0.1'
+end

data/sane_memcached_ttl.gemspec

@@ -0,0 +1,34 @@
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'sane_memcached_ttl/version'
+
+Gem::Specification.new do |spec|
+  spec.name          = 'sane_memcached_ttl'
+  spec.version       = SaneMemcachedTtl::VERSION
+  spec.authors       = ['Errikos Koen']
+  spec.email         = ['eirc.eric@gmail.com']
+  spec.summary       = %q{Add sanity to memcached expiration times.}
+  spec.homepage      = 'https://github.com/eirc/sane_memcached_ttl'
+  spec.license       = 'MIT'
+
+  spec.files         = `git ls-files -z`.split("\x0")
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ['lib']
+
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake', '~> 10.0'
+
+  spec.add_development_dependency 'activesupport'
+
+  # Cache stores
+  spec.add_development_dependency 'couchbase'
+  spec.add_development_dependency 'dalli', '< 2.7.1'
+
+  # Testing gems
+  spec.add_development_dependency 'minitest'
+  spec.add_development_dependency 'mocha'
+  spec.add_development_dependency 'guard'
+  spec.add_development_dependency 'guard-minitest'
+end

data/spec/active_support/cache/couchbase_store_with_sane_ttl_spec.rb

@@ -0,0 +1,333 @@
+require 'spec_helper'
+require 'mocha/setup'
+require 'active_support/cache/couchbase_store_with_sane_ttl'
+
+module ActiveSupport::Cache
+  describe CouchbaseStoreWithSaneTtl do
+    let (:small_ttl) { 7 * 24 * 60 * 60 }
+    let (:large_ttl) { 6 * 30 * 24 * 60 * 60 }
+
+    describe '#initialize' do
+      it 'should remove from options and store large default_ttl value' do
+        Couchbase::Bucket.expects(:new).with do |options|
+          options[:default_ttl].must_be_nil
+          options[:expires_in].must_be_nil
+        end
+
+        store = ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                                  :default_ttl => large_ttl
+
+        store.large_default_ttl.must_equal large_ttl
+      end
+
+      it 'should remove from options and store large expires_in value' do
+        Couchbase::Bucket.expects(:new).with do |options|
+          options[:default_ttl].must_be_nil
+          options[:expires_in].must_be_nil
+        end
+
+        store = ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                                  :expires_in => large_ttl
+
+        store.large_default_ttl.must_equal large_ttl
+      end
+
+      it 'should not remove from options or store small default_ttl value' do
+        Couchbase::Bucket.expects(:new).with do |options|
+          options[:default_ttl].must_equal small_ttl
+          options[:expires_in].must_be_nil
+        end
+
+        store = ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                                  :default_ttl => small_ttl
+
+        store.large_default_ttl.must_be_nil
+      end
+
+      it 'should not remove or store small expires_in value' do
+        Couchbase::Bucket.expects(:new).with do |options|
+          options[:default_ttl].must_equal small_ttl
+          options[:expires_in].must_be_nil
+        end
+
+        store = ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                                  :expires_in => small_ttl
+
+        store.large_default_ttl.must_be_nil
+      end
+    end
+
+    describe '#increment' do
+      describe 'with no default tll' do
+        let(:bucket_mock) { mock }
+        subject do
+          Couchbase::Bucket.expects(:new).returns(bucket_mock)
+          ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl
+        end
+
+        it 'should convert ttl to timestamp when set to large value' do
+          bucket_mock.expects(:incr).with do |key, amount, options|
+            options[:ttl].must_equal Time.now.utc.to_i + large_ttl
+          end
+          subject.increment 'key', 1, :expires_in => large_ttl
+        end
+
+        it 'should keep ttl intact when set to small value' do
+          bucket_mock.expects(:incr).with do |key, amount, options|
+            options[:ttl].must_equal small_ttl
+          end
+          subject.increment 'key', 1, :expires_in => small_ttl
+        end
+
+        it 'should leave ttl nil when not set' do
+          bucket_mock.expects(:incr).with do |key, amount, options|
+            options[:ttl].must_be_nil
+          end
+          subject.increment 'key', 1
+        end
+      end
+
+      describe 'with large default tll' do
+        let(:bucket_mock) { mock }
+        subject do
+          Couchbase::Bucket.expects(:new).returns(bucket_mock)
+          ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                            :expires_in => large_ttl
+        end
+
+        it 'should convert ttl to timestamp when set to large value' do
+          bucket_mock.expects(:incr).with do |key, amount, options|
+            options[:ttl].must_equal Time.now.utc.to_i + large_ttl
+          end
+          subject.increment 'key', 1, :expires_in => large_ttl
+        end
+
+        it 'should keep ttl intact when set to small value' do
+          bucket_mock.expects(:incr).with do |key, amount, options|
+            options[:ttl].must_equal small_ttl
+          end
+          subject.increment 'key', 1, :expires_in => small_ttl
+        end
+
+        it 'should calculate from default ttl when not set' do
+          bucket_mock.expects(:incr).with do |key, amount, options|
+            (options[:ttl]).must_equal Time.now.utc.to_i + large_ttl
+          end
+          subject.increment 'key', 1
+        end
+      end
+
+      describe 'with small default tll' do
+        let(:bucket_mock) { mock }
+        subject do
+          Couchbase::Bucket.expects(:new).returns(bucket_mock)
+          ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                            :default_ttl => small_ttl
+        end
+
+        it 'should convert ttl to timestamp when set to large value' do
+          bucket_mock.expects(:incr).with do |key, amount, options|
+            options[:ttl].must_equal Time.now.utc.to_i + large_ttl
+          end
+          subject.increment 'key', 1, :expires_in => large_ttl
+        end
+
+        it 'should keep ttl intact when set to small value' do
+          bucket_mock.expects(:incr).with do |key, amount, options|
+            options[:ttl].must_equal small_ttl
+          end
+          subject.increment 'key', 1, :expires_in => small_ttl
+        end
+
+        it 'should leave ttl nil when not set' do
+          bucket_mock.expects(:incr).with do |key, amount, options|
+            options[:ttl].must_be_nil
+          end
+          subject.increment 'key', 1
+        end
+      end
+    end
+
+    describe '#decrement' do
+      describe 'with no default tll' do
+        let(:bucket_mock) { mock }
+        subject do
+          Couchbase::Bucket.expects(:new).returns(bucket_mock)
+          ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl
+        end
+
+        it 'should convert ttl to timestamp when set to large value' do
+          bucket_mock.expects(:decr).with do |key, amount, options|
+            options[:ttl].must_equal Time.now.utc.to_i + large_ttl
+          end
+          subject.decrement 'key', 1, :expires_in => large_ttl
+        end
+
+        it 'should keep ttl intact when set to small value' do
+          bucket_mock.expects(:decr).with do |key, amount, options|
+            options[:ttl].must_equal small_ttl
+          end
+          subject.decrement 'key', 1, :expires_in => small_ttl
+        end
+
+        it 'should leave ttl nil when not set' do
+          bucket_mock.expects(:decr).with do |key, amount, options|
+            options[:ttl].must_be_nil
+          end
+          subject.decrement 'key', 1
+        end
+      end
+
+      describe 'with large default tll' do
+        let(:bucket_mock) { mock }
+        subject do
+          Couchbase::Bucket.expects(:new).returns(bucket_mock)
+          ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                            :default_ttl => large_ttl
+        end
+
+        it 'should convert ttl to timestamp when set to large value' do
+          bucket_mock.expects(:decr).with do |key, amount, options|
+            options[:ttl].must_equal Time.now.utc.to_i + large_ttl
+          end
+          subject.decrement 'key', 1, :expires_in => large_ttl
+        end
+
+        it 'should keep ttl intact when set to small value' do
+          bucket_mock.expects(:decr).with do |key, amount, options|
+            options[:ttl].must_equal small_ttl
+          end
+          subject.decrement 'key', 1, :expires_in => small_ttl
+        end
+
+        it 'should calculate from default ttl when not set' do
+          bucket_mock.expects(:decr).with do |key, amount, options|
+            options[:ttl].must_equal Time.now.utc.to_i + large_ttl
+          end
+          subject.decrement 'key', 1
+        end
+      end
+
+      describe 'with small default tll' do
+        let(:bucket_mock) { mock }
+        subject do
+          Couchbase::Bucket.expects(:new).returns(bucket_mock)
+          ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                            :default_ttl => small_ttl
+        end
+
+        it 'should convert ttl to timestamp when set to large value' do
+          bucket_mock.expects(:decr).with do |key, amount, options|
+            options[:ttl].must_equal Time.now.utc.to_i + large_ttl
+          end
+          subject.decrement 'key', 1, :expires_in => large_ttl
+        end
+
+        it 'should keep ttl intact when set to small value' do
+          bucket_mock.expects(:decr).with do |key, amount, options|
+            options[:ttl].must_equal small_ttl
+          end
+          subject.decrement 'key', 1, :expires_in => small_ttl
+        end
+
+        it 'should leave ttl nil when not set' do
+          bucket_mock.expects(:decr).with do |key, amount, options|
+            options[:ttl].must_be_nil
+          end
+          subject.decrement 'key', 1
+        end
+      end
+    end
+
+    describe '#write' do
+      describe 'with no default tll' do
+        let(:bucket_mock) { mock }
+        subject do
+          Couchbase::Bucket.expects(:new).returns(bucket_mock)
+          ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl
+        end
+
+        it 'should convert ttl to timestamp when set to large value' do
+          bucket_mock.expects(:set).with do |key, value, options|
+            options[:ttl].must_equal Time.now.utc.to_i + large_ttl
+          end
+          subject.write 'key', 'value', :expires_in => large_ttl
+        end
+
+        it 'should keep ttl intact when set to small value' do
+          bucket_mock.expects(:set).with do |key, value, options|
+            options[:ttl].must_equal small_ttl
+          end
+          subject.write 'key', 'value', :expires_in => small_ttl
+        end
+
+        it 'should leave ttl nil when not set' do
+          bucket_mock.expects(:set).with do |key, value, options|
+            options[:ttl].must_be_nil
+          end
+          subject.write 'key', 'value'
+        end
+      end
+
+      describe 'with large default tll' do
+        let(:bucket_mock) { mock }
+        subject do
+          Couchbase::Bucket.expects(:new).returns(bucket_mock)
+          ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                            :default_ttl => large_ttl
+        end
+
+        it 'should convert ttl to timestamp when set to large value' do
+          bucket_mock.expects(:set).with do |key, value, options|
+            options[:ttl].must_equal Time.now.utc.to_i + large_ttl
+          end
+          subject.write 'key', 'value', :expires_in => large_ttl
+        end
+
+        it 'should keep ttl intact when set to small value' do
+          bucket_mock.expects(:set).with do |key, value, options|
+            options[:ttl].must_equal small_ttl
+          end
+          subject.write 'key', 'value', :expires_in => small_ttl
+        end
+
+        it 'should calculate from default ttl when not set' do
+          bucket_mock.expects(:set).with do |key, value, options|
+            options[:ttl].must_equal Time.now.utc.to_i + large_ttl
+          end
+          subject.write 'key', 'value'
+        end
+      end
+
+      describe 'with small default tll' do
+        let(:bucket_mock) { mock }
+        subject do
+          Couchbase::Bucket.expects(:new).returns(bucket_mock)
+          ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                            :default_ttl => small_ttl
+        end
+
+        it 'should convert ttl to timestamp when set to large value' do
+          bucket_mock.expects(:set).with do |key, value, options|
+            options[:ttl].must_equal Time.now.utc.to_i + large_ttl
+          end
+          subject.write 'key', 'value', :expires_in => large_ttl
+        end
+
+        it 'should keep ttl intact when set to small value' do
+          bucket_mock.expects(:set).with do |key, value, options|
+            options[:ttl].must_equal small_ttl
+          end
+          subject.write 'key', 'value', :expires_in => small_ttl
+        end
+
+        it 'should leave ttl nil when not set' do
+          bucket_mock.expects(:set).with do |key, value, options|
+            options[:ttl].must_be_nil
+          end
+          subject.write 'key', 'value'
+        end
+      end
+    end
+  end
+end

data/spec/integration/couchbase_stores_spec.rb

@@ -0,0 +1,101 @@
+require 'spec_helper'
+require 'active_support/cache'
+
+module ActiveSupport::Cache
+  describe 'couchbase stores' do
+    let(:large_ttl) { 6 * 30 * 24 * 60 * 60 }
+
+    before do
+      begin
+        ActiveSupport::Cache.lookup_store :couchbase_store,
+                                          CACHE_SETTINGS[:couchbase]
+      rescue
+        skip 'Cannot connect to Couchbase server, skipping integration tests.'
+      end
+    end
+
+    describe 'with connection ttls' do
+      it 'couchbase_store_with_sane_ttl does store keys with large connection default_ttl' do
+        store = ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                                  CACHE_SETTINGS[:couchbase].merge(:default_ttl => large_ttl)
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value'
+        store.read('key').must_equal 'value'
+        store.delete 'key'
+      end
+
+      it 'couchbase_store does not store keys with large connection default_ttl' do
+        store = ActiveSupport::Cache.lookup_store :couchbase_store,
+                                                  CACHE_SETTINGS[:couchbase].merge(:default_ttl => large_ttl)
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value'
+        store.read('key').must_be_nil
+        store.delete 'key'
+      end
+
+      it 'couchbase_store_with_sane_ttl does store keys with large connection expires_in' do
+        store = ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                                  CACHE_SETTINGS[:couchbase].merge(:expires_in => large_ttl)
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value'
+        store.read('key').must_equal 'value'
+        store.delete 'key'
+      end
+
+      it 'couchbase_store does not store keys with large connection expires_in' do
+        store = ActiveSupport::Cache.lookup_store :couchbase_store,
+                                                  CACHE_SETTINGS[:couchbase].merge(:expires_in => large_ttl)
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value'
+        store.read('key').must_be_nil
+        store.delete 'key'
+      end
+    end
+
+    describe 'with ttls on write' do
+      it 'couchbase_store_with_sane_ttl does store keys with large expires_in' do
+        store = ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                                  CACHE_SETTINGS[:couchbase]
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value', :expires_in => large_ttl
+        store.read('key').must_equal 'value'
+        store.delete 'key'
+      end
+
+      it 'couchbase_store does not store keys with large expires_in' do
+        store = ActiveSupport::Cache.lookup_store :couchbase_store,
+                                                  CACHE_SETTINGS[:couchbase]
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value', :expires_in => large_ttl
+        store.read('key').must_be_nil
+        store.delete 'key'
+      end
+
+      it 'couchbase_store_with_sane_ttl does store keys with large ttl' do
+        store = ActiveSupport::Cache.lookup_store :couchbase_store_with_sane_ttl,
+                                                  CACHE_SETTINGS[:couchbase]
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value', :ttl => large_ttl
+        store.read('key').must_equal 'value'
+        store.delete 'key'
+      end
+
+      it 'couchbase_store does not store keys with large ttl' do
+        store = ActiveSupport::Cache.lookup_store :couchbase_store,
+                                                  CACHE_SETTINGS[:couchbase]
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value', :ttl => large_ttl
+        store.read('key').must_be_nil
+        store.delete 'key'
+      end
+    end
+  end
+end

data/spec/integration/dalli_stores_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+require 'active_support/cache'
+require 'active_support/notifications'
+require 'dalli'
+
+module ActiveSupport::Cache
+  describe 'dalli stores' do
+    let(:large_ttl) { 6 * 30 * 24 * 60 * 60 }
+
+    before do
+      # Silence all logging to make an initial check on whether server is up
+      Dalli.logger.level = Logger::UNKNOWN
+      store = ActiveSupport::Cache.lookup_store :dalli_store,
+                                                CACHE_SETTINGS[:dalli]
+
+      if store.stats.values.all? { |value| value == nil }
+        skip 'Cannot connect to Memcached server, skipping dalli stores integration specs.'
+      end
+
+      # Silence connection info messages from dalli
+      Dalli.logger.level = Logger::WARN
+    end
+
+    describe 'with connection ttls' do
+      it 'dalli_store_with_sane_ttl does store keys with large connection expires_in' do
+        store = ActiveSupport::Cache.lookup_store :dalli_store_with_sane_ttl,
+                                                  CACHE_SETTINGS[:dalli],
+                                                  :expires_in => large_ttl
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value'
+        store.read('key').must_equal 'value'
+        store.delete 'key'
+      end
+
+      it 'dalli_store does not store keys with large connection expires_in' do
+        store = ActiveSupport::Cache.lookup_store :dalli_store,
+                                                  CACHE_SETTINGS[:dalli],
+                                                  :expires_in => large_ttl
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value'
+        store.read('key').must_be_nil
+        store.delete 'key'
+      end
+    end
+
+    describe 'with ttls on write' do
+      it 'dalli_store_with_sane_ttl does store keys with large expires_in' do
+        store = ActiveSupport::Cache.lookup_store :dalli_store_with_sane_ttl,
+                                                  CACHE_SETTINGS[:dalli]
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value', :expires_in => large_ttl
+        store.read('key').must_equal 'value'
+        store.delete 'key'
+      end
+
+      it 'dalli_store does not store keys with large expires_in' do
+        store = ActiveSupport::Cache.lookup_store :dalli_store,
+                                                  CACHE_SETTINGS[:dalli]
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value', :expires_in => large_ttl
+        store.read('key').must_be_nil
+        store.delete 'key'
+      end
+    end
+  end
+end

data/spec/integration/mem_cache_stores_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+require 'active_support/cache'
+require 'dalli'
+
+module ActiveSupport::Cache
+  describe 'mem cache stores' do
+    let(:large_ttl) { 6 * 30 * 24 * 60 * 60 }
+
+    before do
+      # Silence all logging to make an initial check on whether server is up (mem_cache_store is backed by a dalli client)
+      Dalli.logger.level = Logger::UNKNOWN
+      store = ActiveSupport::Cache.lookup_store :mem_cache_store,
+                                        CACHE_SETTINGS[:mem_cache]
+
+      if store.stats.values.all? { |value| value == nil }
+        skip 'Cannot connect to Memcached server, skipping mem cache stores integration specs.'
+      end
+
+      # Silence connection info messages
+      Dalli.logger.level = Logger::WARN
+    end
+
+    describe 'with connection ttls' do
+      it 'mem_cache_store_with_sane_ttl does store keys with large connection expires_in' do
+        store = ActiveSupport::Cache.lookup_store :mem_cache_store_with_sane_ttl,
+                                                  CACHE_SETTINGS[:mem_cache],
+                                                  :expires_in => large_ttl
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value'
+        store.read('key').must_equal 'value'
+        store.delete 'key'
+      end
+
+      it 'mem_cache_store does not store keys with large connection expires_in' do
+        store = ActiveSupport::Cache.lookup_store :mem_cache_store,
+                                                  CACHE_SETTINGS[:mem_cache],
+                                                  :expires_in => large_ttl
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value'
+        store.read('key').must_be_nil
+        store.delete 'key'
+      end
+    end
+
+    describe 'with ttls on write' do
+      it 'mem_cache_store_with_sane_ttl does store keys with large expires_in' do
+        store = ActiveSupport::Cache.lookup_store :mem_cache_store_with_sane_ttl,
+                                                  CACHE_SETTINGS[:mem_cache]
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value', :expires_in => large_ttl
+        store.read('key').must_equal 'value'
+        store.delete 'key'
+      end
+
+      it 'mem_cache_store does not store keys with large expires_in' do
+        store = ActiveSupport::Cache.lookup_store :mem_cache_store,
+                                                  CACHE_SETTINGS[:mem_cache]
+
+        store.read('key').must_be_nil
+        store.write 'key', 'value', :expires_in => large_ttl
+        store.read('key').must_be_nil
+        store.delete 'key'
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,10 @@
+require 'minitest/spec'
+require 'minitest/autorun'
+
+require 'sane_memcached_ttl'
+
+CACHE_SETTINGS = {
+    :couchbase => {},
+    :dalli => [],
+    :mem_cache => []
+}

metadata

@@ -0,0 +1,197 @@
+--- !ruby/object:Gem::Specification
+name: sane_memcached_ttl
+version: !ruby/object:Gem::Version
+  version: 0.0.1
+platform: ruby
+authors:
+- Errikos Koen
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2014-10-31 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: couchbase
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: dalli
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 2.7.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 2.7.1
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: 
+email:
+- eirc.eric@gmail.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".gitignore"
+- ".ruby-gemset"
+- ".ruby-version"
+- ".travis.yml"
+- Gemfile
+- Guardfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- lib/active_support/cache/concerns/sane_memcached_ttl_helper.rb
+- lib/active_support/cache/couchbase_store_with_sane_ttl.rb
+- lib/active_support/cache/dalli_store_with_sane_ttl.rb
+- lib/active_support/cache/mem_cache_store_with_sane_ttl.rb
+- lib/sane_memcached_ttl.rb
+- lib/sane_memcached_ttl/utils.rb
+- lib/sane_memcached_ttl/version.rb
+- sane_memcached_ttl.gemspec
+- spec/active_support/cache/couchbase_store_with_sane_ttl_spec.rb
+- spec/integration/couchbase_stores_spec.rb
+- spec/integration/dalli_stores_spec.rb
+- spec/integration/mem_cache_stores_spec.rb
+- spec/spec_helper.rb
+homepage: https://github.com/eirc/sane_memcached_ttl
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.4.2
+signing_key: 
+specification_version: 4
+summary: Add sanity to memcached expiration times.
+test_files:
+- spec/active_support/cache/couchbase_store_with_sane_ttl_spec.rb
+- spec/integration/couchbase_stores_spec.rb
+- spec/integration/dalli_stores_spec.rb
+- spec/integration/mem_cache_stores_spec.rb
+- spec/spec_helper.rb