sandthorn 0.9.1 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a0905a8e583c0c46aa86f5db5b1d9415afa991e
-  data.tar.gz: 56ea78db0b5c871b8e807bbd53a6ae321db983cd
+  metadata.gz: 3e61d651d859798c915aa2cce28faece11f1d4c7
+  data.tar.gz: 592053f9f191cc595b7ccb6a517da939f881fb02
 SHA512:
-  metadata.gz: a16f549f541a59451de1504b9c985fa629033010b77bfb3a8347a5d8b18afb9fc2c7a2ac89229eb9b86444b89fcec67d955de8453f91bceb79b98400b5fc1545
-  data.tar.gz: 1540e391ae9dd007d33ef442d40984435f70746847d61a6b7f972ddde18f919d862bc589c9b381905b3ca77859f4cdabc1e6cd09fae294515396f9854e14bbe5
+  metadata.gz: f7c6fd3e0611518d6ad6d6383bcd99a0b24bf09bca5ccc4f59da46299a83f6e4c19b503cfda4f656ecd813f4a56e3aa6381d3e55cd6abec427c7ce4a55d59564
+  data.tar.gz: f7b104d6f9302685981e39e9d21e9eff0bb60f74bffb5e0fd05717e1984d934e36c7751317c5e853046dad5ccb8b29a8b461838d6293f9fe4b683f7da2df019b

data/lib/sandthorn/aggregate_root_base.rb

@@ -50,26 +50,23 @@ module Sandthorn
       def commit *args
         aggregate_attribute_deltas = get_delta
 
-        unless aggregate_attribute_deltas.empty?
-          method_name = caller_locations(1,1)[0].label.gsub(/block ?(.*) in /, "")
-          increase_current_aggregate_version!
-
-          data = {
-            method_name: method_name,
-            method_args: args,
-            attribute_deltas: aggregate_attribute_deltas
-          }
-          trace_information = @aggregate_trace_information
-          unless trace_information.nil? || trace_information.empty?
-            data.merge!({ trace: trace_information })
-          end
-
-          @aggregate_events << ({
-            aggregate_version: @aggregate_current_event_version,
-            event_name: method_name,
-            event_args: data
-          })
-        end
+        method_name = caller_locations(1,1)[0].label.gsub(/block ?(.*) in /, "")
+        increase_current_aggregate_version!
+        data = {
+          method_name: method_name,
+          method_args: args,
+          attribute_deltas: aggregate_attribute_deltas
+        }
+        trace_information = @aggregate_trace_information
+        unless trace_information.nil? || trace_information.empty?
+          data.merge!({ trace: trace_information })
+        end
+
+        @aggregate_events << ({
+          aggregate_version: @aggregate_current_event_version,
+          event_name: method_name,
+          event_args: data
+        })
 
         self
       end

data/lib/sandthorn/version.rb

@@ -1,3 +1,3 @@
 module Sandthorn
-  VERSION = "0.9.1"
+  VERSION = "0.9.2"
 end

data/spec/aggregate_root_spec.rb

@@ -35,7 +35,9 @@ module Sandthorn
         end
       end
 
-      
+      def no_state_change_only_empty_event
+        commit
+      end
     end
 
     describe "::event_store" do
@@ -74,7 +76,7 @@ module Sandthorn
 
 
     describe "when making a change on a aggregate" do
-      let(:dirty_obejct) { 
+      let(:dirty_object) { 
         o = DirtyClass.new
         o
       }
@@ -92,56 +94,56 @@ module Sandthorn
       context "when changing name (attr_reader)" do
         
         it "should get new_name" do
-          dirty_obejct.change_name "new_name"
-          expect(dirty_obejct.name).to eql "new_name"
+          dirty_object.change_name "new_name"
+          expect(dirty_object.name).to eql "new_name"
         end
 
         it "should generate one event on new" do
-          expect(dirty_obejct.aggregate_events.length).to eql 1
+          expect(dirty_object.aggregate_events.length).to eql 1
         end
 
         it "should generate 2 events new and change_name" do
-          dirty_obejct.change_name "new_name"
-          expect(dirty_obejct.aggregate_events.length).to eql 2
+          dirty_object.change_name "new_name"
+          expect(dirty_object.aggregate_events.length).to eql 2
         end
       end
 
       context "when changing sex (attr)" do
         it "should get new_sex" do
-          dirty_obejct.change_sex "new_sex"
-          expect(dirty_obejct.sex).to eql "new_sex"
+          dirty_object.change_sex "new_sex"
+          expect(dirty_object.sex).to eql "new_sex"
         end
       end
 
       context "when changing writer (attr_writer)" do
         it "should raise error" do
-          expect{dirty_obejct.change_writer "new_writer"}.to raise_error
+          expect{dirty_object.change_writer "new_writer"}.to raise_error
         end
       end
 
       context "save" do
         it "should not have events on aggregete after save" do
-          expect(dirty_obejct.save.aggregate_events.length).to eql 0
+          expect(dirty_object.save.aggregate_events.length).to eql 0
         end
 
         it "should have aggregate_originating_version == 0 pre save" do
-          expect(dirty_obejct.aggregate_originating_version).to eql 0
+          expect(dirty_object.aggregate_originating_version).to eql 0
         end
 
         it "should have aggregate_originating_version == 1 post save" do
-          expect(dirty_obejct.save.aggregate_originating_version).to eql 1
+          expect(dirty_object.save.aggregate_originating_version).to eql 1
         end
       end
 
       context "find" do
-        before(:each) { dirty_obejct.save }
+        before(:each) { dirty_object.save }
         it "should find by id" do
-          expect(DirtyClass.find(dirty_obejct.id).id).to eql dirty_obejct.id
+          expect(DirtyClass.find(dirty_object.id).id).to eql dirty_object.id
         end
 
         it "should hold changed name" do
-          dirty_obejct.change_name("morgan").save
-          expect(DirtyClass.find(dirty_obejct.id).name).to eql "morgan"
+          dirty_object.change_name("morgan").save
+          expect(DirtyClass.find(dirty_object.id).name).to eql "morgan"
         end
 
         it "should raise error if trying to find id that not exist" do
@@ -154,18 +156,18 @@ module Sandthorn
 
     describe "event data" do
 
-      let(:dirty_obejct) { 
+      let(:dirty_object) { 
         o = DirtyClass.new :name => "old_value", :sex => "hen"
         o.save
       }
 
-      let(:dirty_obejct_after_find) { DirtyClass.find dirty_obejct.id }
+      let(:dirty_object_after_find) { DirtyClass.find dirty_object.id }
 
       context "after find" do
 
         it "should set the old_value on the event" do
-          dirty_obejct_after_find.change_name "new_name"
-          expect(dirty_obejct_after_find.aggregate_events.last[:event_args][:attribute_deltas].first[:old_value]).to eql "old_value"
+          dirty_object_after_find.change_name "new_name"
+          expect(dirty_object_after_find.aggregate_events.last[:event_args][:attribute_deltas].first[:old_value]).to eql "old_value"
         end
 
       end
@@ -173,18 +175,18 @@ module Sandthorn
       context "old_value should be set" do
       
         it "should set the old_value on the event" do
-          dirty_obejct.change_name "new_name"
-          expect(dirty_obejct.aggregate_events.last[:event_args][:attribute_deltas].first[:old_value]).to eql "old_value"
+          dirty_object.change_name "new_name"
+          expect(dirty_object.aggregate_events.last[:event_args][:attribute_deltas].first[:old_value]).to eql "old_value"
         end
 
         it "should not change aggregate_id" do
-          dirty_obejct.change_name "new_name"
-          expect(dirty_obejct.aggregate_events.last[:event_args][:attribute_deltas].last[:attribute_name]).not_to eql "aggregate_id"
+          dirty_object.change_name "new_name"
+          expect(dirty_object.aggregate_events.last[:event_args][:attribute_deltas].last[:attribute_name]).not_to eql "aggregate_id"
         end
 
         it "should not change sex attribute if sex method is not runned" do
-          dirty_obejct.change_name "new_name"
-          dirty_obejct.aggregate_events.each do |event|
+          dirty_object.change_name "new_name"
+          dirty_object.aggregate_events.each do |event|
             event[:event_args][:attribute_deltas].each do |attribute_delta|
               expect(attribute_delta[:attribute_name]).not_to eql "sex"
             end
@@ -192,8 +194,8 @@ module Sandthorn
         end
 
         it "should not change sex attribute if sex attribute is the same" do
-          dirty_obejct.change_sex "hen"
-          dirty_obejct.aggregate_events.each do |event|
+          dirty_object.change_sex "hen"
+          dirty_object.aggregate_events.each do |event|
             event[:event_args][:attribute_deltas].each do |attribute_delta|
               expect(attribute_delta[:attribute_name]).not_to eql "sex"
             end
@@ -201,11 +203,28 @@ module Sandthorn
         end
 
         it "should set old_value and new_value on sex change" do
-          dirty_obejct.change_sex "shemale"
-          expect(dirty_obejct.aggregate_events.last[:event_args][:attribute_deltas].first[:old_value]).to eql "hen"
-          expect(dirty_obejct.aggregate_events.last[:event_args][:attribute_deltas].first[:new_value]).to eql "shemale"
+          dirty_object.change_sex "shemale"
+          expect(dirty_object.aggregate_events.last[:event_args][:attribute_deltas].first[:old_value]).to eql "hen"
+          expect(dirty_object.aggregate_events.last[:event_args][:attribute_deltas].first[:new_value]).to eql "shemale"
+        end
+      end
+    end
+
+    context "events should be created event if no state change is made" do
+      let(:dirty_object) do
+        DirtyClass.new.save.tap do |o|
+          o.no_state_change_only_empty_event
         end
       end
+
+      it "should have the event no_state_change_only_empty_event" do
+        expect(dirty_object.aggregate_events.first[:event_name]).to eql("no_state_change_only_empty_event")
+      end
+
+      it "should have attribute_deltas set to empty array" do
+        expect(dirty_object.aggregate_events.first[:event_args][:attribute_deltas]).to eql([])
+      end
+
     end
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sandthorn
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.2
 platform: ruby
 authors:
 - Lars Krantz
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-29 00:00:00.000000000 Z
+date: 2015-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler