sandi_meter 0.0.2 → 0.0.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NzI2Nzc1NDI0OWYyNTExZTJjMGViMWQ2YmNkNzU3YmNhNWU5YmM0MQ==
+    NTkxMGM4NTg4OTVkNjY2MjkyNGZlNTg3YTM0YjdlMTFkNmJlZjcwZA==
   data.tar.gz: !binary |-
-    Njg4MzcxYmMyMDhiOTBhNTJjYTE1MzFhYWM5Yjc0ZWU2YjgyZGE0NA==
+    NTRkZDc2YzMzNDAzMDczM2ZlNTI1MTNmNjk4NGFhMGRiMmM3NDM1OA==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    YTI5YzRhNDExYTg5MTg2ZGUyM2E4NGI0ODE5MjI5YjY1MTg5MTQ1MDNmYTM1
-    NzM2NWU2Y2ZlZGQxNmZlMzIyMmE4ZDI3MjgzY2E1MDYzMWIzZTRjMTI4MDQ4
-    M2Y5MWZhYTA5MzZlM2NjMDk3ZTM2OTI4Y2UyMWM4ZWUwMmNjYWU=
+    ZWMwNTNhZTgyZjY0OGIyYmNmNjc2OTQ2ZWQyMTkzMGIyMjliOGVmNGFhOGQz
+    YmQ1NTU0NTA1ZTYwNmY2YmU5OGRmZmVjZDU0ZDgzYjg5MmE2MWY3MWEzM2Mx
+    MzZlNTI5ZmU3YTg2ZmY2ZWU5MWM3NzVkZjAyNWJhYjlmZDdiN2Y=
   data.tar.gz: !binary |-
-    ZDExZWRiZTA3ODQ1YWY5YTA0NGY4NzZkYzc5YWE5NTNhODBhYzI5M2RlYTkz
-    NzMwMzE1NDJhZjE5OTI3MWVkNzhmMTVmOGY0NmM0Y2MwYmI5MmZjYTJlYmRl
-    MWE4NTVlNmRkNDI2NzJiYzU0NWE0MWEwMTFjMDVmZGZiNDA4YTc=
+    MDNiOGNlYjc3MjdjMmE4Njg2MWU4ODhmNmVjMTg1ODAyOTM5NTMwNTdjNmFk
+    ODczMjczNWMyMDZiZmUwY2FlYTJkYmY3MmM1OTA3YjVhZGU1NDA4M2UyZjk1
+    NTBjYTQ1NGMyMmJhMmY5YjU2NDM0ZWQ1NzQ1NWQwMjU5MWYyYjM=

data/README.md

@@ -1,6 +1,6 @@
 # SandiMeter
 
-Static analysis tool for checking your Ruby code for [Sandi Metz' for rules](http://robots.thoughtbot.com/post/50655960596/sandi-metz-rules-for-developers).
+Static analysis tool for checking your Ruby code for [Sandi Metz' four rules](http://robots.thoughtbot.com/post/50655960596/sandi-metz-rules-for-developers).
 
 * 100 lines per class
 * 5 lines per method

data/bin/sandi_meter

@@ -1,10 +1,55 @@
 #!/usr/bin/env ruby
 
+require 'mixlib/cli'
 require_relative '../lib/sandi_meter/file_scanner'
 require_relative '../lib/sandi_meter/formatter'
 
-scanner = SandiMeter::FileScanner.new(ARGV[1] == "--log")
-data = scanner.scan(ARGV[0])
+class MyCLI
+  include Mixlib::CLI
+
+  option :path,
+    short: "-p PATH",
+    long: "--path PATH",
+    description: "Path to folder or file to analyze",
+    default: "."
+
+  option :log,
+    short: "-l",
+    long: "--log",
+    description: "Show syntax error and indentation log output",
+    boolean: true
+
+  option :help,
+    short: "-h",
+    long: "--help",
+    description: "Help",
+    on: :tail,
+    boolean: true,
+    show_options: true,
+    exit: 0
+
+  option :rules,
+    short: "-r",
+    long: "--rules",
+    description: "Show rules",
+    boolean: 0
+end
+
+cli = MyCLI.new
+cli.parse_options
+
+if cli.config[:rules]
+  puts %(
+    1. 100 lines per class
+    2. 5 lines per method
+    3. 4 params per method call (and don't even try cheating with hash params)
+    4. 1 instance variables per controller' action
+  )
+  exit 0
+end
+
+scanner = SandiMeter::FileScanner.new(cli.config[:log])
+data = scanner.scan(cli.config[:path])
 formatter = SandiMeter::Formatter.new
 
 formatter.print_data(data)

data/lib/sandi_meter/loc_checker.rb

@@ -13,7 +13,7 @@ module SandiMeter
 
     private
     def locs_size(first_line, last_line)
-      file_lines[first_line - 1..last_line - 1].map(&:strip).reject(&:empty?).size
+      file_lines[first_line - 1..last_line - 1].size
     end
   end
 end

data/lib/sandi_meter/version.rb

@@ -1,3 +1,3 @@
 module SandiMeter
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/analyzer_spec.rb

@@ -4,7 +4,7 @@ require_relative '../lib/sandi_meter/analyzer'
 describe SandiMeter::Analyzer do
   let(:analyzer) { SandiMeter::Analyzer.new }
 
-  describe 'finds properly indended classes with lines' do
+  describe 'finds properly indented classes with lines' do
     let(:test_class) { test_file_path(3) }
 
     before do
@@ -44,7 +44,7 @@ describe SandiMeter::Analyzer do
     end
   end
 
-  describe 'finds properly indended classes in one file' do
+  describe 'finds properly indented classes in one file' do
     let(:test_class) { test_file_path(4) }
 
     before do
@@ -160,4 +160,20 @@ describe SandiMeter::Analyzer do
       analyzer.method_calls.should eq([[5, 3]])
     end
   end
+
+  describe 'empty lines inside class' do
+    let(:test_class) { test_file_path(12) }
+
+    before do
+      analyzer.analyze(test_class)
+    end
+
+    it 'are count for class definition' do
+      analyzer.classes.should eq([["Valera", 1, 109, false]])
+    end
+
+    it 'are count for method definition' do
+      analyzer.methods.should eq({"Valera"=>[["doodle", 2, 9, 0, false]]})
+    end
+  end
 end

data/spec/test_classes/12.rb

@@ -0,0 +1,110 @@
+class Valera
+  def doodle
+
+
+
+
+
+
+  end
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+end
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sandi_meter
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Anatoli Makarevich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-18 00:00:00.000000000 Z
+date: 2013-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -65,6 +65,7 @@ files:
 - spec/test_classes/1.rb
 - spec/test_classes/10.rb
 - spec/test_classes/11.rb
+- spec/test_classes/12.rb
 - spec/test_classes/2.rb
 - spec/test_classes/3.rb
 - spec/test_classes/4.rb