samvera-nesting_indexer 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d85b5e9c924b8da1ab4155a9144073696f0d8aba
-  data.tar.gz: a49b5e3004e1b477d878343ce702a03ce02244e4
+  metadata.gz: eda0716fd21bf940a1579608723873ead488df6e
+  data.tar.gz: 6496a06843f6d404036595c82238662275d465d6
 SHA512:
-  metadata.gz: 2769007dd241f6eddf9be40857685f87f7e55a18ac103acb9674242df470388cb45dbc2cf7aa06a5b57bb20a278ea31c254eb3d1c06a225e5de0c79c514b60e5
-  data.tar.gz: bb3bbaface89adceb926133b867ccbe188ec026a1611e3db3c4180aacaddc91bc196a36805dc27c27a083c1776cc08b569107ea3412f4941497b59cf49bc2945
+  metadata.gz: 0d6e41b470b8e3655c8f01f5a2eb593f44b1bf7dd3739363502b65a51bd77c8b5e52e0f84a02b3adba21ea63891fa7368c0660880916016ff0d2ee96a6364bc0
+  data.tar.gz: 647c0d4d3b3e4b50ca0c69cb220b01745e5c77ccb1144c26853f1533a81b7b480fe74454e45b8ba101b2e7489d9606517f007beb3b4bfc86700f11db776b50c8

data/lib/samvera/nesting_indexer/adapters/abstract_adapter.rb

@@ -33,8 +33,9 @@ module Samvera
         end
 
         # @api public
+        # @param attributes [Hash]
         # @return Hash - the attributes written to the indexing layer
-        def self.write_document_attributes_to_index_layer(attributes = {})
+        def self.write_document_attributes_to_index_layer(attributes:)
           raise NotImplementedError
         end
       end

data/lib/samvera/nesting_indexer/adapters/in_memory_adapter.rb

@@ -40,14 +40,16 @@ module Samvera
         # @api public
         # This is not something that I envision using in the production environment;
         # It is hear to keep the Preservation system isolated and accessible only through interfaces.
+        # @param attributes [Hash]
         # @return Samvera::NestingIndexer::Documents::PreservationDocument
-        def self.write_document_attributes_to_preservation_layer(attributes = {})
+        def self.write_document_attributes_to_preservation_layer(attributes)
           Preservation.write_document(attributes)
         end
 
         # @api public
+        # @param attributes [Hash]
         # @return Hash - the attributes written to the indexing layer
-        def self.write_document_attributes_to_index_layer(attributes = {})
+        def self.write_document_attributes_to_index_layer(attributes:)
           Index.write_document(attributes)
         end
 

data/lib/samvera/nesting_indexer/adapters/interface_behavior_spec.rb

@@ -1,13 +1,18 @@
 if defined?(RSpec)
   RSpec.shared_examples 'a Samvera::NestingIndexer::Adapter' do
-    let(:required_parameters_extractor) { ->(method) { method.parameters.select { |type, kwarg| type == :keyreq }.map(&:last) } }
+    let(:required_keyword_parameters) { ->(method) { method.parameters.select { |type, kwarg| type == :keyreq }.map(&:last) } }
+    let(:required_parameters) { ->(method) { method.parameters.select { |type, kwarg| type == :keyreq || type == :req }.map(&:last) } }
     let(:block_parameter_extracter) { ->(method) { method.parameters.select { |type, kwarg| type == :block }.map(&:last) } }
 
     describe '.find_preservation_document_by' do
       subject { described_class.method(:find_preservation_document_by) }
 
       it 'requires the :id  keyword (and does not require any others)' do
-        expect(required_parameters_extractor.call(subject)).to eq([:id])
+        expect(required_keyword_parameters.call(subject)).to eq([:id])
+      end
+
+      it 'does not require any other parameters (besides :id)' do
+        expect(required_parameters.call(subject)).to eq(required_keyword_parameters.call(subject))
       end
 
       it 'does not expect a block' do
@@ -18,7 +23,11 @@ if defined?(RSpec)
       subject { described_class.method(:find_index_document_by) }
 
       it 'requires the :id  keyword (and does not require any others)' do
-        expect(required_parameters_extractor.call(subject)).to eq([:id])
+        expect(required_keyword_parameters.call(subject)).to eq([:id])
+      end
+
+      it 'does not require any other parameters (besides :id)' do
+        expect(required_parameters.call(subject)).to eq(required_keyword_parameters.call(subject))
       end
 
       it 'does not expect a block' do
@@ -29,7 +38,11 @@ if defined?(RSpec)
       subject { described_class.method(:each_preservation_document) }
 
       it 'requires no keywords' do
-        expect(required_parameters_extractor.call(subject)).to eq([])
+        expect(required_keyword_parameters.call(subject)).to eq([])
+      end
+
+      it 'does not require any parameters' do
+        expect(required_parameters.call(subject)).to eq(required_keyword_parameters.call(subject))
       end
 
       it 'expects a block' do
@@ -40,7 +53,11 @@ if defined?(RSpec)
       subject { described_class.method(:each_child_document_of) }
 
       it 'requires the :document keyword (and does not require any others)' do
-        expect(required_parameters_extractor.call(subject)).to eq([:document])
+        expect(required_keyword_parameters.call(subject)).to eq([:document])
+      end
+
+      it 'does not require any other parameters (besides :document)' do
+        expect(required_parameters.call(subject)).to eq(required_keyword_parameters.call(subject))
       end
 
       it 'expects a block' do
@@ -48,6 +65,19 @@ if defined?(RSpec)
       end
     end
     describe '.write_document_attributes_to_index_layer' do
+      subject { described_class.method(:write_document_attributes_to_index_layer) }
+
+      it 'requires the :attributes keyword (and does not require any others)' do
+        expect(required_keyword_parameters.call(subject)).to eq([:attributes])
+      end
+
+      it 'does not require any other parameters (besides :attributes)' do
+        expect(required_parameters.call(subject)).to eq(required_keyword_parameters.call(subject))
+      end
+
+      it 'does not expect a block' do
+        expect(block_parameter_extracter.call(subject)).to be_empty
+      end
     end
   end
 end

data/lib/samvera/nesting_indexer/relationship_reindexer.rb

@@ -72,7 +72,7 @@ module Samvera
         raise Exceptions::CycleDetectionError, id if index_document.maximum_nesting_depth <= 0
         preservation_document = adapter.find_preservation_document_by(id: index_document.id)
         parent_ids_and_path_and_ancestors = parent_ids_and_path_and_ancestors_for(preservation_document)
-        adapter.write_document_attributes_to_index_layer(parent_ids_and_path_and_ancestors)
+        adapter.write_document_attributes_to_index_layer(attributes: parent_ids_and_path_and_ancestors)
       end
 
       def parent_ids_and_path_and_ancestors_for(preservation_document)

data/lib/samvera/nesting_indexer/version.rb

@@ -1,5 +1,5 @@
 module Samvera
   module NestingIndexer
-    VERSION = "0.3.0".freeze
+    VERSION = "0.3.1".freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: samvera-nesting_indexer
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Jeremy Friesen