samurai 0.2.24 → 0.2.25

data/lib/samurai/processor_response.rb

@@ -10,4 +10,10 @@ class Samurai::ProcessorResponse < Samurai::Base
     avs_result_code_message && avs_result_code_message.key
   end
 
+  # Helper method for accessing the CVV result code from the response messages
+  def cvv_result_code
+    cvv_result_code_message = self.messages.find {|m| m.context=='processor.cvv_result_code' || m.context=='gateway.cvv_result_code' }
+    cvv_result_code_message && cvv_result_code_message.key
+  end
+
 end

data/lib/samurai/transaction.rb

@@ -5,25 +5,25 @@
 # It can be used to query Transactions & capture/void/credit/reverse
 class Samurai::Transaction < Samurai::Base
   include Samurai::CacheableByToken
-  
+
   # Alias for `transaction_token`
   def id
     transaction_token
   end
   alias_method :token, :id
-  
+
   # Captures an authorization. Optionally specify an `amount` to do a partial capture of the initial
   # authorization. The default is to capture the full amount of the authorization.
   def capture(amount = nil, options = {})
     execute(:capture, {:amount => amount || self.amount}.reverse_merge(options))
   end
-  
-  # Void this transaction. If the transaction has not yet been captured and settled it can be voided to 
+
+  # Void this transaction. If the transaction has not yet been captured and settled it can be voided to
   # prevent any funds from transferring.
   def void(options = {})
     execute(:void, options)
   end
-  
+
   # Create a credit or refund against the original transaction.
   # Optionally accepts an `amount` to credit, the default is to credit the full
   # value of the original amount
@@ -34,9 +34,7 @@ class Samurai::Transaction < Samurai::Base
   # Reverse this transaction.  First, tries a void.
   # If a void is unsuccessful, (because the transaction has already settled) perform a credit for the full amount.
   def reverse(options = {})
-    transaction = void(options)
-    return transaction if transaction.processor_response.success
-    return credit(nil, options)
+    execute(:reverse, {:amount => amount || self.amount}.reverse_merge(options))
   end
 
   def success?

data/lib/samurai/version.rb

@@ -1,3 +1,3 @@
 module Samurai
-  VERSION = "0.2.24".freeze
+  VERSION = "0.2.25".freeze
 end

data/spec/lib/authorization_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
 describe "processing authorizations" do
-  
+
   before :each do
     payment_method_token = create_payment_method(default_payment_method_params)[:payment_method_token]
     @authorization = Samurai::Processor.authorize(payment_method_token, 1.0, :billing_reference=>rand(1000))
   end
-  
+
   it "should create a new authorization transaction" do
     @authorization.processor_response.success.should be_true
   end
@@ -20,7 +20,7 @@ describe "processing authorizations" do
     capture = @authorization.capture(1.0)
     capture.processor_response.success.should be_true
   end
-  
+
   it "should capture an authorization without specifying an amount" do
     capture = @authorization.capture
     capture.amount.should == "#{1.0}"
@@ -28,8 +28,8 @@ describe "processing authorizations" do
   end
 
   it "should partially capture an authorization" do
-    capture = @authorization.capture(1.0 - BigDecimal('0.5'))
-    capture.amount.should == "#{1.0 - BigDecimal('0.5')}"
+    capture = @authorization.capture(BigDecimal('0.5'))
+    capture.amount.should == "#{BigDecimal('0.5')}"
     capture.processor_response.success.should be_true
   end
 
@@ -40,17 +40,13 @@ describe "processing authorizations" do
 
   it "should credit an authorization for the full amount by default" do
     credit = @authorization.credit
-    credit.amount.should == "#{1.0}"
-    pending "the response is not successful since the authorization hasn't settled" do
-      credit.processor_response.success.should be_true
-    end
+    credit.amount.should == "#{BigDecimal('0.5')}"
+    credit.processor_response.success.should be_true
   end
 
   it "should partially credit an authorization" do
-    credit = @authorization.credit(1.0 - BigDecimal('0.5'))
-    credit.amount.should == "#{1.0 - BigDecimal('0.5')}"
-    pending "the response is not successful since the authorization hasn't settled" do
-      credit.processor_response.success.should be_true
-    end
+    credit = @authorization.credit(BigDecimal('0.5'))
+    credit.amount.should == "#{BigDecimal('0.5')}"
+    credit.processor_response.success.should be_true
   end
 end

data/spec/lib/processor_spec.rb

@@ -9,16 +9,16 @@ describe "Processor actions" do
     processor = Samurai::Processor.the_processor
     processor.should_not be_nil
   end
-  
+
   it "should create a new purchase" do
-    purchase = Samurai::Processor.purchase(@payment_method_token, @seed)
+    purchase = Samurai::Processor.purchase(@payment_method_token, 1.0, :billing_reference=>rand(1000))
     purchase.processor_response.success.should be_true
     # FakeWeb.last_request
   end
 
   it "should create a new purchase with tracking data" do
-    purchase = Samurai::Processor.purchase(@payment_method_token, @seed, {
-      :descriptor => "A test purchase", 
+    purchase = Samurai::Processor.purchase(@payment_method_token, 1.0, {
+      :descriptor => "A test purchase",
       :custom => "some optional custom data",
       :billing_reference => "ABC123",
       :customer_reference => "Customer (123)"
@@ -26,10 +26,10 @@ describe "Processor actions" do
     purchase.processor_response.success.should be_true
     # FakeWeb.last_request
   end
-    
+
   it "should create a non-new authorization" do
-    authorization = Samurai::Processor.authorize(@payment_method_token, @seed)
+    authorization = Samurai::Processor.authorize(@payment_method_token, 1.0)
     authorization.processor_response.success.should be_true
   end
-  
+
 end

data/spec/lib/purchase_spec.rb

@@ -17,24 +17,24 @@ describe "processing purchases" do
       void.processor_response.success.should be_true
     end
 
-    it "should not be able to credit a recent purchase" do
+    it "should be able to credit a recent purchase" do
       credit = @purchase.credit
-      credit.processor_response.success.should be_false
+      credit.processor_response.success.should be_true
+      credit.transaction_type.should == 'Credit'
     end
 
     it "should be able to reverse a recent purchase" do
       reverse = @purchase.reverse
       reverse.processor_response.success.should be_true
+      reverse.transaction_type.should == 'Credit'
     end
 
     it "should be able to reverse a settled purchase" do
-      pending "currently we cannot force settle a purchase, so can't test this properly"
       reverse = @purchase.reverse
       reverse.processor_response.success.should be_true
     end
 
     it "should be able to credit a settled purchase" do
-      pending "currently we cannot force settle a purchase, so can't test this properly"
       credit = @purchase.credit
       credit.processor_response.success.should be_true
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: samurai
 version: !ruby/object:Gem::Version
-  version: 0.2.24
+  version: 0.2.25
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-04 00:00:00.000000000Z
+date: 2011-11-11 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource
-  requirement: &70345403388140 !ruby/object:Gem::Requirement
+  requirement: &70107049098300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,10 @@ dependencies:
         version: 2.2.2
   type: :runtime
   prerelease: false
-  version_requirements: *70345403388140
+  version_requirements: *70107049098300
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70345403387640 !ruby/object:Gem::Requirement
+  requirement: &70107049097080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +33,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *70345403387640
+  version_requirements: *70107049097080
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70345403387140 !ruby/object:Gem::Requirement
+  requirement: &70107049095700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: 2.6.0
   type: :development
   prerelease: false
-  version_requirements: *70345403387140
+  version_requirements: *70107049095700
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: &70345403386760 !ruby/object:Gem::Requirement
+  requirement: &70107049094120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +55,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70345403386760
+  version_requirements: *70107049094120
 - !ruby/object:Gem::Dependency
   name: ruby-debug19
-  requirement: &70345403386220 !ruby/object:Gem::Requirement
+  requirement: &70107049093040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,7 +66,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70345403386220
+  version_requirements: *70107049093040
 description: If you are an online merchant and using samurai.feefighters.com, this
   gem will make your life easy. Integrate with the samurai.feefighters.com portal
   and process transaction.