sampling_prof 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 --- 
 SHA1: 
-  metadata.gz: 67a32fb9840e432741396d9678bfdff29325ae6d
-  data.tar.gz: f09d48a2ab060f0a21e3a72e65818ecde00f1e61
+  metadata.gz: a34b1b2f319695ae28caf643e852eb60f8fa77d2
+  data.tar.gz: 10eb087c4dbbf7fac115ae910119ef62ee922423
 SHA512: 
-  metadata.gz: 6a78021baf2b12e5ad9d88ac050814a02a15ba3987ee1b3f5988547f8e4b90ad04ff4cf8a74ce612c8c49ac3044b2c599296a713335ea47b159354f6468b104d
-  data.tar.gz: 0efb16d632fca6470ea2dfc338857d47f3f69938aa68b40cf34db2fe2db9a1a7efe01130ea67d1ccd021cc681befc31c913f30488b55ca8cbc3a13c52b5da7c6
+  metadata.gz: 8b590f513f6055b87469484db2c9f1034d3b1c0b3ce0ebcada5110c1dcd613493cd36efa4af1f7d42487904f35e34e3b267f2b786bb17d57dfb609120c9d45a0
+  data.tar.gz: 8fecad2a160fe99ec0630720b1d330dddfbb5f24b733788a5b972b3b9f99078ca1246c29fa88256b60a5a0c4ab4be6383e4d35f4ea55a90dfdd4d3af0061c5ab

data/README.md

@@ -35,6 +35,10 @@ The default value is 0.1 seconds.
 
 When running SamplingProf in multithreading environment (e.g. Rails multithreading production environment), you need turn on multithreading mode so that you can profile all requests processing at same time cross threads.
 
+For performance concerns, multithreading mode will only take limit number of threads' sample while profiling. The default max samples of the threads is 4, you can change it by set max_sampling_threads.
+
+Since we randomly find max_sampling_threads number of threads in profiling threads, the result is still a statistical approximation.
+
 ### output interval
 
 Output interval controls how frequent SamplingProf should call output handler to flush out cached data.
@@ -62,6 +66,9 @@ It should be only one line.
 The time unit is ms.
 Runtime can be used to compute an estimated runtime of a call element.
 
+When it's multithreading mode, the runtime result is a little bit tricky.
+But think about we queuing up all threads, and put them into single thread, the time doing sampling in this one single thread is the runtime we output here.
+
 ### call element id map
 
 For storage efficiency, we build this map for counts and call graph chunks to use id instead of a call element string.

data/lib/sampling_prof/internal.rb

@@ -28,7 +28,7 @@ class SamplingProf
     end
 
     def process
-      @threads.each do |thread|
+      @threads.sample_threads.each do |thread|
         locations = thread.backtrace_locations
         from = -1
         paths = []
@@ -64,22 +64,21 @@ class SamplingProf
   end
 
   class Threads
+    attr_accessor :max
+
     def initialize
       @hash = {}
       @mutex = Mutex.new
       @remain_sampling_time = 0
+      @max = 4
     end
 
-    def each(&block)
-      dup.each(&block)
-    end
-
-    def dup
-      @mutex.synchronize { @hash.keys.dup }
+    def sample_threads
+      @mutex.synchronize { @hash.keys.dup.shuffle[0..@max] }
     end
 
-    def add(obj)
-      @mutex.synchronize { @hash[obj] = Time.now }
+    def add(obj, time=Time.now)
+      @mutex.synchronize { @hash[obj] = time }
     end
 
     def sampling_runtime
@@ -110,6 +109,10 @@ class SamplingProf
     @threads = Threads.new
   end
 
+  def max_sampling_threads=(max)
+    @threads.max = max
+  end
+
   def start
     if @multithreading || !@running
       @running = true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: sampling_prof
 version: !ruby/object:Gem::Version 
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors: 
   - Xiao Li
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2014-03-27 00:00:00 Z
+date: 2014-03-28 00:00:00 Z
 dependencies: 
   - !ruby/object:Gem::Dependency 
     name: rake-compiler