saml-kit 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8a6f4a6a0647cd31ca56459bcc2c1925a1cc4842d86626b44ac72cbe9df0d91d
-  data.tar.gz: 9b82a518435e992fe4e034eea0da43ffcde66f6e1cad26f3d87d39b0b4d17dac
+  metadata.gz: fa485135c5f5f05fd68485afd0c7b7d6632f2614ec563bdc01da7dd4f28f17f9
+  data.tar.gz: 25cb0b089d88668ba9164375f0f7b79912cfdd8fea2f62a6ecb0a8c125758fa3
 SHA512:
-  metadata.gz: 0d1c8f0652f11111137a40b9a95a7430879fbc19b14993919d7309a4f1c2f50cd2041bf40928e9513b950508c41cc58acd666bcb2be8b2bfc474844e2cb4e5d2
-  data.tar.gz: ea30a028893904452ef216f56001a9a84681f09a31fa62d324651aa59112f7179974740070d21918f58b764c0709af4943501c9d0e2e1965d3e6e327e03834f3
+  metadata.gz: c3cceecfd6d9b921903a6ea7e3a010742fe9d2447aa2ca384d31af280ec372650025272d58f111ff7c0025578540e4af49ac685f0d079cc7d6d37e72093cdc6b
+  data.tar.gz: a6a4dfe4d470bd57fd901aaced1a465682bbbb0b53002c21d4d10bac89f6821cc2b31c09abceeaf227b344baff7c33c12bfd4b0d0a75c362919c988fcd1cc94b

data/lib/saml/kit/builders/assertion.rb

@@ -6,10 +6,11 @@ module Saml
         include XmlTemplatable
         extend Forwardable
 
-        def_delegators :@response_builder, :embed_signature, :request, :issuer, :reference_id, :now, :configuration, :user, :version, :destination
+        def_delegators :@response_builder, :request, :issuer, :reference_id, :now, :configuration, :user, :version, :destination
 
-        def initialize(response_builder)
+        def initialize(response_builder, embed_signature)
           @response_builder = response_builder
+          self.embed_signature = embed_signature
         end
 
         def name_id_format

data/lib/saml/kit/builders/response.rb

@@ -35,12 +35,10 @@ module Saml
           nil
         end
 
-        private
-
         def assertion
           @assertion ||=
             begin
-              assertion = Saml::Kit::Builders::Assertion.new(self)
+              assertion = Saml::Kit::Builders::Assertion.new(self, embed_signature)
               if encrypt
                 Saml::Kit::Builders::EncryptedAssertion.new(self, assertion)
               else
@@ -49,6 +47,8 @@ module Saml
             end
         end
 
+        private
+
         def response_options
           {
             ID: id,

data/lib/saml/kit/metadata.rb

@@ -77,7 +77,9 @@ module Saml
       def certificates
         @certificates ||= document.find_all("/md:EntityDescriptor/md:#{name}/md:KeyDescriptor").map do |item|
           cert = item.at_xpath("./ds:KeyInfo/ds:X509Data/ds:X509Certificate", NAMESPACES).text
-          ::Xml::Kit::Certificate.new(cert, use: item.attribute('use').value.to_sym)
+          attribute = item.attribute('use')
+          use = attribute.nil? ? nil : item.attribute('use').value
+          ::Xml::Kit::Certificate.new(cert, use: use)
         end
       end
 

data/lib/saml/kit/response.rb

@@ -26,8 +26,6 @@ module Saml
           self.errors[attribute] << error
         end
       end
-
-      Builder = ActiveSupport::Deprecation::DeprecatedConstantProxy.new('Saml::Kit::Response::Builder', 'Saml::Kit::Builders::Response')
     end
   end
 end

data/lib/saml/kit/version.rb

@@ -1,5 +1,5 @@
 module Saml
   module Kit
-    VERSION = "1.0.2"
+    VERSION = "1.0.3"
   end
 end

data/lib/saml/kit/xml_templatable.rb

@@ -12,7 +12,8 @@ module Saml
       # Returns true if an embedded signature is requested and at least one signing certificate is available via the configuration.
       def sign?
         return configuration.sign? if embed_signature.nil?
-        embed_signature && configuration.sign?
+        (embed_signature && configuration.sign?) ||
+          (embed_signature && @signing_key_pair.present?)
       end
 
       def digest_method

data/saml-kit.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "activemodel", ">= 4.2.0"
-  spec.add_dependency "xml-kit", "~> 0.1"
+  spec.add_dependency "xml-kit", ">= 0.1.5", "<= 1.0.0"
   spec.add_development_dependency "bundler", "~> 1.15"
   spec.add_development_dependency "ffaker", "~> 2.7"
   spec.add_development_dependency "rake", "~> 10.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: saml-kit
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - mo khan
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-02-03 00:00:00.000000000 Z
+date: 2018-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -28,16 +28,22 @@ dependencies:
   name: xml-kit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.1.5
+    - - "<="
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.1.5
+    - - "<="
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement