samagotchi 0.79.0 → 0.80.0

data/lib/samagotchi/testing/sessions.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+require_relative "../plugin/context"
+
+module Samagotchi
+  module Testing
+    # One ctx.sessions call: the method's name and its arguments.
+    SessionCall = Data.define(:name, :args, :options)
+
+    # ctx.sessions recorded (Plugin::Sessions' methods, same signatures:
+    # the contract spec checks): each call lands in #calls and returns a
+    # scripted answer (#on), or by default: fork a new id ("fork-1"…), send
+    # and stop the id they got, children [], read raises
+    # Plugin::Sessions::Error (no such session).
+    #
+    #   bundle.sessions.on(:children) { |all:| [{ id: "c1", status: "running" }] }
+    #   bundle.sessions.on(:send) { |id, text, delivery:| raise Samagotchi::Plugin::Sessions::Error, "busy" }
+    class Sessions
+      METHODS = %i[fork send read children stop].freeze
+
+      def initialize
+        @calls = []
+        @scripts = {}
+        @forks = 0
+        @mutex = Mutex.new
+      end
+
+      # @return [Array<SessionCall>]
+      def calls = @mutex.synchronize { @calls.dup }
+
+      # The calls of one method.
+      def calls_to(method) = calls.select { |call| call.name == method }
+
+      # Answer +method+'s calls with the block (it gets the call's
+      # arguments; a raise is the call's).
+      def on(method, &block)
+        raise ArgumentError, "ctx.sessions has no #{method} (#{METHODS.join(", ")})" unless METHODS.include?(method)
+        raise ArgumentError, "on(#{method}) needs a block" unless block
+
+        @mutex.synchronize { @scripts[method] = block }
+        self
+      end
+
+      def fork(messages:, title: nil, prompt: nil)
+        answer(:fork, [], { messages: messages, title: title, prompt: prompt }) do
+          "fork-#{@mutex.synchronize { @forks += 1 }}"
+        end
+      end
+
+      def send(id, text, delivery: nil)
+        answer(:send, [id, text], { delivery: delivery }) { id }
+      end
+
+      def read(id)
+        answer(:read, [id], {}) { raise Plugin::Sessions::Error, "no session #{id}" }
+      end
+
+      def children(all: false)
+        answer(:children, [], { all: all }) { [] }
+      end
+
+      def stop(id)
+        answer(:stop, [id], {}) { id }
+      end
+
+      private
+
+      def answer(method, args, options)
+        script = @mutex.synchronize do
+          @calls << SessionCall.new(name: method, args: args.freeze, options: options.freeze)
+          @scripts[method]
+        end
+        script ? script.call(*args, **options) : yield
+      end
+    end
+  end
+end

data/lib/samagotchi/testing/verdict.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require_relative "../guardrails/verdict"
+
+module Samagotchi
+  module Testing
+    # One deny! or ask! a voter cast, kept or not.
+    Vote = Data.define(:decision, :reason, :options)
+
+    # A real Guardrails::Verdict that also records every deny! and ask!
+    # (#votes), for tests that count votes or check their keywords
+    # (advice:, rule:), even the ones a stricter earlier vote ignored.
+    class Verdict < Guardrails::Verdict
+      # @return [Array<Vote>]
+      def votes = (@votes ||= [])
+
+      def deny!(reason, **options)
+        votes << Vote.new(decision: :deny, reason: reason, options: options)
+        super
+      end
+
+      def ask!(reason, **options)
+        votes << Vote.new(decision: :ask, reason: reason, options: options)
+        super
+      end
+    end
+  end
+end

data/lib/samagotchi/testing/waiting.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module Samagotchi
+  module Testing
+    # Waiting with a deadline, for a test that waits on a thread or a
+    # process (Helpers has them).
+    module Waiting
+      # The block's value once truthy, polled every +interval+ s; after
+      # +timeout+ s its last (falsy) value.
+      def wait_until(timeout: 5, interval: 0.01)
+        deadline = Process.clock_gettime(Process::CLOCK_MONOTONIC) + timeout
+        until (value = yield)
+          return yield if Process.clock_gettime(Process::CLOCK_MONOTONIC) > deadline
+
+          sleep(interval)
+        end
+        value
+      end
+
+      # #wait_until, raising "timed out after N s waiting for <what>" when
+      # the time runs out: for a wait no check follows.
+      def wait_until!(what, timeout: 5, interval: 0.01, &)
+        wait_until(timeout: timeout, interval: interval, &) || raise("timed out after #{timeout} s waiting for #{what}")
+      end
+
+      # Whether no process +pid+ is left (a killed grandchild is reaped a
+      # moment later: wait_until { process_gone?(pid) }).
+      def process_gone?(pid)
+        Process.kill(0, pid)
+        false
+      rescue Errno::ESRCH
+        true
+      end
+    end
+  end
+end

data/lib/samagotchi/testing.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+# The bundle test kit (docs/plugins.md, "Testing a bundle"): load a bundle's
+# plugin and hook files through chi's own loaders, registries, Context and
+# guardrail Gate, with only the edges recorded (the session's Host, the hook
+# runtime, ctx.sessions, init tasks), in a sandboxed environment.
+#
+# EXPERIMENTAL: it may change in any release before 1.0.0; it is not part of
+# "Stable for bundles".
+#
+#   require "samagotchi/testing"            # plain Ruby
+#   require "samagotchi/testing/rspec"      # RSpec helpers
+#   require "samagotchi/testing/minitest"   # Samagotchi::Testing::Case
+require_relative "version"
+require_relative "testing/sandbox"
+require_relative "testing/recorder"
+require_relative "testing/host"
+require_relative "testing/sessions"
+require_relative "testing/fake_http"
+require_relative "testing/verdict"
+require_relative "testing/recording_api"
+require_relative "testing/waiting"
+require_relative "testing/fake_executable"
+require_relative "testing/bundle"
+require_relative "testing/helpers"
+require_relative "testing/boundary"

data/lib/samagotchi/tools/delegate_relay.rb

@@ -5,6 +5,7 @@ require_relative "../bridge_client"
 require_relative "../relay"
 require_relative "../guardrails/approval"
 require_relative "../log"
+require_relative "../question_answer"
 
 module Samagotchi
   # Loaded on first use (a require cycle otherwise; see delegate.rb).
@@ -84,10 +85,10 @@ module Samagotchi
           return closed(answer[:reason].to_s, what, client: client, relay_id: relay_id, qid: qid)
         end
 
-        dismissed = !(answer.is_a?(Hash) && answer[:selected])
-        by = answer.is_a?(Hash) && answer[:by] == "parent_agent" ? "parent_agent" : "user"
-        desk.record(relay_id, selected_indices: dismissed ? [] : Array(answer[:selected_indices]),
-                              freeform: dismissed ? nil : answer[:freeform], dismissed: dismissed, by: by)
+        dismissed = !answer.is_a?(QuestionAnswer)
+        by = answer.is_a?(QuestionAnswer) && answer.parent_agent? ? "parent_agent" : "user"
+        desk.record(relay_id, selected_indices: dismissed ? [] : answer.selected_indices,
+                              freeform: dismissed ? nil : answer.freeform, dismissed: dismissed, by: by)
         response = post(client, "answered", relay_id, qid)
         Outcome.new(line: line(what, delivered(response, answer, fields, dismissed)), stopped: false)
       end
@@ -118,7 +119,7 @@ module Samagotchi
       # allowed once / allowed for its session / denied ("why")
       def verdict(answer, fields)
         scopes = Array(fields.dig(:approval, :scopes))
-        index = Array(answer[:selected_indices]).first
+        index = answer.selected_indices.first
         if index && index < scopes.size
           return case scopes[index].to_s
                  when "once" then "allowed once"
@@ -129,7 +130,7 @@ module Samagotchi
                  end
         end
 
-        why = answer[:freeform].to_s.strip
+        why = answer.freeform.to_s.strip
         why.empty? ? "denied" : "denied (#{why.inspect})"
       end
 

data/lib/samagotchi/tools/tool_index.rb

@@ -194,6 +194,9 @@ module Samagotchi
         nil
       end
 
+      # @return [Array<Source>] the sources added, in order
+      def sources = @sources.dup
+
       # Every group, now: the index's own (#registry_groups), then the
       # sources'. A source group with a reserved name, or one an earlier
       # group has, is left out of search, lookup and the description (said

data/lib/samagotchi/turn_state.rb

@@ -22,6 +22,8 @@ module Samagotchi
       @running = false
       @controller = nil
       @sink = nil
+      @thread = nil
+      @ended = false
       @steers = []
       @carried_steers = []
     end
@@ -64,12 +66,15 @@ module Samagotchi
       @lock.synchronize { @running }
     end
 
-    # A turn begins: running, with its controller and sink, in one step.
+    # A turn begins, on the calling thread (the turn's own): running, with
+    # its controller and sink, in one step.
     def begin!(controller:, sink:)
       @lock.synchronize do
         @running = true
         @controller = controller
         @sink = sink
+        @thread = Thread.current
+        @ended = false
         @steers.concat(@carried_steers)
         @carried_steers = []
       end
@@ -82,15 +87,37 @@ module Samagotchi
         @running = false
         @controller = nil
         @sink = nil
+        @thread = nil
+        @ended = false
         @steers.tap { @steers = [] }
       end
     end
 
+    # The turn's end is decided (its end event is out): what runs after,
+    # its after_turn / session_end hooks, is post-turn work, up to #finish!.
+    def ended!
+      @lock.synchronize { @ended = true }
+    end
+
     # @return [CancellationController, nil] the running turn's controller
     def controller
       @lock.synchronize { @controller }
     end
 
+    # The controller for work done for the turn itself (a plugin's HTTP
+    # call): the running turn's, on the turn's thread or +handler+ (inside a
+    # plugin's event handler, whatever thread fires it), until the turn has
+    # ended; nil for any other thread (an anytime command, a service) and
+    # outside a turn.
+    # @return [CancellationController, nil]
+    def own_controller(handler: false)
+      @lock.synchronize do
+        return nil unless @running && !@ended
+
+        handler || @thread.equal?(Thread.current) ? @controller : nil
+      end
+    end
+
     # Cancel the running turn, if any (outside the lock).
     # @return [Boolean] whether a cancellation was triggered
     def cancel!(reason)

data/lib/samagotchi/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Samagotchi
-  VERSION = "0.79.0"
+  VERSION = "0.80.0"
   # Sent as the User-Agent of every HTTP request chi makes.
   USER_AGENT = "chi/#{VERSION}"
 end

data/lib/samagotchi/web/public/app.js

@@ -24,7 +24,7 @@ import {
 } from "./data.js";
 import { createContextChips } from "./context_chips.js";
 import {
-  chipModel as llmContextChipModel, choiceWords, createLlmContextControl, NEW_CHAT,
+  chipModel as llmContextChipModel, choiceWords, createLlmContextControl, NEW_SESSION,
   withChoice,
 } from "./llm_context_chip.js";
 import {
@@ -38,7 +38,7 @@ import { createShownTexts } from "./shown_texts.js";
 import { MODEL_KEY } from "./model_pick.js";
 import { emptySessionState, sessionStateFrom } from "./session_state.js";
 import { createModelPicker } from "./model_picker.js";
-import { chipName, chipsTemplate, imageFiles, restoredChips, thumbsTemplate, turnRefs, turnText, uploadChips } from "./images.js";
+import { admitImages, chipName, chipsTemplate, imageFiles, restoredChips, thumbsTemplate, turnRefs, turnText, uploadChips } from "./images.js";
 import { normalize, firstPreview, failedTurnText, deleteConfirmText, goneSessionNotice, cantText, withLiveStatus, withoutWorker } from "./format.js";
 import { createTurnView, turnHistoryNodes } from "./turn_view.js";
 import { elementOf, emptyAnswerTemplate } from "./turn_html.js";
@@ -66,6 +66,7 @@ import { scopeDir, scopeTemplate } from "./scope.js";
 import { html, nothing, render } from "./vendor/lit-html.js";
 import { easeScrollTo, FOLLOW_MS, shouldFollowScroll } from "./scroll.js";
 import { SHORT_WINDOW_QUERY, stripAutoHidden } from "./strip.js";
+import { createStripGrip } from "./strip_grip.js";
 import { waitingOn } from "./notify.js";
 import { applySessionEvent, inTree, sortedByUpdated } from "./sessions_list.js";
 import { createNotifications } from "./notifications.js";
@@ -121,7 +122,7 @@ const llmContextControl = createLlmContextControl({
   run: (line) => runSessionCommand(line),
 });
 // The start page's LLM context chip, beside the model picker: the picked
-// model's values, and a choice for the next new chat only (sent with its
+// model's values, and a choice for the next new session only (sent with its
 // create, then dropped; never remembered: a reload or opening a session
 // drops it too, a failed create keeps it).
 const llmContextNewEl = $("#llmContextNew");
@@ -130,7 +131,7 @@ const newChatLlmSummary = () => (selected || modelPickEl.hidden ? null : modelPi
 const llmContextNewControl = createLlmContextControl({
   el: llmContextNewEl,
   summary: newChatLlmSummary,
-  kind: NEW_CHAT,
+  kind: NEW_SESSION,
   choice: () => newChatLlmContext,
   choose: (next) => {
     newChatLlmContext = next;
@@ -159,14 +160,14 @@ const reasoningHistoryControl = createReasoningHistoryControl({
   run: (line) => runSessionCommand(line),
 });
 // The start page's thinking chip: the picked model's level, and a level
-// for the next new chat only (sent with its create, then dropped).
+// for the next new session only (sent with its create, then dropped).
 const thinkingNewEl = $("#thinkingNew");
 let newChatThinking = null;
 const newChatThinkingSummary = () => (selected || modelPickEl.hidden ? null : modelPicker.chosenRow()?.thinking || null);
 const thinkingNewControl = createThinkingControl({
   el: thinkingNewEl,
   summary: newChatThinkingSummary,
-  kind: NEW_CHAT,
+  kind: NEW_SESSION,
   choice: () => newChatThinking,
   choose: (next) => {
     newChatThinking = next;
@@ -177,7 +178,7 @@ const thinkingNewControl = createThinkingControl({
   anchor: "#thinkingNew",
 });
 function renderNewChatThinking() {
-  const chip = thinkingChipModel(withThinkingChoice(newChatThinkingSummary(), newChatThinking), { kind: NEW_CHAT });
+  const chip = thinkingChipModel(withThinkingChoice(newChatThinkingSummary(), newChatThinking), { kind: NEW_SESSION });
   thinkingNewEl.hidden = !chip;
   if (!chip) return thinkingNewControl.close();
   thinkingNewEl.textContent = chip.text;
@@ -186,7 +187,7 @@ function renderNewChatThinking() {
 }
 // Hidden without the model's values (the list not in, an older server).
 function renderNewChatLlmContext() {
-  const chip = llmContextChipModel(withChoice(newChatLlmSummary(), newChatLlmContext), { kind: NEW_CHAT });
+  const chip = llmContextChipModel(withChoice(newChatLlmSummary(), newChatLlmContext), { kind: NEW_SESSION });
   llmContextNewEl.hidden = !chip;
   if (!chip) return llmContextNewControl.close();
   llmContextNewEl.textContent = chip.text;
@@ -205,6 +206,8 @@ let pageEditorUrl = null;
 const promptEl = $("#prompt");
 const actionBtn = $("#actionBtn");
 const cancelBtn = $("#cancelBtn");
+const attachBtn = $("#attachBtn");
+const attachInput = $("#attachInput");
 const infoCancelBtn = $("#infoCancelBtn");
 const modelPickEl = $("#modelPick");
 const composeHintEl = $("#composeHint");
@@ -357,7 +360,7 @@ const sentIds = new Set();
 const earlyRestores = new Map();
 
 // The page's scope (scope.js): ?dir= is the folder a project view came
-// from (new chats start there); the server names its project, if any.
+// from (new sessions start there); the server names its project, if any.
 const scope = {
   dir: scopeDir(location.search),
   projectName: document.body.dataset.projectName || null,
@@ -467,7 +470,7 @@ function followSelectedSession(sess) {
 
 // The header's scope chip: "<project> · all" in a project view (all links
 // to the same place without ?dir); "all projects" otherwise, with where a
-// new chat starts on the start page.
+// new session starts on the start page.
 function renderScope() {
   const el = $("#scope");
   render(scopeTemplate(scope, { error: scopeError, where: () => ({ hash: location.hash, search: location.search }) }), el);
@@ -500,7 +503,6 @@ const lists = createListsView({
   allViewOpen: () => allViewOpen(),
   openAllView: () => openAllView(),
   leaveAllView: (hash) => leaveAllView(hash),
-  setStripHidden: (hidden) => setStripHidden(hidden),
 });
 
 // Delete a session (the info bar's button, an all-sessions card's ✕) after
@@ -544,7 +546,7 @@ function closeAllView() {
     leaveAllView(sessionHash(selected));
   }
 }
-// Leave all sessions for a place of our own (a picked session, a new chat):
+// Leave all sessions for a place of our own (a picked session, a new session):
 // replace its history entry, since history.back() would come back later
 // with the session the view was opened from.
 function leaveAllView(hash) {
@@ -620,7 +622,7 @@ function updateComposerMode() {
   syncModelPick();
   if (selected) {
     llmContextNewControl.close();
-    // The start page's choice was for a new chat: opening a session drops it.
+    // The start page's choice was for a new session: opening a session drops it.
     if (newChatLlmContext) {
       newChatLlmContext = null;
       renderNewChatLlmContext();
@@ -633,6 +635,9 @@ function updateComposerMode() {
   }
   const running = liveTurn.running && !!selected;
   cancelBtn.style.display = running ? "" : "none";
+  // No images for a session a terminal owns (it takes no message from here);
+  // on a phone none while a turn runs either: Stop turn needs the row's room.
+  attachBtn.hidden = (!!selected && current.owner === "tui") || (running && narrowScreen.matches);
   syncDeliveryLine();
   if (running) {
     setPlaceholder("Running… a message goes in at the next step · Enter to send · Alt+Enter queues", "Steer the turn…");
@@ -1535,7 +1540,7 @@ async function handleCancel() {
 
 // The chi logo: back to the empty start, where the composer makes a new
 // session (from all sessions too).
-// The typed draft stays in the composer: paste in a session, then + new chat
+// The typed draft stays in the composer: paste in a session, then + new session
 // starts from it (with the model picker). clearSelection leaves #prompt alone.
 $("#newBtn").addEventListener("click", () => {
   if (allViewOpen()) leaveAllView("");
@@ -1553,7 +1558,7 @@ $("#newBtn").addEventListener("click", () => {
 // tooltip; a route that fails leaves the picker hidden and the server's
 // default in charge. The search list itself is model_picker.js'; a pick
 // sends the focus to the message box.
-const START_PICK_TITLE = "The model the new chat starts on";
+const START_PICK_TITLE = "The model the new session starts on";
 let startPickTitle = START_PICK_TITLE;
 // The fresh link the picker shows (null: the start page, or a session it
 // is hidden in), and a link pick's /model still in flight (a send waits).
@@ -1624,7 +1629,7 @@ function syncModelPick() {
     modelPickEl.setAttribute("aria-label", "Model this link starts on");
   } else {
     modelPickEl.title = startPickTitle;
-    modelPickEl.setAttribute("aria-label", "Model for the new chat");
+    modelPickEl.setAttribute("aria-label", "Model for the new session");
   }
 }
 // Leaving a session: the start page's remembered model again (no fetch).
@@ -1680,9 +1685,14 @@ function clearChips() {
   setChips([]);
 }
 
+// A paste's, a drop's or the image button's files: the images the message
+// may still take become chips (images.js admitImages); a toast says why the
+// rest stayed out. Whether any went in.
 function addImageFiles(files) {
-  if (!files.length) return false;
-  for (const file of files) chips.push({ file, name: chipName(file, chips.length), src: URL.createObjectURL(file) });
+  const { take, refused } = admitImages(files, chips.length);
+  if (refused) showToast(refused);
+  if (!take.length) return false;
+  for (const file of take) chips.push({ file, name: chipName(file, chips.length), src: URL.createObjectURL(file) });
   renderChips();
   focusPrompt();
   return true;
@@ -1695,6 +1705,13 @@ chipsEl.addEventListener("click", (e) => {
   if (chip?.file && chip.src) URL.revokeObjectURL(chip.src);
   renderChips();
 });
+// The image button: the file picker's images join the chips. Its value is
+// cleared after each pick, so the same file can be picked again.
+attachBtn.addEventListener("click", () => attachInput.click());
+attachInput.addEventListener("change", () => {
+  addImageFiles([...attachInput.files]);
+  attachInput.value = "";
+});
 // ── Composer height: grows with the text; the top-edge grip sets a floor ───
 let promptFloor = Number(readStored(GRIP_KEY)) || null;
 
@@ -2093,15 +2110,24 @@ function stripHiddenSaved() {
   return saved === null ? readStored("chi_zen") === "1" : saved === "1";
 }
 // A short window hides the strip by itself, so the stage keeps room for a
-// card that waits (its question and choices); the sessions pill brings it
-// back until the window is tall again. Not saved: the saved choice is the
-// user's own hide ▴ / show.
+// card that waits (its question and choices); the grip brings it back
+// until the window is tall again. Not saved: the saved choice is the
+// user's own hide or show.
 const shortWindow = window.matchMedia(SHORT_WINDOW_QUERY);
 let stripShownWhileShort = false;
+// The strip's grip (strip_grip.js): the handle on the edge between the strip
+// and the chat. It is given the hidden state and the toggle; it speaks its own
+// title and aria-expanded, refreshed below after every change.
+const stripGripRefresh = createStripGrip({
+  gripEl: $("#stripGrip"),
+  isHidden: () => document.body.classList.contains("strip-hidden"),
+  setHidden: (hidden) => setStripHidden(hidden),
+});
 function applyStripHidden() {
   document.body.classList.toggle("strip-hidden", stripAutoHidden({
     saved: stripHiddenSaved(), short: shortWindow.matches, shownWhileShort: stripShownWhileShort,
   }));
+  stripGripRefresh();
   updateSessionTitle();
 }
 function setStripHidden(hidden) {
@@ -2115,8 +2141,6 @@ shortWindow.addEventListener("change", () => {
   if (!shortWindow.matches) stripShownWhileShort = false;
   applyStripHidden();
 });
-$("#stripShow").addEventListener("click", () => setStripHidden(false));
-$("#stripHideTop").addEventListener("click", () => setStripHidden(true));
 
 // Esc leaves select mode first, then the all-sessions view.
 document.addEventListener("keydown", (e) => {

data/lib/samagotchi/web/public/images.js

@@ -15,6 +15,39 @@ export function imageFiles(dataTransfer) {
   return files.filter((f) => /^image\//.test(f?.type || ""));
 }
 
+// The server's caps, mirrored so the composer refuses at once what a send
+// would (spec/web/images_spec.rb pins both): ImageStore::MAX_TURN_REFS
+// images a message, Web::App::MAX_IMAGE_UPLOAD_BYTES a file.
+export const MAX_TURN_IMAGES = 20;
+export const MAX_IMAGE_MB = 20;
+const MAX_IMAGE_BYTES = MAX_IMAGE_MB * 1024 * 1024;
+
+function filesText(n) {
+  return n === 1 ? "1 file" : `${n} files`;
+}
+
+// What the composer takes of +files+ (a paste's, a drop's or the image
+// button's picks) while it holds +held+ chips: images only, none over
+// MAX_IMAGE_MB, and no more than MAX_TURN_IMAGES in all. +refused+ says
+// why the rest stayed out, for a toast ("" when none did).
+export function admitImages(files, held = 0) {
+  const take = [];
+  let notImage = 0;
+  let tooBig = 0;
+  let overCap = 0;
+  for (const file of files || []) {
+    if (!/^image\//.test(file?.type || "")) notImage += 1;
+    else if ((file.size || 0) > MAX_IMAGE_BYTES) tooBig += 1;
+    else if (held + take.length >= MAX_TURN_IMAGES) overCap += 1;
+    else take.push(file);
+  }
+  const why = [];
+  if (overCap) why.push(`${filesText(overCap)} not added: at most ${MAX_TURN_IMAGES} images a message`);
+  if (tooBig) why.push(`${filesText(tooBig)} not added: over ${MAX_IMAGE_MB} MB`);
+  if (notImage) why.push(`${filesText(notImage)} not added: not an image`);
+  return { take, refused: why.join(" · ") };
+}
+
 // A pasted screenshot is often called "image.png": number it so the chips
 // (and what the model reads) tell them apart.
 export function chipName(file, index) {