samagotchi 0.22.0 → 0.23.0

data/lib/samagotchi/memory_bundle/manifest.rb

@@ -64,6 +64,7 @@ module Samagotchi
       def self.read(dir:)
         manifest_path = File.join(dir, "manifest.yml")
         raise ValidationError, "manifest.yml not found in #{dir}" unless File.exist?(manifest_path)
+
         new(path: manifest_path)
       end
 
@@ -72,6 +73,7 @@ module Samagotchi
       def checksum_for(file_key)
         raw = @files[file_key]
         return nil unless raw
+
         raw.start_with?("sha256:") ? raw[7..] : raw
       end
 
@@ -79,8 +81,10 @@ module Samagotchi
       def checksum_for_hook(basename)
         raw = @hooks[basename]
         return nil unless raw
+
         sha = raw[:sha256] || raw["sha256"]
         return nil unless sha
+
         sha.to_s.start_with?("sha256:") ? sha.to_s[7..] : sha.to_s
       end
 
@@ -99,18 +103,18 @@ module Samagotchi
         return nil if Gem::Requirement.new(*requirement.to_s.split(",").map(&:strip)).satisfied_by?(Gem::Version.new(version.to_s))
 
         "it requires chi #{requirement} (this is chi #{version})"
-      rescue ArgumentError, Gem::Requirement::BadRequirementError => e
+      rescue ArgumentError => e # Gem::Requirement::BadRequirementError is one
         "its requires_chi #{requirement.inspect} is not a version requirement (#{e.message})"
       end
 
       # Writes a fresh manifest.yml from computed checksums at `dir`.
-      def self.write(dir:, name:, version:, scope: nil, description: "", files:, hooks: nil, trust_level: nil,
+      def self.write(dir:, name:, version:, files:, scope: nil, description: "", hooks: nil, trust_level: nil,
                      plugin: nil, requires_chi: nil, needs: nil)
         FileUtils.mkdir_p(dir)
         manifest = {
           "name" => name,
           "version" => version,
-          "description" => description,
+          "description" => description
         }
         manifest["scope"] = scope if scope
         manifest["files"] = files # { "file.md" => "sha256:abc..." }
@@ -167,19 +171,23 @@ module Samagotchi
       def require_str(hash, key)
         val = hash[key]
         return val if val.is_a?(String) && !val.empty?
+
         raise ValidationError, "manifest missing required field: #{key}"
       end
 
       def normalize_scope(val)
         return nil if val.nil?
+
         v = val.to_s.strip.downcase
         %w[project system].include?(v) ? v : nil
       end
 
       def parse_files(raw)
         return {} unless raw.is_a?(Hash)
+
         raw.each_with_object({}) do |(k, v), acc|
           next unless k.is_a?(String) && !k.empty?
+
           str = v.to_s
           acc[k] = if str.start_with?("sha256:")
                      str
@@ -234,11 +242,13 @@ module Samagotchi
 
       def parse_hooks(raw)
         return {} unless raw.is_a?(Hash)
+
         raw.each_with_object({}) do |(k, v), acc|
           next unless k.is_a?(String) && !k.empty?
           next unless v.is_a?(Hash)
+
           sha = (v["sha256"] || v[:sha256] || "").to_s
-          sha = sha.start_with?("sha256:") ? sha : "sha256:#{sha}" unless sha.empty?
+          sha = "sha256:#{sha}" unless sha.empty? || sha.start_with?("sha256:")
           event = (v["event"] || v[:event] || "").to_s.strip
           on_error = (v["on_error"] || v[:on_error] || "skip").to_s.strip
           on_error = "skip" if on_error.empty?

data/lib/samagotchi/memory_bundle/merger.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "digest"
 
 module Samagotchi
@@ -33,18 +34,19 @@ module Samagotchi
         incoming_digest = Digest::SHA256.hexdigest(File.read(incoming_path))
 
         if current_digest == incoming_digest
-          return :noop
+          :noop
         elsif current_digest == base_digest
-          return :fast_forward
+          :fast_forward
         elsif incoming_digest == base_digest
-          return :keep
+          :keep
         else
-          return :conflict
+          :conflict
         end
       end
 
       def self.current_modified?(base_path, current_path)
         return true unless base_path && File.exist?(base_path) && File.exist?(current_path)
+
         Digest::SHA256.hexdigest(File.read(base_path)) != Digest::SHA256.hexdigest(File.read(current_path))
       end
     end

data/lib/samagotchi/memory_bundle/provenance.rb

@@ -154,11 +154,11 @@ module Samagotchi
         if existing && existing[:files]
           existing[:files].keys.each do |old_key|
             old_key_str = old_key.to_s
-            unless files.key?(old_key_str) || files.key?(old_key)
-              old_base = File.join(bases_dir, old_key_str)
-              FileUtils.rm_f(old_base) if File.exist?(old_base)
-              merged_entries.delete(old_key_str)
-            end
+            next if files.key?(old_key_str) || files.key?(old_key)
+
+            old_base = File.join(bases_dir, old_key_str)
+            FileUtils.rm_f(old_base)
+            merged_entries.delete(old_key_str)
           end
         end
 
@@ -172,9 +172,10 @@ module Samagotchi
           hooks.each do |k, v|
             next unless k.is_a?(String) && !k.empty?
             next unless v.is_a?(Hash)
+
             hv = v.transform_keys(&:to_sym)
             sha = (hv[:sha256] || "").to_s
-            sha = sha.start_with?("sha256:") ? sha : "sha256:#{sha}" unless sha.empty?
+            sha = "sha256:#{sha}" unless sha.empty? || sha.start_with?("sha256:")
             normalized_hooks[k] = {
               sha256: sha,
               event: (hv[:event] || "").to_s,
@@ -189,7 +190,7 @@ module Samagotchi
             old_key_str = old_key.to_s
             unless normalized_hooks.key?(old_key_str) || normalized_hooks.key?(old_key_str.to_sym)
               old_base = File.join(bases_dir, old_key_str)
-              FileUtils.rm_f(old_base) if File.exist?(old_base)
+              FileUtils.rm_f(old_base)
             end
           end
         end
@@ -204,12 +205,12 @@ module Samagotchi
             meta = meta.merge(sha256: "sha256:#{Digest::SHA256.hexdigest(File.read(src.to_s))}")
           end
           hooks_map[k] = meta.transform_keys(&:to_s)
-          if src && File.exist?(src.to_s)
-            begin
-              File.write(File.join(bases_dir, k), File.read(src.to_s))
-            rescue StandardError
-              nil
-            end
+          next unless src && File.exist?(src.to_s)
+
+          begin
+            File.write(File.join(bases_dir, k), File.read(src.to_s))
+          rescue StandardError
+            nil
           end
         end
 
@@ -256,6 +257,7 @@ module Samagotchi
         conflicts.each do |file_key, info|
           key = file_key.to_s
           next unless raw["files"].key?(key)
+
           src = [info[:incoming], info[:current]].find { |p| p && File.exist?(p) }
           next unless src
 
@@ -270,6 +272,7 @@ module Samagotchi
       def read
         manifest_path = File.join(@bundle_dir, "manifest.json")
         return nil unless File.exist?(manifest_path)
+
         JSON.parse(File.read(manifest_path), symbolize_names: true)
       end
 

data/lib/samagotchi/memory_bundle/source.rb

@@ -28,7 +28,7 @@ module Samagotchi
         lower = path.downcase
         if lower.end_with?(".zip")
           normalize_zip(path)
-        elsif lower.end_with?(".tar.gz") || lower.end_with?(".tgz") || lower.end_with?(".tar")
+        elsif lower.end_with?(".tar.gz", ".tgz", ".tar")
           normalize_tar(path)
         else
           ext = File.extname(path).downcase
@@ -57,6 +57,7 @@ module Samagotchi
       def self.git_url?(str)
         s = str.to_s.strip
         return false if s.empty?
+
         s.match?(%r{\A(?:https?://|git@|ssh://|git://|file://).+})
       end
 
@@ -78,6 +79,7 @@ module Samagotchi
           args += [url, clone_dir]
           result = system(*args)
           raise UnknownSourceError, "git clone failed for #{git_url}" unless result && File.directory?(clone_dir)
+
           # Capture HEAD commit before stripping .git (audit trail)
           commit = nil
           begin
@@ -103,12 +105,11 @@ module Samagotchi
         end
       end
 
-      private
-
       def self.normalize_zip(zip_path)
         Dir.mktmpdir("samagotchi-zip-") do |extract_dir|
           result = system("unzip", "-o", zip_path, "-d", extract_dir)
           raise UnknownSourceError, "unzip failed for #{zip_path}" unless result
+
           clean_copy_of(extract_dir)
         end
       end
@@ -119,6 +120,7 @@ module Samagotchi
           cmd = is_gz ? ["tar", "-xzf"] : ["tar", "-xf"]
           result = system(*cmd, tar_path, "-C", extract_dir)
           raise UnknownSourceError, "tar extraction failed for #{tar_path}" unless result
+
           clean_copy_of(extract_dir)
         end
       end
@@ -150,6 +152,8 @@ module Samagotchi
         end
         [dst, true]
       end
+
+      private_class_method :normalize_zip, :normalize_tar, :clean_copy_of
     end
   end
 end

data/lib/samagotchi/memory_bundle/status.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "digest"
 require_relative "provenance"
 require_relative "manifest"
@@ -20,7 +21,7 @@ module Samagotchi
         return nil unless data
 
         raw_scope = scope_override || data[:scope]&.to_s
-        scope = (raw_scope.nil? || raw_scope.strip.empty?) ? "system" : raw_scope
+        scope = raw_scope.nil? || raw_scope.strip.empty? ? "system" : raw_scope
         target_dir = MemoryPaths.scope_dir(scope)
         files = data[:files] || {}
         details = {}
@@ -108,6 +109,7 @@ module Samagotchi
       def self.index_has_entry?(scope, file_key)
         path = IndexUpdater.index_path_for(scope)
         return false unless path && File.exist?(path)
+
         content = File.read(path)
         [file_key.delete_suffix(".md"), file_key].uniq.any? { |name| content.match?(IndexUpdater.managed_pattern(name)) }
       end

data/lib/samagotchi/memory_bundle/system_bundle.rb

@@ -110,12 +110,13 @@ module Samagotchi
 
       def skip?
         val = ENV[SKIP_ENV].to_s.strip.downcase
-        val == "1" || val == "true"
+        %w[1 true].include?(val)
       end
 
       # Unparseable versions fall back to the old "any difference upgrades" behaviour.
       def installed_newer?(installed, shipped)
-        installed, shipped = installed.to_s, shipped.to_s
+        installed = installed.to_s
+        shipped = shipped.to_s
         return false unless Gem::Version.correct?(installed) && Gem::Version.correct?(shipped)
 
         Gem::Version.new(installed) > Gem::Version.new(shipped)

data/lib/samagotchi/memory_bundle/trash.rb

@@ -44,7 +44,7 @@ module Samagotchi
       def self.empty!(bundles_dir: MemoryPaths.bundles_dir, older_than_days: nil, now: Time.now, dry_run: false)
         entries = self.entries(bundles_dir: bundles_dir, now: now)
         if older_than_days
-          cutoff = now - older_than_days.to_i * 86_400
+          cutoff = now - (older_than_days.to_i * 86_400)
           entries = entries.select { |e| e.time < cutoff }
         end
         return entries if dry_run
@@ -98,7 +98,7 @@ module Samagotchi
         File.directory?(path) && !File.symlink?(path)
       end
 
-      def self.entry_for(trash_dir, name, now)
+      def self.entry_for(trash_dir, name, _now)
         path = File.join(trash_dir, name)
         time = parse_timestamp(name) || File.mtime(path)
         files, bytes = count_files(path)
@@ -126,11 +126,14 @@ module Samagotchi
         bytes = 0
         Dir.glob(File.join(dir, "**", "*"), File::FNM_DOTMATCH).each do |f|
           next if File.directory?(f)
+
           files += 1
           bytes += File.size(f) rescue 0
         end
         [files, bytes]
       end
+
+      private_class_method :real_dir?, :entry_for, :parse_timestamp, :count_files
     end
   end
 end

data/lib/samagotchi/memory_bundle/uninstaller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "fileutils"
 require "digest"
 require_relative "../memory_paths"
@@ -38,7 +39,7 @@ module Samagotchi
         # Determine scope from flag or provenance
         cli_scope = @scope.to_s.strip.empty? ? nil : @scope
         raw = cli_scope || data[:scope]&.to_s
-        target_scope = (raw.nil? || raw.strip.empty?) ? "system" : raw
+        target_scope = raw.nil? || raw.strip.empty? ? "system" : raw
         target_dir = MemoryPaths.scope_dir(target_scope) or raise UninstallError, "invalid scope: #{target_scope}"
 
         files = data[:files] || {}
@@ -55,19 +56,20 @@ module Samagotchi
         end.reject { |_, others| others.empty? }
 
         blocked = []
-        files.each do |file_key, meta|
+        files.each do |file_key, _meta|
           file_key_str = file_key.to_s
           target_path = File.join(target_dir, file_key_str)
           base_path = provenance.base_path(file_key_str)
           next unless File.exist?(target_path)
           next if shared.key?(file_key_str)
+
           if !@force && File.exist?(base_path) && Merger.current_modified?(base_path, target_path)
             blocked << file_key_str
             @warnings << "Skipped #{file_key_str}: local edits detected (use --force to remove)"
           end
         end
 
-        raise UninstallError, "Uninstall blocked: #{blocked.join(', ')} has local edits (use --force)" if blocked.any?
+        raise UninstallError, "Uninstall blocked: #{blocked.join(", ")} has local edits (use --force)" if blocked.any?
 
         files.each do |file_key, _meta|
           file_key_str = file_key.to_s
@@ -108,10 +110,11 @@ module Samagotchi
             end
           end
           # Remove hooks dir if empty, else rm_rf will clean
-          FileUtils.rm_rf(hooks_dir) if Dir.exist?(hooks_dir)
+          FileUtils.rm_rf(hooks_dir)
         else
-          # Ensure stale hooks dir removed even if provenance has no hooks map but dir exists
-          FileUtils.rm_rf(provenance.hooks_dir) if Dir.exist?(provenance.hooks_dir)
+          # A stale hooks dir goes even when provenance has no hooks map
+          # (rm_rf ignores a missing dir).
+          FileUtils.rm_rf(provenance.hooks_dir)
         end
 
         plugin_path = provenance.plugin_path(data)

data/lib/samagotchi/memory_bundle.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative "memory_bundle/manifest"
 require_relative "memory_bundle/source"
 require_relative "memory_bundle/provenance"

data/lib/samagotchi/model_overlay.rb

@@ -32,10 +32,7 @@ module Samagotchi
 
       key = model_name.to_s
         .downcase
-        .gsub(/[^a-z0-9]+/, "-")
-        .gsub(/-+/, "-")
-        .sub(/\A-/, "")
-        .sub(/-\z/, "")
+        .gsub(/[^a-z0-9]+/, "-").squeeze("-").delete_prefix("-").delete_suffix("-")
       key.empty? ? nil : key
     end
 
@@ -43,12 +40,13 @@ module Samagotchi
     # Respects MemoryBundle overrides (delegates to Tools::MemoryRead.memories_dir).
     def self.overlay_path_for(name, key, scope)
       return nil unless key && !key.to_s.strip.empty?
+
       File.join(Tools::MemoryRead.memories_dir(scope), "#{name}.#{key.to_s.strip}.md")
     end
 
     # Regex matching overlay file names: /<something>.<lowercase-dashed-key>.md\z
     # Useful for tooling, tests, and future index suppression.
-    OVERLAY_SUFFIX_PATTERN = /\.([a-z0-9\-]+)\.md\z/
+    OVERLAY_SUFFIX_PATTERN = /\.([a-z0-9-]+)\.md\z/
 
     # The base file name (`tips.md`) an overlay-looking name
     # (`tips.qwen3.md`) would belong to, or nil when it doesn't match the

data/lib/samagotchi/model_profile.rb

@@ -17,10 +17,13 @@ module Samagotchi
     MODEL_FROM_CLI_ENV = "SAMAGOTCHI_DEFAULT_MODEL_FROM_CLI"
     # No model anywhere (--model, default.model in config.yml, the env): a
     # first run before any config. An ArgumentError, as before.
-    MissingModel = Class.new(ArgumentError)
+    class MissingModel < ArgumentError
+    end
+
     # A host-qualified model whose host isn't configured (a MissingModel,
     # so every surface that reports a missing model reports it the same way).
-    UnknownHost = Class.new(MissingModel)
+    class UnknownHost < MissingModel
+    end
 
     # Gemma 4 thinks in a channel: `<|channel>thought` … `<channel|>`. The
     # one source for the parser, the stream splitter, the literal guard and
@@ -74,7 +77,7 @@ module Samagotchi
       new(
         name: "gemma4",
         turn_start: "<|turn>",
-        turn_end: "<end_of_turn>",
+        turn_end: "<turn|>",
         tool_call_open: "<|tool_call>",
         tool_call_close: "<tool_call|>",
         tool_response_open: "<|tool_response>",
@@ -88,7 +91,7 @@ module Samagotchi
         user_prefix: "",
         assistant_prefix: "",
         model_prefix: "",
-        stop_sequences: ["<end_of_turn>", "<|tool_response>"],
+        stop_sequences: ["<turn|>", "<|tool_response>"],
         tool_decl_format: :gemma4
       )
     end
@@ -165,14 +168,15 @@ module Samagotchi
       if !parsed.host_name && (disabled = disabled_host_prefix(ref, hosts, env))
         raise UnknownHost, "host '#{disabled}' is disabled (enabled: false in config.yml)"
       end
+
       warn_host_slash(ref, hosts) unless parsed.host_name
       host = Samagotchi::ConfigFile.unknown_host_prefix(ref, hosts: hosts)
       return model_name unless host
 
       names = hosts.keys.map { |k| k.to_s.downcase }.sort
       near = Samagotchi::Config.near_names(host, names).first(3)
-      hint = near.empty? ? "" : " (did you mean #{near.map { |n| "'#{n}'" }.join(' or ')}?)"
-      raise UnknownHost, "unknown host '#{host}' in model '#{ref}'#{hint}; the configured hosts are #{names.join(', ')}"
+      hint = near.empty? ? "" : " (did you mean #{near.map { |n| "'#{n}'" }.join(" or ")}?)"
+      raise UnknownHost, "unknown host '#{host}' in model '#{ref}'#{hint}; the configured hosts are #{names.join(", ")}"
     end
 
     # The prefix of "box:x" when box is a host config.yml has with
@@ -275,7 +279,7 @@ module Samagotchi
       FINGERPRINTS.each do |name, markers|
         return [name, markers.join(" + ")] if markers.all? { |marker| template.include?(marker) }
       end
-      return ["qwen36", "ChatML"] if template.include?("<|im_start|>")
+      return %w[qwen36 ChatML] if template.include?("<|im_start|>")
 
       nil
     end
@@ -341,7 +345,7 @@ module Samagotchi
 
     def self.configured(value, where)
       profile = named(value)
-      Log.warn(:config, "unknown_profile", echo: "Warning: unknown profile #{value.to_s.inspect} in #{where} (allowed: #{NAMES.join(', ')}) — ignored", profile: value.to_s, where: where) unless profile
+      Log.warn(:config, "unknown_profile", echo: "Warning: unknown profile #{value.to_s.inspect} in #{where} (allowed: #{NAMES.join(", ")}) — ignored", profile: value.to_s, where: where) unless profile
       profile
     end
     private_class_method :configured

data/lib/samagotchi/note_command.rb

@@ -92,6 +92,7 @@ module Samagotchi
     # passes down may never close: waiting on either would hang a script.
     def read_stdin
       return nil if @stdin.respond_to?(:tty?) && @stdin.tty?
+
       if @stdin.respond_to?(:stat)
         stat = @stdin.stat
         return nil unless stat.pipe? || stat.file?
@@ -135,7 +136,7 @@ module Samagotchi
       if owner
         @stdout.puts("#{short}  queued: its worker adds it within a few seconds")
       else
-        queued = SessionInbox.find_new_note_files(File.dirname(File.dirname(path))).size
+        queued = SessionInbox.find_new_note_files(File.dirname(path, 2)).size
         @stdout.puts("#{short}  waits for the session's next start (#{queued} #{queued == 1 ? "note" : "notes"} queued)")
       end
       true

data/lib/samagotchi/output_formatter.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Samagotchi
   # OutputFormatter strips model wire-format tokens from raw engine output at
   # render time, so downstream renderers (web UI, terminal UI) never show the
@@ -23,7 +24,6 @@ module Samagotchi
     # wrapper forms; bare <name> content (no pipe) is deliberately preserved.
     CONTROL_NAMES = %w[
       turn
-      end_of_turn
       tool_call
       tool_response
       tool
@@ -40,31 +40,32 @@ module Samagotchi
     # <word> in the surrounding content is NOT stripped:
     #   <|name> / <name|> / <|name|>
     INDIVIDUAL_RE = Regexp.new(
-      '<\\|(?:' + CONTROL_NAMES.join('|') + ')\\|?>' \
-      '|<(?:' + CONTROL_NAMES.join('|') + ')\\|>'
+      '<\\|(?:' + CONTROL_NAMES.join("|") + ')\\|?>' \
+      "|<(?:" + CONTROL_NAMES.join("|") + ')\\|>'
     )
     INDIVIDUAL_RE.freeze
 
     # Angle-bracketed literal tokens stripped wholesale (including the thought
     # channel's trailing word). Applied before INDIVIDUAL_RE so multi-part tokens
     # are removed as a unit. Pipes are escaped; angle brackets are literal.
-    LITERALS_RE = /<\|"\|>|<end_of_turn>/.freeze
+    LITERALS_RE = /<\|"\|>/
 
     # Gemma 4's thought channel, as a whole block: `<|channel>thought` to its
     # `<channel|>` close, or to the end of the text when the close is missing
     # (ToolCallParser::Gemma strips the same pair). Removing only the marker
     # would leave the model's private reasoning in the answer; the channel is
     # the profile's thinking lane, not output.
-    GEMMA_THOUGHT_RE = /<\|\w*channel>thought.*?(?:<channel\|>|\z)/m.freeze
+    GEMMA_THOUGHT_RE = /<\|\w*channel>thought.*?(?:<channel\|>|\z)/m
 
     # Qwen prompt-literal placeholders, e.g. </think>.
-    PROMPT_LITERALS = /\[\[SAMAGOTCHI_LITERAL_[A-Z_]+\]\]/.freeze
+    PROMPT_LITERALS = /\[\[SAMAGOTCHI_LITERAL_[A-Z_]+\]\]/
 
     # Qwen3.6 thinking blocks: <think>...</think> (including empty)
-    QWEN_THINK_RE = /<think>.*?<\/think>/m.freeze
+    QWEN_THINK_RE = %r{<think>.*?</think>}m
     # Qwen tool_call XML blocks that survive when a tool call is rendered as text
     # e.g. <tool_call>\n<function=list_reminders>\n</function>\n</tool_call>
-    QWEN_TOOL_CALL_RE = /<tool_call>.*?<\/tool_call>/m.freeze
+    QWEN_TOOL_CALL_RE = %r{<tool_call>.*?</tool_call>}m
+
     module_function
 
     # Remove both control-token and prompt-literal token families from +text+.
@@ -79,7 +80,7 @@ module Samagotchi
         .gsub(/[ \t]+/, " ")
         .gsub(/ *\n */, "\n")
         .strip
-      cleaned.empty? ? '' : cleaned
+      cleaned.empty? ? "" : cleaned
     end
 
     # The same tokens as #strip, but the text keeps its layout (indentation,
@@ -91,15 +92,15 @@ module Samagotchi
 
     def remove_tokens(text)
       text.to_s
-          .gsub(QWEN_THINK_RE, '')
-          .gsub(GEMMA_THOUGHT_RE, '')
-          .gsub(QWEN_TOOL_CALL_RE, '')
-          .gsub(LITERALS_RE, '')
-          .gsub(INDIVIDUAL_RE, '')
-          .gsub(PROMPT_LITERALS, '')
+          .gsub(QWEN_THINK_RE, "")
+          .gsub(GEMMA_THOUGHT_RE, "")
+          .gsub(QWEN_TOOL_CALL_RE, "")
+          .gsub(LITERALS_RE, "")
+          .gsub(INDIVIDUAL_RE, "")
+          .gsub(PROMPT_LITERALS, "")
           # orphaned closing tags that may remain after block removal
-          .gsub(/<\/?think>/, '')
-          .gsub(/<\/?tool_call>/, '')
+          .gsub(%r{</?think>}, "")
+          .gsub(%r{</?tool_call>}, "")
     end
   end
 end

data/lib/samagotchi/owner_lock.rb

@@ -40,7 +40,8 @@ module Samagotchi
     # @return [OwnerLock, nil] nil when another owner holds it
     def self.acquire(session_dir, kind:, wait: DEFAULT_WAIT)
       FileUtils.mkdir_p(session_dir)
-      file = File.open(path(session_dir), File::RDWR | File::CREAT, 0o644)
+      # Held open on purpose: the flock lives as long as the OwnerLock (#release closes it).
+      file = File.open(path(session_dir), File::RDWR | File::CREAT, 0o644) # rubocop:disable Style/FileOpen
       deadline = monotonic_now + wait.to_f
       until file.flock(File::LOCK_EX | File::LOCK_NB)
         if monotonic_now >= deadline

data/lib/samagotchi/plugin/api.rb

@@ -51,6 +51,7 @@ module Samagotchi
       #   it runs as other commands do)
       def command(name, description, anytime: false, &block)
         raise ArgumentError, "command #{name.inspect} needs a block" unless block
+
         name = name.to_s
         raise ArgumentError, "command name #{name.inspect} must look like /name (a-z, 0-9, _ and -)" unless name.match?(COMMAND_NAME)
         if (taken = @registries.commands.entries.find { |entry| entry.name == name })
@@ -78,9 +79,9 @@ module Samagotchi
       # @param targets [#call, nil] args → what guardrail rules match: a Hash
       #   with paths: (absolute or relative to the cwd), command: (a shell
       #   command) and cwd:, each optional
-      def tool(name, description, params: {}, schema: nil, label: nil, preview: nil, targets: nil, &block)
+      def tool(name, description, params: {}, schema: nil, label: nil, preview: nil, targets: nil, &)
         spec = Api.tool_spec(name, description, params: params, schema: schema, label: label, preview: preview,
-                                                targets: targets, &block)
+                                                targets: targets, &)
         if (taken = @registries.tools[spec[:name]])
           raise ArgumentError, "tool #{spec[:name]} is already registered (#{taken.source})"
         end
@@ -124,9 +125,9 @@ module Samagotchi
         end
 
         # As Api#tool.
-        def tool(name, description, params: {}, schema: nil, label: nil, preview: nil, targets: nil, &block)
+        def tool(name, description, params: {}, schema: nil, label: nil, preview: nil, targets: nil, &)
           spec = Api.tool_spec(name, description, params: params, schema: schema, label: label, preview: preview,
-                                                  targets: targets, &block)
+                                                  targets: targets, &)
           raise ArgumentError, "tool #{spec[:name]} is registered twice" if @specs.any? { |s| s[:name] == spec[:name] }
 
           @specs << spec
@@ -159,6 +160,7 @@ module Samagotchi
       # @return [Service]
       def service(name, eager: false, &block)
         raise ArgumentError, "service #{name.inspect} needs a block" unless block
+
         name = "#{@bundle}:#{name}"
         raise ArgumentError, "service #{name} is registered twice" if @services.any? { |svc| svc.name == name }
         raise ArgumentError, "this chi has no services (plugins: false)" unless @registries.services
@@ -249,6 +251,7 @@ module Samagotchi
       # @return [Hash] {name:, schema:, label:, preview:, targets:, block:}
       def self.tool_spec(name, description, params: {}, schema: nil, label: nil, preview: nil, targets: nil, &block)
         raise ArgumentError, "tool #{name.inspect} needs a block" unless block
+
         name = name.to_s
         raise ArgumentError, "tool name #{name.inspect} must be a-z, 0-9 and _ (at most 48)" unless name.match?(TOOL_NAME)
         raise ArgumentError, "tool #{name}: preview must respond to #call" if preview && !preview.respond_to?(:call)
@@ -323,7 +326,7 @@ module Samagotchi
       # (a call built without one, in a spec say: the call without its
       # name), string keys, typed by +parameters+, frozen.
       def self.args_of(call, parameters = nil)
-        given = call[:args].is_a?(Hash) ? call[:args] : call.reject { |key, _| key == :name || key == :args }
+        given = call[:args].is_a?(Hash) ? call[:args] : call.reject { |key, _| %i[name args].include?(key) }
         Tools::Args.coerce(given, parameters).freeze
       end
 

data/lib/samagotchi/plugin/context.rb

@@ -107,9 +107,7 @@ module Samagotchi
       # $XDG_STATE_HOME/samagotchi/plugins/<bundle>/, created on first use.
       # @return [String]
       def data_dir
-        @data_dir ||= begin
-          File.join(Paths.state_dir(env: @env), "plugins", @bundle).tap { |dir| FileUtils.mkdir_p(dir) }
-        end
+        @data_dir ||= File.join(Paths.state_dir(env: @env), "plugins", @bundle).tap { |dir| FileUtils.mkdir_p(dir) }
       end
 
       # The conversation so far, a frozen copy, without the system prompt.