samagotchi 0.157.0 → 0.159.0

data/lib/samagotchi/memory_bundle/builder.rb

@@ -4,7 +4,6 @@ require "digest"
 require_relative "file_digest"
 require "fileutils"
 require "tmpdir"
-require_relative "bundle_hook"
 require_relative "manifest"
 require_relative "placeholder"
 require_relative "../memory_paths"
@@ -12,7 +11,9 @@ require_relative "../model_overlay"
 
 module Samagotchi
   module MemoryBundle
-    # Builds local memories and installed hooks into a shareable bundle.
+    # Builds local memories and an installed bundle's rules, plugin and
+    # scripts into a shareable bundle (class-file hooks are retired: an older
+    # record's hooks/ isn't built).
     #
     # Inverse of Installer: reads from the resolved scope directory,
     # computes SHA256 checksums, writes manifest.yml via Manifest.write,
@@ -27,11 +28,10 @@ module Samagotchi
       # record and its dir), else from the scope dir:
       #   record      the InstalledBundle, nil when none is installed (or
       #               it doesn't read)
-      #   hooks       basename => BundleHook; hook_files basename => path
       #   rules       guardrails/*.yml paths
       #   plugin      the installed plugin file, nil without one
       #   scripts     file name => path; context_providers, block_renderers the parsed lists
-      InstalledParts = Data.define(:record, :hooks, :hook_files, :rules, :plugin, :scripts, :context_providers, :block_renderers)
+      InstalledParts = Data.define(:record, :rules, :plugin, :scripts, :context_providers, :block_renderers)
 
       attr_reader :built_files, :warnings, :placeholder_warnings, :out_path, :staging_dir
 
@@ -138,12 +138,10 @@ module Samagotchi
         end
       end
 
-      # The installed bundle's hooks (a recorded one missing on disk left
-      # out; one with no recorded sha gets its file's), guardrail rules,
-      # plugin, scripts, context providers and block renderers (its
-      # InstalledManifest's). Without hooks or rules in a
-      # record, the scope dir's hooks/*.rb and guardrails/*.yml (building
-      # from a raw bundle dir that is also the memories dir).
+      # The installed bundle's guardrail rules, plugin, scripts, context
+      # providers and block renderers (its InstalledManifest's). Without
+      # rules in a record, the scope dir's guardrails/*.yml (building from a
+      # raw bundle dir that is also the memories dir).
       # @return [InstalledParts]
       def installed_parts(name, target_dir)
         prov = nil
@@ -156,23 +154,6 @@ module Samagotchi
           record = nil
         end
 
-        hooks = {}
-        hook_files = {}
-        if record&.hooks&.any?
-          record.hooks.each do |basename, hook|
-            src = File.join(prov.hooks_dir, basename)
-            next unless File.exist?(src)
-
-            hooks[basename] = hook.sha256.empty? ? hook.with(sha256: BundleHook.of_file(src).sha256) : hook
-            hook_files[basename] = src
-          end
-        else
-          Dir.glob(File.join(target_dir, "hooks", "*.rb")).sort.each do |src|
-            hooks[File.basename(src)] = BundleHook.of_file(src)
-            hook_files[File.basename(src)] = src
-          end
-        end
-
         rules_dir = record&.guardrails&.any? ? prov.guardrails_dir : File.join(target_dir, "guardrails")
         plugin = record ? prov.plugin_path(record) : nil
         manifest = record&.manifest
@@ -181,7 +162,7 @@ module Samagotchi
         raise BuildError, "the installed #{name}'s record: #{problem}" if problem
 
         InstalledParts.new(
-          record: record, hooks: hooks, hook_files: hook_files,
+          record: record,
           rules: Dir.exist?(rules_dir) ? Dir.glob(File.join(rules_dir, "*.yml")).sort : [],
           plugin: plugin && File.file?(plugin) ? plugin : nil,
           scripts: installed_scripts(prov, record),
@@ -190,14 +171,10 @@ module Samagotchi
         )
       end
 
-      # The memories, hooks/, guardrails/, the plugin and scripts/ into the
+      # The memories, guardrails/, the plugin and scripts/ into the
       # staging dir, laid out as Installer reads a bundle.
       def stage_files(staging, candidates, parts)
         candidates.each { |src| FileUtils.cp(src, File.join(staging, File.basename(src))) }
-        unless parts.hook_files.empty?
-          FileUtils.mkdir_p(File.join(staging, "hooks"))
-          parts.hook_files.each { |basename, src| FileUtils.cp(src, File.join(staging, "hooks", basename)) }
-        end
         unless parts.rules.empty?
           FileUtils.mkdir_p(File.join(staging, "guardrails"))
           parts.rules.each { |src| FileUtils.cp(src, File.join(staging, "guardrails", File.basename(src))) }
@@ -225,7 +202,6 @@ module Samagotchi
           scope: @scope,
           description: description,
           files: files_map,
-          hooks: parts.hooks.empty? ? nil : parts.hooks,
           trust_level: trust_level,
           plugin: parts.plugin && { file: File.basename(parts.plugin), sha256: FileDigest.sha256(parts.plugin),
                                     required: manifest&.plugin_required },

data/lib/samagotchi/memory_bundle/bundle_hook.rb

@@ -1,16 +1,15 @@
 # frozen_string_literal: true
 
-require_relative "file_digest"
-
 module Samagotchi
   module MemoryBundle
-    # One hook's metadata, as a bundle's manifest.yml declares it and its
-    # installed record (manifest.json) keeps it: the file's sha256
+    # One class-file hook's metadata, as an older chi's installed record
+    # (manifest.json) keeps it (chi no longer installs or loads them:
+    # Manifest::HooksRetired; it reads them to retire, uninstall and name
+    # them, and the trash selection takes #sha256): the file's sha256
     # ("sha256:<hex>", "" when none is recorded), the events it registers
     # for (manifest `event:` for one, `events:` a list; none: it isn't
-    # loaded), on_error (skip, log or fail_closed) and priority. One
-    # instance of the hook serves every event it lists. The one place the
-    # defaults live.
+    # loaded), on_error (skip, log or fail_closed) and priority. The one
+    # place the defaults live.
     class BundleHook < Data.define(:sha256, :events, :on_error, :priority)
       DEFAULT_ON_ERROR = "skip"
       DEFAULT_PRIORITY = 100
@@ -37,35 +36,11 @@ module Samagotchi
             priority: (h["priority"] || DEFAULT_PRIORITY).to_i)
       end
 
-      # A hook known only by its file (no declared event): its sha, the defaults.
-      # Callers pass a file that is there (FileDigest is nil for one that isn't).
-      def self.of_file(path)
-        new(sha256: FileDigest.sha256(path))
-      end
-
       # "sha256:<hex>" from either form, "" for none.
       def self.prefixed(sha)
         sha = sha.to_s.strip
         sha.empty? || sha.start_with?("sha256:") ? sha : "sha256:#{sha}"
       end
-
-      # The sha's hex, "" when none is recorded.
-      def hex = sha256.delete_prefix("sha256:")
-
-      # Whether the hook fails closed: on_error fail_closed applies to its
-      # before_tool_call registration only.
-      def fail_closed?(event) = on_error == "fail_closed" && event.to_s == "before_tool_call"
-
-      # How `chi bundle status` / `diff` name its events: `event=x`, or
-      # `events=x,y` for more than one.
-      def events_field = events.size > 1 ? "events=#{events.join(",")}" : "event=#{events.first}"
-
-      # The string-keyed form manifest.yml and manifest.json hold: `event`
-      # for one event (as an older chi reads it), `events` for more.
-      def to_record
-        listed = events.size > 1 ? { "events" => events.dup } : { "event" => events.first.to_s }
-        { "sha256" => sha256, **listed, "on_error" => on_error, "priority" => priority }
-      end
     end
   end
 end

data/lib/samagotchi/memory_bundle/file_actions.rb

@@ -22,6 +22,8 @@ module Samagotchi
       #   :keep            left as it is (already the bundle's, or kept)
       #   :skip            left as it is, the bundle doesn't take it
       #   :move_to_trash   moved to the trash (a removal)
+      #   :remove          deleted (an asset: save_first copies an edit to the
+      #                    trash first)
       #   :refuse          the command stops
       #   :restore         the bundle's text put back (SystemBundle at its version)
       # save_first: a copy of the old bytes goes to the trash before a write
@@ -157,6 +159,55 @@ module Samagotchi
 
       TABLES = { install: INSTALL, force: FORCE, upgrade: UPGRADE, remerge: REMERGE, restore: RESTORE,
                  uninstall: UNINSTALL }.freeze
+
+      # A bundle's own folder (rules, the plugin, scripts: AssetState), which
+      # every install replaces whole: the source's files go in, the rest go,
+      # an edit (AssetState#edited?) copied to the trash first. A cell is keyed
+      # [state, kind_of_file] or [state, :any]. A file the source has is
+      # written even when it has its bytes already (and so checked against the
+      # manifest's sha, as any other).
+      ASSET_WRITE = Action.new(do: :write_incoming, word: :installed, next_base: :on_disk)
+      ASSET_REMOVE = Action.new(do: :remove, word: nil, next_base: :none, record: :drop)
+      ASSET_GONE = Action.new(do: :skip, word: nil, next_base: :none, record: :drop)
+
+      # A plain install, install --force, and an upgrade with no record yet.
+      ASSET_INSTALL = {
+        %i[new any] => ASSET_WRITE, %i[unchanged any] => ASSET_WRITE.with(word: :up_to_date),
+        %i[pristine any] => ASSET_WRITE, %i[edited any] => ASSET_WRITE.with(save_first: true),
+        %i[linked any] => ASSET_WRITE,
+        # The source dropped it: it goes with the folder, without a word.
+        %i[dropped_pristine any] => ASSET_REMOVE, %i[dropped_edited any] => ASSET_REMOVE.with(save_first: true),
+        %i[missing any] => ASSET_GONE
+      }.freeze
+
+      # An upgrade (--force too) over the record: a file it replaces is
+      # updated, except a rule (an upgrade lists a replaced rule as installed:
+      # the corpus's rule-installed).
+      ASSET_UPGRADE = ASSET_INSTALL.merge(
+        %i[pristine any] => ASSET_WRITE.with(word: :updated),
+        %i[edited any] => ASSET_WRITE.with(word: :updated, save_first: true),
+        %i[linked any] => ASSET_WRITE.with(word: :updated),
+        %i[pristine rule] => ASSET_WRITE, %i[edited rule] => ASSET_WRITE.with(save_first: true),
+        %i[linked rule] => ASSET_WRITE
+      ).freeze
+
+      # Uninstall: the folder goes (no source, so every file there is a
+      # dropped_* or a link), an edit copied to the trash first, --force or not.
+      ASSET_UNINSTALL = {
+        %i[dropped_pristine any] => ASSET_REMOVE, %i[dropped_edited any] => ASSET_REMOVE.with(save_first: true),
+        %i[linked any] => ASSET_REMOVE, %i[missing any] => ASSET_GONE
+      }.freeze
+
+      ASSET_TABLES = { install: ASSET_INSTALL, upgrade: ASSET_UPGRADE, uninstall: ASSET_UNINSTALL }.freeze
+
+      # The command's action for an AssetState: [state, kind_of_file], then
+      # [state, :any].
+      # @param command [Symbol] an ASSET_TABLES key
+      # @return [Action, nil] nil: the command never meets the state
+      def self.for_asset(command, asset)
+        table = ASSET_TABLES.fetch(command)
+        table[[asset.state, asset.kind_of_file]] || table[[asset.state, :any]]
+      end
       # The kinds whose row depends on another bundle listing the file.
       SHARED_ASKED = %i[dropped_pristine dropped_edited pristine pristine_no_base edited edited_no_base].freeze
 

data/lib/samagotchi/memory_bundle/installed_bundle.rb

@@ -119,7 +119,7 @@ module Samagotchi
       # recorded is gone (:missing). false with no dir.
       def manifest_unkept? = !dir.nil? && (manifest_sha.to_s.empty? || !File.file?(kept_manifest_path))
 
-      # What its manifest says (requires_chi, hook metadata, needs, providers,
+      # What its manifest says (requires_chi, needs, providers,
       # renderers, settings…): the one way to read manifest data of an
       # installed bundle.
       # @return [InstalledManifest]

data/lib/samagotchi/memory_bundle/installed_copy.rb

@@ -3,27 +3,28 @@
 require "fileutils"
 require "tmpdir"
 require "yaml"
-require_relative "bundle_hook"
 require_relative "manifest"
 require_relative "provenance"
 
 module Samagotchi
   module MemoryBundle
-    # An installed bundle laid out as a source folder again: the plugin, hooks,
+    # An installed bundle laid out as a source folder again: the plugin,
     # rules and scripts as they are installed (a dev install's links
     # followed), the memories as their bases (the bundle's bytes, not the
     # user's edits). A bundle's source may be gone or be a URL; this is what
     # `chi update` can check of what really runs.
     #
-    # manifest.yml: its files:, hooks:, plugin: and scripts: are the record's
-    # and the copy's (what is installed: a memory the install left out, or one
-    # with no base, and a manifest hook the record lacks aren't listed, so the
-    # check finds no missing-file for them). Every other key is the kept
+    # manifest.yml: its files:, plugin: and scripts: are the record's and
+    # the copy's (what is installed: a memory the install left out, or one
+    # with no base, isn't listed, so the check finds no missing-file for it).
+    # It has no hooks: and no hooks/, whatever the record or the kept
+    # manifest says: class-file hooks don't load (InstalledCheck names a
+    # record's once). Every other key is the kept
     # manifest.yml's when it is read (InstalledManifest origin :kept), so the
     # check sees its unknown keys too; else the record's mirror's.
     #
     # The shas are the files' own, so an edited plugin is checked as written.
-    # A plugin, hook or script the record lists that isn't there stays
+    # A plugin or script the record lists that isn't there stays
     # listed, for the check's missing-file.
     module InstalledCopy
       module_function
@@ -45,7 +46,7 @@ module Samagotchi
           dir: dir, name: bundle.name, version: bundle.version.to_s.empty? ? "0" : bundle.version, trust_level: manifest.trust_level,
           files: memories(bundle, provenance, dir),
           file_descriptions: manifest.file_descriptions,
-          hooks: hooks(bundle, provenance, dir), plugin: plugin(bundle, provenance, dir),
+          plugin: plugin(bundle, provenance, dir),
           scripts: copies(bundle.scripts, provenance.scripts_dir, File.join(dir, "scripts")),
           requires_chi: manifest.requires_chi, needs: manifest.needs,
           context_providers: manifest.context_providers, block_renderers: manifest.block_renderers,
@@ -57,7 +58,8 @@ module Samagotchi
       end
       private_class_method :write
 
-      # What is installed, which the copy's manifest.yml takes from the record.
+      # What is installed, which the copy's manifest.yml takes from the
+      # record (hooks: none, so the kept manifest's isn't taken either).
       INSTALLED_KEYS = %w[name version files hooks plugin scripts].freeze
 
       # The written manifest's INSTALLED_KEYS and +failed+ keys (the value
@@ -80,15 +82,6 @@ module Samagotchi
       end
       private_class_method :memories
 
-      # The recorded hooks with the metadata they load with (InstalledManifest#hooks).
-      def hooks(bundle, provenance, dir)
-        bundle.manifest.hooks.to_h do |file, hook|
-          sha = copy(File.join(provenance.hooks_dir, file), File.join(dir, "hooks", file), hook.sha256)
-          [file, hook.with(sha256: sha)]
-        end
-      end
-      private_class_method :hooks
-
       def plugin(bundle, provenance, dir)
         return nil unless bundle.plugin
 

data/lib/samagotchi/memory_bundle/installed_manifest.rb

@@ -39,9 +39,6 @@ module Samagotchi
     #
     #   requires_chi, trust_level   the strings as recorded, nil when none
     #   description                 the kept manifest's, nil from the record
-    #   hooks                       basename => BundleHook: each recorded hook,
-    #                               the kept manifest's events, on_error and
-    #                               priority with the record's sha
     #   needs                       Manifest.parse_needs'
     #   script_names                the scripts/ files it lists
     #   context_providers           Array<ContextProviders::Provider>
@@ -61,7 +58,7 @@ module Samagotchi
     #   floor_keys                  the kept manifest's Manifest#floor_keys (key =>
     #                               the first chi that read it), {} from the record
     #   origin                      :kept or :record
-    class InstalledManifest < Data.define(:name, :version, :requires_chi, :trust_level, :description, :hooks, :needs,
+    class InstalledManifest < Data.define(:name, :version, :requires_chi, :trust_level, :description, :needs,
                                           :script_names, :context_providers, :block_renderers, :session_settings,
                                           :session_setting_types, :settings, :setting_types, :file_descriptions,
                                           :plugin_required, :includes, :unknown_keys, :floor_keys, :problems, :origin)
@@ -130,7 +127,6 @@ module Samagotchi
         new(name: bundle.name, version: bundle.version,
             requires_chi: pick.call("requires_chi", kept.requires_chi, mirrored.requires_chi),
             trust_level: kept.trust_level, description: kept.description.empty? ? nil : kept.description,
-            hooks: pick.call("hooks", kept_hooks(bundle.hooks, kept.hooks), bundle.hooks),
             needs: pick.call("needs", kept.needs, mirrored.needs),
             script_names: pick.call("scripts", kept.scripts.keys, mirrored.script_names),
             context_providers: pick.call("context_providers", kept.context_providers, mirrored.context_providers),
@@ -150,21 +146,11 @@ module Samagotchi
         {}
       end
 
-      # Each recorded hook (what is installed): the kept manifest's metadata
-      # for it with the record's sha; one the manifest doesn't list (a found
-      # hooks/*.rb) as recorded. A manifest hook the record lacks isn't installed.
-      def self.kept_hooks(recorded, declared)
-        recorded.to_h do |file, hook|
-          [file, declared.key?(file) ? declared[file].with(sha256: hook.sha256) : hook]
-        end
-      end
-
       def self.from_record(bundle)
         raw = recorded(bundle)
         problems = {}
         new(name: bundle.name, version: bundle.version,
             requires_chi: raw["requires_chi"]&.to_s, trust_level: raw["trust_level"]&.to_s, description: nil,
-            hooks: bundle.hooks,
             needs: parsed(problems, "needs", [], Manifest::ValidationError) { Manifest.parse_needs(raw["needs"]) },
             script_names: bundle.scripts.keys,
             context_providers: parsed(problems, "context_providers", []) { ContextProviders.parse_list(raw["context_providers"]) },
@@ -204,7 +190,7 @@ module Samagotchi
           acc[key] = text unless text.empty?
         end
       end
-      private_class_method :deep_freeze, :kept_stat, :build, :standing, :from_kept, :floors, :kept_hooks, :from_record, :recorded, :parsed,
+      private_class_method :deep_freeze, :kept_stat, :build, :standing, :from_kept, :floors, :from_record, :recorded, :parsed,
                            :list, :types, :file_descriptions
 
       # Why the kept manifest.yml wasn't read: :missing, :stale or :edited (the class

data/lib/samagotchi/memory_bundle/installer.rb

@@ -34,8 +34,9 @@ module Samagotchi
     class Installer
       class InstallError < StandardError; end
 
-      # What the run did to one file (a memory, or a hook, rule, plugin or
-      # script: AssetInstaller writes them too), as #results holds it. word is
+      # What the run did to one file (a memory, or a rule, plugin or script:
+      # AssetInstaller writes them too, and removes an older chi's hooks), as
+      # #results holds it. word is
       # the report bucket (#summary): a real run's (:installed, :updated,
       # :merged, :kept, :kept_pruned, :kept_shared, :kept_own (a file left as
       # the user's), :up_to_date, :conflict, :removed) or a dry run's
@@ -166,8 +167,10 @@ module Samagotchi
         would_install = with_word(:would_install)
         would_update = with_word(:would_update)
         fast_forward = with_word(:fast_forward)
-        removed = with_word(:removed)
-        would_remove = with_word(:would_remove)
+        # An older chi's class-file hooks this run removes: a line of their
+        # own, with why (AssetInstaller#retire_hooks).
+        retired, removed = with_word(:removed).partition { |key| @results[key].note == AssetInstaller::RETIRED }
+        would_retire, would_remove = with_word(:would_remove).partition { |key| @results[key].note == AssetInstaller::RETIRED }
 
         lines << "Installed: #{installed.join(", ")}" unless installed.empty?
         lines << "Updated: #{updated.join(", ")}" unless updated.empty?
@@ -178,6 +181,8 @@ module Samagotchi
         lines << FileStanding.merged_line(would_merge, @manifest&.version, dry_run: true) unless would_merge.empty?
         lines << "Removed (no longer in the bundle): #{removed.join(", ")}#{" (moved to #{trash_dir})" if trash_dir}" unless removed.empty?
         lines << "Would remove (no longer in the bundle): #{would_remove.join(", ")}" unless would_remove.empty?
+        lines << "Removed (#{AssetInstaller::RETIRED}): #{retired.join(", ")}" unless retired.empty?
+        lines << "Would remove (#{AssetInstaller::RETIRED}): #{would_retire.join(", ")}" unless would_retire.empty?
         lines << "Kept (local edits preserved): #{kept.join(", ")}" unless kept.empty?
         lines << "Up to date: #{up_to_date.join(", ")}" unless up_to_date.empty?
         lines << "Skipped: #{skipped.join(", ")}" unless skipped.empty?
@@ -213,11 +218,11 @@ module Samagotchi
       def with_word(*words) = @results.select { |_, result| words.include?(result.word) }.keys
 
       # A plain install over a bundle that is already installed from the same
-      # source: it rewrote the bundle's hooks, rules, plugin, scripts and its
+      # source: it rewrote the bundle's rules, plugin, scripts and its
       # record, and left a memory the user wrote as it was. So the line says
       # what changed, and points at the upgrade for the memories it kept.
       def reinstall_line
-        line = "#{@name} was already installed from #{@source}: its hooks, rules, plugin and scripts " \
+        line = "#{@name} was already installed from #{@source}: its rules, plugin and scripts " \
                "now match it and its record was rewritten"
         # :kept_own is the only way a memory is left out of a plain install
         # (its KEPT_OWN or HELD row): its bytes differ from the bundle's.
@@ -256,10 +261,10 @@ module Samagotchi
       # #ref; a path resolved); one it can't place (an older record's
       # relative path) never refuses.
       #   - a name chi ships comes from a shipped dir only, unless --force
-      #     (install and upgrade): the plugin and hooks it replaces are chi's;
+      #     (install and upgrade): the plugin and rules it replaces are chi's;
       #   - a plain install over a bundle from another source is refused,
       #     --force too (that overwrites files, it doesn't switch sources):
-      #     it would delete the plugin and hooks and rewrite the record;
+      #     it would delete the plugin and rules and rewrite the record;
       #   - an upgrade may switch sources (a URL and a local copy of it are
       #     one bundle, an archive's file name has its version), and
       #     #source_change says so (the summary's first line).
@@ -351,19 +356,32 @@ module Samagotchi
         @bundle_dir = @source_dir = prepared.dir
         @source_owned = prepared.owned
         @source_commit = prepared.commit
+        refuse_hooks
         @manifest = Manifest.read(dir: @bundle_dir)
         clash = @manifest.session_settings_clash
         raise InstallError, clash if clash
       rescue SourceNormalizer::UnknownSourceError => e
         raise InstallError, "Source normalization failed: #{e.message}"
+      rescue Manifest::HooksRetired => e
+        # A rule, not a strictness option: refused strict or not, a dry run too.
+        raise InstallError, e.message
       rescue Manifest::ValidationError => e
         raise InstallError, e.message if @strict
 
         @warnings << "No manifest found — proceeding without strict manifest validation"
       end
 
+      # A source that ships class-file hooks (hooks/*.rb, listed or not) is
+      # refused before its manifest is read; its manifest's hooks: is
+      # Manifest.read's refusal (Manifest::HooksRetired either way).
+      # @raise [Manifest::HooksRetired]
+      def refuse_hooks
+        files = Manifest::HooksRetired.files_in(@bundle_dir)
+        raise Manifest::HooksRetired.for_files(files) unless files.empty?
+      end
+
       # A bundle whose requires_chi this chi doesn't meet is not installed at
-      # all: --force is what installs it, and its plugin, hooks and rules then
+      # all: --force is what installs it, and its plugin and rules then
       # warn that they won't load (AssetInstaller). The words come from
       # Manifest.requires_chi_failure, so the requirement is said one way.
       # A dry run is refused the same way: nothing there would load either.
@@ -555,8 +573,11 @@ module Samagotchi
       # differs from its manifest's sha256. One kept or skipped isn't checked
       # (it takes nothing from the bundle). What is checked is the source
       # file, the bytes the write or merge takes, so a dry run checks what it
-      # would bring in, never the user's bytes on disk.
+      # would bring in, never the user's bytes on disk. A dev install follows
+      # its own tree; chi bundle check flags its stale shas instead.
       def verify_memory_checksums
+        return if @dev
+
         @bundle_md.each do |file_key|
           result = @results[file_key]
           next unless result&.action&.takes_source?
@@ -579,7 +600,7 @@ module Samagotchi
 
       # The install's record (Provenance#write), only with a manifest and
       # not on a dry run. An upgrade with conflicts writes it too: the new
-      # version, the plugin's and hooks' new shas, and the old base for each
+      # version, the plugin's new sha, and the old base for each
       # conflicted file, marked conflict (chi bundle status shows it).
       # Skipping it left the replaced plugin failing its sha check.
       # @param installed [AssetInstaller::Installed]
@@ -589,11 +610,8 @@ module Samagotchi
           scope: @target_scope,
           version: @manifest.version,
           source_path: @source,
-          # AssetInstaller added the discovered hooks/*.rb to manifest.hooks.
-          hooks: @manifest.hooks,
           trust_level: @manifest.trust_level,
           source_commit: @source_commit,
-          hooks_files: installed.hook_files,
           guardrails_files: installed.guardrail_files,
           plugin_file: installed.plugin_file,
           plugin_required: @manifest.plugin&.dig(:required) == true,