salsify_rubocop 1.74.0 → 1.85.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 04d76544a5d6aae6ddd1154cee539489026224153120d314a9dd80fed6765be0
-  data.tar.gz: 1a26b0238f38a29663ff1132140db522f63804efd0f62729e6a2b633d764af4a
+  metadata.gz: 041d08c08bd8b52a2f34f7eede60ffd0d4a10fa273677786f2c9ac55022a61ef
+  data.tar.gz: 9d81f7db9c1cc04c626c14ff254bbe63bb4bef0819ccf4814acedc252129ce8f
 SHA512:
-  metadata.gz: a3826cfe3896c3bf4de2da7aed4f3a3ee3a9cabffd0f816fda262db7199365ae31c9b7cdcf861ef2cd52c059831c8e8ba20f259d5b9943010f2d42a8f3db34a0
-  data.tar.gz: d60e9c9c926bc8ef3799008cadc98c92a70187d715975785e2d3a5564a89fb0f549f011d907d4502397532d1dde33472ecc30277055c740ac660f0680b04450a
+  metadata.gz: a8786955249fc8c36608315cb11dfbbd4ca306eae89e5a84df1589be6d4c8f38ff3e88053fd1bec186d34799c3576c27dd8216cfb7731ffa65a92c7670a89a59
+  data.tar.gz: 5109e5d059b580e0d1200270cc59fd4d245d4a71f1ca67ab40bf8e244a1d924b90cc40b6737bf1ae061a741cb778dace5e31f8f2983fccc7b495957fe6ec7474

data/.circleci/config.yml

@@ -2,23 +2,24 @@ version: 2.1
 jobs:
   lint:
     docker:
-      - image: cimg/ruby:2.7.7
+      - image: cimg/ruby:3.3.0
     working_directory: ~/salsify_rubocop
     steps:
       - checkout
       - restore_cache:
           keys:
-            - v1-gems-ruby-2.7.7-{{ checksum "salsify_rubocop.gemspec" }}-{{ checksum "Gemfile" }}
-            - v1-gems-ruby-2.7.7-
+            - v1-gems-ruby-3.3.0-{{ checksum "salsify_rubocop.gemspec" }}-{{ checksum "Gemfile" }}
+            - v1-gems-ruby-3.3.0-
       - run:
           name: Install Gems
           command: |
-            if ! bundle check --path=vendor/bundle; then
-              bundle install --path=vendor/bundle --jobs=4 --retry=3
+            bundle config set path 'vendor/bundle'
+            if ! bundle check; then
+              bundle install --jobs=4 --retry=3
               bundle clean
             fi
       - save_cache:
-          key: v1-gems-ruby-2.6.6-{{ checksum "salsify_rubocop.gemspec" }}-{{ checksum "Gemfile" }}
+          key: v1-gems-ruby-3.3.0-{{ checksum "salsify_rubocop.gemspec" }}-{{ checksum "Gemfile" }}
           paths:
             - "vendor/bundle"
             - "gemfiles/vendor/bundle"
@@ -43,8 +44,9 @@ jobs:
       - run:
           name: Install Gems
           command: |
-            if ! bundle check --path=vendor/bundle; then
-              bundle install --path=vendor/bundle --jobs=4 --retry=3
+            bundle config set path 'vendor/bundle'
+            if ! bundle check; then
+              bundle install --jobs=4 --retry=3
               bundle clean
             fi
       - save_cache:
@@ -66,8 +68,6 @@ workflows:
           matrix:
             parameters:
               ruby_version:
-                - "2.7.2"
-                - "3.0.0"
-                - "3.1.1"
-                - "3.2.0"
                 - "3.3.0"
+                - "3.4.0"
+                - "4.0.0"

data/.rubocop.yml

@@ -2,7 +2,7 @@ inherit_from:
   - conf/rubocop.yml
 
 AllCops:
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.3
 
 Layout/LineLength:
   Exclude:

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # salsify_rubocop
 
+## 1.85.3
+- Enable `Style/HashSyntax` with `EnforcedShorthandSyntax: always`.
+  Hashes whose keys match their values must now use shorthand
+  (`{ foo: }` rather than `{ foo: foo }`). Autocorrectable with
+  `rubocop -a`.
+
+## 1.85.2
+- Add `Salsify/DelayedJobSelfEnqueue` cop to detect `Delayed::Job.enqueue(self, ...)`, which serializes memoized AR objects and can cause `Delayed::DeserializationError` if those records are deleted before the job runs.
+- Drop support for Ruby < 3.3
+
+## 1.85.1
+- Upgrade `rubocop` to v1.85.1.
+
 ## 1.74.0
 - Upgrade `rubocop` to v1.74.0.
 

data/conf/rubocop_without_rspec.yml

@@ -180,7 +180,7 @@ Metrics/CyclomaticComplexity:
 Layout/LineLength:
   Enabled: true
   Max: 120
-  IgnoreCopDirectives: true
+  AllowCopDirectives: true
   AllowedPatterns:
     - ^#
 
@@ -234,9 +234,9 @@ Style/HashAsLastArrayItem:
 Style/HashEachMethods:
   Enabled: false
 
-# Allow both { foo: } and { foo: foo }
+# Enforce the shorthand syntax where the key matches the value.
 Style/HashSyntax:
-  EnforcedShorthandSyntax: either
+  EnforcedShorthandSyntax: always
 
 Style/OptionalBooleanParameter:
   Enabled: false
@@ -326,6 +326,9 @@ Style/QuotedSymbols:
 Style/RedundantInitialize:
   Enabled: false
 
+Style/RedundantParentheses:
+  Enabled: false  
+
 Style/RedundantSelfAssignmentBranch:
   Enabled: false
 

data/config/default.yml

@@ -45,3 +45,8 @@ Salsify/StyleDig:
   Enabled: true
   AutoCorrect: false
 
+Salsify/DelayedJobSelfEnqueue:
+  Description: 'Do not pass `self` to `Delayed::Job.enqueue` to avoid serializing memoized AR objects.'
+  Enabled: true
+  AutoCorrect: false
+

data/lib/rubocop/cop/salsify/delayed_job_self_enqueue.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Salsify
+      # Detects `Delayed::Job.enqueue(self, ...)`.
+      #
+      # Re-enqueuing `self` serializes the entire object including memoized
+      # ActiveRecord instances. If any of those records are deleted before the
+      # job is next executed, deserialization will raise
+      # `Delayed::DeserializationError`. Create a fresh instance with only the
+      # primitive arguments instead.
+      #
+      # @example
+      #
+      #   # bad
+      #   Delayed::Job.enqueue(self, run_at: 5.minutes.from_now)
+      #
+      #   # good
+      #   new_job = self.class.new(arg_one: arg_one, arg_two: arg_two)
+      #   Delayed::Job.enqueue(new_job, run_at: 5.minutes.from_now)
+      class DelayedJobSelfEnqueue < ::RuboCop::Cop::Base
+        MSG = 'Do not pass `self` to `Delayed::Job.enqueue`. ' \
+              'Create a new job instance to avoid serializing memoized AR objects.'
+
+        def_node_matcher :enqueue_self?, <<-PATTERN
+          (send
+            (const (const {nil? (cbase)} :Delayed) :Job)
+            :enqueue
+            self
+            ...)
+        PATTERN
+
+        def on_send(node)
+          return unless enqueue_self?(node)
+
+          add_offense(node, message: MSG)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/salsify/rspec_dot_not_self_dot.rb

@@ -20,7 +20,7 @@ module RuboCop
       class RspecDotNotSelfDot < RuboCop::Cop::RSpec::Base
         extend RuboCop::Cop::AutoCorrector
 
-        SELF_DOT_REGEXP = /["']self\./.freeze
+        SELF_DOT_REGEXP = /["']self\./
         MSG = 'Use ".<class method>" instead of "self.<class method>" for example group description.'
 
         def_node_matcher :example_group_match, <<-PATTERN

data/lib/salsify_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SalsifyRubocop
-  VERSION = '1.74.0'
+  VERSION = '1.85.3'
 end

data/lib/salsify_rubocop.rb

@@ -25,3 +25,4 @@ require 'rubocop/cop/salsify/rspec_doc_string'
 require 'rubocop/cop/salsify/rspec_dot_not_self_dot'
 require 'rubocop/cop/salsify/rspec_string_literals'
 require 'rubocop/cop/salsify/style_dig'
+require 'rubocop/cop/salsify/delayed_job_self_enqueue'

data/salsify_rubocop.gemspec

@@ -30,14 +30,14 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.7'
+  spec.required_ruby_version = '>= 3.3'
 
-  spec.add_development_dependency 'bundler', '~> 2.0'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec_junit_formatter'
 
-  spec.add_runtime_dependency 'rubocop', '~> 1.74.0'
+  spec.add_runtime_dependency 'rubocop', '~> 1.85.1'
   spec.add_runtime_dependency 'rubocop-performance', '~> 1.15.2'
   spec.add_runtime_dependency 'rubocop-rails', '~> 2.17.4'
   spec.add_runtime_dependency 'rubocop-rake', '~> 0.6.0'

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: salsify_rubocop
 version: !ruby/object:Gem::Version
-  version: 1.74.0
+  version: 1.85.3
 platform: ruby
 authors:
 - Salsify, Inc
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2025-03-25 00:00:00.000000000 Z
+date: 2026-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.74.0
+        version: 1.85.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.74.0
+        version: 1.85.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -160,6 +160,7 @@ files:
 - conf/rubocop_rails50.yml
 - conf/rubocop_without_rspec.yml
 - config/default.yml
+- lib/rubocop/cop/salsify/delayed_job_self_enqueue.rb
 - lib/rubocop/cop/salsify/rails_application_mailer.rb
 - lib/rubocop/cop/salsify/rails_application_serializer.rb
 - lib/rubocop/cop/salsify/rails_unscoped.rb
@@ -184,14 +185,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.5.22
 signing_key: 
 specification_version: 4
 summary: Shared RuboCop configuration