salsify_rubocop 1.2.0 → 1.27.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1a27b274167c99b0c602b8179de3b2cc833019ebcdb893278604a5259dc6b011
-  data.tar.gz: b15ac3e56b5ea6095f0dac07858e00aa55a22239dd86611ab97775cbee047d86
+  metadata.gz: ce5d5cbb06696fde312271fdf7309d421476dc692129a4a483211fcd794f9fe8
+  data.tar.gz: 182edaf990710370a9a125f96e021e2185fa13f89c93e5d07001f60409fab3e7
 SHA512:
-  metadata.gz: c3709691e18170f955bc6825637234031dde141fa27a402ac4e3e64c904ee9a063c631587fd3b163a21e94a08a971e36be7d98600baebae8fd894e337c3de03e
-  data.tar.gz: 8adc382c5cb2ba0b196c12452591e5f42af2f7f687c1f2c71b43d62fdf9c47523572c3a535acb4fa7f42ee44af830c941b0bdeee34a82ce47cb8bae350ef0586
+  metadata.gz: e77dd48c195e9018fdb6514f0460cf0568e2c2410246986eca8b84581f7fc34d65d830f1d16f516788f1dd4b5a468a40869ed20a88da3dc942e1b4e184e22ed3
+  data.tar.gz: 8a072d0da7d78be213a1c310402ed8a05e19b3c4729356f96db5412edb9c0b4a95044810546e2ba38d15426ef9399cb8c2cb20c2755a892aa30c069d1cc12d7f

data/.circleci/config.yml

@@ -69,3 +69,4 @@ workflows:
                 - "2.6.6"
                 - "2.7.2"
                 - "3.0.0"
+                - "3.1.1"

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # salsify_rubocop
 
+## 1.27.0
+- Note: Previous versions had drifted from the documented versioning scheme,
+  which states that versions should match the shipped version of `rubocop`.
+- Upgrade to `rubocop` v1.27.0 with support for Ruby 3.1.
+- Upgrade `rubocop-rails` to v2.12.0.
+- Upgrade `rubocop-rspec` to v2.9.0.
+- Upgrade `rubocop-performance` to v1.12.0.
+
 ## 1.2.0
 - Disable Style/ExplicitBlockArgument for performance reasons, https://github.com/JuanitoFatas/fast-ruby/blob/master/code/proc-and-block/proc-call-vs-yield.rb.
 

data/README.md

@@ -127,7 +127,6 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/salsify/salsify_rubocop.
 
-
 ## License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/conf/rubocop_rails.yml

@@ -24,3 +24,116 @@ Rails/UniqBeforePluck:
 
 Salsify/RailsUnscoped:
   Enabled: true
+
+# Disabled for v2.4.0 -> v2.12.0 upgrade.
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: false
+
+Rails/AddColumnIndex:
+  Enabled: false
+
+Rails/AfterCommitOverride:
+  Enabled: false
+
+Rails/ArelStar:
+  Enabled: false
+
+Rails/AttributeDefaultBlockValue:
+  Enabled: false
+
+Rails/ContentTag:
+  Enabled: false
+
+Rails/DefaultScope:
+  Enabled: false
+
+Rails/EagerEvaluationLogMessage:
+  Enabled: false
+
+Rails/EnvironmentVariableAccess:
+  Enabled: false
+
+Rails/ExpandedDateRange:
+  Enabled: false
+
+Rails/FindById:
+  Enabled: false
+
+Rails/I18nLocaleAssignment:
+  Enabled: false
+
+Rails/IndexBy:
+  Enabled: false
+
+Rails/IndexWith:
+  Enabled: false
+
+Rails/Inquiry:
+  Enabled: false
+
+Rails/MailerName:
+  Enabled: false
+
+Rails/MatchRoute:
+  Enabled: false
+
+Rails/NegateInclude:
+  Enabled: false
+
+Rails/OrderById:
+  Enabled: false
+
+Rails/Pick:
+  Enabled: false
+
+Rails/Pluck:
+  Enabled: false
+
+Rails/PluckId:
+  Enabled: false
+
+Rails/PluckInWhere:
+  Enabled: false
+
+Rails/RedundantForeignKey:
+  Enabled: false
+
+Rails/RedundantTravelBack:
+  Enabled: false
+
+Rails/RenderInline:
+  Enabled: false
+
+Rails/RenderPlainText:
+  Enabled: false
+
+Rails/RequireDependency:
+  Enabled: false
+
+Rails/ReversibleMigrationMethodDefinition:
+  Enabled: false
+
+Rails/ShortI18n:
+  Enabled: false
+
+Rails/SquishedSQLHeredocs:
+  Enabled: false
+
+Rails/TimeZoneAssignment:
+  Enabled: false
+
+Rails/UniqueValidationWithoutIndex:
+  Enabled: false
+
+Rails/UnusedIgnoredColumns:
+  Enabled: false
+
+Rails/WhereEquals:
+  Enabled: false
+
+Rails/WhereExists:
+  Enabled: false
+
+Rails/WhereNot:
+  Enabled: false
+# End updates for v2.4.0 -> v2.12.0 upgrade.

data/conf/rubocop_without_rspec.yml

@@ -240,3 +240,92 @@ Style/RedundantSelfAssignment:
 
 Style/SingleArgumentDig:
   Enabled: false
+
+# Added for v1.13.0 -> v1.27.0 version bump.
+Bundler/GemFilename:
+  Enabled: false
+
+Bundler/GemVersion:
+  Enabled: false
+
+Gemspec/RequireMFA:
+  Enabled: false
+
+Layout/LineEndStringConcatenationIndentation:
+  Enabled: false
+
+Layout/SingleLineBlockChain:
+  Enabled: false
+
+Lint/AmbiguousOperatorPrecedence:
+  Enabled: false
+
+Lint/AmbiguousRange:
+  Enabled: false
+
+Lint/EmptyInPattern:
+  Enabled: false
+
+Lint/IncompatibleIoSelectWithFiberScheduler:
+  Enabled: false
+
+Lint/RefinementImportMethods:
+  Enabled: false
+
+Lint/RequireRelativeSelfPath:
+  Enabled: false
+
+Lint/UselessRuby2Keywords:
+  Enabled: false
+
+Naming/BlockForwarding:
+  Enabled: false
+
+Naming/InclusiveLanguage:
+  Enabled: false
+
+Security/IoMethods:
+  Enabled: false
+
+Style/FileRead:
+  Enabled: false
+
+Style/FileWrite:
+  Enabled: false
+
+Style/InPatternThen:
+  Enabled: false
+
+Style/MapToHash:
+  Enabled: false
+
+Style/MultilineInPatternThen:
+  Enabled: false
+
+Style/NestedFileDirname:
+  Enabled: false
+
+Style/NumberedParameters:
+  Enabled: false
+
+Style/NumberedParametersLimit:
+  Enabled: false
+
+Style/OpenStructUse:
+  Enabled: false
+
+Style/QuotedSymbols:
+  Enabled: false
+
+Style/RedundantInitialize:
+  Enabled: false
+
+Style/RedundantSelfAssignmentBranch:
+  Enabled: false
+
+Style/SelectByRegexp:
+  Enabled: false
+
+Style/TopLevelMethodDefinition:
+  Enabled: false
+# End updates for v1.13.0 -> v1.27.0 version bump.

data/lib/rubocop/cop/salsify/rails_application_mailer.rb

@@ -16,8 +16,9 @@ module RuboCop
       #  class Yugo < ActionMailer::Base
       #    ...
       #  end
-      class RailsApplicationMailer < Cop
+      class RailsApplicationMailer < RuboCop::Cop::Base
         extend TargetRailsVersion
+        extend RuboCop::Cop::AutoCorrector
 
         minimum_target_rails_version 5.0
 

data/lib/rubocop/cop/salsify/rails_application_serializer.rb

@@ -16,8 +16,9 @@ module RuboCop
       #  class Yugo < ActiveModel::Serializer
       #    ...
       #  end
-      class RailsApplicationSerializer < Cop
+      class RailsApplicationSerializer < RuboCop::Cop::Base
         extend TargetRailsVersion
+        extend RuboCop::Cop::AutoCorrector
 
         minimum_target_rails_version 5.0
 

data/lib/rubocop/cop/salsify/rspec_doc_string.rb

@@ -28,12 +28,41 @@ module RuboCop
         DOUBLE_QUOTE_MSG =
           'Example Group/Example doc strings must be double-quoted.'
 
-
-        DOCUMENTED_METHODS = RuboCop::ConfigLoader.default_configuration.for_department('RSpec')
-                               .fetch('Language')
-                               .values_at('ExampleGroups', 'Examples', 'SharedGroups', 'Includes')
-                               .flat_map { |element| element.values.flatten }
-                               .map(&:to_sym)
+        DOCUMENTED_METHODS = [
+          :context,
+          :describe,
+          :example,
+          :example_group,
+          :fcontext,
+          :fdescribe,
+          :feature,
+          :fexample,
+          :ffeature,
+          :fit,
+          :focus,
+          :fscenario,
+          :fspecify,
+          :include_context,
+          :include_examples,
+          :it,
+          :it_behaves_like,
+          :it_should_behave_like,
+          :its,
+          :pending,
+          :scenario,
+          :shared_context,
+          :shared_examples,
+          :shared_examples_for,
+          :skip,
+          :specify,
+          :xcontext,
+          :xdescribe,
+          :xexample,
+          :xfeature,
+          :xit,
+          :xscenario,
+          :xspecify
+        ].freeze
 
         def_node_matcher :documented_method?,
                          send_pattern(<<~PATTERN)

data/lib/rubocop/cop/salsify/rspec_string_literals.rb

@@ -14,6 +14,7 @@ module RuboCop
       class RspecStringLiterals < RuboCop::Cop::RSpec::Base
         extend RuboCop::Cop::AutoCorrector
         include ConfigurableEnforcedStyle
+        include StringHelp
         include StringLiteralsHelp
 
         DOCUMENTED_METHODS = RuboCop::Cop::Salsify::RspecDocString::DOCUMENTED_METHODS

data/lib/salsify_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SalsifyRubocop
-  VERSION = '1.2.0'
+  VERSION = '1.27.0'
 end

data/salsify_rubocop.gemspec

@@ -37,8 +37,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec_junit_formatter'
 
-  spec.add_runtime_dependency 'rubocop', '~> 1.13.0'
-  spec.add_runtime_dependency 'rubocop-performance', '~> 1.5.0'
-  spec.add_runtime_dependency 'rubocop-rails', '~> 2.4.0'
-  spec.add_runtime_dependency 'rubocop-rspec', '~> 2.0.0'
+  spec.add_runtime_dependency 'rubocop', '~> 1.27.0'
+  spec.add_runtime_dependency 'rubocop-performance', '~> 1.12.0'
+  spec.add_runtime_dependency 'rubocop-rails', '~> 2.12.0'
+  spec.add_runtime_dependency 'rubocop-rspec', '~> 2.9.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: salsify_rubocop
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.27.0
 platform: ruby
 authors:
 - Salsify, Inc
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-03-31 00:00:00.000000000 Z
+date: 2022-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -72,56 +72,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.0
+        version: 1.27.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.0
+        version: 1.27.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.12.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 2.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 2.12.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: 2.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: 2.9.0
 description: Shared RuboCop configuration
 email:
 - engineering@salsify.com