salsify_rubocop 0.60.0.1 → 0.85.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d32a0adf5e2073f20744ec31f995dc72cdd42f39063a15debe8fa056030e9fa
-  data.tar.gz: 92c54271e80bcfb5e1793b6bd363cc2e397a7a86ec8f8ddfa6335edfd4316fe3
+  metadata.gz: d08274563973f107ae87494c994284ac9989f5653ab55bb8063e312de83e0b8b
+  data.tar.gz: 62498d79bfb7e1e94c86170210531f9d3ab1c37845077f144c42c8e5d83077b3
 SHA512:
-  metadata.gz: ec2e9380ec2455fe9eeecca744ccd77fd625a5a03f46fef78098d5a588d40748b746e7ec44830187df13ae59c460ccd3a73845ceb7b5865bf3378667d73903b0
-  data.tar.gz: 2ecbd226f99dc081cbb9ed8db19ad532906fe84e90a098cb4db0d44888809715ff1630e2e3bbfa13fc40a9455f65f8aa610a0ac721cc2a8bb9c99c6188371c04
+  metadata.gz: d091764bbd87bc8388f17ffb2b980d6aa79cff6cb20f06a50348f9e2ba27ee0dcb8f9b9fc53580fe820e098d3f2a353d431eafe579aef865059e12b92cdaa3c8
+  data.tar.gz: a587b9d3e3aa4d81d30a66bd0cb99c41ff97e50f32de4f8f32460fc8d57701e769b2237d781a8ea67d1e835aecaa4b6e1d3fd47b9e574e9303b0f48d384c993b

data/.rubocop.yml

@@ -2,8 +2,8 @@ inherit_from:
   - conf/rubocop.yml
 
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
 
-Metrics/LineLength:
+Layout/LineLength:
   Exclude:
     - '*.gemspec'

data/.travis.yml

@@ -1,8 +1,12 @@
 language: ruby
 rvm:
-  - 2.5.1
-  - 2.4.4
-  - 2.3.7
+  - 2.7.0
+  - 2.6.0
+  - 2.5.3
+  - 2.4.5
+before_install:
+  - gem update --system
+  - gem install bundler
 script:
   - bundle exec rubocop
   - bundle exec rspec

data/CHANGELOG.md

@@ -1,7 +1,27 @@
 # salsify_rubocop
 
+## 0.85.0
+- Upgrate to `rubocop` v0.85.0
+- Enable enforcement of Gem comments when specifying versions or sources 
+- Drop support for Ruby 2.3, as rubocop v0.81+ doesn't support it anymore
+- Add `FrozenStringLiteralComment` and `LineLength` (max 120) rules.
+
+## v0.78.1
+- Fix "`Style/SymbolArray` is concealed by line 190" warning
+
+## v0.78.0
+- Upgrade to `rubocop` v0.78.0
+- Upgrade to `rubocop_rspec` v1.37.0
+- Add `rubocop-rails `v2.4.0`
+- Add `rubocop-performance `v1.5.0`
+- Update names/namespaces of rules that changed between 0.62 and 0.78
+
+## v0.62.0
+- Upgrade to `rubocop` v0.62.0
+- Upgrade to `rubocop_rspec` v1.31.0
+
 ## v0.60.0.1
-- Upgrade to `rubocop_rspec` 1.30.1
+- Upgrade to `rubocop_rspec` v1.30.1
 
 ## v0.60.0
 - Upgrade to `rubocop` v0.60.0
@@ -16,7 +36,7 @@
 - Adjust Ruby version configuration in `Salsify/StyleDig` spec.
 
 ## v0.52.1.1
-- Fix `Salsify/StyleDig` false positive in assignments (see [#20](https://github.com/salsify/salsify_rubocop/issues/20)). 
+- Fix `Salsify/StyleDig` false positive in assignments (see [#20](https://github.com/salsify/salsify_rubocop/issues/20)).
 
 ## v0.52.1
 - Update to `rubocop` v0.52.1 and `rubocop-rspec` v1.21.0.

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in salsify_rubocop.gemspec

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

data/conf/rubocop_without_rspec.yml

@@ -9,6 +9,15 @@ AllCops:
     - 'tmp/**/*'
     - 'vendor/**/*'
 
+Bundler/GemComment:
+  Enabled: true
+  OnlyFor:
+    - 'version_specifiers'
+    - 'source'
+    - 'git'
+    - 'github'
+    - 'gist'
+
 # This cop has poor handling for the common case of a lambda arg in a DSL
 Lint/AmbiguousBlockAssociation:
   Enabled: false
@@ -22,7 +31,7 @@ Performance/RedundantMerge:
 Style/Alias:
   EnforcedStyle: prefer_alias_method
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: false
 
 Style/Documentation:
@@ -67,13 +76,13 @@ Naming/FileName:
     - 'Appraisals'
 
 Style/FrozenStringLiteralComment:
-  Enabled: false
+  Enabled: true
 
 Style/GuardClause:
   Enabled: false
 
 # does not make sense to enable this without AlignHash
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   Enabled: false
 
 Style/Lambda:
@@ -134,10 +143,6 @@ Style/StringLiterals:
   Exclude:
     - 'spec/**/*'
 
-# We don't require %i() for an array of symbols.
-Style/SymbolArray:
-  Enabled: false
-
 Naming/VariableNumber:
   Enabled: false
 
@@ -156,10 +161,12 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Enabled: false
 
-# Disabling line length enforcement since annotate generates
-# some pretty long lines
-Metrics/LineLength:
-  Enabled: false
+Layout/LineLength:
+  Enabled: true
+  Max: 120
+  IgnoreCopDirectives: true
+  IgnoredPatterns:
+    - ^#
 
 Metrics/MethodLength:
   Enabled: false
@@ -183,3 +190,9 @@ Style/NumericLiterals:
 
 Style/StructInheritance:
   Enabled: false
+
+Style/WordArray:
+  EnforcedStyle: brackets 
+
+Style/SymbolArray:
+  EnforcedStyle: brackets

data/lib/rubocop/cop/salsify/rails_application_mailer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Salsify
@@ -19,9 +21,9 @@ module RuboCop
 
         minimum_target_rails_version 5.0
 
-        MSG = 'Mailers should subclass `ApplicationMailer`.'.freeze
-        SUPERCLASS = 'ApplicationMailer'.freeze
-        BASE_PATTERN = '(const (const nil? :ActionMailer) :Base)'.freeze
+        MSG = 'Mailers should subclass `ApplicationMailer`.'
+        SUPERCLASS = 'ApplicationMailer'
+        BASE_PATTERN = '(const (const nil? :ActionMailer) :Base)'
 
         include RuboCop::Cop::EnforceSuperclass
 

data/lib/rubocop/cop/salsify/rails_application_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Salsify
@@ -19,9 +21,9 @@ module RuboCop
 
         minimum_target_rails_version 5.0
 
-        MSG = 'Serializers should subclass `ApplicationSerializer`.'.freeze
-        SUPERCLASS = 'ApplicationSerializer'.freeze
-        BASE_PATTERN = '(const (const nil? :ActiveModel) :Serializer)'.freeze
+        MSG = 'Serializers should subclass `ApplicationSerializer`.'
+        SUPERCLASS = 'ApplicationSerializer'
+        BASE_PATTERN = '(const (const nil? :ActiveModel) :Serializer)'
 
         include RuboCop::Cop::EnforceSuperclass
 

data/lib/rubocop/cop/salsify/rails_unscoped.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Salsify
@@ -11,7 +13,7 @@ module RuboCop
       #  # bad
       #  User.unscoped
       class RailsUnscoped < Cop
-        MSG = 'Explicitly remove scopes instead of using `unscoped`.'.freeze
+        MSG = 'Explicitly remove scopes instead of using `unscoped`.'
 
         def_node_matcher :unscoped?, <<-PATTERN
           (send _ :unscoped)

data/lib/rubocop/cop/salsify/rspec_doc_string.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Salsify
@@ -21,12 +23,12 @@ module RuboCop
         include ConfigurableEnforcedStyle
 
         SINGLE_QUOTE_MSG =
-          'Example Group/Example doc strings must be single-quoted.'.freeze
+          'Example Group/Example doc strings must be single-quoted.'
         DOUBLE_QUOTE_MSG =
-          'Example Group/Example doc strings must be double-quoted.'.freeze
+          'Example Group/Example doc strings must be double-quoted.'
 
         SHARED_EXAMPLES = RuboCop::RSpec::Language::SelectorSet.new(
-          %i(include_examples it_behaves_like it_should_behave_like include_context)
+          [:include_examples, :it_behaves_like, :it_should_behave_like, :include_context]
         ).freeze
 
         DOCUMENTED_METHODS = (RuboCop::RSpec::Language::ExampleGroups::ALL +

data/lib/rubocop/cop/salsify/rspec_dot_not_self_dot.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Salsify
@@ -18,7 +20,7 @@ module RuboCop
       class RspecDotNotSelfDot < Cop
 
         SELF_DOT_REGEXP = /["']self\./.freeze
-        MSG = 'Use ".<class method>" instead of "self.<class method>" for example group description.'.freeze
+        MSG = 'Use ".<class method>" instead of "self.<class method>" for example group description.'
 
         def_node_matcher :example_group_match, <<-PATTERN
           (send _ #{RuboCop::RSpec::Language::ExampleGroups::ALL.node_pattern_union} $_ ...)
@@ -26,7 +28,7 @@ module RuboCop
 
         def on_send(node)
           example_group_match(node) do |doc|
-            add_offense(doc) if SELF_DOT_REGEXP =~ doc.source
+            add_offense(doc) if SELF_DOT_REGEXP.match?(doc.source)
           end
         end
 

data/lib/rubocop/cop/salsify/rspec_string_literals.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module Salsify
@@ -16,9 +18,9 @@ module RuboCop
         DOCUMENTED_METHODS = RuboCop::Cop::Salsify::RspecDocString::DOCUMENTED_METHODS
 
         SINGLE_QUOTE_MSG = 'Prefer single-quoted strings unless you need ' \
-          'interpolation or special symbols.'.freeze
+          'interpolation or special symbols.'
         DOUBLE_QUOTE_MSG = 'Prefer double-quoted strings unless you need ' \
-          'single quotes to avoid extra backslashes for escaping.'.freeze
+          'single quotes to avoid extra backslashes for escaping.'
 
         def autocorrect(node)
           StringLiteralCorrector.correct(node, style)

data/lib/rubocop/cop/salsify/style_dig.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This may be added in the near future to rubocop, see https://github.com/bbatsov/rubocop/issues/5332
 
 module RuboCop
@@ -21,7 +23,7 @@ module RuboCop
 
         minimum_target_ruby_version 2.3
 
-        MSG = 'Use `dig` for nested access.'.freeze
+        MSG = 'Use `dig` for nested access.'
 
         def_node_matcher :nested_access_match, <<-PATTERN
           (send (send (send _receiver !:[]) :[] !{irange erange}) :[] !{irange erange})

data/lib/rubocop/rspec/language/each_selector.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Monkey-patch SelectorSet to allow enumeration of selectors.
 
 module RuboCop

data/lib/salsify_rubocop.rb

@@ -1,4 +1,8 @@
+# frozen_string_literal: true
+
 require 'salsify_rubocop/version'
+require 'rubocop-performance'
+require 'rubocop-rails'
 require 'rubocop-rspec'
 
 # Because RuboCop doesn't yet support plugins, we have to monkey patch in a

data/lib/salsify_rubocop/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SalsifyRubocop
-  VERSION = '0.60.0.1'.freeze
+  VERSION = '0.85.0'
 end

data/salsify_rubocop.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'salsify_rubocop/version'
@@ -28,10 +30,14 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.11'
+  spec.required_ruby_version = '>= 2.4'
+
+  spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
 
-  spec.add_runtime_dependency 'rubocop', '~> 0.60.0'
-  spec.add_runtime_dependency 'rubocop-rspec', '~> 1.30.1'
+  spec.add_runtime_dependency 'rubocop', '~> 0.85.0'
+  spec.add_runtime_dependency 'rubocop-performance', '~> 1.5.0'
+  spec.add_runtime_dependency 'rubocop-rails', '~> 2.4.0'
+  spec.add_runtime_dependency 'rubocop-rspec', '~> 1.37.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: salsify_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.60.0.1
+  version: 0.85.0
 platform: ruby
 authors:
 - Salsify, Inc
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-11-05 00:00:00.000000000 Z
+date: 2020-06-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -58,28 +58,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.60.0
+        version: 0.85.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.60.0
+        version: 0.85.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.4.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.4.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.30.1
+        version: 1.37.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.30.1
+        version: 1.37.0
 description: Shared shared RuboCop configuration
 email:
 - engineering@salsify.com
@@ -127,15 +155,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: Shared shared RuboCop configuration