salsify_rubocop 0.47.1.rc0 → 0.47.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5dcbe21b6de7a233cf330a202722885b87a49a91
-  data.tar.gz: 2da2ae030c4cd422fecab9b16846759800b7e289
+  metadata.gz: a235a0d2d7c100c09da10c768f5a7e8384d30b8c
+  data.tar.gz: f1c310ca03dea3a45efc6b0c104a5b8411a827ae
 SHA512:
-  metadata.gz: b12655ea2c8447a16bf5036f7576929b896fdff422d3b77b4274978edea6dd1042cde48da63502860735839642fb69f6fb4646ef00a0ed6ce740263cd6436c40
-  data.tar.gz: c9d2e1785dfded5b97b815456d6fd76a1f7f1edb68827cad7bb5ef7e9b59df1e1dd72379625426597756f8747384155dbf1c00708cb2f027d815642471c97b2f
+  metadata.gz: 9c788c146e8be102a39e8340c22c1b391a2fbaef4e6cfae70c93142414af839dd69625e4cdd9f897846d43e1fa602c866e4351f624124f2ba4dab31ed193ccfd
+  data.tar.gz: d445a00088b9745687e1a2f1670e91d3b736d927b96081dfc23d3721cf75c731fbb587d09cc11b98a3cd4013e94d064e69442bd64dc96b4d9a758be5fc502f6b

data/CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## v0.47.1
 - Add `Salsify/StyleDig` cop to recommend using `#dig` for deeply nested access.
+- Add `Salsify/RailsApplicationRecord` cop.
+- Add new `rubocop_rails50` configuration for use with Rails 5.0 apps.
 
 ## v0.47.0
 - Update to `rubocop` v0.47.1 and `rubocop-rspec` v1.10.0.

data/conf/rubocop_rails50.yml

@@ -0,0 +1,8 @@
+inherit_from:
+  - ../conf/rubocop_rails.yml
+
+Rails/HttpPositionalArguments:
+  Enabled: true
+
+Salsify/RailsApplicationRecord:
+  Enabled: true

data/config/default.yml

@@ -1,3 +1,7 @@
+Salsify/RailsApplicationRecord:
+  Description: 'Models must subclass ApplicationRecord.'
+  Enabled: false
+
 Salsify/RspecDocString:
   Description: 'Check that RSpec doc strings use the correct quoting.'
   Enabled: true

data/lib/rubocop/cop/salsify/rails_application_record.rb

@@ -0,0 +1,53 @@
+# encoding: utf-8
+require 'rubocop'
+module RuboCop
+  module Cop
+    module Salsify
+      # Check that models subclass ApplicationRecord with Rails 5.0
+      #
+      # @example
+      #
+      #  # good
+      #  class Tesla < ApplicationRecord
+      #    ...
+      #  end
+      #
+      #  # bad
+      #  class Yugo < ActiveRecord::Base
+      #    ...
+      #  end
+      class RailsApplicationRecord < Cop
+
+        MSG = 'Models must subclass ApplicationRecord'.freeze
+        APPLICATION_RECORD = 'ApplicationRecord'.freeze
+        ACTIVE_RECORD_BASE_PATTERN = '(const (const nil :ActiveRecord) :Base)'.freeze
+
+        def_node_matcher :model_class_definition, <<-PATTERN
+        (class (const _ !:ApplicationRecord) #{ACTIVE_RECORD_BASE_PATTERN} ...)
+        PATTERN
+
+        def_node_matcher :class_new_definition, <<-PATTERN
+        [!^(casgn nil :ApplicationRecord ...) (send (const nil :Class) :new #{ACTIVE_RECORD_BASE_PATTERN})]
+        PATTERN
+
+        def on_class(node)
+          model_class_definition(node) do
+            add_offense(node.children[1], :expression, MSG)
+          end
+        end
+
+        def on_send(node)
+          class_new_definition(node) do
+            add_offense(node.children.last, :expression, MSG)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node.source_range, APPLICATION_RECORD)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/salsify_rubocop.rb

@@ -13,6 +13,7 @@ config = RuboCop::ConfigLoader.merge_with_default(config, path)
 RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, config)
 
 # cops
+require 'rubocop/cop/salsify/rails_application_record'
 require 'rubocop/cop/salsify/rspec_doc_string'
 require 'rubocop/cop/salsify/rspec_string_literals'
 require 'rubocop/cop/salsify/style_dig'

data/lib/salsify_rubocop/version.rb

@@ -1,3 +1,3 @@
 module SalsifyRubocop
-  VERSION = '0.47.1.rc0'.freeze
+  VERSION = '0.47.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: salsify_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.47.1.rc0
+  version: 0.47.1
 platform: ruby
 authors:
 - Salsify, Inc
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-04 00:00:00.000000000 Z
+date: 2017-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -100,8 +100,10 @@ files:
 - bin/setup
 - conf/rubocop.yml
 - conf/rubocop_rails.yml
+- conf/rubocop_rails50.yml
 - conf/rubocop_without_rspec.yml
 - config/default.yml
+- lib/rubocop/cop/salsify/rails_application_record.rb
 - lib/rubocop/cop/salsify/rspec_doc_string.rb
 - lib/rubocop/cop/salsify/rspec_string_literals.rb
 - lib/rubocop/cop/salsify/style_dig.rb
@@ -125,9 +127,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.6.10