salestation 5.3.0 → 5.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3978171d3a2b78287dd0f3b86049f8253d1f66199545002701b1f4bd46295a64
-  data.tar.gz: 469b3e6ddfe9c1b399eda6f63827b7b674142f6a67ac16b03ad0f8ddb5e5e88a
+  metadata.gz: 9f3204f1692dd5da39dba967c0bbad7e233cadbca2ad0290a079e2b109e9fd33
+  data.tar.gz: cf5aea80221f27504428b6f153dfd791e1e677c1816ca9fcdd602c863077b4cd
 SHA512:
-  metadata.gz: 9a5140a9348d79cfde31b44dd7c8d24bbea0135d2d8371272a1ed86db6690be64f3248be27f1a845d3d6f64ab5b8c59809534cae6d68af6223c3d6f0edafcf11
-  data.tar.gz: 14ad1ff09a48d7d6c7be4c7bf5781cf922990dd43dac6f6df46aaa78939ed94875bcdeb9544ec85cac82252453975cc1ad5457bf644aa5ef6fc54e484fc39dec
+  metadata.gz: d0ca53279d7299ab5a29d3fe88bad408cab41ac2475acb9b5962bafc7b1623d6ac218372de87df0a394cc491c52507464eb13af544cb248b1400e03bb95d8f1b
+  data.tar.gz: 93d0075650b3e79f9b954e03d3846aacd82a6b330cb5e63fe6283c5d60d4a83217f5c293a858082359373d6c8db1faf243eeb372da0a2fe171c59b72348d20dd

data/.github/workflows/publish.yml

@@ -15,8 +15,9 @@ jobs:
 
 
       - name: Release Gem
-        uses: discourse/publish-rubygems-action@b55d7b91b55e61752dc6cbc2972f8e16fe6c1a02
+        uses: discourse/publish-rubygems-action@4bd305c65315cb691bad1e8de97a87aaf29a0a85
         env:
-          GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
           RUBYGEMS_API_KEY: ${{secrets.RUBYGEMS_API_KEY}}
           RELEASE_COMMAND: rake release
+          GIT_EMAIL: support@salemove.com
+          GIT_NAME: sm-deployer

data/.github/workflows/ruby.yml

@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['2.6', '2.7']
+        ruby-version: ['2.7', '3.0']
 
     steps:
     - uses: actions/checkout@v2

data/.yardopts

@@ -0,0 +1 @@
+--plugin yard-doctest

data/Rakefile

@@ -1,6 +1,13 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'yard/doctest/rake'
 
 RSpec::Core::RakeTask.new(:spec)
+YARD::Doctest::RakeTask.new
 
-task :default => :spec
+task :default do
+  Rake::Task['spec'].invoke
+  Rake::Task['yard:doctest'].invoke
+end

data/lib/salestation/rspec/glia_input_validation_error_matcher.rb

@@ -13,6 +13,7 @@ module Salestation
         @fields = []
         @field_error_types = {}
         @field_error_messages = {}
+        @expect_exact_match = false
       end
 
       def on(*nested_fields)
@@ -20,6 +21,11 @@ module Salestation
         self
       end
 
+      def exactly
+        @expect_exact_match = true
+        self
+      end
+
       def with_type(*types)
         @field_error_types[field_to_key(@fields.last)] = types
         self
@@ -31,15 +37,32 @@ module Salestation
       end
 
       def matches?(actual)
-        @fields.all? do |field|
-          check_field_exists(actual, *field) &&
-            check_field_error_types(field, actual) &&
-            check_field_error_messages(field, actual)
-        end
+        check_exact_match(actual, self.class.path_list_to_trie(@fields)) &&
+          @fields.all? do |field|
+            check_field_exists(actual, *field) &&
+              check_field_error_types(field, actual) &&
+              check_field_error_messages(field, actual)
+          end
       end
 
       private
 
+      def check_exact_match(actual, field_trie)
+        return true unless @expect_exact_match
+
+        actual[:error_details].keys.all? do |key|
+          field_trie.any? do |field, nested_field_trie|
+            if nested_field_trie.empty?
+              field == key
+            else
+              actual[:error_details][field].all? do |nested_actual|
+                check_exact_match(nested_actual, nested_field_trie)
+              end
+            end
+          end
+        end
+      end
+
       def check_field_exists(actual, field, *nested_fields)
         actual[:error_details].key?(field) &&
           (
@@ -80,6 +103,33 @@ module Salestation
       def field_to_key(fields)
         fields.join('->').to_sym
       end
+
+      class << self
+        # @example
+        #  path_list_to_trie([[:a, :b, :c], [:a, :b, :d], [:a, :e]])
+        #  #=> {a: {b: {c: {}, d: {}}, e: {}}}
+        def path_list_to_trie(paths)
+          paths.reduce({}) do |acc, path|
+            deep_merge(acc, path_to_trie(*path))
+          end
+        end
+
+        private
+
+        # @example
+        #  path_to_trie(*[:a, :b, :c])
+        #  #=> {a: {b: {c: {}}}}
+        def path_to_trie(element, *rest)
+          {element.to_sym => rest.empty? ? {} : path_to_trie(*rest)}
+        end
+
+        # @example
+        #  deep_merge({a: {b: {c: {}}}}, {a: {b: {d: {}}, e: {}}})
+        #  #=> {a: {b: {c: {}, d: {}}, e: {}}}
+        def deep_merge(a, b)
+          a.merge(b) { |_key, nested_a, nested_b| deep_merge(nested_a, nested_b) }
+        end
+      end
     end
   end
 end

data/lib/salestation/web/error_mapper.rb

@@ -7,7 +7,7 @@ module Salestation
 
       ERROR_TO_RESPONSE_DEFAULTS = {
         App::Errors::InvalidInput => -> (error) {
-          Responses::UnprocessableEntityFromSchemaErrors.create(error)
+          Responses::UnprocessableEntityFromSchemaErrors.create(**error)
         },
         App::Errors::DependencyCurrentlyUnavailable => -> (error) {
           Responses::ServiceUnavailable.new(

data/lib/salestation/web/extractors.rb

@@ -61,14 +61,15 @@ module Salestation
       # Handles coercing input values
       #
       # @example
-      #  extractor = BodyParamExtractor[:x, :y]
+      #  extractor = Salestation::Web::Extractors::BodyParamExtractor[:x, :y]
       #    .coerce(x: ->(value) { "x_#{value}"})
       #  input = {
       #   'x' => 'a',
       #   'y' => 'b',
       #  }
       #  # rack_request is Rack::Request with 'rack.request.form_hash' set to input
-      #  extractor.call(rack_request).value #=> {x: 'x_a', y: 'b'}
+      #  extractor.call(rack_request(input)).value
+      #  #=> {x: 'x_a', y: 'b'}
       class InputCoercer
         def initialize(extractor, rules)
           @extractor = extractor
@@ -106,28 +107,25 @@ module Salestation
       # values can be compared in rename.
       #
       # @example
-      #  original_input = {
-      #    x: 'a',
-      #    y: 'b'
+      #  input = {
+      #    'x' => 'a',
+      #    'y' => 'b'
       #  }
       #
-      #  extractor = BodyParamExtractor[:x, :y]
+      #  extractor = Salestation::Web::Extractors::BodyParamExtractor[:x, :y]
       #    .rename(x: :z)
-      #  input = {
-      #    z: 'a',
-      #    y: 'b'
-      #  }
+      #  extractor.call(rack_request(input)).value
+      #  #=> {z: 'a', y: 'b'}
       #
-      #  extractor = BodyParamExtractor[:x, :y]
+      #  extractor = Salestation::Web::Extractors::BodyParamExtractor[:x, :y]
       #    .rename(x: :y)
-      #  input = {
-      #    y: 'b'
-      #  }
-      #  extractor = BodyParamExtractor[:x, :y]
+      #  extractor.call(rack_request(input)).value
+      #  #=> {y: 'b'}
+      #
+      #  extractor = Salestation::Web::Extractors::BodyParamExtractor[:x, :y]
       #    .rename(x: {new_key: :y, override: true})
-      #  input = {
-      #    y: 'a'
-      #  }
+      #  extractor.call(rack_request(input)).value
+      #  #=> {y: 'a'}
       class InputRenamer
         def initialize(extractor, rules)
           @extractor = extractor
@@ -217,7 +215,7 @@ module Salestation
       # Extracts and symbolizes params from request body
       #
       # @example
-      #  extractor = BodyParamExtractor[:x, :y, {foo: [:bar, :baz]}, :aaa]
+      #  extractor = Salestation::Web::Extractors::BodyParamExtractor[:x, :y, {foo: [:bar, :baz]}, :aaa]
       #  input = {
       #   'x' => '1',
       #   'y' => '2',
@@ -232,7 +230,8 @@ module Salestation
       #    ]
       #  }
       #  # rack_request is Rack::Request with 'rack.request.form_hash' set to input
-      #  extractor.call(rack_request).value #=> {x: 1, y: 2, foo: {bar: 'qq'}, aaa: [{bb: 'cc'}]}
+      #  extractor.call(rack_request(input)).value
+      #  #=> {x: '1', y: '2', foo: {bar: 'qq'}, aaa: [{bb: 'cc'}]}
       #
       class BodyParamExtractor
         def self.[](*filters)

data/salestation.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "salestation"
-  spec.version       = "5.3.0"
+  spec.version       = "5.3.2"
   spec.authors       = ["Glia TechMovers"]
   spec.email         = ["techmovers@glia.com"]
 
@@ -22,9 +22,10 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "pry", "~> 0.10.4"
+  spec.add_development_dependency "pry", "~> 0.14.2"
   spec.add_development_dependency "glia-errors", "~> 0.11.4"
   spec.add_development_dependency "dry-validation", "~> 1.7"
+  spec.add_development_dependency "yard-doctest", "~> 0.1.17"
 
   spec.add_dependency 'deterministic'
   spec.add_dependency 'dry-struct'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: salestation
 version: !ruby/object:Gem::Version
-  version: 5.3.0
+  version: 5.3.2
 platform: ruby
 authors:
 - Glia TechMovers
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-08 00:00:00.000000000 Z
+date: 2023-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.4
+        version: 0.14.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.4
+        version: 0.14.2
 - !ruby/object:Gem::Dependency
   name: glia-errors
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +94,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
+- !ruby/object:Gem::Dependency
+  name: yard-doctest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.17
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.17
 - !ruby/object:Gem::Dependency
   name: deterministic
   requirement: !ruby/object:Gem::Requirement
@@ -175,6 +189,7 @@ files:
 - ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
+- ".yardopts"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -204,7 +219,7 @@ homepage: ''
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -219,8 +234,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: ''
 test_files: []