salestation 5.0.0 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 63f86b3537b2db5857f54ef439442a3ca0ef1a4f078d602989783814fd70b718
-  data.tar.gz: 2836da19672da049c461769c8482e4c9cab2e3ce6d6292293051639c0a0cb8e7
+  metadata.gz: 43663c5f6d78d7238e66e9ac88a06a49facfcaf45a329534e44e20891ea1baa9
+  data.tar.gz: 97661dd29a53ab956cbe0c78522b382d052bd4c6f339208fe126f7d3c51f8526
 SHA512:
-  metadata.gz: dc79ff3f36806274195543e4fc0e13f27d098d1239b3c0706cd6a7ed3f643a764a71b2b34426ccfbe19ebc9f29b0018a8c8619a1c2f9729c180df70a2b640906
-  data.tar.gz: 4b4d65d3e6158c9ff0025f2e5548b650dab2d0ca3bf4c5dca3f51b11943be552c44eadda05cb5830962157ef2d1200e8067b731eebbc74bb501d83e8a39d7753
+  metadata.gz: ee4cf2f592d41548e187277789ec6d3484748dc7cc152f3a9b4e4b63b438314e5fe96ab3aeb92dbd4729a485b4d9e73b518904459309b19f3da7a507595100ce
+  data.tar.gz: 22a1c5415ded67ebc22c5f67ef6332706571a156000aac7e5195101c73be14dc950b5f208fb24b19e27c94b70c3c854dc8a5da485a01b030d578e9ccaac92c57

data/.gitignore

@@ -7,3 +7,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+.rspec_persistence

data/lib/salestation/app/input_verification.rb

@@ -18,7 +18,7 @@ module Salestation
                 Errors::InvalidInput.new(errors: result.errors, hints: result.hints)
               )
             end
-          elsif dry_validation_version <= Gem::Version.new('1.8')
+          elsif dry_validation_version < Gem::Version.new('2.0')
             if result.success?
               request.replace_input(input)
             else

data/lib/salestation/rspec/glia_input_validation_error_matcher.rb

@@ -12,37 +12,73 @@ module Salestation
       def initialize
         @fields = []
         @field_error_types = {}
+        @field_error_messages = {}
       end
 
-      def on(field)
-        @fields << field
+      def on(*nested_fields)
+        @fields << nested_fields
         self
       end
 
       def with_type(*types)
-        @field_error_types[@fields.last] = types
+        @field_error_types[field_to_key(@fields.last)] = types
+        self
+      end
+
+      def with_message(*messages)
+        @field_error_messages[field_to_key(@fields.last)] = messages
         self
       end
 
       def matches?(actual)
         @fields.all? do |field|
-          check_field_exists(field, actual) &&
-            check_field_error_types(field, actual)
+          check_field_exists(actual, *field) &&
+            check_field_error_types(field, actual) &&
+            check_field_error_messages(field, actual)
         end
       end
 
       private
 
-      def check_field_exists(field, actual)
-        actual[:error_details].key?(field)
+      def check_field_exists(actual, field, *nested_fields)
+        actual[:error_details].key?(field) &&
+          (
+            nested_fields.empty? ||
+            actual[:error_details][field].any? do |nested_hash|
+              check_field_exists(nested_hash, *nested_fields)
+            end
+          )
       end
 
       def check_field_error_types(field, actual)
-        return true unless @field_error_types[field]
+        return true unless @field_error_types[field_to_key(field)]
+
+        actual_error_types = fetch_field_attribute_nested(actual, :type, *field)
+        (@field_error_types[field_to_key(field)] - actual_error_types).empty?
+      end
+
+      def check_field_error_messages(field, actual)
+        return true unless @field_error_messages[field_to_key(field)]
 
-        actual_error_types = actual[:error_details].fetch(field).map { |f| f.fetch(:type) }
+        actual_error_messages = fetch_field_attribute_nested(actual, :message, *field)
+        (@field_error_messages[field_to_key(field)] - actual_error_messages).empty?
+      end
+
+
+      def fetch_field_attribute_nested(actual, attribute, field, *nested_fields)
+        if nested_fields.empty?
+          actual[:error_details].fetch(field).map { |f| f.fetch(attribute) }
+        else
+          actual[:error_details][field]
+            .lazy
+            .map { |error_hash| fetch_field_attribute_nested(error_hash, attribute, *nested_fields) }
+            .reject(&:nil?)
+            .first
+        end
+      end
 
-        (@field_error_types[field] - actual_error_types).empty?
+      def field_to_key(fields)
+        fields.join('->').to_sym
       end
     end
   end

data/lib/salestation/rspec.rb

@@ -44,6 +44,23 @@ module Salestation
     #         .on(:phone_number).with_type(Glia::Errors::INVALID_FORMAT_ERROR)
     #     )
     #
+    # also has support for nested errors:
+    #  nesting can be represented by calling `on` method with multiple arguments, for example when
+    #  you have a hash like
+    #  {
+    #    nested: {
+    #      name: ''
+    #    }
+    #  }
+    #  Then you can call it like glia_input_validation_error.on(:nested, :name)
+    #
+    #   expect(result).to be_failure
+    #     .with_invalid_input
+    #     .containing(
+    #       glia_input_validation_error
+    #         .on(:nested, :name).with_type(Glia::Errors::INVALID_VALUE_ERROR)
+    #     )
+    #
     # Everything after be_failure is optional. You could also use `.containing`
     # multiple times like this:
     #

data/salestation.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "salestation"
-  spec.version       = "5.0.0"
+  spec.version       = "5.1.0"
   spec.authors       = ["Glia TechMovers"]
   spec.email         = ["techmovers@glia.com"]
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: salestation
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.1.0
 platform: ruby
 authors:
 - Glia TechMovers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-05-11 00:00:00.000000000 Z
+date: 2022-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler