salestation 3.5.0 → 3.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 4fd4756c2f6c74060b5a8fc8d7c86c8b4e4b78ec
-  data.tar.gz: 74aae6794e107f5d25f6bbffd92f43e7d940b469
+SHA256:
+  metadata.gz: b5082a680af9f209df45163e85fbaf36ee19c08f752f8bba5fdcc6b33268da7f
+  data.tar.gz: 367153d32a664158e42d94d9b61f9e96693ee054b6d0944ad9c2ef0f299902fb
 SHA512:
-  metadata.gz: 500d7c1894f02b898ff7b6c7cea53b3fc84699440b1d031bdca0c3f9d12dc2e463c3360d768386e53ed31d18e44e6cb7d04af73d6238173e8b7c52740c3c305c
-  data.tar.gz: 2372c5e2e508edc5949b00476e5e4dc93ffd48d4996d686584b49b943792c83f3b5f384854f5e986896235cb76b220d6931d1c79ebe9252fee08ed794199c125
+  metadata.gz: c4a938998c2bc6b4480d9de13390998fccce96de4d2a65ad5814d033ef647aafce66ab7250546cf5e3f3794c4ab0341c411d91fefe4a562db2078aad2c2b91f4
+  data.tar.gz: 4884f0bff30fea0101d0b34bb47d0fdccea566c0c273da98ba91bc1f8798416506e8aafa922f2de642dd0b212dd34565fa0826f825374604927f77fa2041e65b

data/.travis.yml

@@ -1,6 +1,4 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.4
-  - 2.5
-before_install: gem install bundler -v 1.17.3
+  - 2.7

data/README.md

@@ -142,14 +142,14 @@ end
 
 Salestation provides a StatsD middleware which can be used record request
 execution time. A `timing` call with elapsed seconds is made to the provided
-StatsD instance with `path`, `method`, `status` tags.
+StatsD instance with `path`, `method`, `status` and `status_class` tags.
 
 ```ruby
 class Webapp < Sinatra::Base
   # ...
   use Salestation::Web::StatsdMiddleware,
     Statsd.new(host, port),
-    metric: 'my-metric'
+    metric: 'my_service.response.time'
 end
 ```
 
@@ -157,7 +157,7 @@ You can configure per-request tags by defining `salestation.statsd.tags` in sina
 
 ```ruby
   def my_handler(env)
-    env['salestation.statsd.tags'] = ['foo', 'bar']
+    env['salestation.statsd.tags'] = ['foo:bar']
     # ...
   end
 ```

data/lib/salestation/app.rb

@@ -7,7 +7,7 @@ require 'dry-types'
 module Salestation
   class App
     module Types
-      include Dry::Types.module
+      include Dry::Types()
     end
 
     def initialize(env:, hooks: {})

data/lib/salestation/app/errors.rb

@@ -5,7 +5,7 @@ module Salestation
     module Errors
       class InvalidInput < Dry::Struct
         attribute :errors, Types::Strict::Hash
-        attribute :hints, Types::Coercible::Hash.default({})
+        attribute :hints, Types::Coercible::Hash.default({}.freeze)
         attribute? :debug_message, Types::Strict::String
       end
 

data/lib/salestation/web.rb

@@ -8,7 +8,7 @@ require 'json'
 module Salestation
   class Web < Module
     module Types
-      include Dry::Types.module
+      include Dry::Types()
     end
 
     def initialize(errors: {})

data/lib/salestation/web/responses.rb

@@ -32,19 +32,27 @@ module Salestation
       class Error < Response
         attribute :status, Types::Strict::Integer
         attribute :message, Types::Strict::String
-        attribute :debug_message, Types::String.default('')
-        attribute :context, Types::Hash.default({})
-        attribute :headers, Types::Hash.default({})
+        attribute :debug_message, Types::Coercible::String.default('')
+        attribute :context, Types::Hash.default({}.freeze)
+        attribute :headers, Types::Hash.default({}.freeze)
 
         def body
           {message: message, debug_message: debug_message}
         end
       end
 
+      class UnprocessableEntityError < Error
+        attribute :form_errors, Types::Hash.default({}.freeze)
+
+        def body
+          super.merge(form_errors: form_errors)
+        end
+      end
+
       class Success < Response
         attribute :status, Types::Strict::Integer
         attribute :body, Types::Strict::Hash | Types::Strict::Array
-        attribute :headers, Types::Hash.default({})
+        attribute :headers, Types::Hash.default({}.freeze)
       end
 
       class UnprocessableEntityFromSchemaErrors
@@ -52,7 +60,7 @@ module Salestation
           message = parse_errors(errors)
           debug_message = parse_hints(hints)
 
-          UnprocessableEntity.new(message: message, debug_message: debug_message)
+          UnprocessableEntity.new(message: message, debug_message: debug_message, form_errors: errors)
         end
 
         def self.parse_errors(errors)
@@ -99,7 +107,7 @@ module Salestation
       Conflict = Error.with_code(409)
       RequestEntityTooLarge = Error.with_code(413)
       UnsupportedMediaType = Error.with_code(415)
-      UnprocessableEntity = Error.with_code(422)
+      UnprocessableEntity = UnprocessableEntityError.with_code(422)
 
       InternalError = Error.with_code(500)
       ServiceUnavailable = Error.with_code(503)

data/lib/salestation/web/statsd_middleware.rb

@@ -5,7 +5,7 @@ module Salestation
     class StatsdMiddleware
       EXTRA_TAGS_ENV_KEY = 'salestation.statsd.tags'
 
-      DURATION_PRECISION = 6
+      DURATION_MILLISECOND_PRECISION = 3
 
       def initialize(app, statsd, metric:)
         @app = app
@@ -27,20 +27,21 @@ module Salestation
           end
 
         tags = [
-          "path:#{ path }",
-          "method:#{ method }",
-          "status:#{ status }"
+          "path:#{path}",
+          "method:#{method}",
+          "status:#{status}",
+          "status_class:#{status / 100}xx"
         ] + env.fetch(EXTRA_TAGS_ENV_KEY, [])
 
-        @statsd.timing(@metric, duration(from: start), tags: tags)
+        @statsd.timing(@metric, duration_ms(from: start), tags: tags)
 
         [status, header, body]
       end
 
       private
 
-      def duration(from:)
-        (system_monotonic_time - from).round(DURATION_PRECISION)
+      def duration_ms(from:)
+        ((system_monotonic_time - from) * 1000).round(DURATION_MILLISECOND_PRECISION)
       end
 
       def system_monotonic_time

data/salestation.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "salestation"
-  spec.version       = "3.5.0"
+  spec.version       = "3.8.1"
   spec.authors       = ["Glia TechMovers"]
   spec.email         = ["techmovers@glia.com"]
 
@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.13"
+  spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "pry", "~> 0.10.4"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: salestation
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.8.1
 platform: ruby
 authors:
 - Glia TechMovers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-09 00:00:00.000000000 Z
+date: 2020-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -158,8 +158,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14.4
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: ''