salestation 3.4.0 → 3.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: d9174def3fd040598bc0d97a1e0aeac15005df69
-  data.tar.gz: d248d26c1d3f5ac3241da5263408a4324c1d3a9f
+SHA256:
+  metadata.gz: 2fe9755ef3152c1d5e9821aa2a7be920245b35f7ee95f26fd1e0fe3fb5934468
+  data.tar.gz: f9b1e080731f605cfe7f3ccd2194b923fe70b668757198b105c5ee697ca29637
 SHA512:
-  metadata.gz: a25ca2cf30a5f8e49f265779cf4a87010e06884de56cf99429bcc656633abe281c0bc4be30e03af96d946158a47eaff1ea5a0a1e4d6d3fdff0a9c33532c8e5d5
-  data.tar.gz: 74cf0cc00b2c8f925a45651a6f9a8fdb69adacc76e893d97e9f2e91e96bcdb20fb87bcda498746404ef85984d5e8522dbbed278a05975b5eac0d9243025b922d
+  metadata.gz: c5988265e60fdfa3f8dc7fe1915e38cd6d3afc1aabeca923de08bf9726c21db355d04ce6d9047bfda8d7b8fa4773104fdacbd169a12de6c75ce702aafbd5e6dd
+  data.tar.gz: 1f3351524846ddea69d54281ab5262ffaa138a4fdf83092614030ca7d60bcb99d44a4944aa1690c04ecf88e41e39cf1d3209588e6730bd92566cf25e66393cec

data/.travis.yml

@@ -1,6 +1,4 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.4
-  - 2.5
-before_install: gem install bundler -v 1.17.3
+  - 2.7

data/README.md

@@ -142,17 +142,26 @@ end
 
 Salestation provides a StatsD middleware which can be used record request
 execution time. A `timing` call with elapsed seconds is made to the provided
-StatsD instance with `path`, `method`, `status` tags.
+StatsD instance with `path`, `method`, `status` and `status_class` tags.
 
 ```ruby
 class Webapp < Sinatra::Base
   # ...
   use Salestation::Web::StatsdMiddleware,
     Statsd.new(host, port),
-    metric: 'my-metric'
+    metric: 'my_service.response.time'
 end
 ```
 
+You can configure per-request tags by defining `salestation.statsd.tags` in sinatra `env`:
+
+```ruby
+  def my_handler(env)
+    env['salestation.statsd.tags'] = ['foo:bar']
+    # ...
+  end
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/salestation/app.rb

@@ -7,7 +7,7 @@ require 'dry-types'
 module Salestation
   class App
     module Types
-      include Dry::Types.module
+      include Dry::Types()
     end
 
     def initialize(env:, hooks: {})

data/lib/salestation/app/errors.rb

@@ -5,7 +5,7 @@ module Salestation
     module Errors
       class InvalidInput < Dry::Struct
         attribute :errors, Types::Strict::Hash
-        attribute :hints, Types::Coercible::Hash.default({})
+        attribute :hints, Types::Coercible::Hash.default({}.freeze)
         attribute? :debug_message, Types::Strict::String
       end
 

data/lib/salestation/web.rb

@@ -8,7 +8,7 @@ require 'json'
 module Salestation
   class Web < Module
     module Types
-      include Dry::Types.module
+      include Dry::Types()
     end
 
     def initialize(errors: {})

data/lib/salestation/web/responses.rb

@@ -32,19 +32,27 @@ module Salestation
       class Error < Response
         attribute :status, Types::Strict::Integer
         attribute :message, Types::Strict::String
-        attribute :debug_message, Types::String.default('')
-        attribute :context, Types::Hash.default({})
-        attribute :headers, Types::Hash.default({})
+        attribute :debug_message, Types::Coercible::String.default('')
+        attribute :context, Types::Hash.default({}.freeze)
+        attribute :headers, Types::Hash.default({}.freeze)
 
         def body
           {message: message, debug_message: debug_message}
         end
       end
 
+      class UnprocessableEntityError < Error
+        attribute :form_errors, Types::Hash.default({}.freeze)
+
+        def body
+          super.merge(form_errors: errors)
+        end
+      end
+
       class Success < Response
         attribute :status, Types::Strict::Integer
         attribute :body, Types::Strict::Hash | Types::Strict::Array
-        attribute :headers, Types::Hash.default({})
+        attribute :headers, Types::Hash.default({}.freeze)
       end
 
       class UnprocessableEntityFromSchemaErrors
@@ -52,7 +60,7 @@ module Salestation
           message = parse_errors(errors)
           debug_message = parse_hints(hints)
 
-          UnprocessableEntity.new(message: message, debug_message: debug_message)
+          UnprocessableEntity.new(message: message, debug_message: debug_message, form_errors: errors)
         end
 
         def self.parse_errors(errors)
@@ -99,7 +107,7 @@ module Salestation
       Conflict = Error.with_code(409)
       RequestEntityTooLarge = Error.with_code(413)
       UnsupportedMediaType = Error.with_code(415)
-      UnprocessableEntity = Error.with_code(422)
+      UnprocessableEntity = UnprocessableEntityError.with_code(422)
 
       InternalError = Error.with_code(500)
       ServiceUnavailable = Error.with_code(503)

data/lib/salestation/web/statsd_middleware.rb

@@ -3,6 +3,9 @@
 module Salestation
   class Web < Module
     class StatsdMiddleware
+      EXTRA_TAGS_ENV_KEY = 'salestation.statsd.tags'
+
+      DURATION_MILLISECOND_PRECISION = 3
 
       def initialize(app, statsd, metric:)
         @app = app
@@ -11,7 +14,7 @@ module Salestation
       end
 
       def call(env)
-        start = Time.now
+        start = system_monotonic_time
 
         status, header, body = @app.call env
 
@@ -23,14 +26,27 @@ module Salestation
             'unknown-route'
           end
 
-        @statsd.timing(@metric, (Time.now - start) * 1000, tags: [
-          "path:#{ path }",
-          "method:#{ method }",
-          "status:#{ status }"
-        ])
+        tags = [
+          "path:#{path}",
+          "method:#{method}",
+          "status:#{status}",
+          "status_class:#{status / 100}xx"
+        ] + env.fetch(EXTRA_TAGS_ENV_KEY, [])
+
+        @statsd.timing(@metric, duration_ms(from: start), tags: tags)
 
         [status, header, body]
       end
+
+      private
+
+      def duration_ms(from:)
+        ((system_monotonic_time - from) * 1000).round(DURATION_MILLISECOND_PRECISION)
+      end
+
+      def system_monotonic_time
+        Process.clock_gettime(Process::CLOCK_MONOTONIC)
+      end
     end
   end
 end

data/salestation.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "salestation"
-  spec.version       = "3.4.0"
+  spec.version       = "3.8.0"
   spec.authors       = ["Glia TechMovers"]
   spec.email         = ["techmovers@glia.com"]
 
@@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.13"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "bundler", "~> 2.0"
+  spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "pry", "~> 0.10.4"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: salestation
 version: !ruby/object:Gem::Version
-  version: 3.4.0
+  version: 3.8.0
 platform: ruby
 authors:
 - Glia TechMovers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-03 00:00:00.000000000 Z
+date: 2020-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -158,8 +158,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14.4
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: ''