salesforce_ar_sync 5.2.1 → 5.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d83e1e9497d87d16d9fdebccfee16539bf0487188be9075402327f4db317e20
-  data.tar.gz: 6c34017e100080e5ef5c2210a33285631cdb97b80c9104281b478e370d519edd
+  metadata.gz: 40fc50d80886fc52df3a5e7746cedd628bd6caa59208f98fd4d9da679ce4c02b
+  data.tar.gz: 5a281b4603cab7430a4e7c9b615c5797a9af146a4e3eaf0221136f2ca76d5041
 SHA512:
-  metadata.gz: 7b54b2e245692b924ca1f254eedc27e9d60db2eff15326c3abe8d7dd3b966198d025202f55ba3d391da8cdb4a6f3b2714b02ed6f8aaf0bee49ebc2aa648b7bf2
-  data.tar.gz: 12ebd84b8779026de0675804dbe9dbbae4080e40f1e365aad1931733eb1b39d50c762a7163dde23338312814befb6b0bebccadfdb9879e78f7a5e362815ae45f
+  metadata.gz: 8f811c64d88b6fdeba01af7d5bd97b48aed716de2d9014413ffef4a417eab3155db55655e101edd507adf80e5dc7f2e6066d2430bd57421ecc85102ec4f67ebf
+  data.tar.gz: 1d1d0b72a10dc10e2d47a151fb4dde0281db7ec340f0b910cc899613eb393247ec6ef68b7bcfbc79ecbcabdc70604ea58880382605ccc99fb2fa2583d325e884

data/lib/salesforce_ar_sync/salesforce_sync.rb

@@ -71,24 +71,49 @@ module SalesforceArSync
       def salesforce_update(attributes = {})
         raise ArgumentError, "#{salesforce_id_attribute_name} parameter required" if attributes[salesforce_id_attribute_name].blank?
 
+        attempt_salesforce_update(attributes)
+      end
+
+      private
+
+      def find_record(attributes)
         data_source = unscoped_updates ? unscoped : self
         object = data_source.find_by(salesforce_id: attributes[salesforce_id_attribute_name])
         object ||= data_source.find_by(activerecord_web_id_attribute_name => attributes[salesforce_web_id_attribute_name]) if salesforce_sync_web_id? && attributes[salesforce_web_id_attribute_name]
+        return object if object.present?
 
-        if !object && additional_lookup_fields
+        if additional_lookup_fields
           additional_lookup_fields.each do |attribute_name, salesforce_attribute_name|
             object = data_source.find_by(attribute_name => attributes[salesforce_attribute_name]) if attributes[salesforce_attribute_name]
+            break if object
           end
+          return object
         end
+      end
 
-        if object.nil?
-          object = new
+      def build_record(attributes)
+        new.tap do |object|
           salesforce_default_attributes_for_create.merge(salesforce_id: attributes[salesforce_id_attribute_name]).each_pair do |k, v|
             object.send("#{k}=", v)
           end
         end
+      end
+
+      def attempt_salesforce_update(attributes, retried: false)
+        object = find_record(attributes) || build_record(attributes)
+        return unless object
+
+        object.salesforce_process_update(attributes) if salesforce_stale?(object, attributes[:SystemModstamp])
+      rescue ActiveRecord::RecordNotUnique
+        raise if retried
+
+        attempt_salesforce_update(attributes, retried: true)
+      end
+
+      def salesforce_stale?(object, modstamp)
+        return false if modstamp.blank?
 
-        object.salesforce_process_update(attributes) if object && (object.salesforce_updated_at.nil? || (object.salesforce_updated_at && object.salesforce_updated_at < Time.parse(attributes[:SystemModstamp])))
+        object.salesforce_updated_at.nil? || object.salesforce_updated_at < Time.parse(modstamp)
       end
     end
 
@@ -176,20 +201,19 @@ module SalesforceArSync
 
     def salesforce_create_object(attributes)
       attributes[self.class.salesforce_web_id_attribute_name.to_s] = id if self.class.salesforce_sync_web_id? && !new_record?
-      salesforce_id = SF_CLIENT.create(salesforce_object_name, format_attributes(attributes))
-      self.salesforce_id = salesforce_id
+      self.salesforce_id = SF_CLIENT.create!(salesforce_object_name, format_attributes(attributes))
       @exists_in_salesforce = true
     end
 
     def salesforce_update_object(attributes)
       attributes[self.class.salesforce_web_id_attribute_name.to_s] = id if self.class.salesforce_sync_web_id? && !new_record?
 
-      SF_CLIENT.update(salesforce_object_name, format_attributes(attributes).merge(Id: salesforce_id))
+      SF_CLIENT.update!(salesforce_object_name, format_attributes(attributes).merge(Id: salesforce_id))
     end
 
     def salesforce_delete_object
       if ar_sync_outbound_delete?
-        SF_CLIENT.destroy(salesforce_object_name, salesforce_id)
+        SF_CLIENT.destroy!(salesforce_object_name, salesforce_id)
       end
     end
 
@@ -236,7 +260,7 @@ module SalesforceArSync
     def sync_web_id
       return false if !self.class.salesforce_sync_web_id? || SalesforceArSync.config['SYNC_ENABLED'] == false
 
-      SF_CLIENT.update(salesforce_object_name, Id: salesforce_id, self.class.salesforce_web_id_attribute_name.to_s => get_activerecord_web_id) if salesforce_id
+      SF_CLIENT.update!(salesforce_object_name, Id: salesforce_id, self.class.salesforce_web_id_attribute_name.to_s => get_activerecord_web_id) if salesforce_id
     end
 
     def get_activerecord_web_id

data/lib/salesforce_ar_sync/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SalesforceArSync
-  VERSION = '5.2.1'
+  VERSION = '5.3.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: salesforce_ar_sync
 version: !ruby/object:Gem::Version
-  version: 5.2.1
+  version: 5.3.1
 platform: ruby
 authors:
 - Michael Halliday
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-07-17 00:00:00.000000000 Z
+date: 2026-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack-xml_parser