sal-engine 0.0.6 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 68a2273b0cf8d76b4bceb2bfbf00cc6fc5d44e80
-  data.tar.gz: d8b92b0a3773d336ed4544a7cca4eb13161968ae
+  metadata.gz: 6caf72ddae015a268c0e9304b4496e0b424d45d9
+  data.tar.gz: 0b936547c1b44fbc5da414caf71b150d682f39d5
 SHA512:
-  metadata.gz: 786a8a09e4d55dee5ce68c578966f509f44db811daf1c2a7945d443193b8d6292ff332f5ee6332167302a2dc961725b19b717102d5164f3bd709b0d1048c1273
-  data.tar.gz: b0d0a14d14ada2325c9e6b83696ba223b186b58d39138ebadcb46e8aa699cbe2cbf811e83ac6fc0eea0952beb717c5a142201b89a4d99497a55cb43f02b871fc
+  metadata.gz: ba9a225059c413b3cb46f003e13ff0230aad946f870dbd363df5faaae7fe24201fab0f70ff0147b434be00f2e75cd8d698191d64ba360ca4ffeb9d201818db6e
+  data.tar.gz: a28c83e7c626a534eaaa53df202b9b39b233fc9f9510567076065cd08871ed89431ee4bc6ce5d478ae0172c0f229914346f46fd9b510859f0216c5950467c90a

data/README.md

@@ -35,20 +35,22 @@ When providing both, `notice` will prevail.
 ## menu_item helper
 Very handy for navigation menus:
 ```erb
-<%= menu_item 'first' %>First option<% end %>
-<%= menu_item 'second', :div %><%= link_to root_path, 'Second option' %><% end %>
+<%= menu_item 'first' do %>First option<% end %>
+<%= menu_item 'second', tag: :div do %><%= link_to root_path, 'Second option' %><% end %>
+<%= menu_item 'third', class: 'nav-link' do %>Third option<% end %>
 ```
 
 Renders:
 ```html
 <li class="active">First option<li>
 <div><a href="/">Second option</a><div>
+<li class="nav-link">Third option</li>
 ```
 
 Parameters:
-`menu_item(item, tag)`
+`menu_item(item, options)`
 - item: item name
-- tag: `:li` by default
+- options: a has of options such as :class, etc… An additional option :tag is provided in case you don't want to use LI as default
 
 ## errors_bar helper
 Will indicate if any model in your form has an error. It supports multiple models

data/app/helpers/sal/application_helper.rb

@@ -23,8 +23,12 @@ module Sal
       end
     end
 
-    def menu_item(item, tag = :li)
-      options = section == item ? {class: 'active'} : {}
+    def menu_item(item, options = {})
+      tag = options.delete(:tag) || 'li'
+      if section == item
+        klass = options[:class].to_s.split(' ').push('active').join(' ')
+        options[:class] = klass
+      end
       content_tag tag, options do
         yield
       end

data/lib/sal/version.rb

@@ -1,3 +1,3 @@
 module Sal
-  VERSION = '0.0.6'
+  VERSION = '0.1.0'
 end

data/spec/dummy/config/initializers/assets.rb

@@ -1,7 +1,7 @@
 # Be sure to restart your server when you modify this file.
 
 # Version of your assets, change this if you want to expire all your assets.
-Rails.application.config.assets.version = '1.0'
+#Rails.application.config.assets.version = '1.0'
 
 # Precompile additional assets.
 # application.js, application.css, and all non-JS/CSS in app/assets folder are already added.

data/spec/helpers/application_helper_spec.rb

@@ -62,12 +62,28 @@ describe ApplicationHelper do
       allow(helper).to receive(:section) { 'selected_list_item' }
     end
 
-    context 'list item is selected' do
+    context 'tag is selected' do
       let(:item) { 'selected_list_item' }
 
       it { is_expected.to have_selector('li.active', 'content') }
     end
 
+    context 'list item is selected' do
+      let(:item) { 'selected_list_item' }
+
+      it 'appends the active class' do
+        expect(helper.menu_item(item, tag: 'div') { 'content' }).to have_selector('div.active', 'content')
+      end
+    end
+
+    context 'list item is selected and there are other options' do
+      let(:item) { 'selected_list_item' }
+
+      it 'appends the active class' do
+        expect(helper.menu_item(item, class: 'nav-item') { 'content' }).to have_selector('li.nav-item.active', 'content')
+      end
+    end
+
     context 'list item is not selected' do
       let(:item) { 'unselected_list_item' }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sal-engine
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.1.0
 platform: ruby
 authors:
 - Daniel Cruz Horts
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-05 00:00:00.000000000 Z
+date: 2017-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -28,70 +28,70 @@ dependencies:
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.10'
 - !ruby/object:Gem::Dependency
   name: pry-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.3'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.4'
 description: Sal (salt) is what you add to every meal. I add sal to my Rails projects
@@ -153,7 +153,6 @@ files:
 - spec/dummy/config/locales/en.yml
 - spec/dummy/config/routes.rb
 - spec/dummy/config/secrets.yml
-- spec/dummy/log/test.log
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
@@ -183,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: A Rails engine with my recurrent additions
@@ -216,7 +215,6 @@ test_files:
 - spec/dummy/config/routes.rb
 - spec/dummy/config/secrets.yml
 - spec/dummy/config.ru
-- spec/dummy/log/test.log
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
@@ -228,4 +226,3 @@ test_files:
 - spec/helpers/error_span_view.html.erb
 - spec/rails_helper.rb
 - spec/spec_helper.rb
-has_rdoc: 

data/spec/dummy/log/test.log

@@ -1,4 +0,0 @@
-  Rendered /Users/dani/Pasatiempos/ruby/sal/spec/helpers/error_span_view.html.erb (9.6ms)
-  Rendered /Users/dani/Pasatiempos/ruby/sal/spec/helpers/error_span_view.html.erb (11.2ms)
-  Rendered /Users/dani/Pasatiempos/ruby/sal/spec/helpers/error_span_view.html.erb (5.9ms)
-  Rendered /Users/dani/Pasatiempos/ruby/sal/spec/helpers/error_span_view.html.erb (5.6ms)