sailthru-client 4.0.0 → 4.0.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YWFlMjgwYzY1YjJlODhhYzk1YzFkY2ZhM2ViMGE4MzkyYjQ2ZDQ3Mg==
+    ZmUzNjY1NzM2ZDI3ZDNmZjdmYjFlMjUwMmI4NjIwOTQzZTQxZTYyOQ==
   data.tar.gz: !binary |-
-    ZTY5YjllNGI5Y2MyZjY2MDMwYWE0ZDdlYzdhNDQzODA4YzRiNzc1Mg==
+    ZjNlY2ViMTg3OTVlYjI2MDYyNDRmOWU4M2QyOGJiOTBlODgxNDNhMQ==
 SHA512:
   metadata.gz: !binary |-
-    Y2Q4N2JhZWVjN2Y1ZTJjMGUzNDkxNjg0YzYyMjFjZGFmN2QzZWU3M2RlNWJl
-    ZGRkOWRmNmJiYjU0ZWRhZjgwMWNjMGE2Njk1ZDMxYzhiZDM4ZDgwZGM1ODdl
-    YTA2M2EwODJlMGI2YmIxOGU3YmJkY2U1MjFkZDEzMjUwZmI3YWU=
+    Mzc0ZTM2Nzk3NTExYzEzMzFlYzA1N2U5M2E5MTgxOGJkMTllMGIwZTc3ZWJj
+    MDAyMDRhZDk0ZDY3YzJiNThjN2U5NTVlMTc5ZWIwZjJhMmJhYWM5MzM2OTkw
+    ODFkMjk3NjI0YzhiODVhODYyNDhhZDg3MmVmYjFmOGE5MmRkMTM=
   data.tar.gz: !binary |-
-    MGY0ODNiNzNkMjYwMTQxMjU1N2NjNDA0MGJlNjlhMWM1MGU4Mjk0NjFjZDE5
-    ZDliZWViMGFkMmY5NDY0Y2RkZmJkOGI0MmYyMjdjMzU4ZmJhNzhjMzYxYmJk
-    NDBlYzMxMjA2MWE1MDg5N2ExM2YzNTY3OWE5MTA1MDRlZmIxOTY=
+    OWY5N2E0Njc3ZWE5MWE5Nzg2MDM3MDU0NjkwMTEwMGM4MmRhYjRlYTA0Y2Y1
+    NTMxMGFiMjAxNDI3NjBmOWYyYWIxZjEwMDYzYWJjYjRkMDEyMmE5MjcyMTQ2
+    NmQ2MzhkOGMzYTZkOTI4ZGViNTY5YWFiNDJhMzQ4YTAxOWNhOWU=

data/CHANGELOG.md

@@ -1,4 +1,7 @@
-## 4.0.0 (TBD)
+## 4.0.1 (Jun 27, 2014)
+  - Bug fix for https://github.com/sailthru/sailthru-ruby-client/pull/48
+
+## 4.0.0 (Jun 17, 2014)
   - Rename Sailthru::SailthruClient to Sailthru::Client
   - Rework custom exceptions to be StandardErrors
   - Add `Sailthru.credentials` for easy initialization in Rails apps

data/lib/sailthru/client.rb

@@ -279,13 +279,13 @@ module Sailthru
         return false unless params[:action] == :verify
 
         sig = params.delete(:sig)
-        sig = sig.delete_if {|key, value| key == :controller}
+        params.delete(:controller)
         return false unless sig == get_signature_hash(params, @secret)
 
         _send = get_send(params[:send_id])
-        return false unless _send.has_key?(:email)
+        return false unless _send.has_key?('email')
 
-        return false unless _send[:email] == params[:email]
+        return false unless _send['email'] == params[:email]
 
         return true
       else
@@ -305,7 +305,7 @@ module Sailthru
         return false unless params[:action] == 'optout'
 
         sig = params.delete(:sig)
-        sig = sig.delete_if {|key, value| key == :controller}
+        params.delete(:controller)
         return false unless sig == get_signature_hash(params, @secret)
         return true
       else
@@ -325,7 +325,7 @@ module Sailthru
         return false unless params[:action] == 'hardbounce'
 
         sig = params.delete(:sig)
-        sig = sig.delete_if {|key, value| key == :controller}
+        params.delete(:controller)
         return false unless sig == get_signature_hash(params, @secret)
         return true
       else

data/lib/sailthru/version.rb

@@ -1,3 +1,3 @@
 module Sailthru
-  VERSION = '4.0.0'
+  VERSION = '4.0.1'
 end

data/test/sailthru/receive_post_callback_test.rb

@@ -0,0 +1,54 @@
+require 'test_helper'
+
+class ReceivePostCallbackTest < Minitest::Test
+  describe "API helpers: validate post callbacks" do
+    before do
+      @api_url = 'http://api.sailthru.com'
+      @secret = 'my_secret'
+      @api_key = 'my_api_key'
+      @sailthru_client = Sailthru::Client.new(@api_key, @secret, @api_url)
+    end
+
+    it "can validate a verify callback" do
+      valid_send_id = "TT1ClGdj2bRHAAP6"
+      get_send_params = {
+        'send_id' => valid_send_id
+      }
+      query_string = create_json_payload(@api_key, @secret, get_send_params)
+      stub_get(sailthru_api_call_url(@api_url, 'send') + '?' + query_string , 'send_get_valid.json')
+
+      params = {
+        :email => 'praj@sailthru.com',
+        :action => :verify,
+        :send_id => valid_send_id,
+        :api_key => @api_key
+      }
+      params[:sig] = get_signature_hash(params, @secret)
+      assert @sailthru_client.receive_verify_post(params, mock(:post? => true))
+    end
+
+    it "can validate a opt-out callback" do
+      params = {
+        :email => 'ian@sailthru.com',
+        :mode => 'all',
+        :optout => '0',
+        :action => 'optout',
+        :api_key => @api_key
+      }
+      params[:sig] = get_signature_hash(params, @secret)
+      assert @sailthru_client.receive_optout_post(params, mock(:post? => true))
+    end
+
+    it "can validate a hardbounce callback" do
+      params = {
+        :email => 'ian@sailthru.com',
+        :action => 'hardbounce',
+        :send_id => 'TT1ClGdj2bRHAAP6',
+        :api_key => @api_key
+      }
+      params[:sig] = get_signature_hash(params, @secret)
+      assert @sailthru_client.receive_hardbounce_post(params, mock(:post? => true))
+    end
+
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sailthru-client
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - Prajwal Tuladhar
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-27 00:00:00.000000000 Z
+date: 2014-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -160,6 +160,7 @@ files:
 - test/sailthru/helpers_test.rb
 - test/sailthru/list_test.rb
 - test/sailthru/purchase_test.rb
+- test/sailthru/receive_post_callback_test.rb
 - test/sailthru/send_test.rb
 - test/sailthru/stats_test.rb
 - test/sailthru/template_test.rb
@@ -238,6 +239,7 @@ test_files:
 - test/sailthru/helpers_test.rb
 - test/sailthru/list_test.rb
 - test/sailthru/purchase_test.rb
+- test/sailthru/receive_post_callback_test.rb
 - test/sailthru/send_test.rb
 - test/sailthru/stats_test.rb
 - test/sailthru/template_test.rb