sageone_api_request_signer 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 85eba0ca1d6de0e8d6bfc0e5e9eb91f064e82928
-  data.tar.gz: 67e9e61dc7de0b8a9047f6550038cea2d75b620f
+  metadata.gz: 7ee694bdf80abcf67c8ed334cf38760cc3bf67ed
+  data.tar.gz: 1781b4db7c262a996660a22a5bcd29a52ade7f8f
 SHA512:
-  metadata.gz: 012a0b7e170e9b7d3e49b68fa659a8a504f85cedcde3266674a3ea503393ee9b576f69b0e6c2e6b15f5c14151ef6dc32e3bb48b0ace89a9d17e2c486c38293b2
-  data.tar.gz: e3e1dd196af24336c44487617352a2e8a9e724ecece682771428bd5561add30afa84d8763ab1032b516beafa509d226de587a64e7acffc556cfb8af6d5bf553a
+  metadata.gz: 56a0e39d35f0470e9c4e9cdc358a62cd072252e0d49f1570f4ed883b3a8603480bc5a810f616a32bbb24a5cccd4e91358e7d9d5b90cc38364d1629d5dbc2cea5
+  data.tar.gz: a3e49db37f115b116eca1a947ffb2c3ce6c6bc4975fb0edc53a0c11f07c101f50b8780b99ef5e05c805181cde932519691f3cb1c9195b150f45f8965cd4f0c26

data/lib/sageone_api_request_signer.rb

@@ -1,4 +1,6 @@
 require "sageone_api_request_signer/version"
+require "active_support"
+require "active_support/core_ext"
 require "base64"
 
 # "Sign" an Sageone API request call following the steps detailed here:
@@ -41,8 +43,7 @@ class SageoneApiRequestSigner
 
   def parameter_string
     @parameter_string ||= (
-      key_value_pair = percent_encode_pair(url_params.merge(body_params).sort)
-      key_value_pair.map{|pair| pair.join('=') }.join('&')
+      url_params.merge(body_params).sort.to_h.to_query.gsub('+','%20')
     )
   end
 
@@ -80,10 +81,4 @@ class SageoneApiRequestSigner
   def percent_encode(str)
     URI.escape(str.to_s, /[^0-9A-Za-z\-._~]/)
   end
-
-  def percent_encode_pair(pair)
-    pair.map! do |k,v|
-      [percent_encode(k), percent_encode(v)]
-    end
-  end
 end

data/lib/sageone_api_request_signer/version.rb

@@ -1,3 +1,3 @@
 class SageoneApiRequestSigner
-  VERSION = "1.0.1"
+  VERSION = "1.1.0"
 end

data/sageone_api_request_signer.gemspec

@@ -18,6 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.add_dependency "activesupport"
+
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency 'fudge'

data/spec/integration/complex_body_params_spec.rb

@@ -0,0 +1,82 @@
+require 'rest_client'
+require 'json'
+
+RSpec.describe 'testing complex body params' do
+  subject do
+    SageoneApiRequestSigner.new({
+      request_method: 'post',
+      url: 'https://api.sageone.com/test/accounts/v1/contacts',
+      signing_secret: 'TestSigningSecret',
+      access_token: 'TestToken',
+    })
+  end
+
+  let(:headers) do
+    subject.request_headers.merge({
+      'Accept' => '*/*',
+      'Content-Type' => 'application/x-www-form-urlencoded',
+      'User-Agent' => 'NPSS'
+    })
+  end
+
+  it 'with multi-level hashes' do
+    subject.body_params = {
+      first: 'level',
+      second: {
+        multi: 'level',
+        third: {
+          level: 'the last one'
+        },
+        ok: 'this is enough'
+      }
+    }
+
+    check_signature!
+  end
+
+  it 'with arrays' do
+    subject.body_params = {
+      simple: 'param',
+      complex: [
+        {one:11, two:12, three:13},
+        {one:21, two:22, three:23},
+      ]
+    }
+  end
+
+  it 'hardcore one' do
+    subject.body_params = {
+      hardcore: [
+        {one:11, two:12, three:13},
+        {four:4, two:22, three:23},
+        {
+          fuck_all: {
+            i_am: 'really nested',
+            no: {
+              i_am: 'damm more'
+            }
+          }
+        }
+      ]
+    }
+  end
+
+  describe
+
+  def check_signature!
+    RestClient.post subject.url, subject.body_params, headers
+
+    rescue => e
+      raise e unless e.respond_to? :response
+
+      response = JSON.parse(e.response.to_s)
+
+      expect(subject.nonce).to eql(response['nonce'])
+      expect(subject.request_method).to eql(response['request_method'])
+      expect(subject.access_token).to eql(response['token'])
+      expect(subject.base_url).to eql(response['base_url'])
+      expect(subject.parameter_string).to eql(response['parameter_string'])
+      expect(subject.signature_base_string).to eql(response['signature_base_string'])
+      expect(subject.signing_secret).to eql(response['signing_secret'])
+  end
+end

data/spec/sageone_api_request_signer_spec.rb

@@ -104,6 +104,12 @@ RSpec.describe SageoneApiRequestSigner do
 
       expect(subject.parameter_string).to eql 'aaa=1&bee=2&dee=3&zee=4'
     end
+
+    it 'cant have +, should have %20' do
+      subject.url = 'https://api.sageone.com/accounts/v1/contacts?in_the_url=i+cant+have+pluses'
+      subject.body_params = {'in_the_body_param' => 'cant have pluses here too'}
+      expect(subject.parameter_string).to eql 'in_the_body_param=cant%20have%20pluses%20here%20too&in_the_url=i%20cant%20have%20pluses'
+    end
   end
 
   describe '#signature_base_string' do

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: sageone_api_request_signer
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Rudiney Altair Franceschi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-19 00:00:00.000000000 Z
+date: 2014-12-26 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -183,6 +197,7 @@ files:
 - lib/sageone_api_request_signer/version.rb
 - sageone_api_request_signer.gemspec
 - spec/integration/check_signature_data_spec.rb
+- spec/integration/complex_body_params_spec.rb
 - spec/sageone_api_request_signer_spec.rb
 - spec/spec_helper.rb
 homepage: ''
@@ -205,12 +220,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.3.0
 signing_key: 
 specification_version: 4
 summary: Sign requests call to SageOne API.
 test_files:
 - spec/integration/check_signature_data_spec.rb
+- spec/integration/complex_body_params_spec.rb
 - spec/sageone_api_request_signer_spec.rb
 - spec/spec_helper.rb
 has_rdoc: