sage_pay 0.2.0 → 0.2.1

data/CHANGELOG.md

@@ -0,0 +1,13 @@
+# Changelog
+
+# 0.2.1
+
+* [FIX] SagePay think it's OK to have curly braces in a URL query string.
+  Ruby's URI library thinks otherwise. No matter who's right, one of these is
+  easier to change than the other.
+
+# 0.2.0
+
+* Initial release. This should support the full workflow for making payments,
+  but the notification side hasn't been tested again SagePay in the wild so
+  you mileage probably will vary.

data/lib/sage_pay.rb

@@ -6,11 +6,12 @@ require 'md5'
 require 'uuid'
 
 module SagePay
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end
 
 require 'validatable-ext'
 
+require 'sage_pay/uri_fixups'
 require 'sage_pay/server/address'
 require 'sage_pay/server/transaction_code'
 require 'sage_pay/server/signature_verification_details'

data/lib/sage_pay/uri_fixups.rb

@@ -0,0 +1,42 @@
+module URI
+  module REGEXP
+    module PATTERN
+
+      # FIXME: SagePay insists that curly brackets in URLs is OK, so we have
+      # to convince the URI parser that's the case. First we have to update
+      # the constant in question.
+      remove_const :UNRESERVED
+      UNRESERVED = "-_.!~*'()#{ALNUM}\{\}"
+
+      # FIXME: Then we have to update all the dependent constants we care
+      # about.
+      remove_const :URIC
+      remove_const :QUERY
+      remove_const :X_ABS_URI
+      URIC = "(?:[#{UNRESERVED}#{RESERVED}]|#{ESCAPED})"
+      QUERY = "#{URIC}*"
+      X_ABS_URI = "
+        (#{PATTERN::SCHEME}):                     (?# 1: scheme)
+        (?:
+           (#{PATTERN::OPAQUE_PART})              (?# 2: opaque)
+        |
+           (?:(?:
+             //(?:
+                 (?:(?:(#{PATTERN::USERINFO})@)?  (?# 3: userinfo)
+                   (?:(#{PATTERN::HOST})(?::(\\d*))?))?(?# 4: host, 5: port)
+               |
+                 (#{PATTERN::REG_NAME})           (?# 6: registry)
+               )
+             |
+             (?!//))                              (?# XXX: '//' is the mark for hostport)
+             (#{PATTERN::ABS_PATH})?              (?# 7: path)
+           )(?:\\?(#{PATTERN::QUERY}))?           (?# 8: query)
+        )
+        (?:\\#(#{PATTERN::FRAGMENT}))?            (?# 9: fragment)
+      "
+    end
+    remove_const :ABS_URI
+    ABS_URI = Regexp.new('^' + PATTERN::X_ABS_URI + '$', #'
+                         Regexp::EXTENDED, 'N').freeze
+  end
+end

data/sage_pay.gemspec

@@ -7,8 +7,8 @@ Gem::Specification.new do |s|
   ## If your rubyforge_project name is different, then edit it and comment out
   ## the sub! line in the Rakefile
   s.name              = 'sage_pay'
-  s.version           = '0.2.0'
-  s.date              = '2010-04-13'
+  s.version           = '0.2.1'
+  s.date              = '2010-04-14'
   s.rubyforge_project = 'sage_pay'
 
   ## Make sure your summary is short. The description may be as long
@@ -49,6 +49,7 @@ gateway for accepting credit card payments through your web app.
   ## THE MANIFEST COMMENTS, they are used as delimiters by the task.
   # = MANIFEST =
   s.files = %w[
+    CHANGELOG.md
     LICENSE
     README.md
     Rakefile
@@ -61,6 +62,7 @@ gateway for accepting credit card payments through your web app.
     lib/sage_pay/server/transaction_notification_response.rb
     lib/sage_pay/server/transaction_registration.rb
     lib/sage_pay/server/transaction_registration_response.rb
+    lib/sage_pay/uri_fixups.rb
     lib/validatable-ext.rb
     lib/validations/validates_inclusion_of.rb
     sage_pay.gemspec

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 2
-  - 0
-  version: 0.2.0
+  - 1
+  version: 0.2.1
 platform: ruby
 authors: 
 - Graeme Mathieson
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-13 00:00:00 +01:00
+date: 2010-04-14 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -70,6 +70,7 @@ extra_rdoc_files:
 - README.md
 - LICENSE
 files: 
+- CHANGELOG.md
 - LICENSE
 - README.md
 - Rakefile
@@ -82,6 +83,7 @@ files:
 - lib/sage_pay/server/transaction_notification_response.rb
 - lib/sage_pay/server/transaction_registration.rb
 - lib/sage_pay/server/transaction_registration_response.rb
+- lib/sage_pay/uri_fixups.rb
 - lib/validatable-ext.rb
 - lib/validations/validates_inclusion_of.rb
 - sage_pay.gemspec