sage-rails 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c226da9e35872f807813789601f70a61e0642fe895491226748730abf0ca5ae6
-  data.tar.gz: 383fa6d133de1e90321769974377b71333d3c90bd67858796835fc70be0694ca
+  metadata.gz: cdf45a19f9379935c65e7ee18b70a4cc2ce0df00b71fe13586c89ffe15180524
+  data.tar.gz: 86c1c3fda7b28206020da469995a5bcc6215c61b9249e60e0b121307b31ab66d
 SHA512:
-  metadata.gz: edff5d0c62223b69d985ba897aa619c9e924eff365a6b3c94f8f617bb06b3b28f5929fbea0ce555db046ef78f57986d78c71c8d20965062093374075b214cdf2
-  data.tar.gz: cddfd4cbeb87ba36fbd196fa1c992493a2fca258bc817be25faff43d3f1023c2e1ccd1fa08c915cfd769ee84845df97431dd6a947ed9dea9ec12ecf700fc8682
+  metadata.gz: 717576a4f348569e8610e9675132456b8d213156e666b930c1600e55c513583a05086e4d1082d4efc90ba7a7b3bccd76fbbde81b4e883c318fc94b3fe14a248c
+  data.tar.gz: c3c47a9212d72c6360a3cadcf2e4f20db07d16ad5fe9864faad84a95011ca164d251b0ad2df36e0c0e097e57d6549e9025f25061d000e3dcfa1974b659b9c6f6

data/README.md

@@ -34,13 +34,6 @@ Run bundle install:
 $ bundle install
 ```
 
-## Sprockets
-
-If using sprockets, add this line to your app/javascript/application.js file:
-```js
-import "sage/applicaiton";
-```
-
 ## Getting Started
 
 Run the install generator to set up Sage in your Rails application:
@@ -60,6 +53,14 @@ After installation, run the migrations:
 $ rails db:migrate
 ```
 
+### Sprockets
+
+If using sprockets, add this line to your app/javascript/application.js file:
+```js
+import "sage/application";
+```
+
+
 ## LLM Configuration
 
 Sage supports both Anthropic Claude and OpenAI models for SQL generation. Configure your preferred AI service in `config/initializers/sage.rb`:

data/app/assets/javascripts/sage/controllers/query_toggle_controller.js

@@ -2,21 +2,65 @@ import { Controller } from "@hotwired/stimulus";
 
 export default class extends Controller {
   static targets = ["content", "icon"]
+  static values = {
+    storageKey: { type: String, default: "sage_query_sql_visibility" }
+  }
+
+  connect() {
+    // Load saved visibility state from localStorage
+    this.loadVisibilityState()
+  }
 
   toggle() {
     try {
       const content = this.contentTarget
       const icon = this.iconTarget
-      
-      if (content.style.display === "none") {
-        content.style.display = "block"
-        icon.textContent = "visibility_off"
+
+      const isHidden = window.getComputedStyle(content).display === "none"
+
+      if (isHidden) {
+        this.showContent()
       } else {
-        content.style.display = "none"
-        icon.textContent = "visibility"
+        this.hideContent()
       }
     } catch (error) {
       console.error("Error in toggle:", error)
     }
   }
+
+  showContent() {
+    this.contentTarget.style.display = "block"
+    this.iconTarget.textContent = "visibility_off"
+    this.saveVisibilityState(true)
+  }
+
+  hideContent() {
+    this.contentTarget.style.display = "none"
+    this.iconTarget.textContent = "visibility"
+    this.saveVisibilityState(false)
+  }
+
+  saveVisibilityState(isVisible) {
+    try {
+      localStorage.setItem(this.storageKeyValue, JSON.stringify(isVisible))
+    } catch (error) {
+      console.error("Error saving visibility state:", error)
+    }
+  }
+
+  loadVisibilityState() {
+    try {
+      const savedState = localStorage.getItem(this.storageKeyValue)
+      if (savedState !== null) {
+        const isVisible = JSON.parse(savedState)
+        if (isVisible) {
+          this.showContent()
+        } else {
+          this.hideContent()
+        }
+      }
+    } catch (error) {
+      console.error("Error loading visibility state:", error)
+    }
+  }
 }

data/app/controllers/sage/queries_controller.rb

@@ -140,8 +140,9 @@ module Sage
       @query ||= Blazer::Query.find_by(id: params[:query_id]) if params[:query_id]
 
       # use query data source when present
-      data_source = @query.data_source if @query && @query.data_source
+      data_source = @query.data_source if @query && @query.data_source.present?
       data_source ||= params[:data_source]
+      data_source ||= "main" # Fallback to main data source
       @data_source = Blazer.data_sources[data_source]
 
       # Prefer params statement over query's saved statement (for live editing)

data/app/javascript/sage/controllers/query_toggle_controller.js

@@ -2,23 +2,65 @@ import { Controller } from "@hotwired/stimulus";
 
 export default class extends Controller {
   static targets = ["content", "icon"]
+  static values = {
+    storageKey: { type: String, default: "sage_query_sql_visibility" }
+  }
+
+  connect() {
+    // Load saved visibility state from localStorage
+    this.loadVisibilityState()
+  }
 
   toggle() {
     try {
       const content = this.contentTarget
       const icon = this.iconTarget
-      
+
       const isHidden = window.getComputedStyle(content).display === "none"
-      
+
       if (isHidden) {
-        content.style.display = "block"
-        icon.textContent = "visibility_off"
+        this.showContent()
       } else {
-        content.style.display = "none"
-        icon.textContent = "visibility"
+        this.hideContent()
       }
     } catch (error) {
       console.error("Error in toggle:", error)
     }
   }
+
+  showContent() {
+    this.contentTarget.style.display = "block"
+    this.iconTarget.textContent = "visibility_off"
+    this.saveVisibilityState(true)
+  }
+
+  hideContent() {
+    this.contentTarget.style.display = "none"
+    this.iconTarget.textContent = "visibility"
+    this.saveVisibilityState(false)
+  }
+
+  saveVisibilityState(isVisible) {
+    try {
+      localStorage.setItem(this.storageKeyValue, JSON.stringify(isVisible))
+    } catch (error) {
+      console.error("Error saving visibility state:", error)
+    }
+  }
+
+  loadVisibilityState() {
+    try {
+      const savedState = localStorage.getItem(this.storageKeyValue)
+      if (savedState !== null) {
+        const isVisible = JSON.parse(savedState)
+        if (isVisible) {
+          this.showContent()
+        } else {
+          this.hideContent()
+        }
+      }
+    } catch (error) {
+      console.error("Error loading visibility state:", error)
+    }
+  }
 }

data/app/views/sage/queries/_new_form.html.erb

@@ -10,36 +10,38 @@
 
 <% @variable_params = @query.persisted? ? variable_params(@query) : nested_variable_params(@query) %>
 
-<%= form_for @query, url: (@query.persisted? ? query_path(@query, params: @variable_params) : queries_path(params: @variable_params)), html: {autocomplete: "off", class: ""} do |f| %>
+<!-- Hidden Run button form outside the main form -->
+<%= form_with url: (defined?(sage) && sage.respond_to?(:run_queries_path) ? sage.run_queries_path : run_queries_path), method: :post, local: false, html: {id: 'run-query-form', style: "display: none;"} do |f| %>
+  <%= f.hidden_field :statement, id: 'run_query_statement' %>
+  <%= f.hidden_field :query_id, value: @query.id %>
+  <%= f.hidden_field :data_source, value: @query.data_source || Blazer.data_sources.keys.first %>
+<% end %>
+
+<%= form_for @query, url: (@query.persisted? ? query_path(@query, params: @variable_params) : queries_path(params: @variable_params)), html: {autocomplete: "off", class: "", id: 'query-form'} do |f| %>
   <div class="grid" style='margin-top: 0px'>
     <div class="s10">
       <div class="field label border">
         <%= f.text_field :name %>
         <%= f.label :name, class: (@query.name.present? ? "active" : "") %>
       </div>
-      
+
       <div class="field textarea label border">
         <%= f.text_area :description, style: "height: 145px; resize: vertical;" %>
         <%= f.label :description, "Description (Optional)", class: (@query.description.present? ? "active" : "") %>
       </div>
-      
+
       <%= f.hidden_field :statement, id: 'query_statement_form' %>
     </div>
-    
+
     <div class="s2">
       <nav style="display: flex; flex-direction: column; gap: 12px; padding-left: 8px;">
         <button type='button' onclick="formatSQL()" class="button secondary" title="Format SQL">
           <i>auto_fix_high</i>
         </button>
-        
-        <%= form_with url: (defined?(sage) && sage.respond_to?(:run_queries_path) ? sage.run_queries_path : run_queries_path), method: :post, local: false, style: "margin: 0;" do |f| %>
-          <%= f.hidden_field :statement, id: 'run_query_statement' %>
-          <%= f.hidden_field :query_id, value: @query.id %>
-          <%= f.hidden_field :data_source, value: @query.data_source || Blazer.data_sources.keys.first %>
-          <button type='submit' class="button primary" title="Run Query">
-            <i>play_arrow</i>
-          </button>
-        <% end %>
+
+        <button type='button' onclick="document.getElementById('run-query-form').requestSubmit()" class="button primary" title="Run Query">
+          <i>play_arrow</i>
+        </button>
 
         <button type="submit" name="commit" value="<%= @query.persisted? ? "Update" : "Create" %>" class="button primary" title="<%= @query.persisted? ? "Update" : "Create" %>">
           <i><%= @query.persisted? ? "save" : "add" %></i>

data/app/views/sage/queries/_run.html.erb

@@ -33,7 +33,7 @@
   <% else %>
     <% unless @only_chart %>
       <%= render partial: "caching" %>
-      <p class="text-muted" style="margin-bottom: 10px;">
+      <p class="text-muted" style="margin-top: <%= @rows.any? ? '0' : '40px' %>; margin-bottom: 10px;">
       <% if @row_limit && @rows.size > @row_limit %>
         First
         <% @rows = @rows.first(@row_limit) %>
@@ -225,8 +225,8 @@
         <% end %>
       </div>
     <% end %>
-  <% elsif @only_chart %>
-    <p class="text-muted">No rows</p>
+    <% elsif @only_chart %>
+      <p class="text-muted">No rows</p>
+    <% end %>
   <% end %>
 <% end %>
-<% end %>

data/app/views/sage/queries/show.html.erb

@@ -35,14 +35,25 @@
     <span>Statement</span>
     <i class="material-icons" data-sage--query-toggle-target="icon" data-action="click->sage--query-toggle#toggle" style="cursor: pointer; font-size: 18px; opacity: 0.6;">visibility_off</i>
   </div>
-  
-  <pre id="code" data-sage--query-toggle-target="content"><code><%= @statement.try(:display_statement) || @query.statement %></code></pre>
+
+  <% statement_display = begin
+       @statement.try(:display_statement) if @statement&.statement.present?
+     rescue => e
+       Rails.logger.error("Error displaying statement: #{e.message}")
+       nil
+     end %>
+
+  <pre id="code" data-sage--query-toggle-target="content"><code><%= statement_display || @query.statement || "-- No SQL statement defined --" %></code></pre>
 </div>
 
-<% if @success %>
+<% if @success && @query.statement.present? && @query.data_source.present? %>
   <%= turbo_frame_tag dom_id(@query, 'results'), src: run_query_path(@query.id, from_show: true, variables: variable_params(@query)) do  %>
     loading...
   <% end %>
+<% elsif @query.statement.blank? %>
+  <div class="padding center-align">
+    <p class="secondary-text">No SQL statement to execute. <%= link_to "Edit this query", edit_query_path(@query) %> to add a statement.</p>
+  </div>
 <% end %>
 
 <%= javascript_tag nonce: true do %>

data/lib/sage/version.rb

@@ -1,3 +1,3 @@
 module Sage
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sage-rails
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Nathan Jones