safrano 0.3.4 → 0.4.4

data/lib/{service.rb → safrano/service.rb}

@@ -1,137 +1,92 @@
-#!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'rexml/document'
-require 'odata/relations.rb'
-require 'odata/batch.rb'
-require 'odata/error.rb'
-
-module OData
+require 'odata/relations'
+require 'odata/batch'
+require 'odata/complex_type'
+require 'odata/function_import'
+require 'odata/error'
+require 'odata/filter/sequel'
+require 'set'
+require 'odata/collection'
+
+module Safrano
   # this module has all methods related to expand/defered output preparation
   # and will be included in Service class
   module ExpandHandler
-    PATH_SPLITTER = %r{\A(\w+)\/?(.*)\z}.freeze
-    def get_deferred_odata_h(entity:, attrib:, uribase:)
-      { '__deferred' => { 'uri' => "#{entity.uri(uribase)}/#{attrib}" } }
-    end
-
-    # split expand argument into first and rest part
-    def split_entity_expand_arg(exp_one)
-      if exp_one.include?('/')
-        m = PATH_SPLITTER.match(exp_one)
-        cur_exp = m[1].strip
-        rest_exp = m[2]
-        # TODO: check errorhandling
-        raise OData::ServerError if cur_exp.nil?
+    PATH_SPLITTER = %r{\A(\w+)/?(.*)\z}.freeze
+    DEFERRED = '__deferred'.freeze
+    URI = 'uri'.freeze
 
-        k = cur_exp.to_sym
-      else
-        k = exp_one.strip.to_sym
-        rest_exp = nil
-      end
-      yield k, rest_exp
+    def get_deferred_odata_h(entity_uri:, attrib:)
+      { DEFERRED => { URI => "#{entity_uri}/#{attrib}" } }
     end
 
     # default v2
     # overriden in ServiceV1
-    def get_coll_odata_h(array:, expand: nil, uribase:, icount: nil)
-      res = array.map do |w|
-        get_entity_odata_h(entity: w,
-                           expand: expand,
-                           uribase: uribase)
-      end
-      if icount
-        { 'results' => res, '__count' => icount }
-      else
-        { 'results' => res }
-      end
-    end
-
-    # handle a single expand
-    def handle_entity_expand_one(entity:, exp_one:, nav_values_h:, nav_coll_h:,
-                                 uribase:)
-
-      split_entity_expand_arg(exp_one) do |first, rest_exp|
-        if (enval = entity.nav_values[first])
-          nav_values_h[first.to_s] = get_entity_odata_h(entity: enval,
-                                                        expand: rest_exp,
-                                                        uribase: uribase)
-        elsif (encoll = entity.nav_coll[first])
-          # nav attributes that are a collection (x..n)
-          nav_coll_h[first.to_s] = get_coll_odata_h(array: encoll,
-                                                    expand: rest_exp,
-                                                    uribase: uribase)
-
-        end
-      end
-    end
-
-    def handle_entity_expand(entity:, expand:, nav_values_h:,
-                             nav_coll_h:, uribase:)
-      expand.strip!
-      explist = expand.split(',')
-      # handle multiple expands
-      explist.each do |exp|
-        handle_entity_expand_one(entity: entity, exp_one: exp,
-                                 nav_values_h: nav_values_h,
-                                 nav_coll_h: nav_coll_h,
-                                 uribase: uribase)
-      end
-    end
-
-    def handle_entity_deferred_attribs(entity:, nav_values_h:,
-                                       nav_coll_h:, uribase:)
-      entity.nav_values.each_key do |ksy|
-        ks = ksy.to_s
-        next if nav_values_h.key?(ks)
-
-        nav_values_h[ks] = get_deferred_odata_h(entity: entity,
-                                                attrib: ks, uribase: uribase)
-      end
-      entity.nav_coll.each_key do |ksy|
-        ks = ksy.to_s
-        next if nav_coll_h.key?(ks)
-
-        nav_coll_h[ks] = get_deferred_odata_h(entity: entity, attrib: ks,
-                                              uribase: uribase)
+    RESULTS_K = 'results'.freeze
+    COUNT_K = '__count'.freeze
+    def get_coll_odata_h(array:, template:, icount: nil)
+      array.map! do |w|
+        get_entity_odata_h(entity: w, template: template)
       end
+      icount ? { RESULTS_K => array, COUNT_K => icount } : { RESULTS_K => array }
     end
 
     # handle $links ... Note: $expand seems to be ignored when $links
     # are  requested
-    def get_entity_odata_link_h(entity:, uribase:)
-      { uri: entity.uri(uribase) }
-    end
+    def get_entity_odata_link_h(entity:)
+      { uri: entity.uri }
+    end
+
+    EMPTYH = {}.freeze
+    METADATA_K = '__metadata'.freeze
+    def get_entity_odata_h(entity:, template:)
+      # start with metadata
+      hres = { METADATA_K => entity.metadata_h }
+
+      template.each do |elmt, arg|
+        case elmt
+        when :all_values
+          hres.merge! entity.casted_values
+
+        when :selected_vals
+          hres.merge! entity.casted_values(arg)
+
+        when :expand_e
+
+          arg.each do |attr, templ|
+            enval = entity.send(attr)
+            hres[attr] = if enval
+                           get_entity_odata_h(entity: enval, template: templ)
+                         else
+                           # FK is NULL --> nav_value is nil --> return empty json
+                           EMPTYH
+                         end
+          end
 
-    def get_entity_odata_h(entity:, expand: nil, uribase:)
-      hres = entity.casted_values
-      hres['__metadata'] = entity.metadata_h(uribase: uribase)
+        when :expand_c
+          arg.each do |attr, templ|
+            next unless  (encoll = entity.send(attr))
 
-      nav_values_h = {}
-      nav_coll_h = {}
+            #  nav attributes that are a collection (x..n)
+            hres[attr] = get_coll_odata_h(array: encoll, template: templ)
+            # else error ?
+          end
 
-      # handle expanded nav attributes
-      unless expand.nil?
-        handle_entity_expand(entity: entity, expand: expand,
-                             nav_values_h: nav_values_h,
-                             nav_coll_h: nav_coll_h,
-                             uribase: uribase)
+        when :deferr
+          euri = entity.uri
+          arg.each do |attr|
+            hres[attr] = get_deferred_odata_h(entity_uri: euri, attrib: attr)
+          end
+        end
       end
-
-      # handle not expanded (deferred) nav attributes
-      handle_entity_deferred_attribs(entity: entity,
-                                     nav_values_h: nav_values_h,
-                                     nav_coll_h: nav_coll_h,
-                                     uribase: uribase)
-      # merge  ...
-      hres.merge!(nav_values_h)
-      hres.merge!(nav_coll_h)
-
       hres
     end
   end
 end
 
-module OData
+module Safrano
   # xml namespace constants needed for the output of XML service and
   # and metadata
   module XMLNS
@@ -147,17 +102,18 @@ module OData
 end
 
 # Link to Model
-module OData
+module Safrano
   MAX_DATASERVICE_VERSION = '2'.freeze
   MIN_DATASERVICE_VERSION = '1'.freeze
+  CV_MAX_DATASERVICE_VERSION = Contract.valid(MAX_DATASERVICE_VERSION).freeze
+  CV_MIN_DATASERVICE_VERSION = Contract.valid(MIN_DATASERVICE_VERSION).freeze
   include XMLNS
   # Base class for service. Subclass will be for V1, V2 etc...
   class ServiceBase
     include Safrano
     include ExpandHandler
 
-    XML_PREAMBLE = '<?xml version="1.0" encoding="utf-8" standalone="yes"?>' + \
-                   "\r\n".freeze
+    XML_PREAMBLE = %Q(<?xml version="1.0" encoding="utf-8" standalone="yes"?>\r\n).freeze
 
     # This is just a hash of entity Set Names to the corresponding Class
     # Example
@@ -175,10 +131,14 @@ module OData
     attr_accessor :xname
     attr_accessor :xnamespace
     attr_accessor :xpath_prefix
-    #    attr_accessor :xuribase
+    attr_accessor :xserver_url
+    attr_accessor :uribase
     attr_accessor :meta
     attr_accessor :batch_handler
     attr_accessor :relman
+    attr_accessor :complex_types
+    attr_accessor :function_imports
+
     # Instance attributes for specialized Version specific Instances
     attr_accessor :v1
     attr_accessor :v2
@@ -192,36 +152,31 @@ module OData
       #  because of the version subclasses that dont use "super" initialise
       # (todo: why not??)
       @meta = ServiceMeta.new(self)
-      @batch_handler = OData::Batch::DisabledHandler.new
-      @relman = OData::RelationManager.new
+      @batch_handler = Safrano::Batch::DisabledHandler.new
+      @relman = Safrano::RelationManager.new
+      @complex_types = Set.new
+      @function_imports = {}
       @cmap = {}
       instance_eval(&block) if block_given?
     end
 
-    DATASERVICEVERSION_RGX = /\A([1234])(?:\.0);*\w*\z/.freeze
     TRAILING_SLASH = %r{/\z}.freeze
-    DEFAULT_PATH_PREFIX = '/'
-
-    # input is the       DataServiceVersion request header string, eg.
-    # '2.0;blabla' ---> Version -> 2
-    def self.parse_data_service_version(inp)
-      m = DATASERVICEVERSION_RGX.match(inp)
-      m[1] if m
-    end
+    DEFAULT_PATH_PREFIX = '/'.freeze
+    DEFAULT_SERVER_URL = 'http://localhost:9494'.freeze
 
     def enable_batch
-      @batch_handler = OData::Batch::EnabledHandler.new
+      @batch_handler = Safrano::Batch::EnabledHandler.new
       (@v1.batch_handler = @batch_handler) if @v1
       (@v2.batch_handler = @batch_handler) if @v2
     end
 
     def enable_v1_service
-      @v1 = OData::ServiceV1.new
+      @v1 = Safrano::ServiceV1.new
       copy_attribs_to @v1
     end
 
     def enable_v2_service
-      @v2 = OData::ServiceV2.new
+      @v2 = Safrano::ServiceV2.new
       copy_attribs_to @v2
     end
 
@@ -243,59 +198,91 @@ module OData
       (@v1.xpath_prefix = @xpath_prefix) if @v1
       (@v2.xpath_prefix = @xpath_prefix) if @v2
     end
+
+    def server_url(surl)
+      @xserver_url = surl.sub(TRAILING_SLASH, '')
+      (@v1.xserver_url = @xserver_url) if @v1
+      (@v2.xserver_url = @xserver_url) if @v2
+    end
+
     # end public API
 
+    def set_uribase
+      @uribase = if @xpath_prefix.empty?
+                   @xserver_url
+                 elsif @xpath_prefix[0] == '/'
+                   "#{@xserver_url}#{@xpath_prefix}"
+                 else
+                   "#{@xserver_url}/#{@xpath_prefix}"
+                 end
+      (@v1.uribase = @uribase) if @v1
+      (@v2.uribase = @uribase) if @v2
+    end
+
     def copy_attribs_to(other)
       other.cmap = @cmap
       other.collections = @collections
+      other.allowed_transitions = @allowed_transitions
       other.xtitle = @xtitle
       other.xname = @xname
       other.xnamespace = @xnamespace
       other.xpath_prefix = @xpath_prefix
+      other.xserver_url = @xserver_url
+      other.uribase = @uribase
       other.meta = ServiceMeta.new(other) # hum ... #todo: versions as well ?
       other.relman = @relman
       other.batch_handler = @batch_handler
+      other.complex_types = @complex_types
+      other.function_imports = @function_imports
       other
     end
 
+    # this is a central place. We extend Sequel models with OData functionality
+    # The included/extended modules depends on the properties(eg, pks, field types) of the model
+    # we differentiate
+    #  * Single/Multi PK
+    #  * Media/Non-Media entity
+    # Putting this logic here in modules loaded once on start shall result in less runtime overhead
     def register_model(modelklass, entity_set_name = nil, is_media = false)
       # check that the provided klass is a Sequel Model
-      unless modelklass.is_a? Sequel::Model::ClassMethods
-        raise OData::API::ModelNameError, modelklass
-      end
 
-      if modelklass.ancestors.include? OData::Entity
+      raise(Safrano::API::ModelNameError, modelklass) unless modelklass.is_a? Sequel::Model::ClassMethods
+
+      if modelklass.ancestors.include? Safrano::Entity
         # modules were already added previously;
         # cleanup state to avoid having data from previous calls
         # mostly usefull for testing (eg API)
         modelklass.reset
-      else # first API call... (normal non-testing case)
-        if modelklass.primary_key.is_a?(Array)
-          modelklass.extend OData::EntityClassMultiPK
-          modelklass.include OData::EntityMultiPK
-        else
-          modelklass.extend OData::EntityClassSinglePK
-          modelklass.include OData::EntitySinglePK
-        end
+      elsif modelklass.primary_key.is_a?(Array) # first API call... (normal non-testing case)
+        modelklass.extend Safrano::EntityClassMultiPK
+        modelklass.include Safrano::EntityMultiPK
+      else
+        modelklass.extend Safrano::EntityClassSinglePK
+        modelklass.include Safrano::EntitySinglePK
       end
+
       # Media/Non-media
       if is_media
-        modelklass.extend OData::EntityClassMedia
+        modelklass.extend Safrano::EntityClassMedia
         # set default media handler . Can be overridden later with the
         #  "use HandlerKlass, options" API
 
         modelklass.set_default_media_handler
         modelklass.api_check_media_fields
-        modelklass.include OData::MediaEntity
+        modelklass.include Safrano::MediaEntity
       else
-        modelklass.extend OData::EntityClassNonMedia
-        modelklass.include OData::NonMediaEntity
+        modelklass.extend Safrano::EntityClassNonMedia
+        modelklass.include Safrano::NonMediaEntity
       end
 
       modelklass.prepare_pk
       modelklass.prepare_fields
       esname = (entity_set_name || modelklass).to_s.freeze
-      modelklass.instance_eval { @entity_set_name = esname }
+      serv_namespace = @xnamespace
+      modelklass.instance_eval do
+        @entity_set_name = esname
+        @namespace = serv_namespace
+      end
       @cmap[esname] = modelklass
       set_collections_sorted(@cmap.values)
     end
@@ -316,6 +303,23 @@ module OData
       modelklass.deferred_iblock = block if block_given?
     end
 
+    def publish_complex_type(ctklass)
+      # check that the provided klass is a Safrano ComplexType
+
+      raise(Safrano::API::ComplexTypeNameError, ctklass) unless ctklass.superclass == Safrano::ComplexType
+
+      serv_namespace = @xnamespace
+      ctklass.instance_eval { @namespace = serv_namespace }
+
+      @complex_types.add ctklass
+    end
+
+    def function_import(name)
+      funcimp = Safrano::FunctionImport(name)
+      @function_imports[name] = funcimp
+      funcimp
+    end
+
     def cmap=(imap)
       @cmap = imap
       set_collections_sorted(@cmap.values)
@@ -326,15 +330,14 @@ module OData
     # example: CrewMember must be matched before Crew otherwise we get error
     def set_collections_sorted(coll_data)
       @collections = coll_data
-      if @collections
-        @collections.sort_by! { |klass| klass.entity_set_name.size }.reverse!
-      end
+      @collections.sort_by! { |klass| klass.entity_set_name.size }.reverse! if @collections
       @collections
     end
 
     # to be called at end of publishing block to ensure we get the right names
     # and additionally build the list of valid attribute path's used
     # for validation of $orderby or $filter params
+
     def finalize_publishing
       # build the cmap
       @cmap = {}
@@ -348,8 +351,32 @@ module OData
       # set default path prefix if path_prefix was not called
       path_prefix(DEFAULT_PATH_PREFIX) unless @xpath_prefix
 
-      # and finally build the path list
-      @collections.each(&:build_attribute_path_list)
+      # set default server url if server_url was not called
+      server_url(DEFAULT_SERVER_URL) unless @xserver_url
+
+      set_uribase
+
+      @collections.each(&:finalize_publishing)
+
+      # finalize the uri's and include NoMappingBeforeOutput or MappingBeforeOutput as needed
+      @collections.each do |klass|
+        klass.build_uri(@uribase)
+        klass.include(klass.time_cols.empty? ? Safrano::NoMappingBeforeOutput : Safrano::MappingBeforeOutput)
+      end
+
+      # build allowed transitions (requires that @collections are filled and sorted for having a
+      # correct base_url_regexp)
+      build_allowed_transitions
+
+      # mixin adapter specific modules where needed
+      case Sequel::Model.db.adapter_scheme
+      when :postgres
+        Safrano::Filter::FuncTree.include Safrano::Filter::FuncTreePostgres
+      when :sqlite
+        Safrano::Filter::FuncTree.include Safrano::Filter::FuncTreeSqlite
+      else
+        Safrano::Filter::FuncTree.include Safrano::Filter::FuncTreeDefault
+      end
     end
 
     def execute_deferred_iblocks
@@ -365,19 +392,24 @@ module OData
       @collections.map(&:entity_set_name).join('|')
     end
 
+    def base_url_func_regexp
+      @function_imports.keys.join('|')
+    end
+
     def service
       hres = {}
       hres['d'] = { 'EntitySets' => @collections.map(&:type_name) }
       hres
     end
 
-    def service_xml(req)
+    def service_xml(_req)
       doc = REXML::Document.new
       # separator required ? ?
-      root = doc.add_element('service', 'xml:base' => req.uribase)
+      root = doc.add_element('service', 'xml:base' => @uribase)
 
       root.add_namespace('xmlns:atom', XMLNS::W3_2005_ATOM)
       root.add_namespace('xmlns:app', XMLNS::W3_2007_APP)
+
       # this generates the main xmlns attribute
       root.add_namespace(XMLNS::W3_2007_APP)
       wp = root.add_element 'workspace'
@@ -388,7 +420,7 @@ module OData
       @collections.each do |klass|
         col = wp.add_element('collection', 'href' => klass.entity_set_name)
         ct = col.add_element('atom:title')
-        ct.text = klass.type_name
+        ct.text = klass.entity_set_name
       end
 
       XML_PREAMBLE + doc.to_pretty_xml
@@ -397,10 +429,18 @@ module OData
     def add_metadata_xml_entity_type(schema)
       @collections.each do |klass|
         enty = klass.add_metadata_rexml(schema)
-        klass.add_metadata_navs_rexml(enty, @cmap, @relman, @xnamespace)
+        klass.add_metadata_navs_rexml(enty, @relman)
       end
     end
 
+    def add_metadata_xml_complex_types(schema)
+      @complex_types.each { |ctklass| ctklass.add_metadata_rexml(schema)   }
+    end
+
+    def add_metadata_xml_function_imports(ec)
+      @function_imports.each_value { |func| func.add_metadata_rexml(ec)    }
+    end
+
     def add_metadata_xml_associations(schema)
       @relman.each_rel do |rel|
         rel.with_metadata_info(@xnamespace) do |name, bdinfo|
@@ -423,7 +463,7 @@ module OData
         # 3.a Entity set's
         ec.add_element('EntitySet',
                        'Name' => klass.entity_set_name,
-                       'EntityType' => "#{@xnamespace}.#{klass.type_name}")
+                       'EntityType' => klass.type_name)
       end
       # 3.b Association set's
       @relman.each_rel do |rel|
@@ -437,6 +477,9 @@ module OData
           assoc.add_element('End', assoend)
         end
       end
+
+      # 4 function imports
+      add_metadata_xml_function_imports(ec)
     end
 
     def metadata_xml(_req)
@@ -470,9 +513,12 @@ module OData
       schema = serv.add_element('Schema',
                                 'Namespace' => @xnamespace,
                                 'xmlns' => XMLNS::MSFT_ADO_2009_EDM)
-      # 1. all EntityType
+      # 1. a. all EntityType
       add_metadata_xml_entity_type(schema)
 
+      # 1. b. all ComplexType
+      add_metadata_xml_complex_types(schema)
+
       # 2. Associations
       add_metadata_xml_associations(schema)
 
@@ -485,19 +531,44 @@ module OData
     # methods related to transitions to next state (cf. walker)
     module Transitions
       DOLLAR_ID_REGEXP = Regexp.new('\A\/\$').freeze
+      ALLOWED_TRANSITIONS_FIXED = [
+        Safrano::TransitionEnd,
+        Safrano::TransitionMetadata,
+        Safrano::TransitionBatch,
+        Safrano::TransitionContentId
+      ].freeze
+
+      def build_allowed_transitions
+        @allowed_transitions = if @function_imports.empty?
+                                 (ALLOWED_TRANSITIONS_FIXED + [
+                                   Safrano::Transition.new(%r{\A/(#{base_url_regexp})(.*)},
+                                                           trans: 'transition_collection')
+                                 ]).freeze
+                               else
+                                 (ALLOWED_TRANSITIONS_FIXED + [
+                                   Safrano::Transition.new(%r{\A/(#{base_url_regexp})(.*)},
+                                                           trans: 'transition_collection'),
+                                   Safrano::Transition.new(%r{\A/(#{base_url_func_regexp})(.*)},
+                                                           trans: 'transition_service_op')
+                                 ]).freeze
+                               end
+      end
+
       def allowed_transitions
-        @allowed_transitions = [
-          Safrano::TransitionEnd,
-          Safrano::TransitionMetadata,
-          Safrano::TransitionBatch,
-          Safrano::TransitionContentId,
-          Safrano::Transition.new(%r{\A/(#{base_url_regexp})(.*)},
-                                  trans: 'transition_collection')
-        ]
+        @allowed_transitions
+      end
+
+      def thread_safe_collection(collklass)
+        Safrano::OData::Collection.new(collklass)
       end
 
       def transition_collection(match_result)
-        [@cmap[match_result[1]], :run] if match_result[1]
+        [thread_safe_collection(@cmap[match_result[1]]), :run] if match_result[1]
+        #        [@cmap[match_result[1]], :run] if match_result[1]
+      end
+
+      def transition_service_op(match_result)
+        [@function_imports[match_result[1]], :run] if match_result[1]
       end
 
       def transition_batch(_match_result)
@@ -513,7 +584,7 @@ module OData
       end
 
       def transition_end(_match_result)
-        [nil, :end]
+        Safrano::Transition::RESULT_END
       end
     end
 
@@ -521,14 +592,11 @@ module OData
 
     def odata_get(req)
       if req.accept?(APPXML)
-        #  app.headers  'Content-Type' => 'application/xml;charset=utf-8'
-        # Doc: 2.2.3.7.1 Service Document  As per [RFC5023], AtomPub Service
-        # Documents MUST be
-        # identified with the "application/atomsvc+xml" media type (see
-        # [RFC5023] section 8).
-        [200, CT_ATOMXML, [service_xml(req)]]
+        # OData V2 reference service implementations are returning app-xml-u8
+        # so we do
+        [200, CT_APPXML, [service_xml(req)]]
       else
-        # this is returned by http://services.odata.org/V2/OData/OData.svc
+        # this is returned by http://services.odata.org/V2/OData/Safrano.svc
         415
       end
     end
@@ -540,22 +608,22 @@ module OData
       @data_service_version = '1.0'
     end
 
-    def get_coll_odata_links_h(array:, uribase:, icount: nil)
+    def get_coll_odata_links_h(array:, icount: nil)
       array.map do |w|
-        get_entity_odata_link_h(entity: w, uribase: uribase)
+        get_entity_odata_link_h(entity: w)
       end
     end
 
-    def get_coll_odata_h(array:, expand: nil, uribase:, icount: nil)
-      array.map do |w|
+    def get_coll_odata_h(array:, template:, icount: nil)
+      array.map! do |w|
         get_entity_odata_h(entity: w,
-                           expand: expand,
-                           uribase: uribase)
+                           template: template)
       end
+      array
     end
 
     def get_emptycoll_odata_h
-      [{}]
+      EMPTY_HASH_IN_ARY
     end
   end
 
@@ -565,36 +633,37 @@ module OData
       @data_service_version = '2.0'
     end
 
-    def get_coll_odata_links_h(array:, uribase:, icount: nil)
+    def get_coll_odata_links_h(array:, icount: nil)
       res = array.map do |w|
-        get_entity_odata_link_h(entity: w, uribase: uribase)
+        get_entity_odata_link_h(entity: w)
       end
       if icount
-        { 'results' => res, '__count' => icount }
+        { RESULTS_K => res, COUNT_K => icount }
       else
-        { 'results' => res }
+        { RESULTS_K => res }
       end
     end
 
     def get_emptycoll_odata_h
-      { 'results' => [{}] }
+      { RESULTS_K => EMPTY_HASH_IN_ARY }
     end
   end
 
   # a virtual entity for the service metadata
   class ServiceMeta
     attr_accessor :service
+
     def initialize(service)
       @service = service
     end
 
+    ALLOWED_TRANSITIONS_FIXED = [Safrano::TransitionEnd].freeze
     def allowed_transitions
-      @allowed_transitions = [Safrano::Transition.new('',
-                                                      trans: 'transition_end')]
+      ALLOWED_TRANSITIONS_FIXED
     end
 
     def transition_end(_match_result)
-      [nil, :end]
+      Safrano::Transition::RESULT_END
     end
 
     def odata_get(req)