safer_rails_console 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ddf2baf69a61f2f36895b978b679d3a09b31fa4729ababd4d0dc05d367ee59e9
-  data.tar.gz: 7238b5a777c0d58b3b97a9cd21c99e18dd781cae0c40e7e6694bb0c2d079afb5
+  metadata.gz: 6caeae2629c2967125e660f9982a42cdcb8be7bfeda001ef4d749c48163327fe
+  data.tar.gz: 479df9dd872a07f3af1e743e787acc6689587ff686badcd8de9da40592b545d4
 SHA512:
-  metadata.gz: 29dde7221f4bdca3da031c93037cf445432dcadbcc06515e76ef83ad5a3a5e52e6687b3c4571c154d2d61588fb4ea1401f0d3de23053ca535346c914497742a5
-  data.tar.gz: 609e1dace181f8fde1542d01ef7899467587a4e7b38a457589e8b1db8383165f2e82a4d1d5aea08e2fa475e233a474037d3a8135281bc219aab081e5bb0e6555
+  metadata.gz: 689bfbb1b371f75543b4d724fc211c3da712f5c624df301446c83b327863ab9b24edfe50f824fbf4d287b645db334714c098c0643b62a5c8ae171992afc4da65
+  data.tar.gz: f24a500572bb7fec95dca9c875566da11eb77d3e4ba11070ff561eb8b6dedcbeff4254fef29f97a2f9d9637d1bf16b6e04f2558cda04213332a9d223afd52ee2

data/.circleci/config.yml

@@ -41,6 +41,11 @@ jobs:
           POSTGRES_USER: "circleci"
           POSTGRES_DB: "safer_rails_console_test"
           POSTGRES_HOST_AUTH_METHOD: "trust"
+      - image: cimg/mysql:8.0
+        environment:
+          MYSQL_DATABASE: "safer_rails_console_test"
+          MYSQL_ROOT_HOST: "%"
+          MYSQL_ALLOW_EMPTY_PASSWORD: "yes"
     working_directory: ~/safer_rails_console
     steps:
       - checkout
@@ -60,6 +65,9 @@ jobs:
           paths:
             - "vendor/bundle"
             - "gemfiles/vendor/bundle"
+      - run:
+          name: Wait for Mysql
+          command: dockerize -wait tcp://localhost:3306 -timeout 1m
       - run:
           name: Run Tests
           command: |

data/.gitignore

@@ -15,3 +15,5 @@
 /gemfiles/*.gemfile.lock
 out
 *.sqlite3
+
+.idea

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## v0.9.0
+- Add MySql support
+
 ## v0.8.0
 - Drop support for Ruby 2.7.
 - Drop support for Rails 6.0.

data/README.md

@@ -3,7 +3,7 @@
 [![Build Status](https://circleci.com/gh/salsify/safer_rails_console.svg?style=svg)](https://circleci.com/gh/salsify/safer_rails_console)
 [![Gem Version](https://badge.fury.io/rb/safer_rails_console.svg)](https://badge.fury.io/rb/safer_rails_console)
 
-This gem makes Rails console sessions less dangerous in specified environments by warning, color-coding, and auto-sandboxing PostgreSQL connections. In the future we'd like to extend this to make other external connections read-only too (e.g. disable job queueing, non-GET HTTP requests, etc.)
+This gem makes Rails console sessions less dangerous in specified environments by warning, color-coding, and auto-sandboxing PostgreSQL and MySQL connections. In the future we'd like to extend this to make other external connections read-only too (e.g. disable job queueing, non-GET HTTP requests, etc.)
 
 ## Installation
 

data/lib/safer_rails_console/patches/sandbox/auto_rollback.rb

@@ -11,8 +11,8 @@ module SaferRailsConsole
           connection.begin_db_transaction
         end
 
-        def self.handle_and_reraise_exception(error)
-          if error.message.include?('PG::ReadOnlySqlTransaction')
+        def self.handle_and_reraise_exception(error, message = 'PG::ReadOnlySqlTransaction')
+          if error.message.include?(message)
             puts SaferRailsConsole::Colors.color_text( # rubocop:disable Rails/Output
               'An operation could not be completed due to read-only mode.',
               SaferRailsConsole::Colors::RED
@@ -28,13 +28,27 @@ module SaferRailsConsole
           def execute_and_clear(...)
             super
           rescue StandardError => e
-            SaferRailsConsole::Patches::Sandbox::AutoRollback.handle_and_reraise_exception(e)
+            # rubocop:disable Layout/LineLength
+            SaferRailsConsole::Patches::Sandbox::AutoRollback.handle_and_reraise_exception(e, 'PG::ReadOnlySqlTransaction')
+            # rubocop:enable Layout/LineLength
           end
         end
 
         if defined?(::ActiveRecord::ConnectionAdapters::PostgreSQLAdapter)
           ::ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.prepend(PostgreSQLAdapterPatch)
         end
+
+        module MySQLPatch
+          def execute_and_free(...)
+            super
+          rescue StandardError => e
+            SaferRailsConsole::Patches::Sandbox::AutoRollback.handle_and_reraise_exception(e, 'READ ONLY transaction')
+          end
+        end
+
+        if defined?(::ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter)
+          ::ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter.prepend(MySQLPatch)
+        end
       end
     end
   end

data/lib/safer_rails_console/patches/sandbox/transaction_read_only.rb

@@ -11,6 +11,13 @@ module SaferRailsConsole
           end
         end
 
+        module MySQLPatch
+          def begin_db_transaction
+            execute 'SET TRANSACTION READ ONLY'
+            super
+          end
+        end
+
         if defined?(::ActiveRecord::ConnectionAdapters::PostgreSQLAdapter)
           ::ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.prepend(PostgreSQLAdapterPatch)
 
@@ -18,6 +25,13 @@ module SaferRailsConsole
           connection = ::ActiveRecord::Base.connection
           connection.execute 'SET TRANSACTION READ ONLY' if connection.open_transactions > 0
         end
+
+        if defined?(::ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter)
+          ::ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter.prepend(MySQLPatch)
+
+          # Not possible to change a running transaction to read-only in MySQL
+          # https://dev.mysql.com/doc/refman/8.4/en/set-transaction.html
+        end
       end
     end
   end

data/lib/safer_rails_console/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SaferRailsConsole
-  VERSION = '0.8.0'
+  VERSION = '0.9.0'
 end

data/safer_rails_console.gemspec

@@ -39,6 +39,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'climate_control', '~> 0.2.0'
   spec.add_development_dependency 'mixlib-shellout', '~> 2.2'
+  spec.add_development_dependency 'mysql2', '~> 0.5'
   spec.add_development_dependency 'overcommit', '~> 0.39.0'
   spec.add_development_dependency 'pg', '~> 1.1'
   spec.add_development_dependency 'rake', '~> 12.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: safer_rails_console
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Salsify, Inc
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-01-05 00:00:00.000000000 Z
+date: 2024-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.2'
+- !ruby/object:Gem::Dependency
+  name: mysql2
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: overcommit
   requirement: !ruby/object:Gem::Requirement