safemode 1.3.1 → 2.0.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -1,42 +1,179 @@
1
+ # frozen_string_literal: true
2
+
1
3
  require File.join(File.dirname(__FILE__), 'test_helper')
2
4
 
3
5
  class TestSafemodeParser < Test::Unit::TestCase
4
6
  def test_vcall_should_be_jailed
5
7
  assert_jailed 'to_jail.a.to_jail.class', 'a.class'
6
8
  end
7
-
9
+
8
10
  def test_call_should_be_jailed
9
11
  assert_jailed '(1.to_jail + 1).to_jail.class', '(1 + 1).class'
10
12
  end
11
-
13
+
12
14
  def test_estr_should_be_jailed
13
15
  assert_jailed '"#{1.to_jail.class}"', '"#{1.class}"'
14
16
  end
15
-
17
+
16
18
  def test_if_should_be_usable_for_erb
17
19
  assert_jailed "if true then\n 1\nend", "if true\n 1\n end"
18
20
  end
19
-
21
+
20
22
  def test_if_else_should_be_usable_for_erb
21
23
  assert_jailed "if true then\n 1\n else\n2\nend", "if true\n 1\n else\n2\n end"
22
24
  end
23
-
25
+
24
26
  def test_ternary_should_be_usable_for_erb
25
27
  assert_jailed "if true then\n 1\n else\n2\nend", "true ? 1 : 2"
26
28
  end
27
29
 
30
+ def test_call_with_shorthand
31
+ unsafe = <<~UNSAFE
32
+ a_keyword = true
33
+ @article.method_with_kwargs(a_keyword:)
34
+ UNSAFE
35
+ jailed = <<~JAILED
36
+ a_keyword = true
37
+ @article.to_jail.method_with_kwargs(a_keyword:)
38
+ JAILED
39
+ assert_jailed jailed, unsafe
40
+ end
41
+
42
+ def test_call_with_complex_args
43
+ unsafe = "kwargs = { b_keyword: false }; @article.method_with_kwargs('positional', a_keyword: true, **kwargs)"
44
+ jailed = "kwargs = { :b_keyword => false }\n@article.to_jail.method_with_kwargs(\"positional\", :a_keyword => true, **kwargs)\n"
45
+ assert_jailed jailed, unsafe
46
+ end
47
+
48
+ def test_safe_call_simple
49
+ assert_jailed '@article&.to_jail&.method', '@article&.method'
50
+ end
51
+
52
+ def test_safe_call_with_complex_args
53
+ unsafe = "kwargs = { b_keyword: false }; @article&.method_with_kwargs('positional', a_keyword: true, **kwargs)"
54
+ jailed = "kwargs = { :b_keyword => false }\n@article&.to_jail&.method_with_kwargs(\"positional\", :a_keyword => true, **kwargs)\n"
55
+ assert_jailed jailed, unsafe
56
+ end
57
+
28
58
  def test_output_buffer_should_be_assignable
29
59
  assert_nothing_raised do
30
60
  jail('@output_buffer = ""')
31
61
  end
32
62
  end
33
63
 
64
+ def test_block_pass_is_disabled
65
+ assert_raise Safemode::SecurityError do
66
+ jail('[].each(&:delete)')
67
+ end
68
+ end
69
+
70
+ def test_safe_attrasgn_is_disabled
71
+ assert_raise Safemode::SecurityError do
72
+ jail('@article&.title = "new_value"')
73
+ end
74
+ end
75
+
76
+ def test_safe_op_asgn2_is_allowed
77
+ assert_nothing_raised do
78
+ jail('@article&.title ||= "new_value"')
79
+ end
80
+ end
81
+
82
+ def test_lambda_is_disabled
83
+ assert_raise Safemode::SecurityError do
84
+ jail('-> { 1 }')
85
+ end
86
+ end
87
+
88
+ def test_case_in_with_literal
89
+ jailed = jail("case x; in 1; \"one\"; in 2; \"two\"; end")
90
+ assert_match(/in 1 then/, jailed)
91
+ assert_match(/in 2 then/, jailed)
92
+ assert_match(/to_jail\.x/, jailed)
93
+ end
94
+
95
+ def test_case_in_with_array_pattern
96
+ jailed = jail("case x; in [a, b]; a; end")
97
+ assert_match(/in \[a, b\] then/, jailed)
98
+ assert_no_match(/\^a/, jailed)
99
+ end
100
+
101
+ def test_case_in_with_hash_pattern
102
+ jailed = jail("case x; in {name:}; name; end")
103
+ assert_match(/in \{ name: \} then/, jailed)
104
+ assert_no_match(/\^name/, jailed)
105
+ end
106
+
107
+ def test_case_in_with_find_pattern
108
+ jailed = jail("case x; in [*, 2, *]; \"found\"; end")
109
+ assert_match(/in \[\*, 2, \*\] then/, jailed)
110
+ end
111
+
112
+ def test_case_in_pin_operator
113
+ jailed = jail("y = 1; case x; in ^y; true; end")
114
+ assert_match(/in \^y then/, jailed)
115
+ end
116
+
117
+ def test_case_in_body_does_not_pin_variables
118
+ jailed = jail("case x; in [a, b]; a; end")
119
+ lines = jailed.lines
120
+ body_start = lines.index { |l| l.match?(/^in \[/) } + 1
121
+ lines[body_start..].each { |line| assert_no_match(/\^[a-z]/, line) }
122
+ end
123
+
124
+ def test_case_in_multiple_clauses
125
+ jailed = jail("case x; in [a, b]; a; in {c:}; c; end")
126
+ assert_match(/in \[a, b\] then/, jailed)
127
+ assert_match(/in \{ c: \} then/, jailed)
128
+ end
129
+
130
+ def test_case_in_with_if_guard
131
+ jailed = jail("case x; in 1 if true; \"matched\"; end")
132
+ assert_match(/in 1 if true then/, jailed)
133
+ end
134
+
135
+ def test_case_in_with_unless_guard
136
+ jailed = jail("case x; in 1 unless false; \"matched\"; end")
137
+ assert_match(/in 1 unless false then/, jailed)
138
+ end
139
+
140
+ def test_case_in_guard_does_not_pin_variables
141
+ jailed = jail("case x; in [a, b] if a; a; end")
142
+ guard_line = jailed.lines.find { |l| l.match?(/^in \[/) }
143
+ assert_match(/if a then/, guard_line)
144
+ assert_no_match(/\^a/, guard_line)
145
+ end
146
+
147
+ def test_case_in_guard_jails_method_calls
148
+ jailed = jail('case x; in {name: n} if n.start_with?("a"); n; end')
149
+ assert_match(/if n\.to_jail\.start_with\?/, jailed)
150
+ end
151
+
152
+ def test_rightward_assignment
153
+ jailed = jail("x => a")
154
+ assert_match(/case to_jail\.x/, jailed)
155
+ assert_match(/in a then/, jailed)
156
+ end
157
+
158
+ def test_hash_shorthand_in_literal
159
+ jailed = jail("a = 1; b = 2; { a:, b: }")
160
+ assert_match(/a:,/, jailed)
161
+ end
162
+
163
+ def test_endless_range
164
+ assert_jailed "(1..)", "(1..)"
165
+ end
166
+
167
+ def test_beginless_range
168
+ assert_jailed "(..5)", "(..5)"
169
+ end
170
+
34
171
  private
35
-
172
+
36
173
  def assert_jailed(expected, code)
37
174
  assert_equal expected.gsub(' ', ''), jail(code).gsub(' ', '')
38
- end
39
-
175
+ end
176
+
40
177
  def jail(code)
41
178
  Safemode::Parser.jail(code)
42
179
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: safemode
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.3.1
4
+ version: 2.0.3
5
5
  platform: ruby
6
6
  authors:
7
7
  - Sven Fuchs
@@ -10,186 +10,126 @@ authors:
10
10
  - Kingsley Hendrickse
11
11
  - Ohad Levy
12
12
  - Dmitri Dolguikh
13
- autorequire:
14
13
  bindir: bin
15
14
  cert_chain: []
16
- date: 2017-02-13 00:00:00.000000000 Z
15
+ date: 2026-10-26 00:00:00.000000000 Z
17
16
  dependencies:
18
- - !ruby/object:Gem::Dependency
19
- name: sexp_processor
20
- requirement: !ruby/object:Gem::Requirement
21
- requirements:
22
- - - ">="
23
- - !ruby/object:Gem::Version
24
- version: 4.3.0
25
- type: :runtime
26
- prerelease: false
27
- version_requirements: !ruby/object:Gem::Requirement
28
- requirements:
29
- - - ">="
30
- - !ruby/object:Gem::Version
31
- version: 4.3.0
32
17
  - !ruby/object:Gem::Dependency
33
18
  name: ruby2ruby
34
19
  requirement: !ruby/object:Gem::Requirement
35
20
  requirements:
36
- - - ">="
21
+ - - "~>"
37
22
  - !ruby/object:Gem::Version
38
- version: 2.0.6
23
+ version: '2.4'
39
24
  type: :runtime
40
25
  prerelease: false
41
26
  version_requirements: !ruby/object:Gem::Requirement
42
27
  requirements:
43
- - - ">="
28
+ - - "~>"
44
29
  - !ruby/object:Gem::Version
45
- version: 2.0.6
30
+ version: '2.4'
46
31
  - !ruby/object:Gem::Dependency
47
- name: ruby_parser
32
+ name: prism
48
33
  requirement: !ruby/object:Gem::Requirement
49
34
  requirements:
50
- - - ">="
35
+ - - "~>"
51
36
  - !ruby/object:Gem::Version
52
- version: 3.2.0
37
+ version: '1.0'
53
38
  type: :runtime
54
39
  prerelease: false
55
40
  version_requirements: !ruby/object:Gem::Requirement
56
41
  requirements:
57
- - - ">="
58
- - !ruby/object:Gem::Version
59
- version: 3.2.0
60
- - !ruby/object:Gem::Dependency
61
- name: shoulda
62
- requirement: !ruby/object:Gem::Requirement
63
- requirements:
64
- - - ">="
65
- - !ruby/object:Gem::Version
66
- version: '0'
67
- type: :development
68
- prerelease: false
69
- version_requirements: !ruby/object:Gem::Requirement
70
- requirements:
71
- - - ">="
42
+ - - "~>"
72
43
  - !ruby/object:Gem::Version
73
- version: '0'
44
+ version: '1.0'
74
45
  - !ruby/object:Gem::Dependency
75
- name: rdoc
46
+ name: sexp_processor
76
47
  requirement: !ruby/object:Gem::Requirement
77
48
  requirements:
78
49
  - - "~>"
79
50
  - !ruby/object:Gem::Version
80
- version: '3.12'
81
- type: :development
51
+ version: '4.10'
52
+ type: :runtime
82
53
  prerelease: false
83
54
  version_requirements: !ruby/object:Gem::Requirement
84
55
  requirements:
85
56
  - - "~>"
86
57
  - !ruby/object:Gem::Version
87
- version: '3.12'
58
+ version: '4.10'
88
59
  - !ruby/object:Gem::Dependency
89
- name: bundler
60
+ name: rake
90
61
  requirement: !ruby/object:Gem::Requirement
91
62
  requirements:
92
63
  - - "~>"
93
64
  - !ruby/object:Gem::Version
94
- version: '1.0'
65
+ version: '13.4'
95
66
  type: :development
96
67
  prerelease: false
97
68
  version_requirements: !ruby/object:Gem::Requirement
98
69
  requirements:
99
70
  - - "~>"
100
71
  - !ruby/object:Gem::Version
101
- version: '1.0'
72
+ version: '13.4'
102
73
  - !ruby/object:Gem::Dependency
103
- name: jeweler
104
- requirement: !ruby/object:Gem::Requirement
105
- requirements:
106
- - - ">="
107
- - !ruby/object:Gem::Version
108
- version: '0'
109
- type: :development
110
- prerelease: false
111
- version_requirements: !ruby/object:Gem::Requirement
112
- requirements:
113
- - - ">="
114
- - !ruby/object:Gem::Version
115
- version: '0'
116
- - !ruby/object:Gem::Dependency
117
- name: rcov
74
+ name: rdoc
118
75
  requirement: !ruby/object:Gem::Requirement
119
76
  requirements:
120
- - - ">="
77
+ - - "~>"
121
78
  - !ruby/object:Gem::Version
122
- version: '0'
79
+ version: '7.2'
123
80
  type: :development
124
81
  prerelease: false
125
82
  version_requirements: !ruby/object:Gem::Requirement
126
83
  requirements:
127
- - - ">="
84
+ - - "~>"
128
85
  - !ruby/object:Gem::Version
129
- version: '0'
86
+ version: '7.2'
130
87
  - !ruby/object:Gem::Dependency
131
88
  name: simplecov
132
89
  requirement: !ruby/object:Gem::Requirement
133
90
  requirements:
134
- - - ">="
91
+ - - "~>"
135
92
  - !ruby/object:Gem::Version
136
- version: '0'
93
+ version: '0.22'
137
94
  type: :development
138
95
  prerelease: false
139
96
  version_requirements: !ruby/object:Gem::Requirement
140
97
  requirements:
141
- - - ">="
98
+ - - "~>"
142
99
  - !ruby/object:Gem::Version
143
- version: '0'
100
+ version: '0.22'
144
101
  - !ruby/object:Gem::Dependency
145
102
  name: test-unit
146
103
  requirement: !ruby/object:Gem::Requirement
147
104
  requirements:
148
- - - ">="
149
- - !ruby/object:Gem::Version
150
- version: '0'
151
- type: :development
152
- prerelease: false
153
- version_requirements: !ruby/object:Gem::Requirement
154
- requirements:
155
- - - ">="
156
- - !ruby/object:Gem::Version
157
- version: '0'
158
- - !ruby/object:Gem::Dependency
159
- name: rake
160
- requirement: !ruby/object:Gem::Requirement
161
- requirements:
162
- - - ">="
105
+ - - "~>"
163
106
  - !ruby/object:Gem::Version
164
- version: '0'
107
+ version: '3.7'
165
108
  type: :development
166
109
  prerelease: false
167
110
  version_requirements: !ruby/object:Gem::Requirement
168
111
  requirements:
169
- - - ">="
112
+ - - "~>"
170
113
  - !ruby/object:Gem::Version
171
- version: '0'
114
+ version: '3.7'
172
115
  description: A library for safe evaluation of Ruby code based on RubyParser and Ruby2Ruby.
173
116
  Provides Rails ActionView template handlers for ERB and Haml.
174
- email: ohadlevy@gmail.com
175
117
  executables: []
176
118
  extensions: []
177
119
  extra_rdoc_files:
120
+ - LICENSE
178
121
  - README.markdown
179
122
  files:
180
123
  - Gemfile
181
- - LICENCSE
124
+ - LICENSE
182
125
  - README.markdown
183
126
  - Rakefile
184
- - VERSION
185
127
  - demo.rb
186
128
  - init.rb
187
129
  - lib/action_view/template_handlers/safe_erb.rb
188
130
  - lib/action_view/template_handlers/safe_haml.rb
189
131
  - lib/action_view/template_handlers/safemode_handler.rb
190
132
  - lib/haml/safemode.rb
191
- - lib/ruby_parser_string_io_patch.diff
192
- - lib/rubyparser_bug.rb
193
133
  - lib/safemode.rb
194
134
  - lib/safemode/blankslate.rb
195
135
  - lib/safemode/core_ext.rb
@@ -200,15 +140,16 @@ files:
200
140
  - lib/safemode/scope.rb
201
141
  - safemode.gemspec
202
142
  - test/test_erb_eval.rb
143
+ - test/test_for_loop_jail.rb
203
144
  - test/test_helper.rb
204
145
  - test/test_jail.rb
146
+ - test/test_parser_node_allowlist.rb
205
147
  - test/test_safemode_eval.rb
206
148
  - test/test_safemode_parser.rb
207
- homepage: http://github.com/svenfuchs/safemode
149
+ homepage: https://github.com/svenfuchs/safemode
208
150
  licenses:
209
151
  - MIT
210
152
  metadata: {}
211
- post_install_message:
212
153
  rdoc_options: []
213
154
  require_paths:
214
155
  - lib
@@ -216,17 +157,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
216
157
  requirements:
217
158
  - - ">="
218
159
  - !ruby/object:Gem::Version
219
- version: '0'
160
+ version: '3.0'
161
+ - - "<"
162
+ - !ruby/object:Gem::Version
163
+ version: '3.4'
220
164
  required_rubygems_version: !ruby/object:Gem::Requirement
221
165
  requirements:
222
166
  - - ">="
223
167
  - !ruby/object:Gem::Version
224
168
  version: '0'
225
169
  requirements: []
226
- rubyforge_project:
227
- rubygems_version: 2.6.10
228
- signing_key:
170
+ rubygems_version: 4.0.20
229
171
  specification_version: 4
230
- summary: A library for safe evaluation of Ruby code based on ParseTree/RubyParser
231
- and Ruby2Ruby
172
+ summary: A library for safe evaluation of Ruby code based on Prism and Ruby2Ruby
232
173
  test_files: []
data/VERSION DELETED
@@ -1 +0,0 @@
1
- 1.3.1
@@ -1,194 +0,0 @@
1
- --- lib/ruby_lexer.rb 2008-04-27 01:07:24.000000000 +0200
2
- +++ lib/ruby_lexer.rb 2008-04-27 01:07:03.000000000 +0200
3
- @@ -45,7 +45,7 @@
4
- raise "bad val: #{str.inspect}" unless String === str
5
-
6
- self.file = file
7
- - self.lexer.src = StringIO.new(str)
8
- + self.lexer.src = RubyParser::StringIO.new(str)
9
-
10
- @yydebug = ENV.has_key? 'DEBUG'
11
-
12
- @@ -2604,104 +2604,106 @@
13
- end
14
- end
15
-
16
- -class StringIO # HACK: everything in here is a hack
17
- - attr_accessor :begin_of_line, :was_begin_of_line
18
- - alias :begin_of_line? :begin_of_line
19
- - alias :read_all :read
20
- +class RubyParser
21
- + class StringIO < StringIO # HACK: everything in here is a hack
22
- + attr_accessor :begin_of_line, :was_begin_of_line
23
- + alias :begin_of_line? :begin_of_line
24
- + alias :read_all :read
25
-
26
- - alias :old_initialize :initialize
27
- + alias :old_initialize :initialize
28
-
29
- - def initialize(*args)
30
- - self.begin_of_line = true
31
- - self.was_begin_of_line = false
32
- - old_initialize(*args)
33
- - @original_string = self.string.dup
34
- - end
35
- + def initialize(*args)
36
- + self.begin_of_line = true
37
- + self.was_begin_of_line = false
38
- + old_initialize(*args)
39
- + @original_string = self.string.dup
40
- + end
41
-
42
- - def rest
43
- - self.string[self.pos..-1]
44
- - end
45
- + def rest
46
- + self.string[self.pos..-1]
47
- + end
48
-
49
- - def current_line # HAHA fuck you
50
- - @original_string[0..self.pos][/\A.*__LINE__/m].split(/\n/).size
51
- - end
52
- + def current_line # HAHA fuck you
53
- + @original_string[0..self.pos][/\A.*__LINE__/m].split(/\n/).size
54
- + end
55
-
56
- - def read
57
- - c = self.getc
58
- + def read
59
- + c = self.getc
60
-
61
- - if c == ?\r then
62
- - d = self.getc
63
- - self.ungetc d if d and d != ?\n
64
- - c = ?\n
65
- - end
66
- + if c == ?\r then
67
- + d = self.getc
68
- + self.ungetc d if d and d != ?\n
69
- + c = ?\n
70
- + end
71
-
72
- - self.was_begin_of_line = self.begin_of_line
73
- - self.begin_of_line = c == ?\n
74
- - if c and c != 0 then
75
- - c.chr
76
- - else
77
- - ::RubyLexer::EOF
78
- + self.was_begin_of_line = self.begin_of_line
79
- + self.begin_of_line = c == ?\n
80
- + if c and c != 0 then
81
- + c.chr
82
- + else
83
- + ::RubyLexer::EOF
84
- + end
85
- end
86
- - end
87
-
88
- - def match_string term, indent=false # TODO: add case insensitivity, or just remove
89
- - buffer = []
90
- + def match_string term, indent=false # TODO: add case insensitivity, or just remove
91
- + buffer = []
92
-
93
- - if indent
94
- - while c = self.read do
95
- - if c !~ /\s/ or c == "\n" or c == "\r" then
96
- - self.unread c
97
- - break
98
- + if indent
99
- + while c = self.read do
100
- + if c !~ /\s/ or c == "\n" or c == "\r" then
101
- + self.unread c
102
- + break
103
- + end
104
- + buffer << c
105
- end
106
- - buffer << c
107
- end
108
- - end
109
-
110
- - term.each_byte do |c2|
111
- - c = self.read
112
- - c = self.read if c and c == "\r"
113
- - buffer << c
114
- - if c and c2 != c[0] then
115
- - self.unread_many buffer.join # HACK omg
116
- - return false
117
- + term.each_byte do |c2|
118
- + c = self.read
119
- + c = self.read if c and c == "\r"
120
- + buffer << c
121
- + if c and c2 != c[0] then
122
- + self.unread_many buffer.join # HACK omg
123
- + return false
124
- + end
125
- end
126
- +
127
- + return true
128
- end
129
-
130
- - return true
131
- - end
132
- + def read_line
133
- + self.begin_of_line = true
134
- + self.was_begin_of_line = false
135
- + gets.sub(/\r\n?$/, "\n") # HACK
136
- + end
137
-
138
- - def read_line
139
- - self.begin_of_line = true
140
- - self.was_begin_of_line = false
141
- - gets.sub(/\r\n?$/, "\n") # HACK
142
- - end
143
- -
144
- - def peek expected = nil # FIX: barf
145
- - c = self.getc
146
- - return RubyLexer::EOF if c.nil?
147
- - self.ungetc c if c
148
- - c = c.chr if c
149
- - if expected then
150
- - c == expected
151
- - else
152
- - c
153
- + def peek expected = nil # FIX: barf
154
- + c = self.getc
155
- + return RubyLexer::EOF if c.nil?
156
- + self.ungetc c if c
157
- + c = c.chr if c
158
- + if expected then
159
- + c == expected
160
- + else
161
- + c
162
- + end
163
- end
164
- - end
165
-
166
- - def unread(c)
167
- - return if c.nil? # UGH
168
- + def unread(c)
169
- + return if c.nil? # UGH
170
-
171
- - # HACK: only depth is 2... who cares? really I want to remove all of this
172
- - self.begin_of_line = self.was_begin_of_line || true
173
- - self.was_begin_of_line = nil
174
- + # HACK: only depth is 2... who cares? really I want to remove all of this
175
- + self.begin_of_line = self.was_begin_of_line || true
176
- + self.was_begin_of_line = nil
177
-
178
- - c = c[0] if String === c
179
- - self.ungetc c
180
- - end
181
- + c = c[0] if String === c
182
- + self.ungetc c
183
- + end
184
-
185
- - def unread_many str
186
- - str.split(//).reverse.each do |c|
187
- - unread c
188
- + def unread_many str
189
- + str.split(//).reverse.each do |c|
190
- + unread c
191
- + end
192
- end
193
- end
194
- end
@@ -1,8 +0,0 @@
1
- require 'rubygems'
2
- require 'ruby2ruby'
3
-
4
- sexp = ParseTree.translate('a')
5
- puts Ruby2Ruby.new.process(sexp)
6
-
7
- # should work, but yields:
8
- # UnknownNodeError: Bug! Unknown node-type :vcall to Ruby2Ruby
File without changes