safe_update 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 76e32c112b1472705905d9ee7da198eb56be4a39
-  data.tar.gz: 005240cf53a0e77b505ea876531c9ac91295ec76
+  metadata.gz: e95adcf65e5d5aa163064c2172366ce50f852b0b
+  data.tar.gz: 366a3554dfd2ca55f796946a1a1997402a608309
 SHA512:
-  metadata.gz: 53e735d64c14e5e403bc160deefab71cd09eff6686b666515261a70b5189333d7cfbda62c69fd1292f179f1834805a139369a5963776d3ef32799afc7c5666bc
-  data.tar.gz: f9f836d155ced363c29a8e89bdf59cca3faab248dadb0c61f64db04564f479f2eb1a1ad140f644deef1f7d503a003dc76d05f5862496e9edf15017a641520792
+  metadata.gz: dc1b7b38c84282724216b0eaf24c469acb4fc9e93720d464d5f8d0cb75cd73014f3d7651e6b500fd6c939619b472b526fa338f561fb3f4f3f4527eb01cb83b37
+  data.tar.gz: b60ad414fcf497af52f900269e5ede3f2875dea2692312e1290377772c1e6891d8ba8007183c233d2d28fafa9cbdc75295dd885c3bf0d07fccc2ce6589cfad0c

data/README.md

@@ -56,9 +56,9 @@ FINISHED
 
 I've knocked this up really quickly, and it's pretty MVP-ish. Ideas for future include:
 
-- run your tests each update, and don't update problem gems
-- specify what update sizes you want to apply (major, minor, patch)
-- summary of what's happened at the end (eg. 2 major updates ignored, 5 minor updates applied, etc)
+- run your tests each update, and don't update problem gems.
+- specify what update sizes you want to apply (major, minor, patch); for now you need to rely on the [Gemfile version specifiers](http://bundler.io/gemfile.html).
+- summary of what's happened at the end (eg. 2 major updates ignored, 5 minor updates applied, etc).
 - other ideas? Open an issue.
 
 ## Development

data/lib/safe_update/outdated_gem.rb

@@ -7,7 +7,9 @@ module SafeUpdate
     # or. react-rails (newest 1.6.0, installed 1.5.0)
     def initialize(line)
       @line = line
-      raise "Unexpected output from `bundle outdated --parseable`: #{@line}" unless name.to_s.length > 0
+      if name.to_s.empty?
+        fail "Unexpected output from `bundle outdated --parseable`: #{@line}"
+      end
     end
 
     def update
@@ -16,10 +18,10 @@ module SafeUpdate
       puts "   Newest: #{newest}. "
       puts "Installed: #{installed}."
       puts "Running `bundle update #{name}`..."
-      %x(bundle update #{name})
+      `bundle update #{name}`
       puts "committing changes (message: '#{commit_message}')..."
-      %x(git add -A)
-      %x(git commit -m '#{commit_message}')
+      `git add Gemfile.lock`
+      `git commit -m '#{commit_message}'`
     end
 
     def name
@@ -45,7 +47,7 @@ module SafeUpdate
     private
 
     def commit_message
-      "ran: bundle update #{name}"
+      "update gem: #{name}"
     end
 
     # returns the section of string that resides between marker1 and marker2

data/lib/safe_update/updater.rb

@@ -1,6 +1,8 @@
 module SafeUpdate
   class Updater
     def run
+      check_for_staged_changes
+      check_for_gemfile_lock_changes
       output_array = bundle_outdated_parseable.split(/\n+/)
       output_array.each do |line|
         OutdatedGem.new(line).update
@@ -10,17 +12,37 @@ module SafeUpdate
       puts 'FINISHED'
     end
 
+    private
+
     def bundle_outdated_parseable
-      output = %x(bundle outdated --parseable)
+      output = `bundle outdated --parseable`
       if output.strip == "Unknown switches '--parseable'"
         # pre-1.12.0 version of bundler
-        output = %x(bundle outdated)
+        output = `bundle outdated`
         output.gsub!(/(\n|.)*Outdated gems included in the bundle:/, '')
         output.gsub!(/  \* /, '')
         output.gsub!(/ in group.*/, '')
       end
 
-      return output.strip
+      output.strip
+    end
+
+    def check_for_staged_changes
+      result = `git diff --name-only --cached`
+      if result.strip.length > 0
+        puts 'You have staged changes in git.'
+        puts 'Please commit or stash your changes before running safe_update'
+        exit 1
+      end
+    end
+
+    def check_for_gemfile_lock_changes
+      result = `git diff --name-only`
+      if result.include? 'Gemfile.lock'
+        puts 'You have uncommitted changes in your Gemfile.lock.'
+        puts 'Please commit or stash your changes before running safe_update'
+        exit 1
+      end
     end
   end
-end
+end

data/lib/safe_update/version.rb

@@ -1,3 +1,3 @@
 module SafeUpdate
-  VERSION = "0.1.0"
+  VERSION = '0.1.1'
 end

data/lib/safe_update.rb

@@ -5,9 +5,9 @@
 lib = File.expand_path('../../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
-require "safe_update/version"
-require "safe_update/updater"
-require "safe_update/outdated_gem"
+require 'safe_update/version'
+require 'safe_update/updater'
+require 'safe_update/outdated_gem'
 
 module SafeUpdate
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: safe_update
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Joshua Paling
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-02-29 00:00:00.000000000 Z
+date: 2016-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler