safe_redirection 0.0.1 → 0.0.2

data/lib/safe_redirection/constants.rb

@@ -1,3 +1,3 @@
 module SafeRedirection
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

data/lib/safe_redirection/sanitizer.rb

@@ -20,7 +20,8 @@ module SafeRedirection
     end
 
     def base_path
-      URI(base_url).path
+      match_data = URI(base_url).path.match(/((.*)(\/)|(.+))$/)
+      match_data[2] || match_data[4]
     end
 
     def relative_path(path)

data/spec/lib/safe_redirection/sanitizer_spec.rb

@@ -13,18 +13,18 @@ describe SafeRedirection::Sanitizer do
       let(:params) { { :controller => 'home', :action => 'valid' } }
 
       it "should return this very URL" do
-        resolver.should_receive(:recognize_path).with('valid', anything).and_return(params)
+        resolver.should_receive(:recognize_path).with('/valid', anything).and_return(params)
         subject.safe_url_for(valid_url).should == params
       end
     end
 
     context "with an invalid URL" do
       it "should return the default URL" do
-        resolver.should_receive(:recognize_path).with('rubbish', anything).and_raise('ActionController::RoutingError')
+        resolver.should_receive(:recognize_path).with('/rubbish', anything).and_raise('ActionController::RoutingError')
         subject.safe_url_for("http://test.tld/rubbish").should == default_url
       end
 
-      it "should return the default URL with a non-HTTP(s) scheme" do
+      it "should return the default URL with a non-HTTP(S) scheme" do
         subject.safe_url_for("ftp://test.tld/").should == default_url
       end
     end
@@ -33,17 +33,29 @@ describe SafeRedirection::Sanitizer do
       let(:base_url) { "http://test.tld/some/path/" }
 
       it "should try to resolve the subpath" do
-        resolver.should_receive(:recognize_path).with('subpath', anything)
+        resolver.should_receive(:recognize_path).with('/subpath', anything)
         subject.safe_url_for('http://test.tld/some/path/subpath')
       end
     end
   end
 
+  describe "#base_path" do
+    context "with a trailing slash" do
+      let(:base_url) { "http://test.tld/some/path/" }
+      its(:base_path) { should == "/some/path" }
+    end
+
+    context "without a trailing slash" do
+      let(:base_url) { "http://test.tld/some/path" }
+      its(:base_path) { should == "/some/path" }
+    end
+  end
+
   describe "#relative_path" do
     let(:base_url) { "http://test.tld/in/so.me/path/" }
 
     it "should strip the base path" do
-      subject.relative_path('/in/so.me/path/subpath').should == 'subpath'
+      subject.relative_path('/in/so.me/path/subpath').should == '/subpath'
     end
 
     it "should not strip it if it's not in the beginning" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: safe_redirection
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-12 00:00:00.000000000 Z
+date: 2012-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -104,5 +104,5 @@ rubyforge_project:
 rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
-summary: safe_redirection-0.0.1
+summary: safe_redirection-0.0.2
 test_files: []