safe_redirect 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9b628c68916ed992402ee971523c5937b30538de
-  data.tar.gz: c497d1e8882776fe69f94f8d6095567e76d12036
+  metadata.gz: def94975a8c7c916dbf8d0a1f515d6c326648e11
+  data.tar.gz: d3dba9b3db5f6976130deb2c84fcdb985382bc0f
 SHA512:
-  metadata.gz: 10e83cc957953e5ac78ea5e892ca18b01270663b8afbca3805df74880a62071e98ab3c5e4a919da994adadd882d018f45f4210fbde7d830831d6ee5db043d2a6
-  data.tar.gz: 1a2c4f2755aee51acbeee1014a55246568b4711cfde312b6d49b8a91f6e3dc9e4a2c99209016833f9ac1fc11fe61de51742e7140bb3367e6ad278dd81041057a
+  metadata.gz: af3862f529a3febcabe1e5e39452dc082c9ee4c82b34c25d08109fdfa3d7ea4e8f994169357a1edd666e1d0ac2aec3eec1264d72fcb08bff8d923992ac9f0d2f
+  data.tar.gz: af9e318bcfe8b2ee50678546b209fa68295f937a4359bd0acece8297a6ae674811e4b6b386ad19a977f8dff6c3270659e56c48ee3c2c43fd523aa57f79b5d63c

data/lib/safe_redirect/safe_redirect.rb

@@ -2,20 +2,16 @@ module SafeRedirect
   def safe_domain?(path)
     path =~ /^\// && !(path =~ /^\/\/+/)  ||
     SafeRedirect.configuration.domain_whitelists.any? do |w|
-      path =~ /^https?:\/\/#{w}($|\/.*)/
+      path =~ /^https?:\/\/#{w}($|\/.*)/i
     end
   end
 
   def safe_path(path)
-    if path.kind_of?(String)
-      stripped_path = path.strip
-      if safe_domain?(stripped_path)
-        stripped_path
-      else
-        stripped_path.gsub!(/https?:\/\/[a-z0-9\-\.:@]*/i, '')
-        stripped_path.gsub!(/^(data:|javascript:|\.|\/\/|@)+/i, '')
-        stripped_path
-      end
+    case
+    when path.kind_of?(String)
+      clean_path(path)
+    when path.kind_of?(Symbol)
+      path
     else
       SafeRedirect.configuration.default_path
     end
@@ -25,4 +21,15 @@ module SafeRedirect
     super safe_path(path), options
   rescue NoMethodError
   end
-end
+
+  private
+
+  def clean_path(path)
+    stripped_path = path.strip
+    unless safe_domain?(stripped_path)
+      stripped_path.gsub!(/https?:\/\/[a-z0-9\-\.:@]*/i, '')
+      stripped_path.gsub!(/^(data:|javascript:|\.|\/\/|@)+/i, '')
+    end
+    stripped_path
+  end
+end

data/lib/safe_redirect/version.rb

@@ -1,3 +1,3 @@
 module SafeRedirect
-  VERSION = '0.1.2'
-end
+  VERSION = '0.1.3'
+end

data/spec/lib/safe_redirect/configuration_spec.rb

@@ -6,7 +6,7 @@ module SafeRedirect
       reset_config
     end
 
-    it "default default_path is '/'" do
+    it "default default_path is /" do
       expect(SafeRedirect.configuration.default_path).to eq('/')
     end
 
@@ -28,4 +28,4 @@ module SafeRedirect
       expect(SafeRedirect.configuration.domain_whitelists).to eq(['www.bukalapak.com'])
     end
   end
-end
+end

data/spec/lib/safe_redirect/safe_redirect_spec.rb

@@ -46,6 +46,10 @@ module SafeRedirect
       expect(Controller.safe_path('http://www.twitter.com')).to eq('http://www.twitter.com')
     end
 
+    it "considers :back a safe path" do
+      expect(Controller.safe_path(:back)).to eq(:back)
+    end
+
     it "considers https://www.bukalapak.com@google.com an unsafe path" do
       expect(Controller.safe_path('https://www.bukalapak.com@google.com')).to eq('')
     end
@@ -58,4 +62,4 @@ module SafeRedirect
       Controller.redirect_to '/', notice: 'Back to home page'
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: safe_redirect
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Edwin Tunggawan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-03 00:00:00.000000000 Z
+date: 2016-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec