safe_attributes 1.0.3 → 1.0.4

data/README.rdoc

@@ -62,6 +62,11 @@ without issue using the recommended approach above.
 
 == Using
 
+=== Ruby
+
+Both Ruby 1.8.7 and Ruby 1.9.2 have been tested to work with this gem as
+of version 1.0.4 of SafeAttributes.
+
 === Rails
 Add safe_attributes to your Gemfile.
 

data/VERSION

@@ -1 +1 @@
-1.0.3
+1.0.4

data/lib/safe_attributes.rb

@@ -12,11 +12,11 @@ module SafeAttributes
     #
     def bad_attribute_names(*attrs)
       @bad_attribute_names ||= lambda {
-        methods = Array.new(attrs.collect { |x| x.to_s })
-        methods += ActiveRecord::Base.public_instance_methods
-        methods += ActiveRecord::Base.protected_instance_methods
-        methods += ActiveRecord::Base.private_instance_methods
-        methods -= ['id']
+        methods = Array.new(attrs.collect { |x| x.to_sym })
+        methods += ActiveRecord::Base.public_instance_methods.collect { |x| x.to_sym }
+        methods += ActiveRecord::Base.protected_instance_methods.collect { |x| x.to_sym }
+        methods += ActiveRecord::Base.private_instance_methods.collect { |x| x.to_sym }
+        methods -= [:id]
         return methods
       }.call
     end
@@ -27,7 +27,7 @@ module SafeAttributes
     # bad names
     #
     def define_method_attribute(attr_name)
-      return if (bad_attribute_names.include?(attr_name))
+      return if (bad_attribute_names.include?(attr_name.to_sym))
       super(attr_name)
     end
 
@@ -38,7 +38,7 @@ module SafeAttributes
     #
     def define_method_attribute=(attr_name)
       method = attr_name + '='
-      return if (bad_attribute_names.include?(method))
+      return if (bad_attribute_names.include?(method.to_sym))
       super(attr_name)
     end
   end

data/safe_attributes.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{safe_attributes}
-  s.version = "1.0.3"
+  s.version = "1.0.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Brian Jones"]
-  s.date = %q{2011-02-01}
+  s.date = %q{2011-02-04}
   s.description = %q{Better support for legacy database schemas for ActiveRecord, such as columns named class, or any other name that conflicts with an instance method of ActiveRecord.}
   s.email = %q{cbj@gnu.org}
   s.extra_rdoc_files = [

data/spec/safe_attributes/safe_attributes_spec.rb

@@ -40,33 +40,33 @@ describe MyModel do
   end
 
   it "defines class=()" do
-    @model.respond_to?('class=') # to force method generation
-    @model.methods.include?('class=').should be_true
+    @model.respond_to?(:class=) # to force method generation
+    (@model.methods.include?('class=') || @model.methods.include?(:class=)).should be_true
   end
 
   it "does not define bad_attribute()" do
-    @model.respond_to?('bad_attribute') # to force method generation
-    @model.methods.include?('bad_attribute').should be_false
+    @model.respond_to?(:bad_attribute) # to force method generation
+    (@model.methods.include?('bad_attribute') || @model.methods.include?(:bad_attribute)).should be_false
   end
 
   it "does not define bad_attribute=()" do
-    @model.respond_to?('bad_attribute=') # to force method generation
-    @model.methods.include?('bad_attribute=').should be_false
+    @model.respond_to?(:bad_attribute=) # to force method generation
+    (@model.methods.include?('bad_attribute=') || @model.methods.include?(:bad_attribute=)).should be_false
   end
 
   it "does define good_attribute()" do
-    @model.respond_to?('good_attribute') # to force method generation
-    @model.methods.include?('good_attribute').should be_true
+    @model.respond_to?(:good_attribute) # to force method generation
+    (@model.methods.include?('good_attribute') || @model.methods.include?(:good_attribute)).should be_true
   end
 
   it "does define good_attribute=()" do
-    @model.respond_to?('good_attribute=') # to force method generation
-    @model.methods.include?('good_attribute=').should be_true
+    @model.respond_to?(:good_attribute=) # to force method generation
+    (@model.methods.include?('good_attribute=') || @model.methods.include?(:good_attribute=)).should be_true
   end
 
   it "does define id()" do
-    @model.respond_to?('id') # to force method generation
-    @model.methods.include?('id').should be_true
+    @model.respond_to?(:id) # to force method generation
+    (@model.methods.include?('id') || @model.methods.include?(:id)).should be_true
   end
 
   it "can create instance in database with special attribute name" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: safe_attributes
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 31
   prerelease: false
   segments: 
   - 1
   - 0
-  - 3
-  version: 1.0.3
+  - 4
+  version: 1.0.4
 platform: ruby
 authors: 
 - Brian Jones
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-02-01 00:00:00 -05:00
+date: 2011-02-04 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency