safe-pg-migrations 1.2.3 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b01cc2376f8bcfa1908bdc642a51bd444420540eef7aa01dc403f13ea0b19c8
-  data.tar.gz: 0c09d3bc52ce84542fd50b119cef667714a6058d5fcf59f1be83af72318b3862
+  metadata.gz: 9d05d2e6c8647af8e618652235043dfde1b104065e71113f9f55c25117dd6ab6
+  data.tar.gz: 1f67d82d62855e6566f39c92b3cfdf4e9d6f68cc2bd0b9105c3e61ba32fd8ddf
 SHA512:
-  metadata.gz: f7a822bbb6cc2e924c8da76ca1501cec16588b4972e850fd07e7fbc120e159dfef715a8293c3399454aa9072e2cc6c2da8927e6dc84f15c72670bb16182fe53c
-  data.tar.gz: 4821e1fb76ce6e868a2032eb0e53aceea8f745f31fce521333949c20143150bd03950187d7286d63d1d9c7269b6015f8b9be8e38833d3e6df659f2f8e5940902
+  metadata.gz: daeed81cfc524ad80427179930e86b9ba71d4743e390dc8c5ce805d01ea3fdbb9866c30707f76d6b7578c9370b9761564b784813f165c52e1512afdffd9d74ed
+  data.tar.gz: cb4346bcaf47707bb811cefcace498683f63a7854d80c47487dac462b1e79ec62ee702a75fd18985b114a0ab4b69a8863274eb2af86517f166f50795dff3cc55

data/README.md

@@ -2,6 +2,8 @@
 
 ActiveRecord migrations for Postgres made safe.
 
+![safe-pg-migrations](./logo.png)
+
 ## Requirements
 
 - Ruby 2.5+
@@ -91,7 +93,7 @@ When **Safe PG Migrations** is used, migrations are not wrapped in a transaction
 - In order to be able to retry statements that have failed because of a lock timeout, we have to be outside a transaction.
 - In order to add an index concurrently, we have to be outside a transaction.
 
-Note that if a migration fails, it won't be rollbacked. This can result in migrations being partially applied. In that case, they need to be manually reverted.
+Note that if a migration fails, it won't be rolled back. This can result in migrations being partially applied. In that case, they need to be manually reverted.
 
 </details>
 
@@ -108,7 +110,7 @@ PG will still needs to update every row of the table, and will most likely state
 
 <blockquote>
 
-**Note: Pre-postgre 11**
+**Note: Pre-postgres 11**
 Adding a column with a default value and a not-null constraint is [dangerous](https://wework.github.io/data/2015/11/05/add-columns-with-default-values-to-large-tables-in-rails-postgres/).
 
 **Safe PG Migrations** makes it safe by:
@@ -120,7 +122,7 @@ Adding a column with a default value and a not-null constraint is [dangerous](ht
 
 Note: the addition of the not null constraint may timeout. In that case, you may want to add the not-null constraint as initially not valid and validate it in a separate statement. See [Adding a not-null constraint on Postgres with minimal locking](https://medium.com/doctolib-engineering/adding-a-not-null-constraint-on-pg-faster-with-minimal-locking-38b2c00c4d1c).
 
-</blockquote>    
+</blockquote>
 
 </details>
 
@@ -137,7 +139,7 @@ If you still get lock timeout while adding / removing indexes, it might be for o
 
 </details>
 
-<details><summary id="safe_add_foreign_key">safe <code>add_foreign_key</code> (and <code>add_reference</code>)</summary>
+<details><summary id="safe_add_foreign_key">Safe <code>add_foreign_key</code> (and <code>add_reference</code>)</summary>
 
 Adding a foreign key requires a `SHARE ROW EXCLUSIVE` lock, which **prevent writing in the tables** while the migration is running.
 
@@ -150,7 +152,7 @@ Adding the constraint itself is rather fast, the major part of the time is spent
 
 <details><summary>Retry after lock timeout</summary>
 
-When a statement fails with a lock timeout, **Safe PG Migrations** retries it (5 times max) [list of retryable statments](https://github.com/doctolib/safe-pg-migrations/blob/66933256252b6bbf12e404b829a361dbba30e684/lib/safe-pg-migrations/plugins/statement_retrier.rb#L5)
+When a statement fails with a lock timeout, **Safe PG Migrations** retries it (5 times max) [list of retriable statements](https://github.com/doctolib/safe-pg-migrations/blob/66933256252b6bbf12e404b829a361dbba30e684/lib/safe-pg-migrations/plugins/statement_retrier.rb#L5)
 </details>
 
 <details><summary>Blocking activity logging</summary>
@@ -219,11 +221,11 @@ SafePgMigrations.config.retry_delay = 1.minute # Delay between retries for retry
 SafePgMigrations.config.max_tries = 5 # Number of retries before abortion of the migration
 ```
 
-## Runnings tests
+## Running tests
 
 ```bash
 bundle
-psql -h localhost -U postgres -c 'CREATE DATABASE safe_pg_migrations_test'
+psql -h localhost -c 'CREATE DATABASE safe_pg_migrations_test'
 rake test
 ```
 
@@ -257,3 +259,4 @@ Interesting reads:
 - [Safe Operations For High Volume PostgreSQL](https://www.braintreepayments.com/blog/safe-operations-for-high-volume-postgresql/)
 - [Rails Migrations with Zero Downtime](https://blog.codeship.com/rails-migrations-zero-downtime/)
 - [Stop worrying about PostgreSQL locks in your Rails migrations](https://medium.com/doctolib/stop-worrying-about-postgresql-locks-in-your-rails-migrations-3426027e9cc9)
+- [PostgreSQL at Scale: Database Schema Changes Without Downtime](https://medium.com/paypal-tech/postgresql-at-scale-database-schema-changes-without-downtime-20d3749ed680)

data/lib/safe-pg-migrations/base.rb

@@ -1,21 +1,24 @@
 # frozen_string_literal: true
 
+require 'ruby2_keywords'
 require 'safe-pg-migrations/configuration'
 require 'safe-pg-migrations/plugins/verbose_sql_logger'
 require 'safe-pg-migrations/plugins/blocking_activity_logger'
 require 'safe-pg-migrations/plugins/statement_insurer'
 require 'safe-pg-migrations/plugins/statement_retrier'
-require 'safe-pg-migrations/plugins/idem_potent_statements'
+require 'safe-pg-migrations/plugins/idempotent_statements'
 require 'safe-pg-migrations/plugins/useless_statements_logger'
+require 'safe-pg-migrations/plugins/legacy_active_record_support'
 
 module SafePgMigrations
   # Order matters: the bottom-most plugin will have precedence
   PLUGINS = [
     BlockingActivityLogger,
-    IdemPotentStatements,
+    IdempotentStatements,
     StatementRetrier,
     StatementInsurer,
     UselessStatementsLogger,
+    LegacyActiveRecordSupport,
   ].freeze
 
   class << self
@@ -50,13 +53,13 @@ module SafePgMigrations
       @alternate_connection = nil
     end
 
-    def say(*args)
+    ruby2_keywords def say(*args)
       return unless current_migration
 
       current_migration.say(*args)
     end
 
-    def say_method_call(method, *args)
+    ruby2_keywords def say_method_call(method, *args)
       say "#{method}(#{args.map(&:inspect) * ', '})", true
     end
 
@@ -84,13 +87,23 @@ module SafePgMigrations
       true
     end
 
-    SAFE_METHODS = %i[execute add_column add_index add_reference add_belongs_to change_column_null].freeze
+    SAFE_METHODS = %i[
+      execute
+      add_column
+      add_index
+      add_reference
+      add_belongs_to
+      change_column_null
+      add_foreign_key
+    ].freeze
+
     SAFE_METHODS.each do |method|
       define_method method do |*args|
         return super(*args) unless respond_to?(:safety_assured)
 
         safety_assured { super(*args) }
       end
+      ruby2_keywords method
     end
   end
 end

data/lib/safe-pg-migrations/plugins/blocking_activity_logger.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module SafePgMigrations
-  module BlockingActivityLogger
+  module BlockingActivityLogger # rubocop:disable Metrics/ModuleLength
     FILTERED_COLUMNS = %w[
       blocked_activity.xact_start
       blocked_locks.locktype
@@ -21,6 +21,7 @@ module SafePgMigrations
       define_method method do |*args, &block|
         log_blocking_queries { super(*args, &block) }
       end
+      ruby2_keywords method
     end
 
     private
@@ -112,6 +113,7 @@ module SafePgMigrations
     end
 
     def format_start_time(start_time, reference_time = Time.now)
+      start_time = Time.parse(start_time) unless start_time.is_a? Time
       duration = (reference_time - start_time).round
       "transaction started #{duration} #{'second'.pluralize(duration)} ago"
     end

data/lib/safe-pg-migrations/plugins/idempotent_statements.rb

@@ -0,0 +1,92 @@
+# frozen_string_literal: true
+
+module SafePgMigrations
+  module IdempotentStatements
+    ruby2_keywords def add_index(table_name, column_name, *args)
+      options = args.last.is_a?(Hash) ? args.last : {}
+
+      index_definition = index_definition(table_name, column_name, **options)
+
+      return super unless index_name_exists?(index_definition.table, index_definition.name)
+
+      if index_valid?(index_definition.name)
+        SafePgMigrations.say(
+          "/!\\ Index '#{index_definition.name}' already exists in '#{table_name}'. Skipping statement.",
+          true
+        )
+        return
+      end
+
+      remove_index(table_name, name: index_definition.name)
+      super
+    end
+
+    ruby2_keywords def add_column(table_name, column_name, type, *)
+      return super unless column_exists?(table_name, column_name)
+
+      SafePgMigrations.say("/!\\ Column '#{column_name}' already exists in '#{table_name}'. Skipping statement.", true)
+    end
+
+    ruby2_keywords def remove_column(table_name, column_name, type = nil, *)
+      return super if column_exists?(table_name, column_name)
+
+      SafePgMigrations.say("/!\\ Column '#{column_name}' not found on table '#{table_name}'. Skipping statement.", true)
+    end
+
+    ruby2_keywords def remove_index(table_name, *args)
+      options = args.last.is_a?(Hash) ? args.last : {}
+      index_name = options.key?(:name) ? options[:name].to_s : index_name(table_name, options)
+
+      return super if index_name_exists?(table_name, index_name)
+
+      SafePgMigrations.say("/!\\ Index '#{index_name}' not found on table '#{table_name}'. Skipping statement.", true)
+    end
+
+    ruby2_keywords def add_foreign_key(from_table, to_table, *args)
+      options = args.last.is_a?(Hash) ? args.last : {}
+      suboptions = options.slice(:name, :column)
+      return super unless foreign_key_exists?(from_table, suboptions.present? ? nil : to_table, **suboptions)
+
+      SafePgMigrations.say(
+        "/!\\ Foreign key '#{from_table}' -> '#{to_table}' already exists. Skipping statement.",
+        true
+      )
+    end
+
+    ruby2_keywords def create_table(table_name, *args)
+      options = args.last.is_a?(Hash) ? args.last : {}
+      return super if options[:force] || !table_exists?(table_name)
+
+      SafePgMigrations.say "/!\\ Table '#{table_name}' already exists.", true
+
+      td = create_table_definition(table_name, *args)
+
+      yield td if block_given?
+
+      SafePgMigrations.say(td.indexes.empty? ? '-- Skipping statement' : '-- Creating indexes', true)
+
+      td.indexes.each do |column_name, index_options|
+        add_index(table_name, column_name, **index_options)
+      end
+    end
+
+    protected
+
+    def index_definition(table_name, column_name, **options)
+      index_definition, = add_index_options(table_name, column_name, **options)
+      index_definition
+    end
+
+    private
+
+    def index_valid?(index_name)
+      query_value <<~SQL.squish
+        SELECT indisvalid
+        FROM pg_index i
+        JOIN pg_class c
+          ON i.indexrelid = c.oid
+        WHERE c.relname = '#{index_name}';
+      SQL
+    end
+  end
+end

data/lib/safe-pg-migrations/plugins/legacy_active_record_support.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module SafePgMigrations
+  module LegacyActiveRecordSupport
+    ruby2_keywords def validate_foreign_key(from_table, to_table = nil, **options)
+      return super(from_table, to_table || options) unless satisfied? '>=6.0.0'
+
+      super(from_table, to_table, **options)
+    end
+
+    ruby2_keywords def foreign_key_exists?(from_table, to_table = nil, **options)
+      return super(from_table, to_table || options) unless satisfied? '>=6.0.0'
+
+      super(from_table, to_table, **options)
+    end
+
+    protected
+
+    IndexDefinition = Struct.new(:table, :name)
+
+    def index_definition(table_name, column_name, **options)
+      return super(table_name, column_name, **options) if satisfied? '>=6.1.0'
+
+      index_name = options.key?(:name) ? options[:name].to_s : index_name(table_name, index_column_names(column_name))
+      validate_index_length!(table_name, index_name, options.fetch(:internal, false))
+
+      IndexDefinition.new(table_name, index_name)
+    end
+
+    private
+
+    def satisfied?(version)
+      Gem::Requirement.new(version).satisfied_by? Gem::Version.new(::ActiveRecord::VERSION::STRING)
+    end
+  end
+end

data/lib/safe-pg-migrations/plugins/statement_insurer.rb

@@ -8,9 +8,11 @@ module SafePgMigrations
       define_method method do |*args, &block|
         with_setting(:statement_timeout, SafePgMigrations.config.pg_safe_timeout) { super(*args, &block) }
       end
+      ruby2_keywords method
     end
 
-    def add_column(table_name, column_name, type, **options)
+    ruby2_keywords def add_column(table_name, column_name, type, *args) # rubocop:disable Metrics/CyclomaticComplexity
+      options = args.last.is_a?(Hash) ? args.last : {}
       return super if SafePgMigrations.pg_version_num >= PG_11_VERSION_NUM
 
       default = options.delete(:default)
@@ -36,17 +38,21 @@ module SafePgMigrations
       end
     end
 
-    def add_foreign_key(from_table, to_table, **options)
+    ruby2_keywords def add_foreign_key(from_table, to_table, *args)
+      options = args.last.is_a?(Hash) ? args.last : {}
       validate_present = options.key? :validate
       options[:validate] = false unless validate_present
+      with_setting(:statement_timeout, SafePgMigrations.config.pg_safe_timeout) do
+        super(from_table, to_table, **options)
+      end
 
-      with_setting(:statement_timeout, SafePgMigrations.config.pg_safe_timeout) { super }
+      return if validate_present
 
-      options_or_to_table = options.slice(:name, :column).presence || to_table
-      without_statement_timeout { validate_foreign_key from_table, options_or_to_table } unless validate_present
+      suboptions = options.slice(:name, :column)
+      without_statement_timeout { validate_foreign_key from_table, suboptions.present? ? nil : to_table, **suboptions }
     end
 
-    def create_table(*)
+    ruby2_keywords def create_table(*)
       with_setting(:statement_timeout, SafePgMigrations.config.pg_safe_timeout) do
         super do |td|
           yield td if block_given?
@@ -65,34 +71,25 @@ module SafePgMigrations
         options[:algorithm] = :concurrently
       end
 
-      SafePgMigrations.say_method_call(:add_index, table_name, column_name, options)
+      SafePgMigrations.say_method_call(:add_index, table_name, column_name, **options)
 
-      without_timeout { super }
+      without_timeout { super(table_name, column_name, **options) }
     end
 
-    def remove_index(table_name, options = {})
-      options = { column: options } unless options.is_a?(Hash)
-      options[:algorithm] = :concurrently
-      SafePgMigrations.say_method_call(:remove_index, table_name, options)
+    ruby2_keywords def remove_index(table_name, *args)
+      options = args.last.is_a?(Hash) ? args.last : { column: args.last }
+      options[:algorithm] = :concurrently unless options.key?(:algorithm)
+      SafePgMigrations.say_method_call(:remove_index, table_name, **options)
 
-      without_timeout { super }
+      without_timeout { super(table_name, **options) }
     end
 
     def backfill_column_default(table_name, column_name)
-      quoted_table_name = quote_table_name(table_name)
+      model = Class.new(ActiveRecord::Base) { self.table_name = table_name }
       quoted_column_name = quote_column_name(column_name)
-      primary_key_offset = 0
-      loop do
-        ids = query_values <<~SQL.squish
-          SELECT id FROM #{quoted_table_name} WHERE id > #{primary_key_offset}
-          ORDER BY id LIMIT #{SafePgMigrations.config.batch_size}
-        SQL
-        break if ids.empty?
-
-        primary_key_offset = ids.last
-        execute <<~SQL.squish
-          UPDATE #{quoted_table_name} SET #{quoted_column_name} = DEFAULT WHERE id IN (#{ids.join(',')})
-        SQL
+
+      model.in_batches(of: SafePgMigrations.config.batch_size).each do |relation|
+        relation.update_all("#{quoted_column_name} = DEFAULT")
       end
     end
 

data/lib/safe-pg-migrations/plugins/statement_retrier.rb

@@ -10,6 +10,7 @@ module SafePgMigrations
       define_method method do |*args, &block|
         retry_if_lock_timeout { super(*args, &block) }
       end
+      ruby2_keywords method
     end
 
     private

data/lib/safe-pg-migrations/plugins/useless_statements_logger.rb

@@ -2,22 +2,27 @@
 
 module SafePgMigrations
   module UselessStatementsLogger
-    def self.warn_useless(action, link = nil, *args)
-      SafePgMigrations.say "/!\\ No need to explicitly use #{action}, safe-pg-migrations does it for you", *args
-      SafePgMigrations.say "\t see #{link} for more details", *args if link
+    class << self
+      ruby2_keywords def warn_useless(action, link = nil, *args)
+        SafePgMigrations.say "/!\\ No need to explicitly use #{action}, safe-pg-migrations does it for you", *args
+        SafePgMigrations.say "\t see #{link} for more details", *args if link
+      end
     end
 
-    def add_index(*, **options)
+    ruby2_keywords def add_index(*args)
+      options = args.last.is_a?(Hash) ? args.last : {}
       warn_for_index(**options)
       super
     end
 
-    def remove_index(table_name, options = {})
-      warn_for_index(options) if options.is_a? Hash
+    ruby2_keywords def remove_index(table_name, *args)
+      options = args.last.is_a?(Hash) ? args.last : {}
+      warn_for_index(**options) unless options.empty?
       super
     end
 
-    def add_foreign_key(*, **options)
+    ruby2_keywords def add_foreign_key(*args)
+      options = args.last.is_a?(Hash) ? args.last : {}
       if options[:validate] == false
         UselessStatementsLogger.warn_useless '`validate: :false`', 'https://github.com/doctolib/safe-pg-migrations#safe_add_foreign_key'
       end

data/lib/safe-pg-migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SafePgMigrations
-  VERSION = '1.2.3'
+  VERSION = '1.4.1'
 end

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: safe-pg-migrations
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.4.1
 platform: ruby
 authors:
 - Matthieu Prat
 - Romain Choquet
-autorequire: 
+- Thomas Hareau
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-30 00:00:00.000000000 Z
+date: 2022-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -40,119 +41,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '5.2'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: ruby2_keywords
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: mocha
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pg
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-coolline
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: 0.0.4
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.0.4
 description: Make your PG migrations safe.
-email: matthieuprat@gmail.com
+email:
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -163,7 +66,8 @@ files:
 - lib/safe-pg-migrations/base.rb
 - lib/safe-pg-migrations/configuration.rb
 - lib/safe-pg-migrations/plugins/blocking_activity_logger.rb
-- lib/safe-pg-migrations/plugins/idem_potent_statements.rb
+- lib/safe-pg-migrations/plugins/idempotent_statements.rb
+- lib/safe-pg-migrations/plugins/legacy_active_record_support.rb
 - lib/safe-pg-migrations/plugins/statement_insurer.rb
 - lib/safe-pg-migrations/plugins/statement_retrier.rb
 - lib/safe-pg-migrations/plugins/useless_statements_logger.rb
@@ -173,8 +77,13 @@ files:
 homepage: https://github.com/doctolib/safe-pg-migrations
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  bug_tracker_uri: https://github.com/doctolib/safe-pg-migrations/issues
+  homepage_uri: https://github.com/doctolib/safe-pg-migrations#safe-pg-migrations
+  mailing_list_uri: https://doctolib.engineering/engineering-news-ruby-rails-react
+  source_code_uri: https://github.com/doctolib/safe-pg-migrations
+  contributors_uri: https://github.com/doctolib/safe-pg-migrations/graphs/contributors
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -183,15 +92,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ">="
     - !ruby/object:Gem::Version
       version: '2.5'
+  - - "<"
+    - !ruby/object:Gem::Version
+      version: '4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
+rubyforge_project:
 rubygems_version: 2.7.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Make your PG migrations safe.
 test_files: []

data/lib/safe-pg-migrations/plugins/idem_potent_statements.rb

@@ -1,73 +0,0 @@
-# frozen_string_literal: true
-
-module SafePgMigrations
-  module IdemPotentStatements
-    def add_index(table_name, column_name, **options)
-      index_name = options.key?(:name) ? options[:name].to_s : index_name(table_name, index_column_names(column_name))
-      return super unless index_name_exists?(table_name, index_name)
-
-      return if index_valid?(index_name)
-
-      remove_index(table_name, name: index_name)
-      super
-    end
-
-    def add_column(table_name, column_name, type, options = {})
-      return super unless column_exists?(table_name, column_name)
-
-      SafePgMigrations.say("/!\\ Column '#{column_name}' already exists in '#{table_name}'. Skipping statement.", true)
-    end
-
-    def remove_column(table_name, column_name, type = nil, options = {})
-      return super if column_exists?(table_name, column_name)
-
-      SafePgMigrations.say("/!\\ Column '#{column_name}' not found on table '#{table_name}'. Skipping statement.", true)
-    end
-
-    def remove_index(table_name, options = {})
-      index_name = options.key?(:name) ? options[:name].to_s : index_name(table_name, options)
-
-      return super if index_name_exists?(table_name, index_name)
-
-      SafePgMigrations.say("/!\\ Index '#{index_name}' not found on table '#{table_name}'. Skipping statement.", true)
-    end
-
-    def add_foreign_key(from_table, to_table, **options)
-      options_or_to_table = options.slice(:name, :column).presence || to_table
-      return super unless foreign_key_exists?(from_table, options_or_to_table)
-
-      SafePgMigrations.say(
-        "/!\\ Foreign key '#{from_table}' -> '#{to_table}' already exists. Skipping statement.",
-        true
-      )
-    end
-
-    def create_table(table_name, comment: nil, **options)
-      return super if options[:force] || !table_exists?(table_name)
-
-      SafePgMigrations.say "/!\\ Table '#{table_name}' already exists.", true
-
-      td = create_table_definition(table_name, **options)
-
-      yield td if block_given?
-
-      SafePgMigrations.say(td.indexes.empty? ? '-- Skipping statement' : '-- Creating indexes', true)
-
-      td.indexes.each do |column_name, index_options|
-        add_index(table_name, column_name, index_options)
-      end
-    end
-
-    private
-
-    def index_valid?(index_name)
-      query_value <<~SQL.squish
-        SELECT indisvalid
-        FROM pg_index i
-        JOIN pg_class c
-          ON i.indexrelid = c.oid
-        WHERE c.relname = '#{index_name}';
-      SQL
-    end
-  end
-end