saddler 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1e3cbd21f10fa179c70115b166487b2801affe9f
-  data.tar.gz: 7d52f4d658b072a55228af8bf7e6f7ad1b7c8734
+  metadata.gz: a0203a1f51349d4087bbec200c6dbad7905e4c5f
+  data.tar.gz: 40049df61fa576c5bcde61ac0c669a4ad722c3fd
 SHA512:
-  metadata.gz: 3238a6968d4d42c80db96bde6f27646ae5a13355cdbae6826d53e71a2c60403f257a3ea48d64136a03ea1b802f6aa275c5b0a3ab7bdd0dd04640a0d69078bad6
-  data.tar.gz: 7a049c9cc75960625608e315699cf7cb8b638035e4ae24dea1f4c853dba1c0b6e9805c057264989ffc21833e880eee8a36eca78953b7c06143004c7fd46d1cdb
+  metadata.gz: 7aeea7d80d28736a7618527414ba66f89e272f607809d3f5d903fea47aef20fa2ede61f8768c561f75bbd2e8918fe8a67d52121d1c32993e97aa8055b7d9b28b
+  data.tar.gz: 634660e5c7f571f863177591db94f95032c2fd7cf57cd7f6a9ce82413609e7bdfaa4b8224c9bdd228d1c336bb192e1456ce1364c566e1cbecab2eb6c71db373f

data/CHANGELOG.md

@@ -0,0 +1,13 @@
+### 0.1.1 (2015-03-01)
+
+#### Features
+
+* **logger:** add logger ([e56ec137](https://github.com/packsaddle/ruby-saddler/commit/e56ec137327fb0fe211d2379bad670313a45a5db))
+* **validator:** add xml validator([d230440](https://github.com/packsaddle/ruby-saddler/commit/d230440d5dfc09bffb6553e37ef6a5a0fbe0cf47))
+
+## 0.1.0 (2015-02-24)
+
+
+#### Features
+
+* **app:** release

data/README.md

@@ -5,15 +5,23 @@
 
 **checkstyle2anywhere**, you can exec any lint, security checker and tools.
 
+### Pull Request Review Comment
+
+![Pull Request Review Comment](https://cloud.githubusercontent.com/assets/75448/6392012/842ba6e2-bdff-11e4-84c3-bc180ac199bc.png "Pull Request Review Comment")
+
+### Pull Request Comment
+
+![Pull Request Comment](https://cloud.githubusercontent.com/assets/75448/6392013/892d1e5a-bdff-11e4-8ffb-f8ca93507662.png "Pull Request Comment")
+
 ## Usage
 
 ```
-git diff -z --name-only ..origin/master \
+git diff -z --name-only origin/master \
  | xargs -0 rubocop-select \
  | xargs rubocop \
      --require rubocop/formatter/checkstyle_formatter \
      --format RuboCop::Formatter::CheckstyleFormatter \
- | checkstyle_filter-git diff ..origin/master \
+ | checkstyle_filter-git diff origin/master \
  | saddler report \
     --require saddler/reporter/github \
     --reporter Saddler::Reporter::Github::PullRequestReviewComment
@@ -28,6 +36,14 @@ You can run this from any CI Service (e.g. circle-ci, travis-ci, jenkins, etc).
 * [saddler-reporter-text](https://github.com/packsaddle/ruby-saddler-reporter-text)
 * [saddler-reporter-github](https://github.com/packsaddle/ruby-saddler-reporter-github)
 
+## Examples and Demo
+You can send pull request to repos below. Try this!
+
+* [TravisCI with Pull Request Review Comment](https://github.com/packsaddle/example-travis_ci-pull_request_review)
+* [TravisCI with Pull Request Comment](https://github.com/packsaddle/example-travis_ci-pull_request)
+* [CircleCI with Pull Request Review Comment](https://github.com/packsaddle/example-circle_ci-pull_request_review)
+* [CircleCI with Pull Request Comment](https://github.com/packsaddle/example-circle_ci-pull_request)
+
 ## Installation
 
 Add this line to your application's Gemfile:

data/lib/saddler.rb

@@ -1,6 +1,26 @@
-require 'saddler/version'
+require 'logger'
+require 'saddler/reporter/text'
+require 'rexml/document'
+
+require 'saddler/error'
 require 'saddler/reporter'
+require 'saddler/validator'
+require 'saddler/version'
 
 module Saddler
-  # Your code goes here...
+  def self.default_logger
+    logger = Logger.new(STDERR)
+    logger.progname = 'Saddler'
+    logger.level = Logger::WARN
+    logger
+  end
+
+  def self.logger
+    return @logger if @logger
+    @logger = default_logger
+  end
+
+  class << self
+    attr_writer :logger
+  end
 end

data/lib/saddler/cli.rb

@@ -19,8 +19,39 @@ module Saddler
     option :options, type: :hash, default: {}
     option :require
     option :reporter
+    option :debug, type: :boolean, default: false
+    option :verbose, type: :boolean, default: false
     def report
-      data = \
+      if options[:debug]
+        logger.level = Logger::DEBUG
+      elsif options[:verbose]
+        logger.level = Logger::INFO
+      end
+      logger.debug(options)
+
+      data = fetch_data(options)
+      Validator.valid?(data)
+      require options[:require] if options[:require]
+      reporter = add_reporter(options)
+
+      reporter.report(data, options[:options])
+    rescue StandardError => e
+      logger.error('options')
+      logger.error(options)
+      logger.error('input data')
+      logger.error(data)
+      logger.error('reporter')
+      logger.error(reporter)
+      raise e
+    end
+
+    no_commands do
+      def logger
+        ::Saddler.logger
+      end
+
+      def fetch_data(options)
+        data = \
           if options[:data]
             options[:data]
           elsif options[:file]
@@ -30,15 +61,20 @@ module Saddler
             ARGF.read
           end
 
-      abort('no input') if !data || data.empty?
+        logger.info('input data')
+        logger.info(data)
+        fail NoInputError if !data || data.empty?
 
-      require options[:require] if options[:require]
-      if options[:reporter]
-        reporter = ::Saddler::Reporter.add_reporter(options[:reporter], $stdout)
+        data
       end
 
-      abort('no reporter') unless reporter
-      reporter.report(data, options[:options])
+      def add_reporter(options)
+        reporter = Reporter.add_reporter(options[:reporter], $stdout) if options[:reporter]
+        fail NoReporterError unless reporter
+        logger.info('use reporter')
+        logger.info(reporter)
+        reporter
+      end
     end
   end
 end

data/lib/saddler/error.rb

@@ -0,0 +1,5 @@
+module Saddler
+  class NoInputError < StandardError; end
+  class NoReporterError < StandardError; end
+  class InvalidXMLError < StandardError; end
+end

data/lib/saddler/validator.rb

@@ -0,0 +1,13 @@
+module Saddler
+  class Validator
+    # NOTE: This is easy check
+    def self.valid?(data)
+      REXML::Document.new(data)
+      true
+    rescue REXML::ParseException => e
+      exception = InvalidXMLError.new(e.message)
+      exception.set_backtrace(e.backtrace)
+      raise exception
+    end
+  end
+end

data/lib/saddler/version.rb

@@ -1,3 +1,3 @@
 module Saddler
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/saddler.gemspec

@@ -14,7 +14,17 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/packsaddle/ruby-saddler'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.files         = \
+    `git ls-files -z`
+      .split("\x0")
+      .reject { |f| f.match(%r{^(test|spec|features)/}) }
+      .reject do |f|
+        [
+          '.travis.yml',
+          'circle.yml',
+          '.tachikoma.yml'
+        ].include?(f)
+      end
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: saddler
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - sanemat
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-02-24 00:00:00.000000000 Z
+date: 2015-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -90,7 +90,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -104,7 +104,9 @@ files:
 - exe/saddler
 - lib/saddler.rb
 - lib/saddler/cli.rb
+- lib/saddler/error.rb
 - lib/saddler/reporter.rb
+- lib/saddler/validator.rb
 - lib/saddler/version.rb
 - saddler.gemspec
 homepage: https://github.com/packsaddle/ruby-saddler

data/.travis.yml

@@ -1,15 +0,0 @@
-language: ruby
-sudo: false
-rvm:
-  - 1.9
-  - 2.0
-  - 2.1
-  - 2.2
-before_install:
-  - gem update bundler
-notifications:
-  email:
-    - ogataken@gmail.com
-branches:
-  only:
-    - master