saddle 0.0.11 → 0.0.12

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MzU0YzZkNmQ2YmI0MTE3MGU4NDEwODFkZjhiMjNiMzAzNjNlZWVhZg==
+    MGJkMTFhMzc3ZGU3YWQwZWFlOGQ3ZjdiYmM2OTk3NzRkMjg4OTRiMg==
   data.tar.gz: !binary |-
-    OTBmMWNkZGJmYjFhMGY2Njc4ZGUxYzZlZDljZDFmNDZkOTExY2QyOQ==
+    MTQxMzRjZDdmODhmMGI1ZTA5NzAyYzFhYTVjMzg2MGViMzMwYTY1Yw==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    YjBmMWJhZDE2NjQ2ZTEzNTE5OGU1YTlkYjY4NjVkNTUyZDIyNmQ2NDkxODRk
-    NzVjYjAxOGM0YmMwMjAwYjdjZDViNTZlZTY0ZWI0NDJkZTgzMTZmOGQ0MjI2
-    NTAxY2RkZThiNDFjMjRlNThlZjRmOGQ0NjM1NTg5Y2ZiNmRmNGQ=
+    ZGJmMTZhZTAzOWFmMzg0ODE1Zjc5N2E0Yjk4N2M5N2U4NWNiYjc0MzA1MjJm
+    ZmRhODc3MGYxMjZhNDlmYmNjYTA4ZTQ3ZTVmOTU0MDA5NmQ0MjAxYmEzMzAx
+    YWIxN2NjODdlYmYzYzVlMjY3MmViY2UwM2JiOTcwMDlmMmE3M2I=
   data.tar.gz: !binary |-
-    MDgxMWQ5MGFmYzFkNTEwYWZmMmEzYTdlZjA4MTViODZiNjkyNzIyOTk2MTEy
-    ZjYwMTg5ODJlZTEyYjY0MTdmZjcxNWExM2M1YzQ4M2JiYTM0ZWVhNDg1ZGJj
-    ZGZmOGFmZTk1Y2VkY2U3OGQ4ZjFjNDcxMjkxMWZjNGFhOTBlODI=
+    MzZmOWM1M2RkM2IwNjRmNGM0OGM2NGQ3NmI5ZDAxMjBmY2U3OTEwNjE5YzEz
+    MDA2YzQ2YWQxODY4NmZhMTM1MzQ4NzY3MDQ0YTcwNjUwMDViNGRkOTkyZjQy
+    MzhlYWIwMzAyNWIwMTYxZjVmZTI0NWJkM2Y4MDUyODJjZjNmZGE=

data/README.md

@@ -1,6 +1,6 @@
 # saddle
 
-Hey nerd! Wrangle your SOA!
+Giddyup nerd! Wrangle your SOA.
 
 Saddle makes writing service clients as easy as giving high fives. :hand:
 
@@ -41,15 +41,17 @@ Saddle enables you to create beautifully stable and functionaly API clients, in
 [saddle-example](https://github.com/mLewisLogic/saddle-example)
 
 ### client construction
-0. For the sake of cleanliness, pick a namespace that everything related to your client should live in. For this example, we'll use _SaddleExample_.
-1. Inherit your client class (_SaddleExample::Client_)from _Saddle::Client_
+0. For the sake of cleanliness, pick a namespace that everything related to your client should live in. For this example, we'll use __SaddleExample__
+1. Inherit your client class, __SaddleExample::Client__, from __Saddle::Client__
 2. Create an _endpoints_ directory at the same level as your client class file
-3. Create endpoint classes in the _endpoints_ directory that inherit from _Saddle::TraversalEndpoint_ and are under the _SaddleExample::Endpoints_ namespace module
+3. Create endpoint classes in the _endpoints_ directory that inherit from __Saddle::TraversalEndpoint__ and are under the __SaddleExample::Endpoints__ namespace module
     1. Give these endpoints methods that call _get_ or _post_ to perform the actual request
-    2. Their module/class namespace determines how they are accessed in the client's call tree. For example, the get_all() in _SaddleExample::Endpoints::Fish::Guppy_ would be accessed by:
+    2. Their module/class namespace determines how they are accessed in the client's call tree. For example, the get\_all() in __SaddleExample::Endpoints::Fish::Guppy__ would be accessed by:
 
         client.fish.guppy.get_all()
 
+    3. If you need REST style endpoints like client.fish('guppy').catch() then check out __Saddle::ResourceEndpoint__ and how it's used in [saddle-example](https://github.com/mLewisLogic/saddle-example/blob/master/lib/endpoints/kitten.rb)
+
 4. Initialize an instance of your client. ex:
 
         saddle_example_client = SaddleExample::Client.create

data/lib/saddle.rb

@@ -1,11 +1,9 @@
+require 'saddle/client_attributes'
 require 'saddle/method_tree_builder'
 require 'saddle/options'
-require 'saddle/client_attributes'
 require 'saddle/requester'
-require 'saddle/errors'
 
 
-# Ghost ride the whip.
 # Inherit your client implementation from Saddle::Client
 # then call YourCrayClient.create to get a client instance.
 

data/lib/saddle/client_attributes.rb

@@ -3,8 +3,12 @@ module Saddle::ClientAttributes
   def self.included(obj)
     obj.extend ClassMethods
 
-    # Default values
-    obj.additional_middlewares = []
+    # Clone the parent's additional_middlewares
+    obj.additional_middlewares = if defined?(obj.superclass.additional_middlewares)
+      obj.superclass.additional_middlewares.clone
+    else
+      []
+    end
 
     # We know that this module is included when saddle client is inherited,
     # so we're actually interested in the path of the caller two levels deep.

data/lib/saddle/middleware/logging/statsd.rb

@@ -28,15 +28,17 @@ module Saddle::Middleware
       end
 
       def call(env)
+        # Try to build up a path for the STATSD logging
         statsd_path = nil
         if env[:request][:statsd_path]
           statsd_path = env[:request][:statsd_path]
         elsif env[:request][:saddle] && env[:request][:saddle][:call_chain] && env[:request][:saddle][:action]
-          statsd_path = (env[:request][:saddle][:call_chain] + [env[:request][:saddle][:action]]).join('.')
+          statsd_path = (['saddle'] + env[:request][:saddle][:call_chain] + [env[:request][:saddle][:action]]).join('.')
         end
 
+        # If we have a path, wrap the ensuing app call in STATSD timing
         if statsd_path
-          self.statsd.time statsd_path do
+          self.statsd.time(statsd_path) do
             @app.call(env)
           end
         else

data/lib/saddle/version.rb

@@ -1,3 +1,3 @@
 module Saddle
-  VERSION = '0.0.11'
+  VERSION = '0.0.12'
 end

data/saddle.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |s|
   s.name          = 'saddle'
   s.version       = Saddle::VERSION
 
-  s.authors       = ['Mike Lewis', 'Naseem Hakim']
-  s.email         = 'mike@cleverkoala.com'
+  s.authors       = ['Mike Lewis']
+  s.email         = 'mike.lewis@airbnb.com'
   s.description   = %q{Makes writing API clients as easy as giving high fives}
   s.summary       = %q{
     A full-featured, generic consumer layer for you to build API client implementations with.

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: saddle
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - Mike Lewis
-- Naseem Hakim
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-08 00:00:00.000000000 Z
+date: 2013-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -54,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.9.0
 description: Makes writing API clients as easy as giving high fives
-email: mike@cleverkoala.com
+email: mike.lewis@airbnb.com
 executables: []
 extensions: []
 extra_rdoc_files: []