saboteur 0.11.0 → 0.11.2

data/lib/saboteur/cli/explicit_sources.rb

@@ -39,7 +39,7 @@ module Saboteur
       # A test may carry an example selector: spec/a_spec.rb:12 or spec/a_spec.rb[1:2].
       def require_existing_test(test)
         path = test.sub(/(:\d+|\[[\d:,]+\])+\z/, "")
-        raise UsageError, "test file not found: #{test}" unless File.exist?(path)
+        raise UsageError, "test file not found: #{test}; check the path or drop --test" unless File.exist?(path)
       end
     end
   end

data/lib/saboteur/cli/failure_output.rb

@@ -25,7 +25,7 @@ module Saboteur
       end
 
       def usage_error(message = nil)
-        @err.puts(message) if message
+        @err.puts(Reporter::Palette.for(@err, mode: @color || :auto).paint(:fail, message)) if message
         @err.puts(USAGE)
         agent_failure(message || USAGE, EXIT_USAGE)
       end
@@ -43,7 +43,7 @@ module Saboteur
       # name must not become a workflow command in the CI log).
       def report_failure(error, exit_code)
         message = Text.display_safe_lines(error.message)
-        @err.puts("saboteur: #{message}")
+        @err.puts(Reporter::Palette.for(@err, mode: @color || :auto).paint(:fail, "saboteur: #{message}"))
         @err.puts(verdict_line(EXIT_BASELINE_RED)) if exit_code == EXIT_BASELINE_RED
         agent_failure(message, exit_code)
       end

data/lib/saboteur/cli/flaky_exit.rb

@@ -0,0 +1,23 @@
+# SPDX-License-Identifier: MIT
+# frozen_string_literal: true
+
+module Saboteur
+  class CLI
+    # --flaky-check (#1167): a verdict that flipped on the reordered rerun is
+    # unverified, outside the score. The run was not stopped by a budget, so
+    # it is not exit 4, but it cannot go green either.
+    module FlakyExit
+      private
+
+      def flaky_disagreement?(report)
+        flaky = report.results.select(&:flaky?)
+        return false if flaky.empty?
+
+        @err.puts("saboteur: #{flaky.size} mutant#{'s' unless flaky.one?} changed verdict on the --flaky-check " \
+                  "reordered rerun (#{flaky.first(3).map(&:digest).join(', ')}), so they are unverified: " \
+                  "your tests depend on run order; fix that and run again")
+        true
+      end
+    end
+  end
+end

data/lib/saboteur/cli/presets.rb

@@ -14,6 +14,11 @@ module Saboteur
                       --html .saboteur/audit-report.html]
       }.freeze
 
+      # What a new user types first; there is no such command, the Rails
+      # generator writes the starter files.
+      SETUP_WORDS = %w[init install setup].freeze
+      SETUP_HINT = "To set up a Rails app, run: bin/rails generate saboteur:install"
+
       # Preset flags that take a separate value token: the pairs a user
       # flag can override in the banner (#666).
       VALUE_FLAGS = %w[--baseline-passes --max-duration --since --operators --json --html].freeze
@@ -21,7 +26,12 @@ module Saboteur
       private
 
       def preset_or_usage_error(command)
-        PRESETS.key?(command) ? preset(command) : usage_error
+        return preset(command) if PRESETS.key?(command)
+
+        # A typo'd command is not a run: say so before the usage line.
+        @err.puts("unknown command: #{command}. Run 'saboteur help' for the commands.") if command
+        @err.puts(SETUP_HINT) if SETUP_WORDS.include?(command)
+        usage_error
       end
 
       def preset(name)

data/lib/saboteur/cli/run_command.rb

@@ -17,6 +17,18 @@ module Saboteur
 
       private
 
+      # A fresh checkout has no config file: say once that defaults are in
+      # use, and who writes one (#1172). Agent output stays machine-clean;
+      # there is no init command - the Rails generator writes the config.
+      def announce_missing_config_file(palette)
+        # @format, not agent_requested?: parse! has already eaten --format.
+        return if @format == "agent" || config.config_file_present
+
+        path = options[:config] || Config::FILE
+        notice = "saboteur: no #{path} - using defaults (Rails: bundle exec rails generate saboteur:install writes one)"
+        @err.puts(palette.paint(:dim, notice))
+      end
+
       def baseline_red?(error)
         error.message.to_s.match?(BASELINE_RED_MESSAGE)
       end
@@ -30,7 +42,11 @@ module Saboteur
         validate_run_options
         warn_dirty_tree
 
-        config.deprecation_warnings.each { |warning| @err.puts("saboteur: #{warning}") }
+        notices = Reporter::Palette.for(@err, mode: @color || :auto, overrides: config["palette"])
+        config.deprecation_warnings.each do |warning|
+          @err.puts(Reporter::Notice.paint(notices, "saboteur: #{warning}"))
+        end
+        announce_missing_config_file(notices)
 
         return preview if options[:list_operators] || options[:dry_run]
 

data/lib/saboteur/cli/run_output.rb

@@ -21,6 +21,16 @@ module Saboteur
         @out.puts "\nReports: #{names.join(', ')}"
       end
 
+      # The clean screen's scope label (#1173, #1174): --since, positional
+      # sources and --subject each name what the run covered.
+      def scope_label
+        parts = []
+        parts << "--since #{config['since']}" if config["since"]
+        parts.concat(@sources) if @sources
+        parts << "--subject #{config['subjects'].join(', ')}" if config["subjects"].any?
+        parts.empty? ? "whole project" : parts.join(", ")
+      end
+
       # Agent mode: stdout carries exactly one JSON payload. The target's own output (boot
       # files, hooks, spec loading, child processes) goes to stderr while the engine runs.
       # Descriptor 1 points at stderr for the block, so Kernel#puts, system and forked

data/lib/saboteur/cli/run_reporting.rb

@@ -22,7 +22,9 @@ module Saboteur
                                      overrides: config["palette"], threshold: config["threshold"],
                                      replay_command: survivor_replay_command(report, engine),
                                      all_mutants: options[:all_mutants] || false,
-                                     exit_code: code, previous_score: previous_score,
+                                     exit_code: code, previous_score: previous_score, scope: scope_label,
+                                     whole_suite_map: whole_suite_map_for(engine),
+                                     run_map: engine&.run_coverage_map,
                                      baseline_gate: (baseline_gate(report) if config["baseline"])).call(report)
         Reporter::Replay.new(@out).call(report) if options[:id]
         # The JSON carries the exit cause an outer harness trusts, so it is
@@ -38,6 +40,14 @@ module Saboteur
         code
       end
 
+      # No engine or no cache: no whole-suite map can exist, so the survivor
+      # block keeps its legacy covered-by line over an impossible build (review C1).
+      def whole_suite_map_for(engine)
+        return engine.whole_suite_coverage_map if engine&.whole_suite_map_lookup?
+
+        Reporter::SurvivorList::NO_WHOLE_SUITE_LOOKUP
+      end
+
       def agent_run(arguments)
         tree = WorkingTree.new(config.root, ignored: config.ignored_tree_paths).state
         # The machine path is exempt from the noise diet: quiet_start: false
@@ -94,7 +104,8 @@ module Saboteur
       def survivor_replay_command(report, engine)
         lambda do |digest|
           tree = WorkingTree.new(config.root, ignored: config.ignored_tree_paths).state
-          Reporter::Agent::Commands.replay(agent_provenance(report, tree, engine), digest, capped: false)
+          Reporter::Agent::Commands.replay(agent_provenance(report, tree, engine), digest, capped: false,
+                                                                                           report: report)
         end
       end
 

data/lib/saboteur/cli/survivors_command.rb

@@ -3,6 +3,9 @@
 
 require "json"
 
+require_relative "../survivor_guidance"
+require_relative "../reporter/survivor_hints"
+
 module Saboteur
   class CLI
     # saboteur survivors <report.json> (#475): a read-only, line-oriented
@@ -11,6 +14,9 @@ module Saboteur
     # one digest prints the diff, the exact replay command and the
     # ignore-file template. It never edits the ignore file.
     module SurvivorsCommand
+      # Where `saboteur run` writes the JSON report unless configured otherwise.
+      DEFAULT_REPORT = Config::DEFAULTS["json_report"]
+
       private
 
       def survivors_command
@@ -25,13 +31,12 @@ module Saboteur
           opts.on("--ranked", "Review-priority order: the report's ranked findings first")
           opts.on("--file SUBSTR", "Only survivors whose path contains SUBSTR")
           opts.on("--operator NAME", "Only survivors of operator NAME")
-          opts.on("--triage LABEL", "Only survivors classified LABEL (for example missing_test)")
+          opts.on("--triage LABEL", "Only survivors classified LABEL (for example boundary)")
           opts.on("--show DIGEST", "Diff, replay command and ignore template for one survivor")
         end
         options = {}
         args = parser.parse!(@argv, into: options)
-        path = args.shift or raise UsageError,
-                                   "survivors expects a report path: saboteur survivors .saboteur/report.json"
+        path = args.shift || DEFAULT_REPORT
         raise UsageError, "unexpected arguments: #{args.join(' ')}" if args.any?
 
         report = load_survivor_report(path)
@@ -45,7 +50,10 @@ module Saboteur
       end
 
       def load_survivor_report(path)
-        raise UsageError, "report not found: #{path}" unless File.file?(path)
+        unless File.file?(path)
+          hint = path == DEFAULT_REPORT ? "; run saboteur first, or pass a report path" : ""
+          raise UsageError, "report not found: #{path}#{hint}"
+        end
 
         JSON.parse(File.read(path))
       rescue JSON::ParserError => e
@@ -70,26 +78,77 @@ module Saboteur
       end
 
       def show(digest)
-        survivor = all_survivors.find { |s| s[:digest].start_with?(digest) } ||
-                   raise(UsageError, "no survivor with digest #{digest} in this report")
+        survivor = unique_survivor(digest)
         finding = findings_by_digest[survivor[:digest]] || {}
-        subject = finding["subject"]
+        subject = finding["subject"] || survivor[:subject]
+        seed = @report.dig("config", "seed")
         [
-          "#{survivor[:path]}:#{survivor[:line]}  #{survivor[:operator]}  #{survivor[:digest]}",
-          "",
-          "- #{finding['original'] || original_line(survivor)}",
-          "+ #{finding['replacement'] || survivor[:replacement]}",
+          *detail_lines(survivor, finding),
           "",
-          "Replay exactly this mutant:",
-          "  bundle exec saboteur run --id #{survivor[:digest]}",
+          "replay one survivor: #{SurvivorGuidance.replay_command(survivor[:digest], seed: seed)}",
+          "  #{SurvivorGuidance::REPLAY_CAVEAT}",
           "",
-          "Ignore-file entry (config/saboteur_ignore.rb):",
-          *ignore_entry(survivor, subject)
+          SurvivorGuidance::IGNORE_INTRO,
+          "  #{ignore_entry(survivor, subject)}"
         ].join("\n")
       end
 
       private
 
+      def detail_lines(survivor, finding)
+        [
+          "#{survivor[:path]}:#{survivor[:line]}  #{survivor[:operator]}  #{survivor[:digest]}",
+          *classification_line(survivor[:classification]),
+          "",
+          "- #{finding['original'] || original_line(survivor)}",
+          "+ #{finding['replacement'] || survivor[:replacement]}",
+          "why it matters: #{Reporter::SurvivorHints.why(survivor[:operator])}",
+          *covered_line(survivor),
+          *hint_line(survivor, survivor[:classification])
+        ]
+      end
+
+      # The same wording the terminal survivor block uses (#1183).
+      def classification_line(label)
+        return [] unless label
+
+        reason = Reporter::SurvivorHints.label_reason(label)
+        ["classification: #{label}#{" - #{reason}" if reason}"]
+      end
+
+      def covered_line(survivor)
+        names = survivor[:covered].map { |id| test_names[id] }.compact
+        return [] if names.empty?
+
+        rest = " (+#{names.size - 1} more)" if names.size >= 2
+        ["covered by #{names.first}#{rest} - ran, still passed"]
+      end
+
+      def test_names
+        @test_names ||= @report.fetch("testFiles", {}).values
+                               .flat_map { |file| file.fetch("tests", []) }
+                               .to_h { |test| [test["id"], test["name"]] }
+      end
+
+      def hint_line(survivor, label)
+        return [] unless label
+
+        text = Reporter::SurvivorHints.for_label(survivor[:operator], label: label)
+        text ? ["hint: #{text}"] : []
+      end
+
+      # A prefix names one survivor or none: an ambiguous one is refused
+      # with the candidates, never resolved to the first match.
+      def unique_survivor(digest)
+        match, *others = all_survivors.select { |s| s[:digest].start_with?(digest) }
+        raise UsageError, "no survivor with digest #{digest} in this report" unless match
+        return match if others.empty?
+
+        digests = [match, *others].map { |m| m[:digest] }.sort
+        raise UsageError, "digest prefix #{digest} matches #{digests.size} survivors: " \
+                          "#{digests.join(', ')}; use more characters"
+      end
+
       def filtered(file, operator, triage)
         survivors = all_survivors
         survivors = survivors.select { |s| s[:path].include?(file) } if file
@@ -114,8 +173,13 @@ module Saboteur
       end
 
       def ignore_entry(survivor, subject)
-        note = subject ? subject.inspect : '"Klass#meth" # TODO: capped findings omit this digest - fill it in'
-        [%(  i.mutation "#{survivor[:digest]}",), "      subject: #{note},", %(      reason: "...")]
+        block = if subject
+                  SurvivorGuidance.ignore_block(survivor[:digest], subject)
+                else
+                  SurvivorGuidance.ignore_block(survivor[:digest], "Klass#meth",
+                                                todo: "capped findings omit this digest - fill in the subject")
+                end
+        block.gsub("\n", "\n  ")
       end
 
       def all_survivors
@@ -124,7 +188,7 @@ module Saboteur
             entry.fetch("mutants", []).select { |m| m["status"] == "Survived" }.map do |m|
               { path: path, line: m.dig("location", "start", "line").to_i, operator: m["mutatorName"],
                 digest: m["id"], replacement: m["replacement"], classification: m["classification"],
-                covered: m["coveredBy"] || [], source: entry["source"] }
+                subject: m["subject"], covered: m["coveredBy"] || [], source: entry["source"] }
             end
           end
           survivors.sort_by { |s| [s[:path], s[:line], s[:digest]] }

data/lib/saboteur/cli.rb

@@ -15,6 +15,7 @@ require_relative "cli/baseline_gate"
 require_relative "preview"
 require_relative "cli/run_reporting"
 require_relative "cli/survivors_command"
+require_relative "cli/explain_command"
 require_relative "cli/source_set"
 require_relative "cli/run_budget_options"
 require_relative "cli/shard_options"
@@ -44,6 +45,7 @@ module Saboteur
     include BaselineGate
     include RunReporting
     include SurvivorsCommand
+    include ExplainCommand
     include SourceSet
     include RunBudgetOptions
     include ShardOptions
@@ -103,6 +105,7 @@ module Saboteur
       when "run" then run_command
       when "baseline" then baseline
       when "survivors" then survivors_command
+      when "explain" then explain_command
       when "doctor" then doctor_command
       when "badge", "trend" then history_entry(command)
       when "version", "--version" then @out.puts(VERSION) || EXIT_OK

data/lib/saboteur/config.rb

@@ -146,7 +146,7 @@ module Saboteur
       end
 
       from_file = File.file?(path) ? ConfigFile.load(path) : {}
-      new(from_file.merge(stringify(overrides)), root: root)
+      new(from_file.merge(stringify(overrides)), root: root, config_file_present: File.file?(path))
     end
 
     def self.stringify(hash)
@@ -156,11 +156,16 @@ module Saboteur
     # Deprecations found while loading: printed by the CLI, never fatal.
     attr_reader :deprecation_warnings
 
-    def initialize(values = {}, root: Dir.pwd, explicit: nil)
+    # Whether the config file existed at load (#1172): the CLI says once
+    # when a run falls back to defaults because no file was there.
+    attr_reader :config_file_present
+
+    def initialize(values = {}, root: Dir.pwd, explicit: nil, config_file_present: true)
       # Retag the root losslessly: under a non-UTF-8 locale it arrives
       # locale-tagged, and every glob, join and expand below would mix
       # encodings with the UTF-8 patterns from the config file (#231).
       @root = Text.utf8_identity(File.expand_path(root))
+      @config_file_present = config_file_present
       unknown = values.keys - DEFAULTS.keys
       raise ConfigError, "unknown config key(s): #{unknown.join(', ')}" if unknown.any?
 

data/lib/saboteur/crash_report.rb

@@ -38,8 +38,9 @@ module Saboteur
       line = "saboteur: #{summary} - please report it: #{ISSUES_URL}"
       written = write_log(log_path, error)
       line = "#{line}; full backtrace: #{display_path(written)}" if written
-      err.puts(line)
-      err.puts(Reporter::Palette.for(err, mode: color).paint(:fail, VERDICT_LINE))
+      palette = Reporter::Palette.for(err, mode: color)
+      err.puts(palette.paint(:fail, line))
+      err.puts(palette.paint(:fail, VERDICT_LINE))
       err.puts(full_text(error)) if verbose
       out.print(agent_json(summary)) if agent
       EXIT_CRASH

data/lib/saboteur/doctor.rb

@@ -76,7 +76,14 @@ module Saboteur
     # post-boot check re-reads the state without printing a second line.
     def check_coverage
       state = Coverage.state
-      @out.puts "Coverage: #{state}"
+      # "suspended" alone reads as a finding; it is the expected boot state
+      # - coverage is stopped while the app boots and starts for the map
+      # build (#1176). Any other state stays terse: verify_coverage raises.
+      if state == :suspended
+        @out.puts "Coverage: suspended during boot (saboteur starts it for the coverage map)"
+      else
+        @out.puts "Coverage: #{state}"
+      end
       verify_coverage(state)
     end
 
@@ -195,7 +202,9 @@ module Saboteur
           @out.puts "#{key}: #{file} (found)"
         end
       end
-      @config.unmatched_patterns.each { |pattern| @out.puts "Warning: #{pattern} matches no file" }
+      @config.unmatched_patterns.each do |pattern|
+        @out.puts "Warning: #{pattern} matches no file - point include at your code in config/saboteur.rb"
+      end
     end
   end
 end

data/lib/saboteur/engine/boot.rb

@@ -48,7 +48,8 @@ module Saboteur
         return if ::SimpleCov.singleton_class.include?(SimpleCovOff)
 
         ::SimpleCov.singleton_class.prepend(SimpleCovOff)
-        warn "saboteur: SimpleCov.start ignored for this run (saboteur needs Ruby's Coverage itself)"
+        notice = "saboteur: SimpleCov.start ignored for this run (saboteur needs Ruby's Coverage itself)"
+        warn Saboteur::Reporter::Palette.for($stderr).paint(:warn, notice)
       end
 
       # The Rails profile when rails: true, else nil (set by load_target).
@@ -74,7 +75,8 @@ module Saboteur
         # Running outside the bundle or beside an Appraisal gemfile set
         # loads the wrong gems; say so before the spec load fails in
         # confusing ways (#598, #609). Advisory only.
-        EnvironmentHints.all(@root).each { |hint| warn "saboteur: warning: #{hint}" }
+        hints = Saboteur::Reporter::Palette.for($stderr)
+        EnvironmentHints.all(@root).each { |hint| warn hints.paint(:warn, "saboteur: warning: #{hint}") }
         integration.setup
         rails&.after_boot
         @hooks.run(:after_boot)

data/lib/saboteur/engine/coverage_store.rb

@@ -16,6 +16,9 @@ module Saboteur
       include CoverageParts
 
       CACHE_INPUTS = %w[integration require rspec_args rails tests coverage_recorder].freeze
+      # Names the freshest whole-suite map build; read as an untrusted hint:
+      # only a bare 64-hex key joins the cache dir (#427).
+      WHOLE_SUITE_POINTER = "whole-suite-map"
       LOCKFILES = %w[Gemfile.lock gems.locked].freeze
       LOG = "coverage-build.log"
       # RSpec rewrites this on every run (example_status_persistence_file_path),
@@ -31,7 +34,7 @@ module Saboteur
       TAIL_LINE_WIDTH = 300
 
       def initialize(config:, integration:, hooks:, supervisor:, diagnostics:, load_lines: {}, load_methods: {},
-                     timeout_cap: nil, parts: 1)
+                     timeout_cap: nil, parts: 1, whole_suite_run: false)
         @config = config
         @parts = parts
         @integration = integration
@@ -41,6 +44,7 @@ module Saboteur
         @timeout_cap = timeout_cap
         @load_lines = load_lines
         @load_methods = load_methods
+        @whole_suite_run = whole_suite_run
         @root = File.realpath(config.root)
         @root_prefixes = Selection::CoverageMap.root_prefixes(config.root)
       end
@@ -58,14 +62,14 @@ module Saboteur
         path = cache_path(files)
         preloaded = LoadCoverage.preloaded_uninstrumented(files)
         cached = cached_map(files)
-        return refuse_empty_map(cached.with_preloaded(preloaded), files, preloaded) if cached
+        return serve_cached(path, cached, files, preloaded) if cached
 
         note = miss_note(files)
         @diagnostics.inform(note.message(scoped: !@config["tests"].empty?)) if @config["cache"]
         started = Process.clock_gettime(Process::CLOCK_MONOTONIC)
         map = fresh_map(files, note, preloaded)
         build_seconds = Process.clock_gettime(Process::CLOCK_MONOTONIC) - started
-        map.save(path)
+        persist_map(path, map)
         shadow(files, map, note, build_seconds) if shadow?
         note.save
         File.write(File.join(@config.path("cache_dir"), "preview.json"),
@@ -73,6 +77,31 @@ module Saboteur
         map
       end
 
+      # The map a whole-suite coverage build wrote on this tree, or nil.
+      # Survivor presentation consults it (presentation only, never
+      # selection): in a scoped run the run's own map holds only the specs
+      # the run loaded, so a "covered by" list from it can read as complete
+      # when another spec pins the behavior (false survivors by default,
+      # review C1). A full run keys its map with tests: [], so the lookup
+      # overrides a scoped run's --test value.
+      # The map this store's fetch produced (or served from cache): the
+      # run's own selection map, read by survivor presentation (review C1).
+      attr_reader :fetched_map
+
+      def whole_suite_map
+        return nil unless @config["cache"]
+
+        pointer = File.join(@config.path("cache_dir"), WHOLE_SUITE_POINTER)
+        return nil unless File.file?(pointer)
+
+        key = File.read(pointer, encoding: Encoding::UTF_8).strip
+        return nil unless key.match?(/\A[0-9a-f]{64}\z/)
+
+        Selection::CoverageMap.load(File.join(@config.path("cache_dir"), "coverage-#{key}.json"))
+      rescue SystemCallError, EncodingError
+        nil
+      end
+
       private
 
       # The partial map when it is on and safe, else the full build.
@@ -106,6 +135,28 @@ module Saboteur
         @cached_map ||= Selection::CoverageMap.load(cache_path(files))
       end
 
+      def serve_cached(path, cached, files, preloaded)
+        record_whole_suite_map(path)
+        refuse_empty_map(@fetched_map = cached.with_preloaded(preloaded), files, preloaded)
+      end
+
+      def persist_map(path, map)
+        map.save(path)
+        record_whole_suite_map(path)
+        @fetched_map = map
+      end
+
+      # The engine tells us when this run is a whole-suite build (no
+      # --since, no subjects, no explicit --test): remember the map key for
+      # later scoped runs, whose tree has usually drifted past the exact
+      # cache key already (review C1).
+      def record_whole_suite_map(path)
+        return unless @whole_suite_run
+
+        File.write(File.join(@config.path("cache_dir"), WHOLE_SUITE_POINTER),
+                   File.basename(path, ".json").delete_prefix("coverage-"), perm: 0o600)
+      end
+
       def cache_key(files)
         Selection::CoverageMap.cache_key(files: key_files(files), extra: key_inputs)
       end

data/lib/saboteur/engine/distribution.rb

@@ -110,7 +110,11 @@ module Saboteur
       # scheduler stopped mid-list at the budget deadline. Worker-level error
       # rows synthesize an error per candidate, so they never look truncated.
       def unverified_result?(result)
-        result.is_a?(MutantResult) && result.status == :unverified
+        result.is_a?(MutantResult) && result.status == :unverified && !result.flaky?
+      end
+
+      def budget_unverified_row?(result)
+        result["status"] == "unverified" && !MutantResult.flaky_reason?(result["reason"])
       end
 
       def record_unreached(rows, subjects, lists)
@@ -125,7 +129,7 @@ module Saboteur
           next unless row["results"] && !row["error"]
 
           @truncated << [subjects[i], lists[i].size - row["results"].size] if row["results"].size < lists[i].size
-          @unverified << subjects[i] if row["results"].any? { |result| result["status"] == "unverified" }
+          @unverified << subjects[i] if row["results"].any? { |result| budget_unverified_row?(result) }
         end
       end
 

data/lib/saboteur/engine/pipelines.rb

@@ -24,7 +24,9 @@ module Saboteur
                       mutate(subjects, files, integration, scope, ignore_list,
                              load_lines:, load_methods:)
                     end
-          @diagnostics.add_warnings(ignore_list.apply(results, unscoped_digests: @unscoped_digests))
+          warnings = ignore_list.apply(results, subjects: subjects,
+                                                unscoped_digests: @unscoped_digests, full_run: unscoped_full_run?)
+          @diagnostics.add_warnings(warnings)
           build_report(results, subjects, scope, started)
         ensure
           # Cleanup runs however the call ends - a partway boot failure, no
@@ -54,7 +56,9 @@ module Saboteur
         files = config.included_files
         subjects, scope = select_subjects(files)
         results = subjects.empty? ? [] : mutate_external(subjects, scope, ignore_list)
-        @diagnostics.add_warnings(ignore_list.apply(results, unscoped_digests: @unscoped_digests))
+        warnings = ignore_list.apply(results, subjects: subjects,
+                                              unscoped_digests: @unscoped_digests, full_run: unscoped_full_run?)
+        @diagnostics.add_warnings(warnings)
         build_report(results, subjects, scope, started)
       end
 
@@ -97,6 +101,14 @@ module Saboteur
         @diagnostics.warn(warning) if warning
       end
 
+      # "Full run" for ignore staleness (#1206): no --since diff, no --subject
+      # filter, and no narrowed include (explicit file arguments replace the
+      # configured include) - only then was every in-scope subject examined, so
+      # an entry whose subject never appears really points at gone code.
+      def unscoped_full_run?
+        !config["since"] && config["subjects"].empty? && config["include"] == Config::DEFAULTS["include"]
+      end
+
       def external_command? = !config["test_command"].to_s.empty?
 
       # The preflight's absolute monotonic deadline: its own

data/lib/saboteur/engine/result_cache.rb

@@ -16,7 +16,8 @@ module Saboteur
     # same: the method's source, the whole file the method lives in (so a
     # constant or helper changed elsewhere in that file is seen), the mutant,
     # the set of covering tests, the content of those tests' files, the
-    # lockfile, the run's inputs (config, saboteur version), and every source
+    # lockfile, the run's inputs (config, the saboteur version, the Ruby
+    # runtime's engine, version, patchlevel and platform), and every source
     # file a covering test touched (a method it calls, a constant defined
     # elsewhere - #197). Only killed, survived and timeout are stored;
     # errors and skips always run again.
@@ -162,7 +163,8 @@ module Saboteur
 
       def fingerprint(subject, tests)
         digest = Digest::SHA256.new
-        digest << [VERSION, @inputs, @suite_digest, source_set, subject.source].join("\0") << "\0"
+        digest << [VERSION, RUBY_ENGINE, RUBY_VERSION, RUBY_PATCHLEVEL, RUBY_PLATFORM, @inputs, @suite_digest,
+                   source_set, subject.source].join("\0") << "\0"
         # A hex digest has a fixed width, so it needs no separator after it.
         digest << Digest::SHA256.hexdigest(subject.file_source)
         digest_tests(digest, tests)