sabat-rubocop 0.9.0

data/spec/rubocop/config_store_spec.rb

@@ -0,0 +1,66 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  describe ConfigStore do
+    before(:each) { ConfigStore.prepare }
+    before do
+      Config.stub(:configuration_file_for) do |arg|
+        # File tree:
+        # file1
+        # dir/.rubocop.yml
+        # dir/file2
+        # dir/subdir/file3
+        (arg =~ /dir/ ? 'dir' : '.') + '/.rubocop.yml'
+      end
+      Config.stub(:configuration_from_file) { |arg| arg }
+      Config.stub(:load_file) { |arg| "#{arg} loaded" }
+      Config.stub(:merge_with_default) { |config, file| "merged #{config}" }
+    end
+
+    describe '.prepare' do
+      it 'resets @options_config' do
+        ConfigStore.set_options_config(:options_config)
+        ConfigStore.prepare
+        Config.should_receive(:configuration_file_for)
+        ConfigStore.for('file1')
+      end
+
+      it 'resets @config_cache' do
+        ConfigStore.for('file1')
+        ConfigStore.prepare
+        Config.should_receive(:configuration_file_for)
+        ConfigStore.for('file1')
+      end
+    end
+
+    describe '.for' do
+      it 'always uses config specified in command line' do
+        ConfigStore.set_options_config(:options_config)
+        expect(ConfigStore.for('file1')).to eq('merged options_config loaded')
+      end
+
+      context 'when no config specified in command line' do
+        it 'gets config path and config from cache if available' do
+          Config.should_receive(:configuration_file_for).once.with('dir')
+          Config.should_receive(:configuration_file_for).once.with('dir/' +
+                                                                   'subdir')
+          # The stub returns the same config path for dir and dir/subdir.
+          Config.should_receive(:configuration_from_file).once
+            .with('dir/.rubocop.yml')
+
+          ConfigStore.for('dir/file2')
+          ConfigStore.for('dir/file2')
+          ConfigStore.for('dir/subdir/file3')
+        end
+
+        it 'searches for config path if not available in cache' do
+          Config.should_receive(:configuration_file_for).once
+          Config.should_receive(:configuration_from_file).once
+          ConfigStore.for('file1')
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/cop_spec.rb

@@ -0,0 +1,38 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe Cop do
+      let(:cop) { Cop.new }
+      let(:location) do
+        source_buffer = Parser::Source::Buffer.new('test', 1)
+        source_buffer.source = "a\n"
+        Parser::Source::Range.new(source_buffer, 0, 1)
+      end
+
+      it 'initially has 0 offences' do
+        expect(cop.offences).to be_empty
+      end
+
+      it 'keeps track of offences' do
+        cop.add_offence(:convention, location, 'message')
+
+        expect(cop.offences.size).to eq(1)
+      end
+
+      it 'will report registered offences' do
+        cop.add_offence(:convention, location, 'message')
+
+        expect(cop.offences).not_to be_empty
+      end
+
+      it 'registers offence with its name' do
+        cop = Style::AvoidFor.new
+        cop.add_offence(:convention, location, 'message')
+        expect(cop.offences.first.cop_name).to eq('AvoidFor')
+      end
+    end
+  end
+end

data/spec/rubocop/cops/lint/assignment_in_condition_spec.rb

@@ -0,0 +1,111 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Lint
+      describe AssignmentInCondition do
+        let(:cop) { AssignmentInCondition.new }
+        before do
+          AssignmentInCondition.config = { 'AllowSafeAssignment' => true }
+        end
+
+        it 'registers an offence for lvar assignment in condition' do
+          inspect_source(cop,
+                         ['if test = 10',
+                          'end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for lvar assignment in while condition' do
+          inspect_source(cop,
+                         ['while test = 10',
+                          'end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for lvar assignment in until condition' do
+          inspect_source(cop,
+                         ['until test = 10',
+                          'end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for ivar assignment in condition' do
+          inspect_source(cop,
+                         ['if @test = 10',
+                          'end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for clvar assignment in condition' do
+          inspect_source(cop,
+                         ['if @@test = 10',
+                          'end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for gvar assignment in condition' do
+          inspect_source(cop,
+                         ['if $test = 10',
+                          'end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for constant assignment in condition' do
+          inspect_source(cop,
+                         ['if TEST = 10',
+                          'end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'accepts == in condition' do
+          inspect_source(cop,
+                         ['if test == 10',
+                          'end'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'accepts ||= in condition' do
+          inspect_source(cop,
+                         ['raise StandardError unless foo ||= bar'])
+          expect(cop.offences).to be_empty
+        end
+
+        context 'safe assignment is allowed' do
+          it 'accepts = in condition surrounded with braces' do
+            inspect_source(cop,
+                           ['if (test = 10)',
+                            'end'
+                           ])
+            expect(cop.offences).to be_empty
+          end
+
+        end
+
+        context 'safe assignment is not allowed' do
+          before do
+            AssignmentInCondition.config['AllowSafeAssignment'] = false
+          end
+
+          it 'does not accepts = in condition surrounded with braces' do
+            inspect_source(cop,
+                           ['if (test == 10)',
+                           'end'
+                           ])
+            expect(cop.offences).to be_empty
+          end
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/lint/end_alignment_spec.rb

@@ -0,0 +1,333 @@
+# encoding: utf-8
+# rubocop:disable LineLength
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Lint
+      describe EndAlignment do
+        let(:cop) { EndAlignment.new }
+
+        it 'registers an offence for mismatched class end' do
+          inspect_source(cop,
+                         ['class Test',
+                          '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for mismatched module end' do
+          inspect_source(cop,
+                         ['module Test',
+                          '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for mismatched def end' do
+          inspect_source(cop,
+                         ['def test',
+                          '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for mismatched defs end' do
+          inspect_source(cop,
+                         ['def Test.test',
+                          '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for mismatched if end' do
+          inspect_source(cop,
+                         ['if test',
+                          '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for mismatched while end' do
+          inspect_source(cop,
+                         ['while test',
+                          '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for mismatched until end' do
+          inspect_source(cop,
+                         ['until test',
+                          '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'registers an offence for mismatched block end' do
+          inspect_source(cop,
+                         ['test do |ala|',
+                          '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        context 'when the block is a logical operand' do
+          it 'accepts a correctly aligned block end' do
+            inspect_source(cop,
+                           ['(value.is_a? Array) && value.all? do |subvalue|',
+                            '  type_check_value(subvalue, array_type)',
+                            'end',
+                            'a || b do',
+                            'end',
+                           ])
+            expect(cop.offences).to be_empty
+          end
+        end
+
+        it 'accepts end aligned with a variable' do
+          inspect_source(cop,
+                         ['variable = test do |ala|',
+                         'end'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        context 'and the block is an operand' do
+          it 'accepts end aligned with a variable' do
+            inspect_source(cop,
+                           ['b = 1 + preceding_line.reduce(0) do |a, e|',
+                           '  a + e.length + newline_length',
+                           'end + 1'
+                           ])
+            expect(cop.offences).to be_empty
+          end
+        end
+
+        it 'registers an offence for mismatched block end with a variable' do
+          inspect_source(cop,
+                         ['variable = test do |ala|',
+                         '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        context 'when the block is defined on the next line' do
+          it 'accepts end aligned with the block expression' do
+            inspect_source(cop,
+                           ['variable =',
+                            '  a_long_method_that_dont_fit_on_the_line do |v|',
+                            '    v.foo',
+                            '  end'
+                           ])
+            expect(cop.offences).to be_empty
+          end
+
+          it 'registers an offences for mismatched end alignment' do
+            inspect_source(cop,
+                           ['variable =',
+                            '  a_long_method_that_dont_fit_on_the_line do |v|',
+                            '    v.foo',
+                            'end'
+                           ])
+            expect(cop.offences.size).to eq(1)
+          end
+        end
+
+        it 'accepts end aligned with an instance variable' do
+          inspect_source(cop,
+                         ['@variable = test do |ala|',
+                         'end'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'registers an offence for mismatched block end with an instance variable' do
+          inspect_source(cop,
+                         ['@variable = test do |ala|',
+                         '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'accepts end aligned with a class variable' do
+          inspect_source(cop,
+                         ['@@variable = test do |ala|',
+                         'end'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'registers an offence for mismatched block end with a class variable' do
+          inspect_source(cop,
+                         ['@@variable = test do |ala|',
+                         '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'accepts end aligned with a global variable' do
+          inspect_source(cop,
+                         ['$variable = test do |ala|',
+                         'end'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'registers an offence for mismatched block end with a global variable' do
+          inspect_source(cop,
+                         ['$variable = test do |ala|',
+                         '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'accepts end aligned with a constant' do
+          inspect_source(cop,
+                         ['CONSTANT = test do |ala|',
+                         'end'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'registers an offence for mismatched block end with a constant' do
+          inspect_source(cop,
+                         ['Module::CONSTANT = test do |ala|',
+                         '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'accepts end aligned with a method call' do
+          inspect_source(cop,
+                         ['parser.childs << lambda do |token|',
+                         '  token << 1',
+                         'end'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'registers an offence for mismatched block end with a method call' do
+          inspect_source(cop,
+                         ['parser.childs << lambda do |token|',
+                         '  token << 1',
+                         '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'accepts end aligned with a method call with arguments' do
+          inspect_source(cop,
+                         ['@h[:f] = f.each_pair.map do |f, v|',
+                         '  v = 1',
+                         'end'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'registers an offence for mismatched end with a method call with arguments' do
+          inspect_source(cop,
+                         ['@h[:f] = f.each_pair.map do |f, v|',
+                         '  v = 1',
+                         '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'does not raise an error for nested block in a method call' do
+          inspect_source(cop,
+                         ['expect(arr.all? { |o| o.valid? })'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'accepts end aligned with the outermost method in the method chain that calls the block' do
+          inspect_source(cop,
+                         ['expect(arr.all? do |o|',
+                         '  o.valid?',
+                         'end)'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'registers an offence for mismatched end aligned with the outermost method in the method chain that calls the block' do
+          inspect_source(cop,
+                         ['expect(arr.all? do |o|',
+                         '  o.valid?',
+                         '  end)'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'accepts end aligned with an op-asgn (+=, -=)' do
+          inspect_source(cop,
+                         ['rb += files.select do |file|',
+                         '  file << something',
+                         'end'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'registers an offence for mismatched block end with an op-asgn (+=, -=)' do
+          inspect_source(cop,
+                         ['rb += files.select do |file|',
+                         '  file << something',
+                         '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'accepts end aligned with an and-asgn (&&=)' do
+          inspect_source(cop,
+                         ['variable &&= test do |ala|',
+                         'end'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'registers an offence for mismatched block end with an and-asgn (&&=)' do
+          inspect_source(cop,
+                         ['variable &&= test do |ala|',
+                         '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'accepts end aligned with an or-asgn (||=)' do
+          inspect_source(cop,
+                         ['variable ||= test do |ala|',
+                         'end'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'registers an offence for mismatched block end with an or-asgn (||=)' do
+          inspect_source(cop,
+                         ['variable ||= test do |ala|',
+                         '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+
+        it 'accepts end aligned with a mass assignment' do
+          inspect_source(cop,
+                         ['var1, var2 = lambda do |test|',
+                         '  [1, 2]',
+                         'end'
+                         ])
+          expect(cop.offences).to be_empty
+        end
+
+        it 'registers an offence for mismatched block end with a mass assignment' do
+          inspect_source(cop,
+                         ['var1, var2 = lambda do |test|',
+                         '  [1, 2]',
+                         '  end'
+                         ])
+          expect(cop.offences.size).to eq(1)
+        end
+      end
+    end
+  end
+end