s3_form_presenter 0.0.2 → 0.0.3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    s3_form_presenter (0.0.2)
+    s3_form_presenter (0.0.3)
 
 GEM
   remote: http://rubygems.org/

data/README.md

@@ -4,10 +4,10 @@ Generates a simple form that is compatible with S3's form API. You can upload S3
 
 ## Usage
 
-```ruby
-<% S3FormPresenter::Form.new("some/key/path.ext") do %>
+```
+<% S3FormPresenter::Form.new("some/key/path.ext", "http://www.theredirecttowebsite.com/redirect/to/this/path") do %>
   <input name="file" type="file">
-	<input type="submit" value="Save File">
+  <input type="submit" value="Save File">
 <% end %>
 ```
 

data/lib/s3_form_presenter/version.rb

@@ -1,3 +1,3 @@
 module S3FormPresenter
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/s3_form_presenter.rb

@@ -9,13 +9,14 @@ module S3FormPresenter
     RENAMED_FIELDS = {:redirect_url => "success_action_redirect", :access_key => "AWSAccessKeyId"}
     attr_accessor :bucket, :inner_content, :extra_form_attributes
 
-    def initialize(key, options={}, &block)
+    def initialize(key, redirect_url, options={}, &block)
       @key = key
       @access_key = options[:access_key] || ENV["AWS_ACCESS_KEY_ID"]
       @secret_key = options[:secret_key] || ENV["AWS_SECRET_ACCESS_KEY"]
       @bucket = options[:bucket] || ENV["AWS_S3_BUCKET"]
-      @acl = options[:acl]
+      @acl = options[:acl] || :private
       @extra_form_attributes = options[:extra_form_attributes]
+      @redirect_url = redirect_url
       if block_given?
         @inner_content = block.call
       else

data/test/form_test.rb

@@ -4,7 +4,7 @@ include S3FormPresenter
 
 describe S3FormPresenter::Form do
   before do
-    @form = Form.new("some/test/key.ext") do
+    @form = Form.new("some/test/key.ext", "http://www.someurl.com/comeback") do
       %Q(<input name="file" type="file"><input type="submit" value="Upload File" class="btn btn-primary">)
     end
     @form.bucket = "test_bucket"
@@ -15,24 +15,35 @@ describe S3FormPresenter::Form do
   end
 
   describe "initializer" do
+    describe "defaults" do
+      before do
+        @form = Form.new("some/test/key", "http://www.someurl.com/comeback")
+      end
+
+      it "should specify some defaults" do
+        @form.acl.must_equal :private
+      end
+    end
+
     it "allows an empty block and provides a sane default" do
-      @form = Form.new("some/test/key.ext").inner_content.must_equal %Q(<input name="file" type="file"><input type="submit" value="Upload File" class="btn btn-primary">)
+      @form = Form.new("some/test/key.ext", "http://www.someurl.com/comeback").inner_content.must_equal %Q(<input name="file" type="file"><input type="submit" value="Upload File" class="btn btn-primary">)
     end
 
     it "should let you override access_key, secret_key and bucket with ENV" do
       ENV["AWS_ACCESS_KEY_ID"] = "overridden_env_access_key"
       ENV["AWS_SECRET_ACCESS_KEY"] = "overridden_env_secret_key"
       ENV["AWS_S3_BUCKET"] = "overridden_env_bucket"
-      @form = Form.new("some/test/key.ext").access_key.must_equal "overridden_env_access_key"
-      @form = Form.new("some/test/key.ext").secret_key.must_equal "overridden_env_secret_key"
-      @form = Form.new("some/test/key.ext").bucket.must_equal "overridden_env_bucket"
+      @form = Form.new("some/test/key.ext", "http://www.someurl.com/comeback")
+      @form.access_key.must_equal "overridden_env_access_key"
+      @form.secret_key.must_equal "overridden_env_secret_key"
+      @form.bucket.must_equal "overridden_env_bucket"
     end
 
     it "should let you override access_key, secret_key and bucket and acl with options in the initializer" do
-      @form = Form.new("some/test/key.ext", :access_key => "overridden_options_access_key").access_key.must_equal "overridden_options_access_key"
-      @form = Form.new("some/test/key.ext", :secret_key => "overridden_options_secret_key").secret_key.must_equal "overridden_options_secret_key"
-      @form = Form.new("some/test/key.ext", :bucket => "overridden_options_bucket").bucket.must_equal "overridden_options_bucket"
-      @form = Form.new("some/test/key.ext", :acl => "overridden_options_acl").acl.must_equal "overridden_options_acl"
+      Form.new("some/test/key.ext", "http://www.someurl.com/comeback", :access_key => "overridden_options_access_key").access_key.must_equal "overridden_options_access_key"
+      Form.new("some/test/key.ext", "http://www.someurl.com/comeback", :secret_key => "overridden_options_secret_key").secret_key.must_equal "overridden_options_secret_key"
+      Form.new("some/test/key.ext", "http://www.someurl.com/comeback", :bucket => "overridden_options_bucket").bucket.must_equal "overridden_options_bucket"
+      Form.new("some/test/key.ext", "http://www.someurl.com/comeback", :acl => "overridden_options_acl").acl.must_equal "overridden_options_acl"
     end
   end
 
@@ -109,7 +120,7 @@ describe S3FormPresenter::Form do
 
   describe "extra_form_attributes" do
     it "generates extra form attributes when provided in options" do
-      Form.new("some/key.ext", :extra_form_attributes => %Q( class="form-horizontal")).header.must_equal %Q(<form action="http://.s3.amazonaws.com/" method="post" enctype="multipart/form-data" class="form-horizontal">)
+      Form.new("some/key.ext", "http://www.someurl.com/comeback", :extra_form_attributes => %Q( class="form-horizontal")).header.must_equal %Q(<form action="http://.s3.amazonaws.com/" method="post" enctype="multipart/form-data" class="form-horizontal">)
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: s3_form_presenter
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -44,7 +44,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1039604683610752818
+      hash: 3980563017398046619
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -53,7 +53,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1039604683610752818
+      hash: 3980563017398046619
 requirements: []
 rubyforge_project: s3_form_presenter
 rubygems_version: 1.8.15