ryanb-thinking_sphinx 0.9.8

data/lib/thinking_sphinx/tasks.rb

@@ -0,0 +1,86 @@
+require 'fileutils'
+
+namespace :thinking_sphinx do
+  task :app_env do
+    Rake::Task[:environment].invoke if defined?(RAILS_ROOT)
+    Rake::Task[:merb_env].invoke    if defined?(Merb)
+  end
+  
+  desc "Start a Sphinx searchd daemon using Thinking Sphinx's settings"
+  task :start => :app_env do
+    config = ThinkingSphinx::Configuration.new
+    
+    FileUtils.mkdir_p config.searchd_file_path
+    raise RuntimeError, "searchd is already running." if sphinx_running?
+    
+    Dir["#{config.searchd_file_path}/*.spl"].each { |file| File.delete(file) }
+    
+    cmd = "searchd --config #{config.config_file}"
+    puts cmd
+    system cmd
+    
+    sleep(2)
+    
+    if sphinx_running?
+      puts "Started successfully (pid #{sphinx_pid})."
+    else
+      puts "Failed to start searchd daemon. Check #{config.searchd_log_file}."
+    end
+  end
+  
+  desc "Stop Sphinx using Thinking Sphinx's settings"
+  task :stop => :app_env do
+    raise RuntimeError, "searchd is not running." unless sphinx_running?
+    pid = sphinx_pid
+    system "kill #{pid}"
+    puts "Stopped search daemon (pid #{pid})."
+  end
+  
+  desc "Restart Sphinx"
+  task :restart => [:app_env, :stop, :start]
+  
+  desc "Generate the Sphinx configuration file using Thinking Sphinx's settings"
+  task :configure => :app_env do
+    ThinkingSphinx::Configuration.new.build
+  end
+  
+  desc "Index data for Sphinx using Thinking Sphinx's settings"
+  task :index => [:app_env, :configure] do
+    config = ThinkingSphinx::Configuration.new
+    
+    FileUtils.mkdir_p config.searchd_file_path
+    cmd = "indexer --config #{config.config_file} --all"
+    cmd << " --rotate" if sphinx_running?
+    puts cmd
+    system cmd
+  end
+end
+
+namespace :ts do
+  desc "Start a Sphinx searchd daemon using Thinking Sphinx's settings"
+  task :start   => "thinking_sphinx:start"
+  desc "Stop Sphinx using Thinking Sphinx's settings"
+  task :stop    => "thinking_sphinx:stop"
+  desc "Index data for Sphinx using Thinking Sphinx's settings"
+  task :in      => "thinking_sphinx:index"
+  desc "Index data for Sphinx using Thinking Sphinx's settings"
+  task :index   => "thinking_sphinx:index"
+  desc "Restart Sphinx"
+  task :restart => "thinking_sphinx:restart"
+  desc "Generate the Sphinx configuration file using Thinking Sphinx's settings"
+  task :config  => "thinking_sphinx:configure"
+end
+
+def sphinx_pid
+  config = ThinkingSphinx::Configuration.new
+  
+  if File.exists?(config.pid_file)
+    `cat #{config.pid_file}`[/\d+/]
+  else
+    nil
+  end
+end
+
+def sphinx_running?
+  sphinx_pid && `ps -p #{sphinx_pid} | wc -l`.to_i > 1
+end

data/spec/unit/thinking_sphinx/active_record/delta_spec.rb

@@ -0,0 +1,207 @@
+require 'spec/spec_helper'
+
+describe "ThinkingSphinx::ActiveRecord::Delta" do
+  describe "after_commit callback" do
+    before :each do
+      Person.stub_method(:write_inheritable_array => true)
+    end
+
+    # This spec only passes with ActiveRecord 2.0.2 or earlier.
+    # it "should add callbacks" do
+    #   Person.after_commit :toggle_delta
+    #   
+    #   Person.should have_received(:write_inheritable_array).with(
+    #     :after_commit, [:toggle_delta]
+    #   )
+    # end
+    
+    it "should have an after_commit method by default" do
+      Person.instance_methods.should include("after_commit")
+    end
+  end
+  
+  describe "save_with_after_commit_callback method" do
+    before :each do
+      @person = Person.new
+      @person.stub_methods(
+        :save_without_after_commit_callback => true,
+        :callback                           => true
+      )
+    end
+    
+    it "should call the normal save method" do
+      @person.save
+      
+      @person.should have_received(:save_without_after_commit_callback)
+    end
+    
+    it "should call the callbacks if the save was successful" do
+      @person.save
+      
+      @person.should have_received(:callback).with(:after_commit)
+    end
+    
+    it "shouldn't call the callbacks if the save failed" do
+      @person.stub_method(:save_without_after_commit_callback => false)
+      
+      @person.save
+      
+      @person.should_not have_received(:callback)
+    end
+    
+    it "should return the normal save's result" do
+      @person.save.should be_true
+      
+      @person.stub_method(:save_without_after_commit_callback => false)
+      
+      @person.save.should be_false
+    end
+  end
+  
+  describe "save_with_after_commit_callback! method" do
+    before :each do
+      @person = Person.new
+      @person.stub_methods(
+        :save_without_after_commit_callback! => true,
+        :callback                            => true
+      )
+    end
+    
+    it "should call the normal save! method" do
+      @person.save!
+      
+      @person.should have_received(:save_without_after_commit_callback!)
+    end
+    
+    it "should call the callbacks if the save! was successful" do
+      @person.save!
+      
+      @person.should have_received(:callback).with(:after_commit)
+    end
+    
+    it "shouldn't call the callbacks if the save! failed" do
+      @person.stub_method(:save_without_after_commit_callback! => false)
+      
+      @person.save!
+      
+      @person.should_not have_received(:callback)
+    end
+    
+    it "should return the normal save's result" do
+      @person.save!.should be_true
+      
+      @person.stub_method(:save_without_after_commit_callback! => false)
+      
+      @person.save!.should be_false
+    end
+  end
+  
+  describe "destroy_with_after_commit_callback method" do
+    before :each do
+      @person = Person.new
+      @person.stub_methods(
+        :destroy_without_after_commit_callback  => true,
+        :callback                               => true
+      )
+    end
+    
+    it "should call the normal destroy method" do
+      @person.destroy
+      
+      @person.should have_received(:destroy_without_after_commit_callback)
+    end
+    
+    it "should call the callbacks if the destroy was successful" do
+      @person.destroy
+      
+      @person.should have_received(:callback).with(:after_commit)
+    end
+    
+    it "shouldn't call the callbacks if the destroy failed" do
+      @person.stub_method(:destroy_without_after_commit_callback => false)
+      
+      @person.destroy
+      
+      @person.should_not have_received(:callback)
+    end
+    
+    it "should return the normal save's result" do
+      @person.destroy.should be_true
+      
+      @person.stub_method(:destroy_without_after_commit_callback => false)
+      
+      @person.destroy.should be_false
+    end
+  end
+  
+  describe "toggle_delta method" do
+    it "should set the delta value to true" do
+      @person = Person.new
+      
+      @person.delta.should be_false
+      @person.send(:toggle_delta)
+      @person.delta.should be_true
+    end
+  end
+  
+  describe "index_delta method" do
+    before :each do
+      ThinkingSphinx::Configuration.stub_method(:environment => "spec")
+      ThinkingSphinx.stub_method(:deltas_enabled? => true)
+      
+      @person = Person.new
+      @person.stub_method(:system => true, :in_core_index? => false)
+      
+      @client = Riddle::Client.stub_instance(:update => true)
+      Riddle::Client.stub_method(:new => @client)
+    end
+    
+    it "shouldn't index if delta indexing is disabled" do
+      ThinkingSphinx.stub_method(:deltas_enabled? => false)
+      
+      @person.send(:index_delta)
+      
+      @person.should_not have_received(:system)
+      @client.should_not have_received(:update)
+    end
+    
+    it "shouldn't index if index updating is disabled" do
+      ThinkingSphinx.stub_method(:updates_enabled? => false)
+      
+      @person.send(:index_delta)
+      
+      @person.should_not have_received(:system)
+    end
+    
+    it "shouldn't index if the environment is 'test'" do
+      ThinkingSphinx.unstub_method(:deltas_enabled?)
+      ThinkingSphinx::Configuration.stub_method(:environment => "test")
+      
+      @person.send(:index_delta)
+      
+      @person.should_not have_received(:system)
+    end
+    
+    it "should call indexer for the delta index" do
+      @person.send(:index_delta)
+      
+      @person.should have_received(:system).with(
+        "indexer --config #{ThinkingSphinx::Configuration.new.config_file} --rotate person_delta"
+      )
+    end
+    
+    it "shouldn't update the deleted attribute if not in the index" do
+      @person.send(:index_delta)
+      
+      @client.should_not have_received(:update)
+    end
+    
+    it "should update the deleted attribute if in the core index" do
+      @person.stub_method(:in_core_index? => true)
+      
+      @person.send(:index_delta)
+      
+      @client.should have_received(:update)
+    end
+  end
+end

data/spec/unit/thinking_sphinx/active_record/has_many_association_spec.rb

@@ -0,0 +1,53 @@
+require 'spec/spec_helper'
+
+describe 'ThinkingSphinx::ActiveRecord::HasManyAssociation' do
+  describe "search method" do
+    before :each do
+      Friendship.stub_method(:search => true)
+      
+      @person = Person.find(:first)
+      @index  = Friendship.indexes.first
+    end
+    
+    it "should raise an error if the required attribute doesn't exist" do
+      @index.stub_method(:attributes => [])
+      
+      lambda { @person.friendships.search "test" }.should raise_error(RuntimeError)
+      
+      @index.unstub_method(:attributes)
+    end
+    
+    it "should add a filter for the attribute into a normal search call" do
+      @person.friendships.search "test"
+      
+      Friendship.should have_received(:search).with(
+        "test", :with => {:person_id => @person.id}
+      )
+    end    
+  end
+  
+  describe "search method for has_many :through" do
+    before :each do
+      Person.stub_method(:search => true)
+      
+      @person = Person.find(:first)
+      @index  = Person.indexes.first
+    end
+    
+    it "should raise an error if the required attribute doesn't exist" do
+      @index.stub_method(:attributes => [])
+      
+      lambda { @person.friends.search "test" }.should raise_error(RuntimeError)
+      
+      @index.unstub_method(:attributes)
+    end
+    
+    it "should add a filter for the attribute into a normal search call" do
+      @person.friends.search "test"
+      
+      Person.should have_received(:search).with(
+        "test", :with => {:friendly_ids => @person.id}
+      )
+    end
+  end
+end

data/spec/unit/thinking_sphinx/active_record/search_spec.rb

@@ -0,0 +1,107 @@
+require 'spec/spec_helper'
+
+describe "ThinkingSphinx::ActiveRecord::Search" do
+  it "should add search_for_ids to ActiveRecord::Base" do
+    ActiveRecord::Base.methods.should include("search_for_ids")
+  end
+  
+  it "should add search_for_ids to ActiveRecord::Base" do
+    ActiveRecord::Base.methods.should include("search")
+  end
+  
+  it "should add search_count to ActiveRecord::Base" do
+    ActiveRecord::Base.methods.should include("search_count")
+  end
+
+  it "should add search_for_id to ActiveRecord::Base" do
+    ActiveRecord::Base.methods.should include("search_for_id")
+  end
+  
+  describe "search_for_ids method" do
+    before :each do
+      ThinkingSphinx::Search.stub_method(:search_for_ids => true)
+    end
+    
+    it "should call ThinkingSphinx::Search#search_for_ids with the class option set" do
+      Person.search_for_ids("search")
+      
+      ThinkingSphinx::Search.should have_received(:search_for_ids).with(
+        "search", :class => Person
+      )
+    end
+    
+    it "should override the class option" do
+      Person.search_for_ids("search", :class => Friendship)
+      
+      ThinkingSphinx::Search.should have_received(:search_for_ids).with(
+        "search", :class => Person
+      )
+    end
+  end
+  
+  describe "search method" do
+    before :each do
+      ThinkingSphinx::Search.stub_method(:search => true)
+    end
+    
+    it "should call ThinkingSphinx::Search#search with the class option set" do
+      Person.search("search")
+      
+      ThinkingSphinx::Search.should have_received(:search).with(
+        "search", :class => Person
+      )
+    end
+    
+    it "should override the class option" do
+      Person.search("search", :class => Friendship)
+      
+      ThinkingSphinx::Search.should have_received(:search).with(
+        "search", :class => Person
+      )
+    end
+  end
+  
+  describe "search_for_id method" do
+    before :each do
+      ThinkingSphinx::Search.stub_method(:search_for_id => true)
+    end
+    
+    it "should call ThinkingSphinx::Search#search with the class option set" do
+      Person.search_for_id(10)
+      
+      ThinkingSphinx::Search.should have_received(:search_for_id).with(
+        10, :class => Person
+      )
+    end
+    
+    it "should override the class option" do
+      Person.search_for_id(10, :class => Friendship)
+      
+      ThinkingSphinx::Search.should have_received(:search_for_id).with(
+        10, :class => Person
+      )
+    end
+  end
+
+  describe "search_count method" do
+    before :each do
+      ThinkingSphinx::Search.stub_method(:count => true)
+    end
+
+    it "should call ThinkingSphinx::Search#search with the class option set" do
+      Person.search_count("search")
+
+      ThinkingSphinx::Search.should have_received(:count).with(
+        "search", :class => Person
+      )
+    end
+
+    it "should override the class option" do
+      Person.search_count("search", :class => Friendship)
+
+      ThinkingSphinx::Search.should have_received(:count).with(
+        "search", :class => Person
+      )
+    end
+  end
+end