rvista 0.6.1 → 0.6.2

data/CHANGELOG

@@ -1,3 +1,6 @@
+v0.6.2 (19th August 2009)
+- don't barf on input files with quotes in them
+
 v0.6.1 (17th June 2009)
 - improve return values from RVista::POALineItem#status_text
 

data/Rakefile

@@ -5,7 +5,7 @@ require 'rake/testtask'
 require "rake/gempackagetask"
 require "rubygems"
 
-PKG_VERSION = "0.6.1"
+PKG_VERSION = "0.6.2"
 PKG_NAME = "rvista"
 PKG_FILE_NAME = "#{PKG_NAME}-#{PKG_VERSION}"
 

data/lib/rvista/invoice.rb

@@ -19,14 +19,14 @@ module RVista
     # that specifies the file path
     def self.load_from_file(input)
       raise InvalidFileError, 'Invalid file' unless File.exist?(input)
-      data = FasterCSV.read(input)
+      data = FasterCSV.read(input, :quote_char => "`")
       return self.build_message(data)
     end
 
     # creates a RVista::Invoice object from a string. Input should
     # be a complete vista file as a string
     def self.load_from_string(input)
-      data = FasterCSV.parse(input)
+      data = FasterCSV.parse(input, :quote_char => "`")
       return self.build_message(data)
     end
 

data/lib/rvista/po.rb

@@ -22,14 +22,14 @@ module RVista
     # that specifies the file path
     def self.load_from_file(input)
       raise InvalidFileError, 'Invalid file' unless File.exist?(input)
-      data = FasterCSV.read(input)
+      data = FasterCSV.read(input, :quote_char => "`")
       return self.build_message(data)
     end
 
     # creates a RVista::Message object from a string. Input should
     # be a complete vista file as a string
     def self.load_from_string(input)
-      data = FasterCSV.parse(input)
+      data = FasterCSV.parse(input, :quote_char => "`")
       return self.build_message(data)
     end
 

data/lib/rvista/poa.rb

@@ -19,14 +19,14 @@ module RVista
     # that specifies the file path
     def self.load_from_file(input)
       raise InvalidFileError, 'Invalid file' unless File.exist?(input)
-      data = FasterCSV.read(input)
+      data = FasterCSV.read(input, :quote_char => "`")
       return self.build_message(data)
     end
 
     # creates a RVista::POA object from a string. Input should
     # be a complete vista file as a string
     def self.load_from_string(input)
-      data = FasterCSV.parse(input)
+      data = FasterCSV.parse(input, :quote_char => "`")
       return self.build_message(data)
     end
 

data/test/data/po/quotes.txt

@@ -0,0 +1,13 @@
+H,9027378,9013725,,16742,,00,,090819,,000000,000000,,,,,,9027378,,,
+D,1,EN,9780486264035,Little Zoo Animals Coloring Bo,1,0.00,EA,,,40000,Y,,
+D,2,EN,9780517228678,Vampire Stories,1,0.00,EA,,,40000,Y,,
+D,3,EN,9780566087721,Project Management : 9Th Editi,1,0.00,EA,,,40000,Y,,
+D,4,EN,9780566087981,Understanding and Managing Ris,1,0.00,EA,,,40000,Y,,
+D,5,EN,9780754645986,Safety at the Sharp End : Trai,1,0.00,EA,,,40000,Y,,
+D,6,EN,9780754651772,After Sibelius : Studies in Fi,1,0.00,EA,,,40000,Y,,
+D,7,EN,9780754658115,The Counts of Laval : Culture ,1,0.00,EA,,,40000,Y,,
+D,8,EN,9780827230262,Unveiling the Secret Life of B,1,0.00,EA,,,40000,Y,,
+D,9,EN,9781426700187,Noah's Very Big Boat,1,0.00,EA,,,40000,Y,,
+D,10,EN,9781426700231,The Cool Cat: A Modern "Tail",1,0.00,EA,,,40000,Y,,
+D,11,EN,9781921421259,The Climate Caper,4,0.00,EA,,,40000,Y,,
+S,11,,

data/test/unit/message_test.rb

@@ -6,6 +6,7 @@ require 'rvista'
 class POTest < Test::Unit::TestCase
 
   VALID = File.dirname(__FILE__) + "/../data/po/valid.txt"
+  VALID_QUOTES = File.dirname(__FILE__) + "/../data/po/quotes.txt"
   INVALID_MISSING_HEADER = File.dirname(__FILE__) + "/../data/po/invalid_missing_header.txt"
   INVALID_MISSING_FOOTER = File.dirname(__FILE__) + "/../data/po/invalid_missing_footer.txt"
   INVALID_LINE = File.dirname(__FILE__) + "/../data/po/invalid_line.txt"
@@ -18,7 +19,6 @@ class POTest < Test::Unit::TestCase
     assert_equal msg.items.size, 38
 
     validate_msg(msg)
-      
   end
 
   # ensure the load_from_file method works as expected
@@ -26,14 +26,23 @@ class POTest < Test::Unit::TestCase
     msg = RVista::PO.load_from_string(File.read(VALID))
     assert_kind_of RVista::PO, msg
     assert_equal msg.items.size, 38
-    
+
     validate_msg(msg)
   end
 
+  # ensure files that (probably incorrectly) contain quotes can be
+  # parsed.
+  #
+  def test_files_with_quotes
+    msg = RVista::PO.load_from_string(File.read(VALID_QUOTES))
+    assert_kind_of RVista::PO, msg
+    assert_equal msg.items.size, 11
+  end
+
   # ensure the load_from_file method throws the correct exceptions
   # when it encounters a problem
   def test_product_validation
-    
+
     assert_raise(RVista::InvalidFileError) {
       msg = RVista::PO.load_from_file(INVALID_MISSING_HEADER)
     }
@@ -41,7 +50,7 @@ class POTest < Test::Unit::TestCase
     assert_raise(RVista::InvalidFileError) {
       msg = RVista::PO.load_from_file(INVALID_MISSING_FOOTER)
     }
-    
+
     assert_raise(RVista::InvalidLineItemError) {
       msg = RVista::PO.load_from_file(INVALID_LINE)
     }

data/test/unit/poa_line_item_test.rb

@@ -63,7 +63,7 @@ class POALineItemTest < Test::Unit::TestCase
 
   def test_status_text
     item = RVista::POALineItem.load_from_array(@row)
-    assert_equal item.status_text, "Shipped as ordered"
+    assert_equal "Accepted: Title Shipped As Ordered", item.status_text
   end
 
   def test_to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rvista
 version: !ruby/object:Gem::Version 
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors: 
 - James Healy
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-17 00:00:00 +10:00
+date: 2009-08-19 00:00:00 +10:00
 default_executable: 
 dependencies: []
 
@@ -43,6 +43,7 @@ files:
 - test/data/po/no_delivery_location.txt
 - test/data/po/seperate_delivery_location.txt
 - test/data/po/valid.txt
+- test/data/po/quotes.txt
 - test/data/poa/invalid_line.txt
 - test/data/poa/invalid_missing_footer.txt
 - test/data/poa/invalid_missing_header.txt