rux 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8b60a8c9f9753af9e86862c0f907f726d5c853e2e7c96613d681ea36f6859ac
-  data.tar.gz: 4ed1a4772678e181f7fa67ccdd4814e726a2731145e0c8a419261c2b40ad4f36
+  metadata.gz: 2bce30eb18d21630d6f5734554e7f81d24443cad2b97134127a606c2f9f0c341
+  data.tar.gz: 8925dcc3f10f9a21f03951c27218f17c9e6dc491a8b3c08864d5cd06650ccf07
 SHA512:
-  metadata.gz: f70d67e41488c9dc648d4f05692813fe7b00ee86fc3ce34511ab75ad27de888578558775cb075f29b32df3876d0fbc7dfad78be43bdda5c198c52be8a05e5707
-  data.tar.gz: c43ab2dbbeeb1ae8ec17b68cb2b24df38e167787b85004bc6085669fb5963180e7f41712f4b41a5697190e851494e575927a21ed01b3800705b721f399eb76fa
+  metadata.gz: fa4a8295e55aa4bc1be19afbba78f61633ed384752f85f3f19e61e1b5c8566e8ccb26a354bf679c95e671082eefdbb7b66fc7edefbaf57c8527bf66eb2b3d03a
+  data.tar.gz: 4ae2860e39d8ea6ec56b1c4679b4ffd4418a5fa83ba1b30ac71137938e9f66267aecdbd2ef65d4f141108df5f5a99a305b2e051bfdcc513172c7f48f0859eb96

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.1.1
+* Don't slugify HTML attributes.
+  - Previously rux would emit `<div data-foo="bar">` as `<div data_foo="bar">` because it treated HTML attributes as if they were being passed as Ruby arguments, which don't allow dashes. If these arguments are passed to a component initializer, then they must be slugified, but HTML attributes shouldn't be affected.
+
 # 1.1.0
 * Remove newlines between elements. (@aalin, #3)
 

data/lib/rux/ast/tag_node.rb

@@ -12,6 +12,10 @@ module Rux
       def accept(visitor)
         visitor.visit_tag(self)
       end
+
+      def component?
+        name.start_with?(/[A-Z]/)
+      end
     end
   end
 end

data/lib/rux/default_visitor.rb

@@ -22,10 +22,10 @@ module Rux
 
         at = node.attrs.each_with_object([]) do |(k, v), ret|
           next if k == 'as'
-          ret << Utils.attr_to_hash_elem(k, visit(v))
+          ret << Utils.attr_to_hash_elem(k, visit(v), slugify: node.component?)
         end
 
-        if node.name.start_with?(/[A-Z]/)
+        if node.component?
           result << "render(#{node.name}.new"
 
           unless node.attrs.empty?

data/lib/rux/utils.rb

@@ -1,7 +1,7 @@
 module Rux
   module Utils
-    def attr_to_hash_elem(key, value)
-      key = key.gsub('-', '_')
+    def attr_to_hash_elem(key, value, slugify: true)
+      key = key.gsub('-', '_') if slugify
 
       if key =~ /\A[\w\d]+\z/
         "#{key}: #{value}"

data/lib/rux/version.rb

@@ -1,3 +1,3 @@
 module Rux
-  VERSION = '1.1.0'
+  VERSION = '1.1.1'
 end

data/spec/parser_spec.rb

@@ -270,4 +270,22 @@ describe Rux::Parser do
       }
     RUBY
   end
+
+  it 'slugifies ruby arguments' do
+    code = <<~RUX
+      <Hello data-foo="bar" />
+    RUX
+    expect(compile(code)).to eq(<<~RUBY.strip)
+      render(Hello.new(data_foo: "bar"))
+    RUBY
+  end
+
+  it 'does not slugify HTML attributes' do
+    code = <<~RUX
+      <div data-foo="bar" />
+    RUX
+    expect(compile(code)).to eq(<<~RUBY.strip)
+      Rux.tag("div", { :"data-foo" => "bar" })
+    RUBY
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rux
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Cameron Dutro
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-12-17 00:00:00.000000000 Z
+date: 2023-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -97,7 +97,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.4.5
 signing_key:
 specification_version: 4
 summary: A jsx-inspired way to write view components.