rux 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37160ed3c69f6fd3ee0e3b4597db3c41f0244853233b02aae52ba8bda17da87f
-  data.tar.gz: 20291beda480bab76790dbc9c6c300badd673d5d100aa097ef68244620bec4a7
+  metadata.gz: 65ad08596c2e77c802c6f7cb2a458ac8d293d5c80a35c98c8a2eb85a5749b365
+  data.tar.gz: cb6487c91a9b21e328f491f5f23b8703a8b4b20a35ddcfa029a19e56bc835dca
 SHA512:
-  metadata.gz: d9b6bbf7e49fdd07dd528a24e4c7ab496e29872a84024c1d011ce8026f0e003b0f941ede542728d44d0bd5d67dfa66ffcdd0658514c61a9e59580b86ce946f5e
-  data.tar.gz: f7f5611e56d78988a6a514f2ae38cfe54848e6e855cdd85d5143963424a4c566bb09cd723c835bd16dcd7470591f21295d75432ef05981b0994533bc0e951949
+  metadata.gz: 4bc663ef90eec4c6a8abcfe997f259ccea9d211e898813280f534e4b8b5853a4bbbf3f8358164f4472f9329594a4a8b24e986d7b2fd621ecf74d92ebe09ea3e7
+  data.tar.gz: 944d83744f268a221cda2c414e7dd16df13efe37110a99c0d553ff2237be99f17aef37ae88d6653cdff43f0abe56e64cac48614bd5dd7f187e154cfe3cc0cead

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.0.2
+* Fix bug causing `ArgumentError`s under Ruby 3.0.
+  - Related: https://github.com/mbj/unparser/issues/254
+
 ## 1.0.1
 * Fix bug in default buffer implementation causing `TypeError`s when attempting to shovel in arrays.
 

data/README.md

@@ -1,4 +1,6 @@
-## rux [![Build Status](https://travis-ci.com/camertron/rux.svg?branch=master)](https://travis-ci.com/camertron/rux)
+## rux
+
+![Unit Tests](https://github.com/camertron/rux/actions/workflows/unit_tests.yml/badge.svg?branch=master)
 
 Rux is a JSX-inspired way to write HTML tags in your Ruby code. It can be used to render view components in Rails via the [rux-rails gem](https://github.com/camertron/rux-rails). This repo however contains only the rux parser itself.
 

data/lib/rux/default_visitor.rb

@@ -29,7 +29,7 @@ module Rux
           result << "render(#{node.name}.new"
 
           unless node.attrs.empty?
-            result << "({ #{at.join(', ')} })"
+            result << "(#{at.join(', ')})"
           end
         else
           result << "Rux.tag('#{node.name}'"

data/lib/rux/version.rb

@@ -1,3 +1,3 @@
 module Rux
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/rux.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.platform = Gem::Platform::RUBY
 
   s.add_dependency 'parser', '~> 3.0'
-  s.add_dependency 'unparser', '~> 0.6'
+  s.add_dependency 'unparser', '<= 0.5.5'
 
   s.require_path = 'lib'
   s.executables << 'ruxc'

data/spec/parser_spec.rb

@@ -29,67 +29,67 @@ describe Rux::Parser do
 
   it 'handles single-quoted rux attributes' do
     expect(compile("<Hello foo='bar' />")).to eq(
-      'render(Hello.new({ foo: "bar" }))'
+      'render(Hello.new(foo: "bar"))'
     )
 
     expect(compile("<Hello foo='bar'></Hello>")).to eq(
-      'render(Hello.new({ foo: "bar" }))'
+      'render(Hello.new(foo: "bar"))'
     )
   end
 
   it 'handles double-quoted rux attributes' do
     expect(compile('<Hello foo="bar" />')).to eq(
-      'render(Hello.new({ foo: "bar" }))'
+      'render(Hello.new(foo: "bar"))'
     )
 
     expect(compile('<Hello foo="bar"></Hello>')).to eq(
-      'render(Hello.new({ foo: "bar" }))'
+      'render(Hello.new(foo: "bar"))'
     )
   end
 
   it 'handles non-uniform spacing between attributes' do
     expect(compile('<Hello  foo="bar"    baz= "boo" bix  ="bit" />')).to eq(
-      'render(Hello.new({ foo: "bar", baz: "boo", bix: "bit" }))'
+      'render(Hello.new(foo: "bar", baz: "boo", bix: "bit"))'
     )
   end
 
   it 'handles boolean attributes' do
     expect(compile('<Hello disabled />')).to eq(
-      'render(Hello.new({ disabled: "true" }))'
+      'render(Hello.new(disabled: "true"))'
     )
 
     expect(compile('<Hello disabled/>')).to eq(
-      'render(Hello.new({ disabled: "true" }))'
+      'render(Hello.new(disabled: "true"))'
     )
 
     expect(compile('<Hello disabled></Hello>')).to eq(
-      'render(Hello.new({ disabled: "true" }))'
+      'render(Hello.new(disabled: "true"))'
     )
   end
 
   it 'converts dashes to underscores in attribute keys' do
     expect(compile('<Hello foo-bar="baz" />')).to eq(
-      'render(Hello.new({ foo_bar: "baz" }))'
+      'render(Hello.new(foo_bar: "baz"))'
     )
   end
 
   it 'handles simple ruby statements in attributes' do
     expect(compile('<Hello foo={true} />')).to eq(
-      'render(Hello.new({ foo: true }))'
+      'render(Hello.new(foo: true))'
     )
   end
 
   it 'handles ruby hashes in attributes' do
     expect(compile('<Hello foo={{ foo: "bar", baz: "boo" }} />')).to eq(
-      'render(Hello.new({ foo: { foo: "bar", baz: "boo" } }))'
+      'render(Hello.new(foo: { foo: "bar", baz: "boo" }))'
     )
   end
 
   it 'handles ruby code with curly braces in attributes' do
     expect(compile('<Hello foo={[1, 2, 3].map { |n| n * 2 }} />')).to eq(<<~RUBY.strip)
-      render(Hello.new({ foo: [1, 2, 3].map { |n,|
+      render(Hello.new(foo: [1, 2, 3].map { |n,|
         n * 2
-      } }))
+      }))
     RUBY
   end
 

data/spec/render_spec.rb

@@ -29,4 +29,12 @@ describe Rux do
 
     expect(result).to eq("<div> <p>Welcome!</p><p>Welcome!</p><p>Welcome!</p> </div>")
   end
+
+  it 'correctly handles keyword arguments (ruby 3)' do
+    result = render(<<~RUBY)
+      <ArgsComponent a="a" b="b" />
+    RUBY
+
+    expect(result).to eq("<p>a and b</p>")
+  end
 end

data/spec/spec_helper.rb

@@ -8,7 +8,7 @@ module ViewComponent
     attr_accessor :content
 
     def render(component, &block)
-      component.content = block.call
+      component.content = block.call if block
       component.call
     end
   end
@@ -20,5 +20,18 @@ class TestComponent < ViewComponent::Base
   end
 end
 
+class ArgsComponent < ViewComponent::Base
+  attr_reader :a, :b
+
+  def initialize(a:, b:)
+    @a = a
+    @b = b
+  end
+
+  def call
+    "<p>#{a} and #{b}</p>"
+  end
+end
+
 RSpec.configure do |config|
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rux
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Cameron Dutro
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-06-11 00:00:00.000000000 Z
+date: 2021-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -28,16 +28,16 @@ dependencies:
   name: unparser
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<="
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: 0.5.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<="
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: 0.5.5
 description: A jsx-inspired way to write view components.
 email:
 - camertron@gmail.com
@@ -97,7 +97,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.3
 signing_key:
 specification_version: 4
 summary: A jsx-inspired way to write view components.