rux-rails 1.2.2 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71cd84c42747191f92518e982abfb2f631dc2d4238dfc377e58abdd168d9bf0a
-  data.tar.gz: '098b4d8af3d352512a82143fae3ac3c8ac04b9d8f080906838017410c6d17324'
+  metadata.gz: 80c3381d7ae7854540067cd7267c5636961a7b30a538fad7c5fd063c5cb12a64
+  data.tar.gz: c4234d93e5b93109b612a5249f06b065cc53157999246cc04f12aea1bdc98cad
 SHA512:
-  metadata.gz: b4a554cd0d719bbd78dc46d99aaaa801fedd83b10c8917242dae01f3e4bbe51f0aabe7f2f7eb626f25379fd0bbfce01e934c055ad98443a56d6f698af2210334
-  data.tar.gz: 82e1d14c6083c55bdb653147e07fdf16f4416f000d4555c094ac7700fd98db0da989723d89adcee4df4e00524926f945004bce936cb84f7fcd1ab4c2734b976b
+  metadata.gz: 8b61ed880646e3a058c4bd525f6f7fe9e308fe066f40d76c53ea312a5c604874eb321405f9d41f3a026221df3a83b3049356c1146f897ca7c9c4cf96b5274443
+  data.tar.gz: 6aa7c072623ab565de33479b0428c096412377f9cf020c0c91751cf9b80e2f21fad1c2f8500a95b2b67dd5450a985ef8a5d0162ac72978d6cd1de04d706b64dc

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## 1.4.0
+* Make rux-rails safe to load in production.
+  - All the monkeypatches to `Kernel`, etc are now only loaded if `config.rux.transpile` is `true`.
+
+## 1.3.0
+* Add support for view_component v3.0.
+
 ## 1.2.2
 * Fix calling private Zeitwerk method.
 * Check railties version in dummy app instead of rails.

data/Gemfile

@@ -11,8 +11,12 @@ end
 
 group :development do
   gem 'appraisal'
+  gem 'benchmark-ips'
+  gem 'rails', '~> 7.0'
+  gem 'slim', '~> 5.0'
 end
 
 group :test do
   gem 'rspec-rails'
+  gem 'capybara', '~> 3.0'
 end

data/lib/rux-rails/railtie.rb

@@ -8,35 +8,37 @@ module RuxRails
     config.rux = ActiveSupport::OrderedOptions.new
 
     initializer 'rux-rails.initialize', before: :set_autoload_paths do |app|
-      if Rails.respond_to?(:autoloaders) && Rails.autoloaders.zeitwerk_enabled?
-        require 'rux-rails/core_ext/kernel_zeitwerk'
-        require 'rux-rails/ext/zeitwerk/loader'
+      if config.rux.transpile.nil? && (Rails.env.development? || Rails.env.test?)
+        config.rux.transpile = true
+      end
+
+      RuxRails.transpile_on_load = -> () { config.rux.transpile }
 
-        RuxRails.zeitwerk_mode = true
-      else
-        require 'rux-rails/core_ext/kernel'
-        require 'rux-rails/ext/activesupport/dependencies'
+      if config.rux.transpile
+        if Rails.respond_to?(:autoloaders) && Rails.autoloaders.zeitwerk_enabled?
+          require 'rux-rails/core_ext/kernel_zeitwerk'
+          require 'rux-rails/ext/zeitwerk/loader'
 
-        RuxRails.zeitwerk_mode = false
-      end
+          RuxRails.zeitwerk_mode = true
+        else
+          require 'rux-rails/core_ext/kernel'
+          require 'rux-rails/ext/activesupport/dependencies'
+
+          RuxRails.zeitwerk_mode = false
+        end
 
-      begin
-        require 'bootsnap'
-      rescue LoadError
-      else
-        require 'rux-rails/ext/bootsnap/autoload'
+        begin
+          require 'bootsnap'
+        rescue LoadError
+        else
+          require 'rux-rails/ext/bootsnap/autoload'
+        end
       end
 
       ActionView::Template.register_template_handler(
         :ruxt, RuxRails::TemplateHandler
       )
 
-      if config.rux.transpile.nil? && (Rails.env.development? || Rails.env.test?)
-        config.rux.transpile = true
-      end
-
-      RuxRails.transpile_on_load = -> () { config.rux.transpile }
-
       Rux.library_paths.each do |library_path|
         app.config.eager_load_paths << library_path
         app.config.autoload_paths << library_path

data/lib/rux-rails/version.rb

@@ -1,3 +1,3 @@
 module RuxRails
-  VERSION = '1.2.2'
+  VERSION = '1.4.0'
 end

data/lib/rux-rails.rb

@@ -28,6 +28,9 @@ end
 
 require 'rux'
 require 'rux-rails/railtie'
+
+# require both of these to support multiple versions of view_component
+require 'view_component'
 require 'view_component/engine'
 
 ViewComponent::Base.send(:include, RuxRails::Components)

data/rux-rails.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |s|
 
   s.add_dependency 'rux', '~> 1.0'
   s.add_dependency 'railties', '>= 5.0'
-  s.add_dependency 'view_component', '~> 2.0'
+  s.add_dependency 'view_component', '>= 2', '< 4'
 
   s.require_path = 'lib'
 

data/spec/controllers/home_controller_spec.rb

@@ -4,7 +4,11 @@ describe HomeController, type: :request do
   describe '#index' do
     it 'works' do
       get '/'
+
       expect(response).to have_http_status(:ok)
+      expect(response.body).to(
+        have_selector("div.container img[src='/images/cat.png'] + button", text: "Click Me!")
+      )
     end
   end
 end

data/spec/dummy/app/components/home_component.rb

@@ -2,13 +2,10 @@ class HomeComponent < ViewComponent::Base
   def call
     Rux.tag("div", { class: "container" }) {
       Rux.create_buffer.tap { |_rux_buf_|
-        _rux_buf_ << " "
         _rux_buf_ << render(Image.new(src: "cat.png", size: "40"))
-        _rux_buf_ << " "
         _rux_buf_ << render(Button.new(outline: true, disabled: "true", size: :large)) {
-          " Click Me! "
+          "Click Me!"
         }
-        _rux_buf_ << " "
       }.to_s
     }
   end

data/spec/dummy/log/test.log

@@ -160,3 +160,60 @@ Processing by HomeController#index as HTML
   Rendered home/index.html.ruxt within layouts/application (Duration: 77.5ms | Allocations: 43481)
   Rendered layout layouts/application.html.erb (Duration: 78.0ms | Allocations: 43712)
 Completed 200 OK in 89ms (Views: 83.2ms | Allocations: 49251)
+Started GET "/" for 127.0.0.1 at 2023-05-28 13:52:10 -0700
+Processing by HomeController#index as HTML
+  Rendering layout layouts/application.html.erb
+  Rendering home/index.html.ruxt within layouts/application
+  Rendered home/index.html.ruxt within layouts/application (Duration: 76.5ms | Allocations: 42477)
+  Rendered layout layouts/application.html.erb (Duration: 77.6ms | Allocations: 42711)
+Completed 200 OK in 90ms (Views: 82.8ms | Allocations: 49992)
+Started GET "/" for 127.0.0.1 at 2023-05-28 13:52:23 -0700
+Processing by HomeController#index as HTML
+  Rendering layout layouts/application.html.erb
+  Rendering home/index.html.ruxt within layouts/application
+  Rendered home/index.html.ruxt within layouts/application (Duration: 71.3ms | Allocations: 42478)
+  Rendered layout layouts/application.html.erb (Duration: 71.8ms | Allocations: 42712)
+Completed 200 OK in 87ms (Views: 78.2ms | Allocations: 49993)
+Started GET "/" for 127.0.0.1 at 2023-05-28 13:54:28 -0700
+Processing by HomeController#index as HTML
+  Rendering layout layouts/application.html.erb
+  Rendering home/index.html.ruxt within layouts/application
+  Rendered home/index.html.ruxt within layouts/application (Duration: 61.9ms | Allocations: 42478)
+  Rendered layout layouts/application.html.erb (Duration: 62.3ms | Allocations: 42712)
+Completed 200 OK in 73ms (Views: 67.1ms | Allocations: 49993)
+Started GET "/" for 127.0.0.1 at 2023-05-28 13:58:00 -0700
+Processing by HomeController#index as HTML
+  Rendering layout layouts/application.html.erb
+  Rendering home/index.html.ruxt within layouts/application
+  Rendered home/index.html.ruxt within layouts/application (Duration: 113.6ms | Allocations: 43896)
+  Rendered layout layouts/application.html.erb (Duration: 114.4ms | Allocations: 44131)
+Completed 200 OK in 128ms (Views: 120.0ms | Allocations: 51788)
+Started GET "/" for 127.0.0.1 at 2023-05-28 14:27:01 -0700
+Processing by HomeController#index as HTML
+  Rendering home/index.html.ruxt within layouts/application
+  Rendered home/index.html.ruxt within layouts/application (95.1ms)
+Completed 200 OK in 106ms (Views: 105.4ms)
+Started GET "/" for 127.0.0.1 at 2023-06-07 20:52:52 -0700
+Processing by HomeController#index as HTML
+  Rendering home/index.html.ruxt within layouts/application
+  Rendered home/index.html.ruxt within layouts/application (88.7ms)
+Completed 200 OK in 100ms (Views: 98.6ms)
+Started GET "/" for 127.0.0.1 at 2023-06-07 20:52:58 -0700
+Processing by HomeController#index as HTML
+  Rendering home/index.html.ruxt within layouts/application
+  Rendered home/index.html.ruxt within layouts/application (Duration: 75.5ms | Allocations: 45236)
+Completed 200 OK in 88ms (Views: 82.7ms | Allocations: 52067)
+Started GET "/" for 127.0.0.1 at 2023-06-07 20:53:04 -0700
+Processing by HomeController#index as HTML
+  Rendering layout layouts/application.html.erb
+  Rendering home/index.html.ruxt within layouts/application
+  Rendered home/index.html.ruxt within layouts/application (Duration: 85.3ms | Allocations: 44654)
+  Rendered layout layouts/application.html.erb (Duration: 85.8ms | Allocations: 44800)
+Completed 200 OK in 100ms (Views: 93.6ms | Allocations: 50960)
+Started GET "/" for 127.0.0.1 at 2023-06-07 20:53:10 -0700
+Processing by HomeController#index as HTML
+  Rendering layout layouts/application.html.erb
+  Rendering home/index.html.ruxt within layouts/application
+  Rendered home/index.html.ruxt within layouts/application (Duration: 84.7ms | Allocations: 44260)
+  Rendered layout layouts/application.html.erb (Duration: 85.3ms | Allocations: 44407)
+Completed 200 OK in 108ms (Views: 94.0ms | Allocations: 52425)

data/spec/spec_helper.rb

@@ -22,4 +22,5 @@ end
 
 RSpec.configure do |config|
   config.include(SpecHelpers)
+  config.include(Capybara::RSpecMatchers, type: :request)
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rux-rails
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.4.0
 platform: ruby
 authors:
 - Cameron Dutro
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-25 00:00:00.000000000 Z
+date: 2023-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rux
@@ -42,16 +42,22 @@ dependencies:
   name: view_component
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '4'
 description: Rux view components on Rails.
 email:
 - camertron@gmail.com
@@ -101,7 +107,7 @@ files:
 homepage: http://github.com/camertron/rux-rails
 licenses: []
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -116,8 +122,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.5
-signing_key:
+rubygems_version: 3.1.6
+signing_key: 
 specification_version: 4
 summary: Rux view components on Rails.
 test_files: []