russian-reversal 1.0.5 → 1.0.6

data/lib/russian-reversal.rb

@@ -6,7 +6,7 @@ require 'nokogiri'
 
 module RussianReversal
   REGEXP_NONWORD = /[^a-zA-Z -]/
-  VERBS_IGNORED = [ 'be', 'have', 'can', ]
+  VERBS_IGNORED = [ 'be', 'become', 'can', 'do', 'get', 'go', 'have', 'put', 'say',  ]
   NOUNS_IGNORED = [ 'it', 'him', 'her', 'them', 'me', 'you', 'us', 'this', 'that', 'these', 'those', ]
 
   def self.strip( s )
@@ -14,20 +14,23 @@ module RussianReversal
   end
 
   def self.infinitive_of( verb )
+    return  if verb =~ REGEXP_NONWORD
+
     doc = Nokogiri::HTML( open( "http://www.oxfordadvancedlearnersdictionary.com/dictionary/#{verb}" ) )
     doc.search('div#relatedentries > ul > li').each do |e|
       pos_element = e.at('span.pos')
-      if pos_element
-        pos = pos_element.text.gsub( REGEXP_NONWORD, '' )
-        return  if pos == 'modal verb' || pos == 'auxiliary verb'
-        if pos == 'verb'
-          v = e.at('span').children.first.text.strip
-          if VERBS_IGNORED.include?( v )
-            return
-          else
-            return v
-          end
-        end
+      next  if pos_element.nil?
+
+      pos = pos_element.text.gsub( REGEXP_NONWORD, '' )
+      return  if pos == 'modal verb' || pos == 'auxiliary verb'
+
+      next  if pos != 'verb'
+
+      v = e.at('span').children.first.text.strip
+      if VERBS_IGNORED.include?( v )
+        return
+      else
+        return v
       end
     end
   end

data/spec/reverse.rb

@@ -23,6 +23,7 @@ describe 'RussianReversal' do
     RussianReversal.reverse( "He was a criminal." ).should.be.nil
     RussianReversal.reverse( "He might be a criminal." ).should.be.nil
     RussianReversal.reverse( "He ought to be good." ).should.be.nil
+    RussianReversal.reverse( "yeah, and it's horrible to install onigurama versions" ).should.be.nil
   end
 
   it "doesn't activate on pronouns or demonstratives" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: russian-reversal
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: false
   segments: 
   - 1
   - 0
-  - 5
-  version: 1.0.5
+  - 6
+  version: 1.0.6
 platform: ruby
 authors: 
 - Pistos
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-18 00:00:00 -05:00
+date: 2010-11-19 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency