ruote-kit 2.2.0.3 → 2.3.0.2

data/spec/cases/orphan_workitem_spec.rb

@@ -0,0 +1,141 @@
+
+require 'spec_helper'
+
+
+describe RuoteKit do
+
+  context 'with an orphan workitem' do
+
+    before(:all) do
+
+      prepare_engine_with_participants
+
+      pdef = Ruote.process_definition :name => 'test' do
+        toto
+      end
+
+      #RuoteKit.engine.noisy = true
+
+      @wfid = RuoteKit.engine.launch(pdef)
+      RuoteKit.engine.wait_for(:toto)
+      RuoteKit.engine.wait_for(1)
+
+      @wi = RuoteKit.engine.storage_participant.first
+
+      RuoteKit.engine.cancel(@wfid)
+      RuoteKit.engine.wait_for('terminated')
+
+      @wi.h.delete('_rev')
+      RuoteKit.engine.storage.put(@wi.h)
+    end
+
+    after(:all) do
+
+      shutdown_and_purge_engine
+    end
+
+    describe 'GET /_ruote/processes' do
+
+      it 'does not list the process' do
+
+        get '/_ruote/processes.json'
+
+        last_response.status.should == 200
+
+        last_response.json_body['processes'].should == []
+      end
+    end
+
+    describe 'GET /_ruote/workitems' do
+
+      it 'lists the orphan workitem' do
+
+        get '/_ruote/workitems.json'
+
+        last_response.status.should == 200
+
+        last_response.json_body['workitems'].size.should == 1
+        last_response.json_body['workitems'][0]['id'].should == @wi.sid
+
+        links = last_response.json_body['workitems'][0]['links']
+
+        link_for(links, 'self').should ==
+          "/_ruote/workitems/#{@wi.sid}"
+        link_for(links, '#expression').should ==
+          "/_ruote/expressions/#{@wi.sid}"
+      end
+    end
+
+    describe 'GET /_ruote/workitems/:wfid' do
+
+      it 'lists the orphan workitems' do
+
+        get "/_ruote/workitems/#{@wi.wfid}.json"
+
+        last_response.status.should == 200
+
+        last_response.json_body['workitems'].size.should == 1
+        last_response.json_body['workitems'][0]['id'].should == @wi.sid
+      end
+    end
+
+    describe 'GET /_ruote/workitems/:fei' do
+
+      it 'renders the workitem' do
+
+        get "/_ruote/workitems/#{@wi.sid}.json"
+
+        last_response.status.should == 200
+
+        links = last_response.json_body['links']
+
+        link_for(links, 'self').should == "/_ruote/workitems/#{@wi.sid}"
+      end
+    end
+
+    describe 'GET /_ruote/processes/:wfid' do
+
+      it 'goes 404 (HTML)' do
+
+        get "/_ruote/processes/#{@wi.wfid}"
+
+        last_response.status.should == 404
+      end
+
+      it 'goes 404 (JSON)' do
+
+        get "/_ruote/processes/#{@wi.wfid}.json"
+
+        last_response.status.should == 404
+      end
+    end
+
+    describe 'GET /_ruote/expressions/:fei' do
+
+      it 'goes 404' do
+
+        get "/_ruote/expressions/#{@wi.sid}.json"
+
+        last_response.status.should == 404
+      end
+    end
+
+    describe 'GET /_ruote/expressions/:wfid' do
+
+      it 'goes 404 (HTML)' do
+
+        get "/_ruote/expressions/#{@wi.wfid}"
+
+        last_response.status.should == 404
+      end
+
+      it 'goes 404 (JSON)' do
+
+        get "/_ruote/expressions/#{@wi.wfid}.json"
+
+        last_response.status.should == 404
+      end
+    end
+  end
+end
+

data/spec/core_ext_spec.rb

@@ -0,0 +1,19 @@
+
+require 'spec_helper'
+
+describe Symbol do
+
+  describe "#<=>", :if => RUBY_VERSION < "1.9" do
+
+    it "is defined" do
+      :foo.should respond_to(:<=>)
+    end
+
+    it "compares self with other against their to_s representation" do
+      (:foo <=> :bar).should == ("foo" <=> "bar")
+      (:bar <=> :foo).should == ("bar" <=> "foo")
+      (:foo <=> :foo).should == ("foo" <=> "foo")
+    end
+  end
+end
+

data/spec/resources/errors_spec.rb

@@ -1,231 +1,257 @@
 
-require File.join(File.dirname(__FILE__), '..', 'spec_helper.rb')
+require 'spec_helper'
 
 
-describe 'without any running processes' do
+describe '/_ruote/errors' do
 
-  before(:each) do
+  context 'without any running processes' do
 
-    prepare_engine
-  end
-
-  after(:each) do
-
-    shutdown_and_purge_engine
-  end
+    before(:each) do
+      prepare_engine
+    end
+    after(:each) do
+      shutdown_and_purge_engine
+    end
 
-  describe 'GET /_ruote/errors' do
+    describe 'GET /_ruote/errors' do
 
-    it 'should give no processes back (HTML)' do
+      it 'gives no processes back (HTML)' do
 
-      get '/_ruote/errors'
+        get '/_ruote/errors'
 
-      last_response.status.should be(200)
-    end
+        last_response.status.should be(200)
+      end
 
-    it 'should give an empty array (JSON)' do
+      it 'gives an empty array (JSON)' do
 
-      get '/_ruote/errors.json'
+        get '/_ruote/errors.json'
 
-      last_response.status.should be(200)
+        last_response.status.should be(200)
 
-      body = last_response.json_body
-      body.should have_key('errors')
+        body = last_response.json_body
+        body.should have_key('errors')
 
-      body['errors'].should be_empty
+        body['errors'].should be_empty
+      end
     end
   end
-end
 
-describe 'with a running process that has an error' do
+  context 'with a running process that has no errors' do
 
-  before(:each) do
+    before(:each) do
 
-    prepare_engine
+      prepare_engine
 
-    RuoteKit.engine.register_participant :alice, Ruote::StorageParticipant
-
-    @wfid = RuoteKit.engine.launch(
-      Ruote.process_definition(:name => 'test') do
-        sequence do
-          nemo
-          alice
+      @wfid = RuoteKit.engine.launch(
+        Ruote.define do
+          stall # sit there and do nothing
         end
-      end
-    )
+      )
 
-    RuoteKit.engine.wait_for(@wfid)
+      RuoteKit.engine.wait_for(2)
+    end
 
-    @error = RuoteKit.engine.process(@wfid).errors.first
-    @fei = @error.fei
-  end
+    describe 'GET /_ruote/errors/:wfid' do
+
+      it 'returns an empty list' do
 
-  after(:each) do
+        get "/_ruote/errors/#{@wfid}"
 
-    shutdown_and_purge_engine
+        last_response.status.should == 200
+      end
+    end
   end
 
-  describe 'GET /_ruote/errors' do
+  context 'with a running process that has an error' do
 
-    it 'should list errors (HTML)' do
+    before(:each) do
 
-      get '/_ruote/errors'
+      prepare_engine
 
-      last_response.status.should be(200)
-      last_response.should match(/nemo/)
-    end
+      RuoteKit.engine.register_participant :alice, Ruote::StorageParticipant
+
+      @wfid = RuoteKit.engine.launch(
+        Ruote.process_definition(:name => 'test') do
+          sequence do
+            nemo
+            alice
+          end
+        end
+      )
 
-    it 'should list errors (JSON)' do
-
-      get '/_ruote/errors.json'
-
-      last_response.status.should be(200)
-
-      json = last_response.json_body
-
-      # global links
-
-      json['links'].should == [
-        { 'href' => '/_ruote',
-          'rel' => 'http://ruote.rubyforge.org/rels.html#root'  },
-        { 'href' => '/_ruote/processes',
-          'rel' => 'http://ruote.rubyforge.org/rels.html#processes' },
-        { 'href' => '/_ruote/workitems',
-          'rel' => 'http://ruote.rubyforge.org/rels.html#workitems' },
-        { 'href' => '/_ruote/errors',
-          'rel' => 'http://ruote.rubyforge.org/rels.html#errors' },
-        { 'href' => '/_ruote/participants',
-          'rel' => 'http://ruote.rubyforge.org/rels.html#participants' },
-        { 'href' => '/_ruote/schedules',
-          'rel' => 'http://ruote.rubyforge.org/rels.html#schedules' },
-        { 'href' => '/_ruote/history',
-          'rel' => 'http://ruote.rubyforge.org/rels.html#history' },
-        { 'href' => '/_ruote/errors',
-          'rel' => 'self' },
-        { 'href' => '/_ruote/errors',
-          'rel' => 'all' },
-        { 'href' => '/_ruote/errors?limit=100&skip=0',
-          'rel' => 'first' },
-        { 'href' => '/_ruote/errors?limit=100&skip=0',
-          'rel' => 'last' },
-        { 'href' => '/_ruote/errors?limit=100&skip=0',
-          'rel' => 'previous' },
-        { 'href' => '/_ruote/errors?limit=100&skip=0',
-          'rel' => 'next' } ]
-
-      # the error itself
-
-      json['errors'].size.should == 1
-      json['errors'].first['message'].should == "#<RuntimeError: unknown participant or subprocess 'nemo'>"
-
-      # the links for the error itself
-
-      json['errors'].first['links'].should == [
-        { 'href' => "/_ruote/errors/#{@fei.expid}!#{@fei.subid}!#{@wfid}",
-          'rel' => 'self' },
-        { 'href' => "/_ruote/errors/#{@wfid}",
-          'rel' => 'http://ruote.rubyforge.org/rels.html#process_errors' },
-        { 'href' => "/_ruote/processes/#{@wfid}",
-          'rel' => 'http://ruote.rubyforge.org/rels.html#process' }
-      ]
-
-      #puts Rufus::Json.pretty_encode(json)
+      RuoteKit.engine.wait_for(@wfid)
+
+      @error = RuoteKit.engine.process(@wfid).errors.first
+      @fei = @error.fei
     end
-  end
 
-  describe 'GET /_ruote/errors/:wfid' do
+    describe 'GET /_ruote/errors' do
 
-    it 'should list process errors (HTML)' do
+      it 'lists errors (HTML)' do
 
-      get "/_ruote/errors/#{@wfid}"
+        get '/_ruote/errors'
 
-      last_response.status.should be(200)
-      last_response.should match(/nemo/)
+        last_response.status.should be(200)
+        last_response.should match(/nemo/)
+      end
+
+      it 'lists errors (JSON)' do
+
+        get '/_ruote/errors.json'
+
+        last_response.status.should be(200)
+
+        json = last_response.json_body
+
+        # global links
+
+        json['links'].should == [
+          { 'href' => '/_ruote',
+            'rel' => 'http://ruote.rubyforge.org/rels.html#root'  },
+          { 'href' => '/_ruote/processes',
+            'rel' => 'http://ruote.rubyforge.org/rels.html#processes' },
+          { 'href' => '/_ruote/workitems',
+            'rel' => 'http://ruote.rubyforge.org/rels.html#workitems' },
+          { 'href' => '/_ruote/errors',
+            'rel' => 'http://ruote.rubyforge.org/rels.html#errors' },
+          { 'href' => '/_ruote/participants',
+            'rel' => 'http://ruote.rubyforge.org/rels.html#participants' },
+          { 'href' => '/_ruote/schedules',
+            'rel' => 'http://ruote.rubyforge.org/rels.html#schedules' },
+          { 'href' => '/_ruote/history',
+            'rel' => 'http://ruote.rubyforge.org/rels.html#history' },
+          { 'href' => '/_ruote/errors',
+            'rel' => 'self' },
+          { 'href' => '/_ruote/errors',
+            'rel' => 'all' },
+          { 'href' => '/_ruote/errors?limit=100&skip=0',
+            'rel' => 'first' },
+          { 'href' => '/_ruote/errors?limit=100&skip=0',
+            'rel' => 'last' },
+          { 'href' => '/_ruote/errors?limit=100&skip=0',
+            'rel' => 'previous' },
+          { 'href' => '/_ruote/errors?limit=100&skip=0',
+            'rel' => 'next' } ]
+
+        # the error itself
+
+        json['errors'].size.should == 1
+        json['errors'].first['message'].should == "#<RuntimeError: unknown participant or subprocess 'nemo'>"
+
+        # the links for the error itself
+
+        json['errors'].first['links'].should == [
+          { 'href' => "/_ruote/errors/#{@fei.expid}!#{@fei.subid}!#{@wfid}",
+            'rel' => 'self' },
+          { 'href' => "/_ruote/errors/#{@wfid}",
+            'rel' => 'http://ruote.rubyforge.org/rels.html#process_errors' },
+          { 'href' => "/_ruote/processes/#{@wfid}",
+            'rel' => 'http://ruote.rubyforge.org/rels.html#process' }
+        ]
+
+        #puts Rufus::Json.pretty_encode(json)
+      end
     end
 
-    it 'should list process errors (JSON)' do
+    describe 'GET /_ruote/errors/:wfid' do
 
-      get "/_ruote/errors/#{@wfid}.json"
+      it 'lists process errors (HTML)' do
 
-      last_response.status.should be(200)
+        get "/_ruote/errors/#{@wfid}"
 
-      json = last_response.json_body
+        last_response.status.should be(200)
+        last_response.should match(/nemo/)
+      end
 
-      json['errors'].size.should == 1
-      json['errors'].first['message'].should == "#<RuntimeError: unknown participant or subprocess 'nemo'>"
+      it 'lists process errors (JSON)' do
 
-      json['errors'].first['links'].should == [
-        { 'href' => "/_ruote/errors/#{@fei.expid}!#{@fei.subid}!#{@wfid}",
-          'rel' => 'self' },
-        { 'href' => "/_ruote/errors/#{@wfid}",
-          'rel' => 'http://ruote.rubyforge.org/rels.html#process_errors' },
-        { 'href' => "/_ruote/processes/#{@wfid}",
-          'rel' => 'http://ruote.rubyforge.org/rels.html#process' } ]
-    end
-  end
+        get "/_ruote/errors/#{@wfid}.json"
 
-  describe 'GET /_ruote/errors/:fei' do
+        last_response.status.should be(200)
 
-    it 'should show the error (HTML)' do
+        json = last_response.json_body
 
-      get "/_ruote/errors/0_0_0!!#{@wfid}"
+        json['errors'].size.should == 1
+        json['errors'].first['message'].should == "#<RuntimeError: unknown participant or subprocess 'nemo'>"
 
-      last_response.status.should be(200)
-      last_response.should match(/nemo/)
+        json['errors'].first['links'].should == [
+          { 'href' => "/_ruote/errors/#{@fei.expid}!#{@fei.subid}!#{@wfid}",
+            'rel' => 'self' },
+          { 'href' => "/_ruote/errors/#{@wfid}",
+            'rel' => 'http://ruote.rubyforge.org/rels.html#process_errors' },
+          { 'href' => "/_ruote/processes/#{@wfid}",
+            'rel' => 'http://ruote.rubyforge.org/rels.html#process' } ]
+      end
     end
 
-    it 'should show the error (JSON)' do
+    describe 'GET /_ruote/errors/:fei' do
+
+      it 'shows the error (HTML)' do
 
-      get "/_ruote/errors/0_0_0!!#{@wfid}.json"
+        get "/_ruote/errors/#{@error.fei.sid}"
 
-      last_response.status.should be(200)
+        last_response.status.should be(200)
+        last_response.should match(/nemo/)
+        last_response.should match(/details/)
+      end
+
+      it 'shows the error (JSON)' do
+
+        get "/_ruote/errors/#{@error.fei.sid}.json"
+
+        last_response.status.should be(200)
+
+        json = last_response.json_body
 
-      json = last_response.json_body
+        #pp json
 
-      #puts Rufus::Json.pretty_encode(json)
+        json.should have_key('error')
+        json['error'].should have_key('at')
+        json['error'].should have_key('details')
+      end
     end
-  end
 
-  describe 'DELETE /_ruote/errors/:fei' do
+    describe 'DELETE /_ruote/errors/:fei' do
 
-    it 'should replay errors (HTML)' do
+      it 'replays errors (HTML)' do
 
-      RuoteKit.engine.register_participant :nemo, Ruote::StorageParticipant
+        RuoteKit.engine.register_participant :nemo, Ruote::StorageParticipant
 
-      delete "/_ruote/errors/#{@error.fei.sid}"
+        delete "/_ruote/errors/#{@error.fei.sid}"
 
-      last_response.status.should be(302)
-      last_response['Location'].should == '/_ruote/errors'
+        last_response.status.should be(302)
+        last_response['Location'].should == 'http://example.org/_ruote/errors'
 
-      RuoteKit.engine.wait_for(:nemo)
+        RuoteKit.engine.wait_for(:nemo)
 
-      RuoteKit.engine.storage_participant.size.should == 1
+        RuoteKit.engine.storage_participant.size.should == 1
 
-      wi = RuoteKit.engine.storage_participant.first
-      wi.participant_name.should == 'nemo'
+        wi = RuoteKit.engine.storage_participant.first
+        wi.participant_name.should == 'nemo'
 
-      RuoteKit.engine.process(@wfid).errors.size.should == 0
-    end
+        RuoteKit.engine.process(@wfid).errors.size.should == 0
+      end
 
-    it 'should replay errors (JSON)' do
+      it 'replays errors (JSON)' do
 
-      #RuoteKit.engine.noisy = true
+        #RuoteKit.engine.noisy = true
 
-      RuoteKit.engine.register_participant :nemo, Ruote::StorageParticipant
+        RuoteKit.engine.register_participant :nemo, Ruote::StorageParticipant
 
-      delete "/_ruote/errors/#{@error.fei.sid}.json"
+        delete "/_ruote/errors/#{@error.fei.sid}.json"
 
-      last_response.status.should be(200)
-      last_response.json_body['status'].should == 'ok'
+        last_response.status.should be(200)
+        last_response.json_body['status'].should == 'ok'
 
-      RuoteKit.engine.wait_for(:nemo)
+        RuoteKit.engine.wait_for(:nemo)
 
-      RuoteKit.engine.storage_participant.size.should == 1
+        RuoteKit.engine.storage_participant.size.should == 1
 
-      wi = RuoteKit.engine.storage_participant.first
-      wi.participant_name.should == 'nemo'
+        wi = RuoteKit.engine.storage_participant.first
+        wi.participant_name.should == 'nemo'
 
-      RuoteKit.engine.process(@wfid).errors.size.should == 0
+        RuoteKit.engine.process(@wfid).errors.size.should == 0
+      end
     end
   end
 end