ruote-kit 2.1.4.1 → 2.1.7

data/spec/helpers/render_helpers_spec.rb

@@ -1,6 +1,9 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
-describe "json helper" do
+undef :context if defined?(context)
+
+describe "json helper", :type => :with_engine do
+
   describe "rendering defaults" do
     before(:each) do
       stub_chain( :request, :fullpath ).and_return('/_ruote')
@@ -200,7 +203,7 @@ describe "json helper" do
 
       stub_chain( :request, :fullpath ).and_return("/_ruote/workitems")
 
-      @hash = Rufus::Json.decode( json( :workitems, store_participant.all ) )
+      @hash = Rufus::Json.decode( json( :workitems, storage_participant.all ) )
     end
 
     it "should have the workitems" do

data/spec/resources/expressions_spec.rb

@@ -1,6 +1,7 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
-describe "GET /_ruote/expressions" do
+describe "GET /_ruote/expressions", :type => :with_engine do
+
   it "should report a friendly message to the user (HTML)" do
     get "/_ruote/expressions"
 
@@ -16,7 +17,8 @@ describe "GET /_ruote/expressions" do
   end
 end
 
-describe "GET /_ruote/expressions/wfid" do
+describe "GET /_ruote/expressions/wfid", :type => :with_engine do
+
   describe "with running processes" do
     before(:each) do
       @wfid = launch_test_process
@@ -52,7 +54,8 @@ describe "GET /_ruote/expressions/wfid" do
   end
 end
 
-describe "GET /_ruote/expressions/wfid/expid" do
+describe "GET /_ruote/expressions/wfid/expid", :type => :with_engine do
+
   describe "with running processes" do
     before(:each) do
       @wfid = launch_test_process
@@ -90,7 +93,8 @@ describe "GET /_ruote/expressions/wfid/expid" do
   end
 end
 
-describe "DELETE /_ruote/expressions/wfid/expid" do
+describe "DELETE /_ruote/expressions/wfid/expid", :type => :with_engine do
+
   describe "with running processes" do
     before(:each) do
       @wfid = launch_test_process do

data/spec/resources/index_spec.rb

@@ -1,6 +1,7 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
-describe "GET /" do
+describe "GET /", :type => :with_engine do
+
   it "should return a welcome message in HTML be default" do
     get "/_ruote"
 
@@ -24,7 +25,8 @@ describe "GET /" do
   end
 end
 
-describe "Generic error handling" do
+describe "Generic error handling", :type => :with_engine do
+
   it "should give our own 404 page (HTML)" do
     get "/kenneth"
 

data/spec/resources/processes_spec.rb

@@ -1,6 +1,7 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
-describe "GET /_ruote/processes" do
+describe "GET /_ruote/processes", :type => :with_engine do
+
   describe "without any running processes" do
     it "should give no processes back (HTML)" do
       get "/_ruote/processes"
@@ -43,7 +44,8 @@ describe "GET /_ruote/processes" do
   end
 end
 
-describe "GET /_ruote/processes/X-Y" do
+describe "GET /_ruote/processes/X-Y", :type => :with_engine do
+
   describe "with a running process" do
     before(:each) do
       @wfid = launch_test_process
@@ -83,12 +85,13 @@ describe "GET /_ruote/processes/X-Y" do
       last_response.status.should be(404)
 
       last_response.json_body.keys.should include("error")
-      last_response.json_body['error'].should == { "code" => "404", "message" => "Resource not found" }
+      last_response.json_body['error'].should == { "code" => 404, "message" => "Resource not found" }
     end
   end
 end
 
-describe "GET /_ruote/processes/new" do
+describe "GET /_ruote/processes/new", :type => :with_engine do
+
   it "should return a launch form" do
     get "/_ruote/processes/new"
 
@@ -96,7 +99,8 @@ describe "GET /_ruote/processes/new" do
   end
 end
 
-describe "POST /_ruote/processes" do
+describe "POST /_ruote/processes", :type => :with_engine do
+
   before(:each) do
     engine.processes.should be_empty
   end
@@ -147,8 +151,7 @@ describe "POST /_ruote/processes" do
 
     post "/_ruote/processes", params
 
-    last_response.should be_redirect
-    last_response['Location'].should match( /^\/_ruote\/processes\/[0-9a-z\-]+$/ )
+    last_response.should be_ok
 
     sleep 0.4
 
@@ -165,8 +168,7 @@ describe "POST /_ruote/processes" do
 
     post '/_ruote/processes', params
 
-    last_response.should be_redirect
-    last_response['Location'].should match( /^\/_ruote\/processes\/([0-9a-z\-]+)$/ )
+    last_response.should be_ok
 
     sleep 0.5
 
@@ -183,15 +185,39 @@ describe "POST /_ruote/processes" do
 
     post '/_ruote/processes', params
 
-    last_response.should be_redirect
+    last_response.should be_ok
 
     sleep 0.4
 
     engine.processes.should_not be_empty
   end
+
+  it "should return a 422 unprocessable entity error when launching a process fails (JSON)" do
+    params = { :definition => 'http://invalid.invalid' }
+
+    post '/_ruote/processes.json', params.to_json, { 'CONTENT_TYPE' => 'application/json' }
+
+    last_response.should_not be_ok
+    last_response.status.should be(422)
+
+    last_response.json_body.keys.should include("error")
+  end
+
+  it "should return a nice error page when launching a process fails (HTML)" do
+    params = { :process_definition => %q{http://invalid.invalid} }
+
+    post '/_ruote/processes', params
+
+    last_response.should_not be_ok
+    last_response.status.should be(422)
+
+    last_response.should match(/Process failed to launch/)
+  end
+
 end
 
-describe "DELETE /_ruote/processes/X-Y" do
+describe "DELETE /_ruote/processes/X-Y", :type => :with_engine do
+
   before(:each) do
     @wfid = launch_test_process do
       Ruote.process_definition :name => 'test' do

data/spec/resources/workitems_spec.rb

@@ -1,6 +1,9 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
-describe "GET /_ruote/workitems" do
+undef :context if defined?(context)
+
+describe "GET /_ruote/workitems", :type => :with_engine do
+
   describe "without any workitems" do
     it "should report no workitems (HTML)" do
       get "/_ruote/workitems"
@@ -56,7 +59,8 @@ describe "GET /_ruote/workitems" do
   end
 end
 
-describe "GET /_ruote/workitems/wfid" do
+describe "GET /_ruote/workitems/wfid", :type => :with_engine do
+
   describe "with workitems" do
     before(:each) do
       @wfid = launch_test_process do
@@ -109,7 +113,8 @@ describe "GET /_ruote/workitems/wfid" do
   end
 end
 
-describe "GET /_ruote/workitems/wfid/expid" do
+describe "GET /_ruote/workitems/wfid/expid", :type => :with_engine do
+
   describe "with a workitem" do
     before(:each) do
       @wfid = launch_test_process do
@@ -156,7 +161,8 @@ describe "GET /_ruote/workitems/wfid/expid" do
   end
 end
 
-describe "PUT /_ruote/workitems/X-Y" do
+describe "PUT /_ruote/workitems/X-Y", :type => :with_engine do
+
   before(:each) do
     @wfid = launch_test_process do
       Ruote.process_definition :name => 'foo' do
@@ -263,7 +269,8 @@ describe "PUT /_ruote/workitems/X-Y" do
   end
 end
 
-describe "Filtering workitems" do
+describe "Filtering workitems", :type => :with_engine do
+
   describe "on participants" do
     before(:each) do
       @wfid = launch_test_process do

data/spec/ruote-kit_configure_spec.rb

@@ -0,0 +1,100 @@
+
+require File.join(File.dirname(__FILE__), 'spec_helper.rb')
+
+undef :context if defined?(context)
+
+class MyCustomStorage
+  attr_reader :opts
+  def initialize (opts)
+    @opts = opts
+  end
+end
+
+class MyParticipant
+end
+
+describe RuoteKit do
+
+  describe 'configure' do
+
+    before(:each) do
+      # nothing
+    end
+
+    it 'should default to :transient' do
+
+      RuoteKit.configuration.mode.should == :transient
+    end
+  end
+
+  describe 'configure with a custom storage' do
+
+    before(:each) do
+
+      RuoteKit.configure do |conf|
+        #require 'path/to/my_custom_storage'
+        conf.set_storage( MyCustomStorage, :a => 'A', :b => 'B' )
+        conf.run_engine = false
+      end
+    end
+
+    after(:each) do
+      RuoteKit.reset_configuration!
+    end
+
+    it 'should advertise mode as :custom' do
+
+      RuoteKit.configuration.mode.should == :custom
+    end
+
+    it 'should return an instance of the customer storage' do
+
+      si = RuoteKit.configuration.storage_instance
+
+      si.class.should == MyCustomStorage
+      si.opts.should == { :a => 'A', :b => 'B' }
+    end
+  end
+
+  describe 'register participants' do
+
+    require 'ruote/participant'
+
+    describe 'custom participant' do
+      RuoteKit.configure do |conf|
+        conf.register do
+          participant 'al', MyParticipant
+        end
+      end
+
+      RuoteKit.engine.context.plist.names.should == ['^al$']
+    end
+
+    describe 'catchall participant' do
+      RuoteKit.configure do |conf|
+        conf.register do
+          catchall MyParticipant
+        end
+      end
+
+      RuoteKit.engine.context.plist.names.should == [ '^.+$' ]
+    end
+
+    describe 'catchall participant without any options' do
+      require 'ruote/part/storage_participant'
+
+      RuoteKit.configure do |conf|
+        conf.register do
+          catchall
+        end
+      end
+
+      RuoteKit.engine.context.plist.lookup('.+').instance_of?(Ruote::StorageParticipant).should == true
+    end
+
+    after do
+      RuoteKit.reset_configuration!
+    end
+  end
+end
+

data/spec/spec_helper.rb

@@ -18,11 +18,12 @@ Test::Unit::TestCase.send :include, Rack::Test::Methods
 require File.dirname(__FILE__) + '/../vendor/gems/environment' if File.exists?( File.dirname(__FILE__) + '/../vendor/gems/environment.rb' )
 require File.dirname(__FILE__) + '/../lib/ruote-kit'
 
+require 'ruote/part/storage_participant'
+
 RuoteKit.configure do |config|
 
   # In memory is perfect for tests
   config.mode = :transient
-
 end
 
 require 'ruote-kit/spec/ruote_helpers'
@@ -42,13 +43,12 @@ Spec::Runner.configure do |config|
   config.include Webrat::Matchers, :type => :views
   config.include RuoteKit::Spec::RuoteHelpers
 
-  RuoteKit::Application.included_modules.each do |klass|
-    if klass.name =~ /RuoteKit::Helpers::\w+Helpers/
-      config.include klass
+  config.before(:each, :type => :with_engine) do
+    RuoteKit.configure do |conf|
+      conf.register do
+        catchall Ruote::StorageParticipant
+      end
     end
-  end
-
-  config.before(:each) do
     RuoteKit.run_engine!
 
     @tracer = Tracer.new
@@ -61,17 +61,23 @@ Spec::Runner.configure do |config|
   end
 
   # Purge the engine after every run
-  config.after(:each) do
+  config.after(:each, :type => :with_engine) do
     @_spec_worker.shutdown
 
     # Seems in some rubies this block gets called multiple times
     unless RuoteKit.engine.nil?
-      RuoteKit.engine.context.plist.lookup('.*').purge!
+      RuoteKit.storage_participant.purge!
       RuoteKit.engine.storage.purge! unless RuoteKit.engine.storage.nil?
 
       RuoteKit.shutdown_engine( true )
     end
   end
+
+  RuoteKit::Application.included_modules.each do |klass|
+    if klass.name =~ /RuoteKit::Helpers::\w+Helpers/
+      config.include klass
+    end
+  end
 end
 
 def app

data/spec/views/expressions.html.haml_spec.rb

@@ -0,0 +1,31 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+
+undef :context if defined?(context)
+
+
+describe "expressions.html.haml", :type => :with_engine do
+
+  describe "without expressions" do
+    it "should be helpful" do
+      render "expressions.html.haml"
+
+      response.should match(/Expressions are atomic pieces of process instances/)
+    end
+  end
+
+  describe "with expressions" do
+    before(:each) do
+      @wfid = launch_test_process
+      @process = engine.process( @wfid )
+
+      assigns[:process] = @process
+
+      render 'expressions.html.haml'
+    end
+
+    it "should have the process id" do
+      response.should include(@wfid)
+    end
+  end
+end

data/spec/views/launch_process.html.haml_spec.rb

@@ -1,6 +1,7 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
-describe "launch_process.html.haml" do
+describe "launch_process.html.haml", :type => :with_engine do
+
   it "should have a process definition field" do
     render 'launch_process.html.haml'
 

data/spec/views/process.html.haml_spec.rb

@@ -1,6 +1,7 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
-describe "process.html.haml" do
+describe "process.html.haml", :type => :with_engine do
+
   before(:each) do
     @wfid = launch_test_process
     @process = engine.process( @wfid )

data/spec/views/process_launched.html.haml_spec.rb

@@ -0,0 +1,16 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe "process_launched.html.haml", :type => :with_engine do
+
+  before(:each) do
+    @wfid = launch_test_process
+
+    assigns[:wfid] = @wfid
+
+    render 'process_launched.html.haml'
+  end
+
+  it "should have the process id" do
+    response.should include(@wfid)
+  end
+end

data/spec/views/processes.html.haml_spec.rb

@@ -1,6 +1,7 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
-describe "processes.html.haml" do
+describe "processes.html.haml", :type => :with_engine do
+
   describe "without processes" do
     before(:each) do
       assigns[:processes] = []

data/spec/views/workitems.html.haml_spec.rb

@@ -1,6 +1,7 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
-describe "workitems.html.haml" do
+describe "workitems.html.haml", :type => :with_engine do
+
   describe "rendering no workitems" do
     before(:each) do
       assigns[:workitems] = []
@@ -18,7 +19,7 @@ describe "workitems.html.haml" do
       @wfid1 = launch_test_process
       @wfid2 = launch_test_process
 
-      assigns[:workitems] = store_participant.all
+      assigns[:workitems] = storage_participant.all
 
       render 'workitems.html.haml'
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: ruote-kit
 version: !ruby/object:Gem::Version 
-  version: 2.1.4.1
+  version: 2.1.7
 platform: ruby
 authors: 
 - kenneth.kalmer@gmail.com
@@ -9,9 +9,19 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-12 00:00:00 +02:00
+date: 2010-03-10 00:00:00 +01:00
 default_executable: 
 dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: bundler
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 0.9.5
+    version: 
 - !ruby/object:Gem::Dependency 
   name: sinatra
   type: :runtime
@@ -22,6 +32,16 @@ dependencies:
       - !ruby/object:Gem::Version 
         version: 0.9.4
     version: 
+- !ruby/object:Gem::Dependency 
+  name: sinatra-respond_to
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 0.4.0
+    version: 
 - !ruby/object:Gem::Dependency 
   name: haml
   type: :runtime
@@ -48,9 +68,19 @@ dependencies:
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
-    - - "="
+    - - ">="
       - !ruby/object:Gem::Version 
-        version: 2.1.4
+        version: 2.1.7
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: rake
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
     version: 
 - !ruby/object:Gem::Dependency 
   name: rspec
@@ -62,6 +92,16 @@ dependencies:
       - !ruby/object:Gem::Version 
         version: "0"
     version: 
+- !ruby/object:Gem::Dependency 
+  name: jeweler
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+    version: 
 description: ruote-kit is a RESTful Rack app for the ruote workflow engine
 email: kenneth.kalmer@gmail.com
 executables: []
@@ -104,28 +144,15 @@ files:
 - lib/ruote-kit/resources/processes.rb
 - lib/ruote-kit/resources/workitems.rb
 - lib/ruote-kit/spec/ruote_helpers.rb
-- lib/ruote-kit/vendor/sinatra-respond_to/LICENSE
-- lib/ruote-kit/vendor/sinatra-respond_to/README.markdown
-- lib/ruote-kit/vendor/sinatra-respond_to/Rakefile
-- lib/ruote-kit/vendor/sinatra-respond_to/VERSION.yml
-- lib/ruote-kit/vendor/sinatra-respond_to/lib/sinatra/respond_to.rb
-- lib/ruote-kit/vendor/sinatra-respond_to/sinatra-respond_to.gemspec
-- lib/ruote-kit/vendor/sinatra-respond_to/spec/app/public/static folder/.keep
-- lib/ruote-kit/vendor/sinatra-respond_to/spec/app/public/static.txt
-- lib/ruote-kit/vendor/sinatra-respond_to/spec/app/test_app.rb
-- lib/ruote-kit/vendor/sinatra-respond_to/spec/app/unreachable_static.txt
-- lib/ruote-kit/vendor/sinatra-respond_to/spec/app/views/layout.html.haml
-- lib/ruote-kit/vendor/sinatra-respond_to/spec/app/views/resource.html.haml
-- lib/ruote-kit/vendor/sinatra-respond_to/spec/app/views/resource.js.erb
-- lib/ruote-kit/vendor/sinatra-respond_to/spec/app/views/resource.xml.builder
-- lib/ruote-kit/vendor/sinatra-respond_to/spec/extension_spec.rb
-- lib/ruote-kit/vendor/sinatra-respond_to/spec/spec_helper.rb
+- lib/ruote-kit/version.rb
 - lib/ruote-kit/views/expression.html.haml
 - lib/ruote-kit/views/expressions.html.haml
 - lib/ruote-kit/views/index.html.haml
 - lib/ruote-kit/views/launch_process.html.haml
 - lib/ruote-kit/views/layout.html.haml
 - lib/ruote-kit/views/process.html.haml
+- lib/ruote-kit/views/process_failed_to_launch.html.haml
+- lib/ruote-kit/views/process_launched.html.haml
 - lib/ruote-kit/views/processes.html.haml
 - lib/ruote-kit/views/resource_not_found.html.haml
 - lib/ruote-kit/views/workitem.html.haml
@@ -136,11 +163,14 @@ files:
 - spec/resources/index_spec.rb
 - spec/resources/processes_spec.rb
 - spec/resources/workitems_spec.rb
+- spec/ruote-kit_configure_spec.rb
 - spec/ruote-kit_spec.rb
 - spec/spec.opts
 - spec/spec_helper.rb
+- spec/views/expressions.html.haml_spec.rb
 - spec/views/launch_process.html.haml_spec.rb
 - spec/views/process.html.haml_spec.rb
+- spec/views/process_launched.html.haml_spec.rb
 - spec/views/processes.html.haml_spec.rb
 - spec/views/workitems.html.haml_spec.rb
 has_rdoc: true
@@ -172,14 +202,17 @@ signing_key:
 specification_version: 3
 summary: ruote workflow engine, wrapped in a loving rack embrace
 test_files: 
-- spec/helpers/render_helpers_spec.rb
 - spec/resources/expressions_spec.rb
+- spec/resources/workitems_spec.rb
 - spec/resources/index_spec.rb
 - spec/resources/processes_spec.rb
-- spec/resources/workitems_spec.rb
+- spec/ruote-kit_configure_spec.rb
 - spec/ruote-kit_spec.rb
-- spec/spec_helper.rb
+- spec/helpers/render_helpers_spec.rb
+- spec/views/workitems.html.haml_spec.rb
+- spec/views/process_launched.html.haml_spec.rb
 - spec/views/launch_process.html.haml_spec.rb
-- spec/views/process.html.haml_spec.rb
+- spec/views/expressions.html.haml_spec.rb
 - spec/views/processes.html.haml_spec.rb
-- spec/views/workitems.html.haml_spec.rb
+- spec/views/process.html.haml_spec.rb
+- spec/spec_helper.rb

data/lib/ruote-kit/vendor/sinatra-respond_to/LICENSE

@@ -1,21 +0,0 @@
-The MIT License
-
-Copyright (c) 2009 Chris Hoffman
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in
-all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.