runger_style 5.6.0 → 5.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46c8dd4a66ab7a5c4cc4e85f6eb30c32231cd9239e31966ef24ef79dcb784d4f
-  data.tar.gz: 0bcf2c8461c4016d99db10173549f954172704eb35c8244a44f49829d32774b6
+  metadata.gz: 433d7866a6c69efc507f09c68022683e7b618827f0faa48ec1f3b9645ff7cec8
+  data.tar.gz: a5134a48f6202d334181c6e249512ea0667f1164a4271c98341149e6d78f8e8a
 SHA512:
-  metadata.gz: d65e0c70b7a6951a5d7dcc53c680176f0afe0f043e141548d6c2d9e86ddc942841900879e0caeec350ba3cd8fb7ac579e330dc3a1f08f18b243b37864dd21db5
-  data.tar.gz: 9eaef8530ec93cf560f2ff230363af55971c2e4bc06ee547703e5eab300bf8062404f24119dd6d3dd5dd14763e049ccc3e451a2364d6c4b5944d813a3f80b361
+  metadata.gz: b47191a357b029cc8229ad742c17e4d95ab81c04cf8abc69a23f058c6cbd7180acc38345f505e08b55dcbe46a4b3de3340f0a9ea813aff39b5ddcb897faa370c
+  data.tar.gz: 656755b18538550827715ab0c33bcf2ae46c55d41e73fac16f0fa6e1f8a2ab172018e5a7dc990b3ca6592bd13ce50d769f077b965734f78923f410733277d925

data/CHANGELOG.md

@@ -1,3 +1,20 @@
+## Unreleased
+[no unreleased changes yet]
+
+## v5.8.0 (2025-03-22)
+- Disable `Metrics/PerceivedComplexity` and `Metrics/MethodLength`.
+- Allowlist `find_by_hashid` and `find_by_hashid!` for `Rails/DynamicFindBy`.
+- Add `Aws.config` to `AllowedReceivers` for `Rails/SaveBang`.
+
+### Internal
+- Turn off warnings when running RSpec.
+
+## v5.7.0 (2025-03-10)
+- Disable `Capybara/AmbiguousClick` and `Capybara/ClickLinkOrButtonStyle` and add `RungerStyle/ClickAmbiguously`, which does the opposite of `Capybara/AmbiguousClick`, i.e. it requires the use of `click_on` and forbids the use of `click_button` or `click_link`.
+
+### Internal
+- Move default custom cops and monkeypatches to `default/` subdirectory. This will make it possible to also add cops/monkeypatches for other plugins in other subdirectories (e.g. capybara) that we don't want to require/include in the default config.
+
 ## v5.6.0 (2025-03-10)
 - Switch from `require` to `plugins` for `rubocop-rspec_rails` ruleset (`rulesets/rspec_rails.yml`).
 - Switch from `require` to `plugins` for `rubocop-capybara` ruleset (`rulesets/capybara.yml`).

data/Gemfile.lock

@@ -1,6 +1,6 @@
 GIT
   remote: https://github.com/davidrunger/pry-byebug.git
-  revision: 4ef3e66233451fcbeff3a5f7a616380214379272
+  revision: f4a00d93566ef28f87e03210ea94d303fa544f2f
   specs:
     pry-byebug (3.10.1)
       pry (>= 0.13)
@@ -9,14 +9,14 @@ GIT
 PATH
   remote: .
   specs:
-    runger_style (5.6.0)
+    runger_style (5.8.0)
       prism (>= 0.24.0)
       rubocop (>= 1.72.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (8.0.1)
+    activesupport (8.0.2)
       base64
       benchmark (>= 0.3)
       bigdecimal
@@ -29,7 +29,7 @@ GEM
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
-    ast (2.4.2)
+    ast (2.4.3)
     base64 (0.2.0)
     benchmark (0.4.0)
     bigdecimal (3.1.9)
@@ -46,21 +46,21 @@ GEM
       pp (>= 0.6.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.10.1)
+    json (2.10.2)
     language_server-protocol (3.17.0.4)
     lint_roller (1.1.0)
     logger (1.6.6)
     memo_wise (1.11.0)
     method_source (1.1.0)
-    minitest (5.25.4)
+    minitest (5.25.5)
     parallel (1.26.3)
-    parser (3.3.7.1)
+    parser (3.3.7.2)
       ast (~> 2.4.1)
       racc
     pp (0.6.2)
       prettyprint
     prettyprint (0.2.0)
-    prism (1.3.0)
+    prism (1.4.0)
     pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
@@ -68,7 +68,7 @@ GEM
       date
       stringio
     racc (1.8.1)
-    rack (3.1.11)
+    rack (3.1.12)
     rainbow (3.1.1)
     rake (13.2.1)
     rdoc (6.12.0)
@@ -89,7 +89,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.2)
-    rubocop (1.73.2)
+    rubocop (1.74.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -100,12 +100,12 @@ GEM
       rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.38.1)
-      parser (>= 3.3.1.0)
-    rubocop-capybara (2.22.0)
+    rubocop-ast (1.41.0)
+      parser (>= 3.3.7.2)
+    rubocop-capybara (2.22.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-factory_bot (2.27.0)
+    rubocop-factory_bot (2.27.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
     rubocop-performance (1.24.0)
@@ -132,10 +132,11 @@ GEM
     runger_byebug (11.4.0)
       irb
       reline
-    runger_release_assistant (2.0.0)
+    runger_release_assistant (4.3.1)
       activesupport (>= 6)
       memo_wise (>= 1.7)
       rainbow (>= 3.0)
+      rake (>= 13.2.1)
       slop (~> 4.8)
     securerandom (0.4.1)
     slop (4.10.1)
@@ -168,8 +169,8 @@ DEPENDENCIES
   runger_style!
 
 CHECKSUMS
-  activesupport (8.0.1) sha256=fd5bc74641c24ac3541055c2879789198ff42adee3e39c2933289ba008912e37
-  ast (2.4.2) sha256=1e280232e6a33754cde542bc5ef85520b74db2aac73ec14acef453784447cc12
+  activesupport (8.0.2) sha256=8565cddba31b900cdc17682fd66ecd020441e3eef320a9930285394e8c07a45e
+  ast (2.4.3) sha256=954615157c1d6a382bc27d690d973195e79db7f55e9765ac7c481c60bdb4d383
   base64 (0.2.0) sha256=0f25e9b21a02a0cc0cea8ef92b2041035d39350946e8789c562b2d1a3da01507
   benchmark (0.4.0) sha256=0f12f8c495545e3710c3e4f0480f63f06b4c842cc94cec7f33a956f5180e874a
   bigdecimal (3.1.9) sha256=2ffc742031521ad69c2dfc815a98e426a230a3d22aeac1995826a75dabfad8cc
@@ -182,23 +183,23 @@ CHECKSUMS
   i18n (1.14.7) sha256=ceba573f8138ff2c0915427f1fc5bdf4aa3ab8ae88c8ce255eb3ecf0a11a5d0f
   io-console (0.8.0) sha256=cd6a9facbc69871d69b2cb8b926fc6ea7ef06f06e505e81a64f14a470fddefa2
   irb (1.15.1) sha256=d9bca745ac4207a8b728a52b98b766ca909b86ff1a504bcde3d6f8c84faae890
-  json (2.10.1) sha256=ddc88ad91a1baf3f0038c174f253af3b086d30dc74db17ca4259bbde982f94dc
+  json (2.10.2) sha256=34e0eada93022b2a0a3345bb0b5efddb6e9ff5be7c48e409cfb54ff8a36a8b06
   language_server-protocol (3.17.0.4) sha256=c484626478664fd13482d8180947c50a8590484b1258b99b7aedb3b69df89669
   lint_roller (1.1.0) sha256=2c0c845b632a7d172cb849cc90c1bce937a28c5c8ccccb50dfd46a485003cc87
   logger (1.6.6) sha256=dd618d24e637715472732e7eed02e33cfbdf56deaad225edd0f1f89d38024017
   memo_wise (1.11.0) sha256=06ef23a1edb6b8ee4f37d950bba04836b437b4d1036e45d24c2fd2f25b5490c3
   method_source (1.1.0) sha256=181301c9c45b731b4769bc81e8860e72f9161ad7d66dd99103c9ab84f560f5c5
-  minitest (5.25.4) sha256=9cf2cae25ac4dfc90c988ebc3b917f53c054978b673273da1bd20bcb0778f947
+  minitest (5.25.5) sha256=391b6c6cb43a4802bfb7c93af1ebe2ac66a210293f4a3fb7db36f2fc7dc2c756
   parallel (1.26.3) sha256=d86babb7a2b814be9f4b81587bf0b6ce2da7d45969fab24d8ae4bf2bb4d4c7ef
-  parser (3.3.7.1) sha256=7dbe61618025519024ac72402a6677ead02099587a5538e84371b76659e6aca1
+  parser (3.3.7.2) sha256=c71de9076be0b84459a268581b5aa75e5eeaac892b564430371d1f8eb55fb65f
   pp (0.6.2) sha256=947ec3120c6f92195f8ee8aa25a7b2c5297bb106d83b41baa02983686577b6ff
   prettyprint (0.2.0) sha256=2bc9e15581a94742064a3cc8b0fb9d45aae3d03a1baa6ef80922627a0766f193
-  prism (1.3.0) sha256=b11620829831b1cb7e6c9b46c81ff8a6e36ccb3f888f164485eb7351f386273a
+  prism (1.4.0) sha256=dc0e3e00e93160213dc2a65519d9002a4a1e7b962db57d444cf1a71565bb703e
   pry (0.15.2) sha256=12d54b8640d3fa29c9211dd4ffb08f3fd8bf7a4fd9b5a73ce5b59c8709385b6b
   pry-byebug (3.10.1)
   psych (5.2.3) sha256=84a54bb952d14604fea22d99938348814678782f58b12648fcdfa4d2fce859ee
   racc (1.8.1) sha256=4a7f6929691dbec8b5209a0b373bc2614882b55fc5d2e447a21aaa691303d62f
-  rack (3.1.11) sha256=2b1111a754890d57e7bccefe3a8be28c0f9c02b43433b5a1276c07773e16e8f7
+  rack (3.1.12) sha256=00d83055c89273eb13679ab562767b8826955aa6c4371d7d161deb975c50c540
   rainbow (3.1.1) sha256=039491aa3a89f42efa1d6dec2fc4e62ede96eb6acd95e52f1ad581182b79bc6a
   rake (13.2.1) sha256=46cb38dae65d7d74b6020a4ac9d48afed8eb8149c040eccf0523bec91907059d
   rdoc (6.12.0) sha256=7d6f706e070bffa5d18a448f24076cbfb34923a99c1eab842aa18e6ca69f56e0
@@ -209,10 +210,10 @@ CHECKSUMS
   rspec-expectations (3.13.3) sha256=0e6b5af59b900147698ea0ff80456c4f2e69cac4394fbd392fbd1ca561f66c58
   rspec-mocks (3.13.2) sha256=2327335def0e1665325a9b617e3af9ae20272741d80ac550336309a7c59abdef
   rspec-support (3.13.2) sha256=cea3a2463fd9b84b9dcc9685efd80ea701aa8f7b3decb3b3ce795ed67737dbec
-  rubocop (1.73.2) sha256=35cd1b1365ba97234323fe771abcecd09c9b77098464cd726c76aa7d9bc12b5d
-  rubocop-ast (1.38.1) sha256=80ecbe2ac9bb26693cab9405bf72b41b85a1f909f20f021b983c32c2e7d857fe
-  rubocop-capybara (2.22.0) sha256=9c3a6704ed0243e5332fdc45112b4bb90fc4cfd23a7f175f74af4a01e21627d0
-  rubocop-factory_bot (2.27.0) sha256=de9918bc4e1406b3025da87c5c34c91dd6c3e802cd59339790631f963a5652ba
+  rubocop (1.74.0) sha256=06138a35d7d11c963d5abc0148b355e3999007cb0225a619940db0e75521379b
+  rubocop-ast (1.41.0) sha256=0eeff9ad3743f42823e3c687cbc15f8c552ff63c9f8e3d35fbafe746977c7c0d
+  rubocop-capybara (2.22.1) sha256=ced88caef23efea53f46e098ff352f8fc1068c649606ca75cb74650970f51c0c
+  rubocop-factory_bot (2.27.1) sha256=9d744b5916778c1848e5fe6777cc69855bd96548853554ec239ba9961b8573fe
   rubocop-performance (1.24.0) sha256=e5bd39ff3e368395b9af886927cc37f5892f43db4bd6c8526594352d5b4440b5
   rubocop-rails (2.30.3) sha256=fc5a6506daa916d15e282cc806943afa64a020bf592b93a94025d89a2a78a715
   rubocop-rake (0.7.1) sha256=3797f2b6810c3e9df7376c26d5f44f3475eda59eb1adc38e6f62ecf027cbae4d
@@ -220,8 +221,8 @@ CHECKSUMS
   rubocop-rspec_rails (2.31.0) sha256=775375e18a26a1184a812ef3054b79d218e85601b9ae897f38f8be24dddf1f45
   ruby-progressbar (1.13.0) sha256=80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33
   runger_byebug (11.4.0) sha256=569e22ba2215f57e7f69e145fcb63be401e29fcd312f7936d813e12d0c7bbee6
-  runger_release_assistant (2.0.0) sha256=f4f5708291eaeef1b881208f87a494877fe768739d6e96b7293fc335b28a3865
-  runger_style (5.6.0)
+  runger_release_assistant (4.3.1) sha256=3246c925240739eb12b9e6b9526a77ea00fcf0a0941441ff5ffacefb7e3e4d83
+  runger_style (5.8.0)
   securerandom (0.4.1) sha256=cc5193d414a4341b6e225f0cb4446aceca8e50d5e1888743fac16987638ea0b1
   slop (4.10.1) sha256=844322b5ffcf17ed4815fdb173b04a20dd82b4fd93e3744c88c8fafea696d9c7
   stringio (3.1.5) sha256=bca92461515a131535743bc81d5559fa1de7d80cff9a654d6c0af6f9f27e35c8

data/README.md

@@ -4,21 +4,22 @@ Shared rubocop rules for the preferred Ruby coding style of [@davidrunger][1].
 
 [1]: https://github.com/davidrunger/
 
-# Table of Contents
+## Table of Contents
 
 <!--ts-->
-   * [runger_style](#runger_style)
+* [runger_style](#runger_style)
    * [Table of Contents](#table-of-contents)
    * [Installation](#installation)
    * [Usage](#usage)
    * [Inspiration / Credits](#inspiration--credits)
    * [For maintainers](#for-maintainers)
 
-<!-- Added by: david, at: Tue Jan 26 02:54:38 PST 2021 -->
+<!-- Created by https://github.com/ekalinin/github-markdown-toc -->
+<!-- Added by: david, at: Sat Mar 22 04:48:36 AM CDT 2025 -->
 
 <!--te-->
 
-# Installation
+## Installation
 
 Add this to your application's Gemfile:
 
@@ -34,7 +35,7 @@ And then run:
 $ bundle install
 ```
 
-# Usage
+## Usage
 
 Create a `.rubocop.yml` file, including as many of the directives below as appropriate/desired.
 
@@ -84,13 +85,13 @@ Then, run:
 $ bundle exec rubocop
 ```
 
-# Inspiration / Credits
+## Inspiration / Credits
 
 This gem is inspired by (/ largely copied from) https://github.com/percy/percy-style , which was
 written about here: https://blog.percy.io/share-rubocop-rules-across-all-of-your-repos-f3281fbd71f8
 .
 
-# For maintainers
+## For maintainers
 
 To release a new version, run `bin/release` with an appropriate `--type` option, e.g.:
 

data/lib/runger_style/cops/capybara/click_ambiguously.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
+  class ClickAmbiguously < ::RuboCop::Cop::Base
+    extend ::RuboCop::Cop::AutoCorrector
+    MSG = 'Use `click_on` instead of `click_link` or `click_button`.'
+    RESTRICT_ON_SEND = %i[click_button click_link].freeze
+
+    def on_send(node)
+      add_offense(node) do |corrector|
+        corrector.replace(node.loc.selector, 'click_on')
+      end
+    end
+  end
+end

data/lib/runger_style/cops/{multiline_method_arguments_line_breaks.rb → default/multiline_method_arguments_line_breaks.rb}

@@ -7,7 +7,6 @@ module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
 
     MSG = 'Each argument in a multi-line method call must start on a separate line.'
 
-    # rubocop:disable Metrics/PerceivedComplexity
     def on_send(node)
       if node.arguments? && multiline_method_call?(node)
         # When a method call uses keyword arguments without braces,
@@ -34,7 +33,6 @@ module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
         end
       end
     end
-    # rubocop:enable Metrics/PerceivedComplexity
 
     private
 

data/lib/runger_style/cops/default/require_all_custom_cops.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+Dir[File.expand_path('./**/*.rb', __dir__)].each do |file|
+  unless file == __FILE__
+    require file
+  end
+end

data/lib/runger_style/cops/default/require_all_monkeypatches.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+Dir[File.expand_path('./monkeypatches/**/*.rb', __dir__)].each do |file|
+  require file
+end

data/lib/runger_style/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RungerStyle
-  VERSION = '5.6.0'
+  VERSION = '5.8.0'
 end

data/lib/runger_style.rb

@@ -4,5 +4,5 @@ require 'rubocop'
 
 module RungerStyle ; end
 
-require 'runger_style/cops/require_all_custom_cops'
+require 'runger_style/cops/default/require_all_custom_cops'
 require 'runger_style/version'

data/rulesets/capybara.yml

@@ -1,7 +1,16 @@
+require:
+  - ../lib/runger_style/cops/capybara/require_all_custom_cops.rb
+
 plugins:
   - rubocop-capybara
 
+Capybara/AmbiguousClick:
+  Enabled: false
+Capybara/ClickLinkOrButtonStyle:
+  Enabled: false
 Capybara/NegationMatcher:
   EnforcedStyle: not_to
 Capybara/SpecificMatcher:
   Enabled: false
+RungerStyle/ClickAmbiguously:
+  Enabled: true

data/rulesets/default.yml

@@ -1,5 +1,5 @@
 require:
-  - ../lib/runger_style/cops/require_all_custom_cops.rb
+  - ../lib/runger_style/cops/default/require_all_custom_cops.rb
 
 AllCops:
   EnabledByDefault: true
@@ -87,9 +87,11 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Enabled: false
 Metrics/MethodLength:
-  Max: 30
+  Enabled: false
 Metrics/ModuleLength:
   Enabled: false
+Metrics/PerceivedComplexity:
+  Enabled: false
 Naming/BlockForwarding:
   Enabled: false
 Naming/InclusiveLanguage:

data/rulesets/rails.yml

@@ -18,6 +18,12 @@ Rails/CreateTableWithTimestamps:
     - db/schema.rb
 Rails/Delegate:
   Enabled: false
+Rails/DynamicFindBy:
+  AllowedMethods:
+    - find_by_hashid
+    - find_by_hashid!
+    - find_by_sql
+    - find_by_token_for
 Rails/EnvironmentVariableAccess:
   AllowReads: true
 Rails/I18nLocaleTexts:
@@ -33,5 +39,8 @@ Rails/RakeEnvironment:
 Rails/ReversibleMigration:
   Exclude:
     - !ruby/regexp /db/migrate/201[1-9].*\.rb\z/
+Rails/SaveBang:
+  AllowedReceivers:
+    - Aws.config
 Rails/SchemaComment:
   Enabled: false

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: runger_style
 version: !ruby/object:Gem::Version
-  version: 5.6.0
+  version: 5.8.0
 platform: ruby
 authors:
 - David Runger
 bindir: bin
 cert_chain: []
-date: 2025-03-10 00:00:00.000000000 Z
+date: 2025-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: prism
@@ -66,14 +66,16 @@ files:
 - bin/rspec
 - bin/rubocop
 - lib/runger_style.rb
-- lib/runger_style/cops/argument_alignment.rb
-- lib/runger_style/cops/first_argument_indentation.rb
-- lib/runger_style/cops/multiline_hash_value_indentation.rb
-- lib/runger_style/cops/multiline_method_arguments_line_breaks.rb
-- lib/runger_style/cops/require_all_custom_cops.rb
-- lib/runger_style/cops/require_all_monkeypatches.rb
-- lib/runger_style/monkeypatches/multiline_element_line_breaks.rb
-- lib/runger_style/monkeypatches/multiline_expression_indentation.rb
+- lib/runger_style/cops/capybara/click_ambiguously.rb
+- lib/runger_style/cops/capybara/require_all_custom_cops.rb
+- lib/runger_style/cops/default/argument_alignment.rb
+- lib/runger_style/cops/default/first_argument_indentation.rb
+- lib/runger_style/cops/default/monkeypatches/multiline_element_line_breaks.rb
+- lib/runger_style/cops/default/monkeypatches/multiline_expression_indentation.rb
+- lib/runger_style/cops/default/multiline_hash_value_indentation.rb
+- lib/runger_style/cops/default/multiline_method_arguments_line_breaks.rb
+- lib/runger_style/cops/default/require_all_custom_cops.rb
+- lib/runger_style/cops/default/require_all_monkeypatches.rb
 - lib/runger_style/version.rb
 - rulesets/capybara.yml
 - rulesets/default.yml

data/lib/runger_style/cops/require_all_monkeypatches.rb

@@ -1,5 +0,0 @@
-# frozen_string_literal: true
-
-Dir[File.expand_path('../monkeypatches/**/*.rb', __dir__)].each do |file|
-  require file
-end