runger_style 5.6.0 → 5.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46c8dd4a66ab7a5c4cc4e85f6eb30c32231cd9239e31966ef24ef79dcb784d4f
-  data.tar.gz: 0bcf2c8461c4016d99db10173549f954172704eb35c8244a44f49829d32774b6
+  metadata.gz: d5e730830fe1047b48c1b164d9fe75077212ddc755b69de830a055096e96edf0
+  data.tar.gz: 1135cdb63db280a9eb50ed20b0b81709331034c41d8bae7feebb3aed7a3d3589
 SHA512:
-  metadata.gz: d65e0c70b7a6951a5d7dcc53c680176f0afe0f043e141548d6c2d9e86ddc942841900879e0caeec350ba3cd8fb7ac579e330dc3a1f08f18b243b37864dd21db5
-  data.tar.gz: 9eaef8530ec93cf560f2ff230363af55971c2e4bc06ee547703e5eab300bf8062404f24119dd6d3dd5dd14763e049ccc3e451a2364d6c4b5944d813a3f80b361
+  metadata.gz: aad4fd7aae84f1a1d4b846e42643f10cad2c438061c6225a5bf81ac969cabe98d8273ca2f253d0a00c11214a743f8f130815794fa432e2fc00405ae10d7fa2f5
+  data.tar.gz: d948ea9b48164ab543367685949059ddb0a77e0c6fac373f35356508b8983bae785752cd99e125c6308f229a8234bf96d3f1158a516faabb74fcd205e0379f56

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## v5.7.0 (2025-03-10)
+- Disable `Capybara/AmbiguousClick` and `Capybara/ClickLinkOrButtonStyle` and add `RungerStyle/ClickAmbiguously`, which does the opposite of `Capybara/AmbiguousClick`, i.e. it requires the use of `click_on` and forbids the use of `click_button` or `click_link`.
+
+### Internal
+- Move default custom cops and monkeypatches to `default/` subdirectory. This will make it possible to also add cops/monkeypatches for other plugins in other subdirectories (e.g. capybara) that we don't want to require/include in the default config.
+
 ## v5.6.0 (2025-03-10)
 - Switch from `require` to `plugins` for `rubocop-rspec_rails` ruleset (`rulesets/rspec_rails.yml`).
 - Switch from `require` to `plugins` for `rubocop-capybara` ruleset (`rulesets/capybara.yml`).

data/Gemfile.lock

@@ -9,7 +9,7 @@ GIT
 PATH
   remote: .
   specs:
-    runger_style (5.6.0)
+    runger_style (5.7.0)
       prism (>= 0.24.0)
       rubocop (>= 1.72.0)
 
@@ -221,7 +221,7 @@ CHECKSUMS
   ruby-progressbar (1.13.0) sha256=80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33
   runger_byebug (11.4.0) sha256=569e22ba2215f57e7f69e145fcb63be401e29fcd312f7936d813e12d0c7bbee6
   runger_release_assistant (2.0.0) sha256=f4f5708291eaeef1b881208f87a494877fe768739d6e96b7293fc335b28a3865
-  runger_style (5.6.0)
+  runger_style (5.7.0)
   securerandom (0.4.1) sha256=cc5193d414a4341b6e225f0cb4446aceca8e50d5e1888743fac16987638ea0b1
   slop (4.10.1) sha256=844322b5ffcf17ed4815fdb173b04a20dd82b4fd93e3744c88c8fafea696d9c7
   stringio (3.1.5) sha256=bca92461515a131535743bc81d5559fa1de7d80cff9a654d6c0af6f9f27e35c8

data/lib/runger_style/cops/capybara/click_ambiguously.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
+  class ClickAmbiguously < ::RuboCop::Cop::Base
+    extend ::RuboCop::Cop::AutoCorrector
+    MSG = 'Use `click_on` instead of `click_link` or `click_button`.'
+    RESTRICT_ON_SEND = %i[click_button click_link].freeze
+
+    def on_send(node)
+      add_offense(node) do |corrector|
+        corrector.replace(node.loc.selector, 'click_on')
+      end
+    end
+  end
+end

data/lib/runger_style/cops/default/require_all_custom_cops.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+Dir[File.expand_path('./**/*.rb', __dir__)].each do |file|
+  unless file == __FILE__
+    require file
+  end
+end

data/lib/runger_style/cops/default/require_all_monkeypatches.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+Dir[File.expand_path('./monkeypatches/**/*.rb', __dir__)].each do |file|
+  require file
+end

data/lib/runger_style/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RungerStyle
-  VERSION = '5.6.0'
+  VERSION = '5.7.0'
 end

data/lib/runger_style.rb

@@ -4,5 +4,5 @@ require 'rubocop'
 
 module RungerStyle ; end
 
-require 'runger_style/cops/require_all_custom_cops'
+require 'runger_style/cops/default/require_all_custom_cops'
 require 'runger_style/version'

data/rulesets/capybara.yml

@@ -1,7 +1,16 @@
+require:
+  - ../lib/runger_style/cops/capybara/require_all_custom_cops.rb
+
 plugins:
   - rubocop-capybara
 
+Capybara/AmbiguousClick:
+  Enabled: false
+Capybara/ClickLinkOrButtonStyle:
+  Enabled: false
 Capybara/NegationMatcher:
   EnforcedStyle: not_to
 Capybara/SpecificMatcher:
   Enabled: false
+RungerStyle/ClickAmbiguously:
+  Enabled: true

data/rulesets/default.yml

@@ -1,5 +1,5 @@
 require:
-  - ../lib/runger_style/cops/require_all_custom_cops.rb
+  - ../lib/runger_style/cops/default/require_all_custom_cops.rb
 
 AllCops:
   EnabledByDefault: true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: runger_style
 version: !ruby/object:Gem::Version
-  version: 5.6.0
+  version: 5.7.0
 platform: ruby
 authors:
 - David Runger
@@ -66,14 +66,16 @@ files:
 - bin/rspec
 - bin/rubocop
 - lib/runger_style.rb
-- lib/runger_style/cops/argument_alignment.rb
-- lib/runger_style/cops/first_argument_indentation.rb
-- lib/runger_style/cops/multiline_hash_value_indentation.rb
-- lib/runger_style/cops/multiline_method_arguments_line_breaks.rb
-- lib/runger_style/cops/require_all_custom_cops.rb
-- lib/runger_style/cops/require_all_monkeypatches.rb
-- lib/runger_style/monkeypatches/multiline_element_line_breaks.rb
-- lib/runger_style/monkeypatches/multiline_expression_indentation.rb
+- lib/runger_style/cops/capybara/click_ambiguously.rb
+- lib/runger_style/cops/capybara/require_all_custom_cops.rb
+- lib/runger_style/cops/default/argument_alignment.rb
+- lib/runger_style/cops/default/first_argument_indentation.rb
+- lib/runger_style/cops/default/monkeypatches/multiline_element_line_breaks.rb
+- lib/runger_style/cops/default/monkeypatches/multiline_expression_indentation.rb
+- lib/runger_style/cops/default/multiline_hash_value_indentation.rb
+- lib/runger_style/cops/default/multiline_method_arguments_line_breaks.rb
+- lib/runger_style/cops/default/require_all_custom_cops.rb
+- lib/runger_style/cops/default/require_all_monkeypatches.rb
 - lib/runger_style/version.rb
 - rulesets/capybara.yml
 - rulesets/default.yml

data/lib/runger_style/cops/require_all_monkeypatches.rb

@@ -1,5 +0,0 @@
-# frozen_string_literal: true
-
-Dir[File.expand_path('../monkeypatches/**/*.rb', __dir__)].each do |file|
-  require file
-end