runger_style 5.5.0 → 5.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae6337c6b78da16e6519968926bd10c9f6458eb6fde4005221bed2a497f073f5
-  data.tar.gz: 0cd105ad8a560fa9add2b403dd7b1a793fb7aafa13233375c17cdc97a3f290d7
+  metadata.gz: d5e730830fe1047b48c1b164d9fe75077212ddc755b69de830a055096e96edf0
+  data.tar.gz: 1135cdb63db280a9eb50ed20b0b81709331034c41d8bae7feebb3aed7a3d3589
 SHA512:
-  metadata.gz: 5108d376a1e498b2f6287c7dc048c9761bb8d5b4c563bc689d5a9b45b9be21bf4194b197285eb7f80ae33be911e611ae6d1f2468778864d1b67503f08a46820e
-  data.tar.gz: 1c8b4fcb740c07314f10abe70726c0dc08143a586191c7072bed5913de87ca0d0ccb5255155f82b642c11900f9c14433f4cfdee7098b33924448b61e94f65910
+  metadata.gz: aad4fd7aae84f1a1d4b846e42643f10cad2c438061c6225a5bf81ac969cabe98d8273ca2f253d0a00c11214a743f8f130815794fa432e2fc00405ae10d7fa2f5
+  data.tar.gz: d948ea9b48164ab543367685949059ddb0a77e0c6fac373f35356508b8983bae785752cd99e125c6308f229a8234bf96d3f1158a516faabb74fcd205e0379f56

data/.github/workflows/ruby.yml

@@ -22,7 +22,13 @@ jobs:
         gem install bundler -v 2.1.4
         bundle install --jobs 4 --retry 3
     - name: Run RuboCop
-      run: bin/rubocop --format clang
+      run: bin/rubocop --format clang --color 2> >(tee /tmp/rubocop_stderr >&2)
+    - name: Check that RuboCop didn't write anything to stderr
+      run: |
+        if [[ -s /tmp/rubocop_stderr ]] ; then
+          echo "Error: stderr was not empty" >&2
+          exit 1
+        fi
     - name: Run RSpec tests
       run: bin/rspec --format progress
     - name: Ensure alpha version

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## v5.7.0 (2025-03-10)
+- Disable `Capybara/AmbiguousClick` and `Capybara/ClickLinkOrButtonStyle` and add `RungerStyle/ClickAmbiguously`, which does the opposite of `Capybara/AmbiguousClick`, i.e. it requires the use of `click_on` and forbids the use of `click_button` or `click_link`.
+
+### Internal
+- Move default custom cops and monkeypatches to `default/` subdirectory. This will make it possible to also add cops/monkeypatches for other plugins in other subdirectories (e.g. capybara) that we don't want to require/include in the default config.
+
+## v5.6.0 (2025-03-10)
+- Switch from `require` to `plugins` for `rubocop-rspec_rails` ruleset (`rulesets/rspec_rails.yml`).
+- Switch from `require` to `plugins` for `rubocop-capybara` ruleset (`rulesets/capybara.yml`).
+
 ## v5.5.0 (2025-03-06)
 - Switch from `require` to `plugins` for `rubocop-factory_bot` ruleset (`rulesets/factory_bot.yml`).
 

data/Gemfile.lock

@@ -9,7 +9,7 @@ GIT
 PATH
   remote: .
   specs:
-    runger_style (5.5.0)
+    runger_style (5.7.0)
       prism (>= 0.24.0)
       rubocop (>= 1.72.0)
 
@@ -102,8 +102,9 @@ GEM
       unicode-display_width (>= 2.4.0, < 4.0)
     rubocop-ast (1.38.1)
       parser (>= 3.3.1.0)
-    rubocop-capybara (2.21.0)
-      rubocop (~> 1.41)
+    rubocop-capybara (2.22.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
     rubocop-factory_bot (2.27.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
@@ -123,9 +124,10 @@ GEM
     rubocop-rspec (3.5.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-rspec_rails (2.30.0)
-      rubocop (~> 1.61)
-      rubocop-rspec (~> 3, >= 3.0.1)
+    rubocop-rspec_rails (2.31.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+      rubocop-rspec (~> 3.5)
     ruby-progressbar (1.13.0)
     runger_byebug (11.4.0)
       irb
@@ -209,17 +211,17 @@ CHECKSUMS
   rspec-support (3.13.2) sha256=cea3a2463fd9b84b9dcc9685efd80ea701aa8f7b3decb3b3ce795ed67737dbec
   rubocop (1.73.2) sha256=35cd1b1365ba97234323fe771abcecd09c9b77098464cd726c76aa7d9bc12b5d
   rubocop-ast (1.38.1) sha256=80ecbe2ac9bb26693cab9405bf72b41b85a1f909f20f021b983c32c2e7d857fe
-  rubocop-capybara (2.21.0) sha256=5d264efdd8b6c7081a3d4889decf1451a1cfaaec204d81534e236bc825b280ab
+  rubocop-capybara (2.22.0) sha256=9c3a6704ed0243e5332fdc45112b4bb90fc4cfd23a7f175f74af4a01e21627d0
   rubocop-factory_bot (2.27.0) sha256=de9918bc4e1406b3025da87c5c34c91dd6c3e802cd59339790631f963a5652ba
   rubocop-performance (1.24.0) sha256=e5bd39ff3e368395b9af886927cc37f5892f43db4bd6c8526594352d5b4440b5
   rubocop-rails (2.30.3) sha256=fc5a6506daa916d15e282cc806943afa64a020bf592b93a94025d89a2a78a715
   rubocop-rake (0.7.1) sha256=3797f2b6810c3e9df7376c26d5f44f3475eda59eb1adc38e6f62ecf027cbae4d
   rubocop-rspec (3.5.0) sha256=710c942fe1af884ba8eea75cbb8bdbb051929a2208880a6fc2e2dce1eed5304c
-  rubocop-rspec_rails (2.30.0) sha256=888112e83f9d7ef7ad2397e9d69a0b9614a4bae24f072c399804a180f80c4c46
+  rubocop-rspec_rails (2.31.0) sha256=775375e18a26a1184a812ef3054b79d218e85601b9ae897f38f8be24dddf1f45
   ruby-progressbar (1.13.0) sha256=80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33
   runger_byebug (11.4.0) sha256=569e22ba2215f57e7f69e145fcb63be401e29fcd312f7936d813e12d0c7bbee6
   runger_release_assistant (2.0.0) sha256=f4f5708291eaeef1b881208f87a494877fe768739d6e96b7293fc335b28a3865
-  runger_style (5.5.0)
+  runger_style (5.7.0)
   securerandom (0.4.1) sha256=cc5193d414a4341b6e225f0cb4446aceca8e50d5e1888743fac16987638ea0b1
   slop (4.10.1) sha256=844322b5ffcf17ed4815fdb173b04a20dd82b4fd93e3744c88c8fafea696d9c7
   stringio (3.1.5) sha256=bca92461515a131535743bc81d5559fa1de7d80cff9a654d6c0af6f9f27e35c8

data/lib/runger_style/cops/capybara/click_ambiguously.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
+  class ClickAmbiguously < ::RuboCop::Cop::Base
+    extend ::RuboCop::Cop::AutoCorrector
+    MSG = 'Use `click_on` instead of `click_link` or `click_button`.'
+    RESTRICT_ON_SEND = %i[click_button click_link].freeze
+
+    def on_send(node)
+      add_offense(node) do |corrector|
+        corrector.replace(node.loc.selector, 'click_on')
+      end
+    end
+  end
+end

data/lib/runger_style/cops/default/require_all_custom_cops.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+Dir[File.expand_path('./**/*.rb', __dir__)].each do |file|
+  unless file == __FILE__
+    require file
+  end
+end

data/lib/runger_style/cops/default/require_all_monkeypatches.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+Dir[File.expand_path('./monkeypatches/**/*.rb', __dir__)].each do |file|
+  require file
+end

data/lib/runger_style/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RungerStyle
-  VERSION = '5.5.0'
+  VERSION = '5.7.0'
 end

data/lib/runger_style.rb

@@ -4,5 +4,5 @@ require 'rubocop'
 
 module RungerStyle ; end
 
-require 'runger_style/cops/require_all_custom_cops'
+require 'runger_style/cops/default/require_all_custom_cops'
 require 'runger_style/version'

data/rulesets/capybara.yml

@@ -1,7 +1,16 @@
 require:
+  - ../lib/runger_style/cops/capybara/require_all_custom_cops.rb
+
+plugins:
   - rubocop-capybara
 
+Capybara/AmbiguousClick:
+  Enabled: false
+Capybara/ClickLinkOrButtonStyle:
+  Enabled: false
 Capybara/NegationMatcher:
   EnforcedStyle: not_to
 Capybara/SpecificMatcher:
   Enabled: false
+RungerStyle/ClickAmbiguously:
+  Enabled: true

data/rulesets/default.yml

@@ -1,5 +1,5 @@
 require:
-  - ../lib/runger_style/cops/require_all_custom_cops.rb
+  - ../lib/runger_style/cops/default/require_all_custom_cops.rb
 
 AllCops:
   EnabledByDefault: true

data/rulesets/rspec_rails.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-rspec_rails
 
 RSpecRails/HttpStatus:

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: runger_style
 version: !ruby/object:Gem::Version
-  version: 5.5.0
+  version: 5.7.0
 platform: ruby
 authors:
 - David Runger
 bindir: bin
 cert_chain: []
-date: 2025-03-06 00:00:00.000000000 Z
+date: 2025-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: prism
@@ -66,14 +66,16 @@ files:
 - bin/rspec
 - bin/rubocop
 - lib/runger_style.rb
-- lib/runger_style/cops/argument_alignment.rb
-- lib/runger_style/cops/first_argument_indentation.rb
-- lib/runger_style/cops/multiline_hash_value_indentation.rb
-- lib/runger_style/cops/multiline_method_arguments_line_breaks.rb
-- lib/runger_style/cops/require_all_custom_cops.rb
-- lib/runger_style/cops/require_all_monkeypatches.rb
-- lib/runger_style/monkeypatches/multiline_element_line_breaks.rb
-- lib/runger_style/monkeypatches/multiline_expression_indentation.rb
+- lib/runger_style/cops/capybara/click_ambiguously.rb
+- lib/runger_style/cops/capybara/require_all_custom_cops.rb
+- lib/runger_style/cops/default/argument_alignment.rb
+- lib/runger_style/cops/default/first_argument_indentation.rb
+- lib/runger_style/cops/default/monkeypatches/multiline_element_line_breaks.rb
+- lib/runger_style/cops/default/monkeypatches/multiline_expression_indentation.rb
+- lib/runger_style/cops/default/multiline_hash_value_indentation.rb
+- lib/runger_style/cops/default/multiline_method_arguments_line_breaks.rb
+- lib/runger_style/cops/default/require_all_custom_cops.rb
+- lib/runger_style/cops/default/require_all_monkeypatches.rb
 - lib/runger_style/version.rb
 - rulesets/capybara.yml
 - rulesets/default.yml

data/lib/runger_style/cops/require_all_monkeypatches.rb

@@ -1,5 +0,0 @@
-# frozen_string_literal: true
-
-Dir[File.expand_path('../monkeypatches/**/*.rb', __dir__)].each do |file|
-  require file
-end